First of all, thank you so much for the detailed feedback. I wasn't sure
how much to include in the proposal, but I see it still needs a lot of work.
> When you talk about "Convert each main task in git-submodule into a C
> function." and "If certain functionality is missing, add it to the correct
ano wrote:
>
> Khalid Ali writes:
>
> > The exit code of the upstream in a pipe is ignored thus we
> > should avoid using it. By writing out the output of the git command to a
> > file, we can test the exit codes of both the commands.
>
> End the log message here
Hi,
My name is Khalid Ali and I am looking to convert the git-submodule to
a builtin C script. The link below contains my first proposal draft
[1] and my microproject is at [2]. My main concern is that my second
task is not verbose enough. I am not sure if I should add a specific
breakdown of
adding functionality for the
rebase interactive command.
Any review on this commit would be appreciated!
Signed-off-by: Khalid Ali
---
t/t9811-git-p4-label-import.sh | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/t/t9811-git-p4-label-import.sh b/t/t9811-git-p4
4 matches
Mail list logo