[PATCH] Make stashing nothing exit 1

In the case there are no files to stash, but the user asked to stash, we should exit 1 since the stashing failed. --- git-stash.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-stash.sh b/git-stash.sh index 789ce2f41d4a3..ca362b1a31277 100755 --- a/git-stash.sh +++ b/git-

Re: [PATCH] Add support for 'git remote rm' in Bash completion script

It would be great if we could land this. Non of the other solutions since I proposed my patch have happened, so in the meantime this would be nice to have. -- Keith Smiley > On Feb 8, 2019, at 22:27, Todd Zullinger wrote: > > Hi Sergey, > > There was a previous discus

Re: [PATCH] Add shell completion for git remote rm

Since there hasn't been any movement on the alternative solutions mentioned here, would it be reasonable to accept this patch in the meantime? -- Keith Smiley > On Jan 17, 2018, at 01:48, Duy Nguyen wrote: > >> On Wed, Jan 17, 2018 at 1:17 PM, Kevin Daudt wrote: >>&g

Re: [PATCH] Add shell completion for git remote rm

So it sounds like either we should deprecate rm, or I should update the patch to the suggested method where we just complete remotes, but not rm in the list of completions. Thoughts? -- Keith Smiley On Wed, Jan 3, 2018, at 11:24, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason wri

Re: [PATCH] Add shell completion for git remote rm

I'm definitely happy to update this patch for now to just complete the remote names, and not add rm to the list of subcommand completions if we're all ok with that! -- Keith Smiley On 12/30, Ævar Arnfjörð Bjarmason wrote: On Sat, Dec 30 2017, Todd Zullinger jotted: Ævar Arnfjörð

Re: [PATCH] Add shell completion for git remote rm

The goal of this fix isn't to complete rm itself (although that is a side effect), it's to complete the remote names after you type rm. Without this patch doing this: git remote rm Attempts to complete the options for `git remote` instead of the remote names. -- Keith Smiley

Re: [PATCH] completion: restore 'remote rm'

Updated: e17dba8fe1 ("remote: prefer subcommand name 'remove' to 'rm'", 2012-09-06) removed the 'rm' subcommand from completion. The 'remote rm' subcommand is still supported and not planned to be removed. Offer completions for it. Signe

Re: [PATCH] Add shell completion for git remote rm

Sorry about that! Patch below. Previously git remote rm did not complete your list of removes as remove does. Signed-off-by: Keith Smiley --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b

Re: [PATCH] Add shell completion for git remote rm

It looks like that was just about preferring remove in documentation and the like, I think it would still make sense to have both for completion since rm is still supported. -- Keith Smiley On 12/28, Todd Zullinger wrote: Hi Keith, Keith Smiley wrote: Previously git remote rm did not

[PATCH] Add shell completion for git remote rm

From: Keith Smiley Previously git remote rm did not complete your list of removes as remove does. --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index