On 10/15/19 6:55 AM, Derrick Stolee via GitGitGadget wrote:
V4 UPDATE: Rebased on latest master to include ew/hashmap and
ds/include-exclude in the base.
I did a partial review of the v4 patches out of curiosity and I notice
in sparse-checkout.c there are a couple of unchecked `fopen` call site
On 8/29/19 4:48 PM, Eric Sunshine wrote:
On Thu, Aug 29, 2019 at 7:12 PM Jon Simons wrote:
On 8/29/19 3:45 PM, Eric Sunshine wrote:
On Thu, Aug 29, 2019 at 6:38 PM Jon Simons wrote:
+ test_write_lines /* >sparse-src/all-files &&
Hmm, does this work correctly? I would
n earlier failure to resolve it,
and when an OID resolves but parsing the sparse filter spec fails.
t5616 is updated to demonstrate the change.
Co-authored-by: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Jon Simons
---
list-objects-filter.c| 6 +-
t/t5616-partial-clone.sh | 7
s a future direction.
t5616 is updated to demonstrate the change.
Signed-off-by: Jon Simons
---
list-objects-filter-options.c | 3 ++-
t/t5616-partial-clone.sh | 21 +
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-obje
Included here are two fixes for partial cloning with sparse filters.
These issues were uncovered in early testing internally at GitHub,
where Taylor and Peff have provided early offlist review feedback.
This third revision includes a fix for a test bug introduced in the
second revision.
Jon
On 8/29/19 3:45 PM, Eric Sunshine wrote:
On Thu, Aug 29, 2019 at 6:38 PM Jon Simons wrote:
Fix a bug in partial cloning with sparse filters by ensuring to check
for 'have_git_dir' before attempting to resolve the sparse filter OID.
[...]
Signed-off-by: Jon Simons
---
diff --git
n earlier failure to resolve it,
and when an OID resolves but parsing the sparse filter spec fails.
t5616 is updated to demonstrate the change.
Co-authored-by: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Jon Simons
---
list-objects-filter.c| 6 +-
t/t5616-partial-clone.sh | 7
f the test details: fixes, whitespace adjustment,
and some further simplifications -- thanks!
Jon Simons (2):
list-objects-filter: only parse sparse OID when 'have_git_dir'
list-objects-filter: handle unresolved sparse filter OID
list-objects-filter-options.c | 3 ++-
list-objects-f
s a future direction.
t5616 is updated to demonstrate the change.
Signed-off-by: Jon Simons
---
list-objects-filter-options.c | 3 ++-
t/t5616-partial-clone.sh | 21 +
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-obje
Included here are two fixes for partial cloning with sparse filters.
These issues were uncovered in early testing internally at GitHub,
where Taylor and Peff have provided early offlist review feedback.
Jon Simons (2):
list-objects-filter: only parse sparse OID when 'have_git_dir&#x
s a future direction.
t5616 is updated to demonstrate the change.
Signed-off-by: Jon Simons
---
list-objects-filter-options.c | 3 ++-
t/t5616-partial-clone.sh | 23 +++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/list-objects-filter-options.c b/list-obje
n earlier failure to resolve it,
and when an OID resolves but parsing the sparse filter spec fails.
t5616 is updated to demonstrate the change.
Co-authored-by: Jeff King
Signed-off-by: Jeff King
Signed-off-by: Jon Simons
---
list-objects-filter.c| 6 +-
t/t5616-partial-clone.sh | 7
From: Jeff King
The packet_read_line() function dies if it gets an
unexpected EOF. It only returns NULL if we get a flush
packet (or technically, a zero-length "0004" packet, but
nobody is supposed to send those, and they are
indistinguishable from a flush in this interface).
Let's correct error
error rather than segfault.
Signed-off-by: Jon Simons
---
remote-curl.c | 2 ++
send-pack.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/remote-curl.c b/remote-curl.c
index 0053b09..9903077 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -339,6 +339,8 @@ static struct discovery
Included here are a couple of fixes and cleanups for
handling NULL return values from 'packet_read_line'.
Jeff King (1):
correct error messages for NULL packet_read_line()
Jon Simons (1):
always check for NULL return from packet_read_line()
builtin/archive.c | 2 +-
fetch-pack.
15 matches
Mail list logo
