Re: [PATCH] Add .gitconfig variable commit.gpg-sign

2013-04-23 Thread Joel Jacobson
On Tue, Apr 23, 2013 at 8:25 PM, Junio C Hamano wrote: > Yup. > > And then we would need to add the same option to existing callers of > "git commit" (such as "git rebase") to pass it down the callchain. Got it. > But stepping back a bit, I have a suspicion that your upstream > project _only_ ca

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

2013-04-23 Thread Joel Jacobson
On Tue, Apr 23, 2013 at 6:53 PM, Junio C Hamano wrote: > I would consider such use of "git -c key=val" a last-resort escape > hatch to work around broken commands that do not implement a proper > escape hatch designed in to help users, unless the "key" is for > something very obscure and not meant

Re: [PATCH] Add .gitconfig variable commit.gpg-sign

2013-04-22 Thread Joel Jacobson
On Tue, Apr 23, 2013 at 12:43 AM, Junio C Hamano wrote: > No docs? No tests? Maybe simply adding this text to git-commit.txt, The default can be changed by the 'commit.gpg-sign' configuration variable (see linkgit:git-config[1]). after, -S[]:: --gpg-sign[=]:: GPG-sign commit. would be suffic