Re: [PATCH 28/29] blame: move scoreboard setup to libgit

2017-05-25 Thread Jeffrey Smith
I had meant to change the name to match what is in find_single_final. While the intent was for it to change while in builtin/blame.c, apparently I missed that in the shuffle. On Thu, May 25, 2017 at 12:53 AM, Junio C Hamano wrote: > Jeff Smith writes: > >> Signed-off-by: Jeff Smith >> --- >> b

Re: [RFC PATCH v2 00/22] Add blame to libgit

2017-05-15 Thread Jeffrey Smith
reboard is already causing each use to change (from xyz to sb->xyz). On Mon, May 15, 2017 at 7:23 PM, Junio C Hamano wrote: > Jeffrey Smith writes: > >> On Mon, May 15, 2017 at 4:24 AM, Junio C Hamano wrote: >>> Jeff Smith writes: >>> >>>> Rather than

Re: [RFC PATCH v2 00/22] Add blame to libgit

2017-05-15 Thread Jeffrey Smith
I did try to keep any unnecessary changes out of the big movement patches (17-19). Would you prefer I break down 19 further? I had been holding back because of the added churn that would introduce from lots of changing function visibility in blame.h and blame.c. (And if gmail would quit trying t

Re: [RFC PATCH 01/10] Remove unneeded dependency on blob.h from blame

2017-05-05 Thread Jeffrey Smith
ved use of blob_type. I will update the commit message accordingly. Thanks On Fri, May 5, 2017 at 8:52 AM, Jeffrey Smith wrote: > While it was added there (it was part of builtin pickaxe which was > renamed builtin blame), it was actually needed then, but I do see > what you are gettin