From: Jeff Hostetler
When Git updates the working directory with the sparse-checkout
feature enabled, the unpack_trees() method calls clear_ce_flags()
to update the skip-wortree bits on the cache entries. This
check can be expensive, depending on the patterns used.
Add trace2 regions around the
From: Jeff Hostetler
When Git updates the working directory with the sparse-checkout
feature enabled, the unpack_trees() method calls clear_ce_flags()
to update the skip-wortree bits on the cache entries. This
check can be expensive, depending on the patterns used.
Add trace2 regions around the
From: Jeff Hostetler
When Git updates the working directory with the sparse-checkout
feature enabled, the unpack_trees() method calls clear_ce_flags()
to update the skip-wortree bits on the cache entries. This
check can be expensive, depending on the patterns used.
Add trace2 regions around the
On 9/19/2019 6:47 PM, Josh Steadmon wrote:
On 2019.09.19 14:23, Jeff Hostetler wrote:
On 9/16/2019 2:20 PM, Josh Steadmon wrote:
On 2019.09.16 10:11, Jeff Hostetler wrote:
On 9/16/2019 8:07 AM, Derrick Stolee wrote:
On 9/13/2019 8:26 PM, Josh Steadmon wrote:
Add a new "ove
On 9/16/2019 2:20 PM, Josh Steadmon wrote:
On 2019.09.16 10:11, Jeff Hostetler wrote:
On 9/16/2019 8:07 AM, Derrick Stolee wrote:
On 9/13/2019 8:26 PM, Josh Steadmon wrote:
Add a new "overload" event type for trace2 event destinations. Write
this event into the sentinel file
From: Jeff Hostetler
When Git updates the working directory with the sparse-checkout
feature enabled, the unpack_trees() method calls clear_ce_flags()
to update the skip-wortree bits on the cache entries. This
check can be expensive, depending on the patterns used.
Add trace2 regions around the
On 9/14/2019 9:09 PM, Jeff King wrote:
On Mon, Sep 09, 2019 at 01:08:24PM -0400, Jeff King wrote:
I'll work up what I sent earlier into a real patch, and include some of
this discussion.
Here it is. I pulled Jon's tests out into their own patch (mostly
because it makes it easier to give cr
On 9/16/2019 8:07 AM, Derrick Stolee wrote:
On 9/13/2019 8:26 PM, Josh Steadmon wrote:
Add a new "overload" event type for trace2 event destinations. Write
this event into the sentinel file created by the trace2.maxFiles
feature. Bump up the event format version since we've added a new event
r-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
pr-323/garimasi514/coreGit-commit-graph-trace2-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/323
Looks good to me. Thanks!
Signed-off-by: Jeff Hostetler
On 9/9/2019 1:08 PM, Jeff King wrote:
On Mon, Sep 09, 2019 at 09:54:36AM -0400, Jeff Hostetler wrote:
It would be nice if we could continue to let parse_list_objects_filter()
do the syntax checking -- that is, we can still check that we received a
ulong in "blob:limit:" and that &
On 9/9/2019 1:12 PM, Junio C Hamano wrote:
Jeff Hostetler writes:
It would be nice if we could continue to let parse_list_objects_filter()
do the syntax checking -- that is, we can still check that we received a
ulong in "blob:limit:" and that "sparse:oid:" looks l
laced with something like the (totally untested)
approach below, which just pushes the parsing closer to the
point-of-use.
Adding Jeff Hostetler to the cc, in case he recalls any reason not to
use that approach.
Thanks.
I think both of Peff's guesses are correct.
IIRC I wrote the original
On 8/25/2019 1:44 PM, René Scharfe wrote:
Let warning() format the message instead of using an intermediate strbuf
for that. This is shorter, easier to read and avoids an allocation.
Signed-off-by: René Scharfe
---
trace2/tr2_dst.c | 9 ++---
1 file changed, 2 insertions(+), 7 deleti
From: Jeff Hostetler
The clear_ce_flags_1 method is used by many types of calls to
unpack_trees(). Add trace2 regions around the method, including
some flag information, so we can get granular performance data
during experiments.
Signed-off-by: Jeff Hostetler
Signed-off-by: Derrick Stolee
On 8/9/2019 1:54 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
+/*
+ * Legacy function to append each argv value, quoted as necessasry,
+ * with whitespace before each value. This results in a leading
+ * space in the result.
+ */
void sq_quote_argv_pre
On 8/8/2019 6:49 PM, René Scharfe wrote:
Am 08.08.19 um 21:04 schrieb Jeff Hostetler:
On 8/8/2019 2:05 PM, Junio C Hamano wrote:
Having made the primary purpose of the helper clearer leads me to
wonder if "do not add SP before the first element, i.e. argv[0]", is
really what we wa
From: Jeff Hostetler
Truncate/elide very long "filename:linenumber" field.
Truncate region and data "category" field if necessary.
Adjust overall column widths.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 39 +--
1 file ch
V2 of this patch series cleans up some whitespace and column alignment
issues in the trace2 perf and normal formats. It also removes some dead
code.
Jeff Hostetler (7):
trace2: cleanup column alignment in perf target format
trace2: trim whitespace in region messages in perf target format
From: Jeff Hostetler
sq_quote_argv_pretty() builds a "pretty" string from the given argv.
It inserts whitespace before each value, rather than just between
them, so the resulting string always has a leading space. Lets give
callers an option to not have the leading space or have to
From: Jeff Hostetler
Avoid creating unnecessary trailing whitespace in normal
target format error messages when the message is omitted.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/trace2/tr2_tgt_normal.c
From: Jeff Hostetler
Avoid unecessary trailing whitespace in "region_enter" and "region_leave"
messages in perf target format.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/tra
From: Jeff Hostetler
Remove an unnecessary "if" block in maybe_add_string_va().
Commit "ad006fe419e trace2: NULL is not allowed for va_list"
changed "if (fmt && *fmt && ap)" to just "if (fmt && *fmt)"
because it isn't sa
From: Jeff Hostetler
Make use of new sq_append_quote_argv_pretty() to normalize
how we handle leading whitespace in perf format messages.
Signed-off-by: Jeff Hostetler
---
t/t0211-trace2-perf.sh | 4 ++--
trace2/tr2_tgt_perf.c | 31 ---
2 files changed, 22
From: Jeff Hostetler
Make use of new sq_append_quote_argv_pretty() to normalize
how we handle leading whitespace in normal format messages.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a
On 8/8/2019 2:05 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
Create version of sq_quote_argv_pretty() that does not
insert a leading space before argv[0].
Signed-off-by: Jeff Hostetler
---
quote.c | 11 +++
quote.h
From: Jeff Hostetler
Make use of new sq_quote_argv_pretty_ltrim() to normalize
how we handle leading whitespace in normal format messages.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a
From: Jeff Hostetler
Avoid unecessary trailing whitespace in "region_enter" and "region_leave"
messages in perf target format.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/tra
From: Jeff Hostetler
Remove an unnecessary "if" block in maybe_add_string_va().
Commit "ad006fe419e trace2: NULL is not allowed for va_list"
changed "if (fmt && *fmt && ap)" to just "if (fmt && *fmt)"
because it isn't sa
From: Jeff Hostetler
Make use of new sq_quote_argv_pretty_ltrim() to normalize
how we handle leading whitespace in perf format messages.
Signed-off-by: Jeff Hostetler
---
t/t0211-trace2-perf.sh | 4 ++--
trace2/tr2_tgt_perf.c | 31 ---
2 files changed, 22
From: Jeff Hostetler
Create version of sq_quote_argv_pretty() that does not
insert a leading space before argv[0].
Signed-off-by: Jeff Hostetler
---
quote.c | 11 +++
quote.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/quote.c b/quote.c
index 7f2aa6faa4..7cad8798ac 100644
From: Jeff Hostetler
Avoid creating unnecessary trailing whitespace in normal
target format error messages when the message is omitted.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_normal.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/trace2/tr2_tgt_normal.c
From: Jeff Hostetler
Truncate/elide very long "filename:linenumber" field.
Truncate region and data "category" field if necessary.
Adjust overall column widths.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 39 +--
1 file ch
V2 of this patch series cleans up some whitespace and column alignment
issues in the trace2 perf and normal formats. It also removes some dead
code.
Jeff Hostetler (7):
trace2: cleanup column alignment in perf target format
trace2: trim whitespace in region messages in perf target format
On 8/1/2019 5:34 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
Trim leading/trailing whitespace from the command line
printed in the "start" message in the perf target format.
We use `sq_quote_argv_pretty()` to format the m
On 8/2/2019 6:02 PM, Josh Steadmon wrote:
trace2 can write files into a target directory. With heavy usage, this
directory can fill up with files, causing difficulty for
trace-processing systems.
This patch adds a config option (trace2.maxFiles) to set a maximum
number of files that trace2 wi
On 7/31/2019 8:49 PM, Jeff King wrote:
On Wed, Jul 31, 2019 at 07:12:57PM -0400, Jeff King wrote:
Hrm. But common-main calls initialize_the_repository(), which points it
at &the_repo. And I can't find any other assignments. So how does it
become NULL? And is every caller of have_git_dir() at
This patch series contains a few column alignment and whitespace fixes for
perf target format. This should make it a little easier to read.
Jeff Hostetler (3):
trace2: cleanup column alignment in perf target format
trace2: trim whitespace in start message in perf target format
trace2: trim
From: Jeff Hostetler
Trim trailing whitespace in "region_enter" and "region_leave"
messages in perf target format.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/trace2/tr2_tgt_perf.c b/trace2/tr2_tgt_per
From: Jeff Hostetler
Truncate/elide very long "filename:linenumber" field.
Truncate region and data "category" field if necessary.
Adjust overall column widths.
Signed-off-by: Jeff Hostetler
---
trace2/tr2_tgt_perf.c | 39 +--
1 file ch
From: Jeff Hostetler
Trim leading/trailing whitespace from the command line
printed in the "start" message in the perf target format.
We use `sq_quote_argv_pretty()` to format the message
and it adds a leading space to the output. Trim that.
Signed-off-by: Jeff Hostetler
-
On 7/29/2019 6:20 PM, Josh Steadmon wrote:
trace2 can write files into a target directory. With heavy usage, this
directory can fill up with files, causing difficulty for
trace-processing systems.
I'm routing data in my org to a daemon via a Named Pipe or UD Socket,
so I'm not seeing the tho
On 7/29/2019 6:20 PM, Josh Steadmon wrote:
trace2 can write files into a target directory. With heavy usage, this
directory can fill up with files, causing difficulty for
trace-processing systems.
When trace2 would write a file to a target directory, first check
whether or not the directory i
On 6/21/2019 7:53 AM, Jakub Narebski wrote:
Josh Steadmon writes:
On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote:
On Wed, Jun 12 2019, Josh Steadmon wrote:
trace_schema_validator can be used to verify that trace2 event output
conforms to the expectations set by the API documentation a
On 6/27/2019 6:48 AM, Duy Nguyen wrote:
On Tue, Jun 25, 2019 at 7:40 PM Derrick Stolee wrote:
On 6/25/2019 6:29 AM, Duy Nguyen wrote:
On Tue, Jun 25, 2019 at 3:06 AM Jeff Hostetler wrote:
I'm curious how big these EWAHs will be in practice and
how useful an array of integers wi
On 6/26/2019 4:03 PM, Carlo Marcelo Arenas Belón wrote:
an apparent typo for the environment variable was included with 81567caf87
("trace2: update docs to describe system/global config settings",
2019-04-15), and was missed when renamed variables by e4b75d6a1d
("trace2: rename environment var
On 6/21/2019 12:33 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
The --[no-]ahead-behind option was introduced in fd9b544a
(status: add --[no-]ahead-behind to status and commit for V2
format, 2018-01-09). This is a necessary change o
On 6/25/2019 5:52 AM, Duy Nguyen wrote:
On Tue, Jun 25, 2019 at 2:15 AM Jeff Hostetler wrote:
@@ -202,6 +202,28 @@ void jw_object_null(struct json_writer *jw, const char
*key)
strbuf_addstr(&jw->json, "null");
}
+void jw_object_filemode(struct json_writer *jw
From: Jeff Hostetler
With this patch, Git can be built using the Microsoft toolchain, via:
make MSVC=1 [DEBUG=1]
Third party libraries are built from source using the open source
"vcpkg" tool set. See https://github.com/Microsoft/vcpkg
On a first build, the vcpkg tools and
From: Jeff Hostetler
It is just called differently in MSVC's headers.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index d336d80670..d7525cf61d 100644
--- a/compat/m
From: Jeff Hostetler
This special-cases various signals that are not supported on Windows,
such as SIGPIPE. These cause the UCRT to throw asserts (at least in
debug mode).
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 25 +
1
From: Jeff Hostetler
VS2015's headers already declare that struct.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 210f1b01a8..a03e40e6e2 100644
--- a/c
From: Jeff Hostetler
The ntstatus.h header is only available in MINGW.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/winansi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/compat/winansi.c b/compat/winansi.c
index f4f08237f9..11cd9b82cc
From: Jeff Hostetler
In MS Visual C, the `DEBUG` constant is set automatically whenever
compiling with debug information.
This is clearly not what was intended in `cache-tree.c` nor in
`builtin/blame.c`, so let's use a less ambiguous name there.
Signed-off-by: Jeff Hostetler
Signed-o
From: Jeff Hostetler
Ignore .dll files copied into the top-level directory.
Ignore MSVC incremental compiler output files.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
.gitignore | 5 +
1 file changed, 5 insertions(+)
diff --git a/.gitignore b/.gitignore
index
From: Jeff Hostetler
VS2015 complains when using a const pointer in memcpy()/free().
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 0d8713e515
From: Jeff Hostetler
It is quite common that MS Visual C++ is installed into a location whose
path contains spaces, therefore we need to quote it.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: Jeff Hostetler
MS Visual C comes with a few neat features we can use to analyze the
heap consumption (i.e. leaks, max memory, etc).
With this patch, we introduce support via the build-time flag
`USE_MSVC_CRTDBG`.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
On 6/24/2019 9:02 AM, Nguyễn Thái Ngọc Duy wrote:
Signed-off-by: Nguyễn Thái Ngọc Duy
---
json-writer.c | 14 ++
json-writer.h | 3 +++
split-index.c | 9 -
t/t3011-ls-files-json.sh | 14 ++
t/t3011/split-index (new)
On 6/24/2019 9:02 AM, Nguyễn Thái Ngọc Duy wrote:
The big part of UNTR extension is dumped at the end instead of dumping
as soon as we read it, because we actually "patch" some fields in
untracked_cache_dir with EWAH bitmaps at the end.
Signed-off-by: Nguyễn Thái Ngọc Duy
---
dir.c
On 6/24/2019 9:02 AM, Nguyễn Thái Ngọc Duy wrote:
So far we don't have a command to basically dump the index file out,
with all its glory details. Checking some info, for example, stat
time, usually involves either writing new code or firing up "xxd" and
decoding values by yourself.
This --js
On 6/24/2019 2:00 PM, Johannes Schindelin wrote:
Hi Duy,
On Mon, 24 Jun 2019, Nguyễn Thái Ngọc Duy wrote:
- json field names now use '_' instead of '.' to be friendlier to some
languages. I stick to underscore_name instead of camelCase because
the former is closer to what we use
Thi
On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:
This is probably just my itch. Every time I have to do something with
the index, I need to add a little bit code here, a little bit there to
get a better "view" of the index.
This solves it for me. It allows me to see pretty much everything in
From: Jeff Hostetler
The ntstatus.h header is only available in MINGW.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/winansi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/compat/winansi.c b/compat/winansi.c
index f4f08237f9..11cd9b82cc
From: Jeff Hostetler
With this patch, Git can be built using the Microsoft toolchain, via:
make MSVC=1 [DEBUG=1]
Third party libraries are built from source using the open source
"vcpkg" tool set. See https://github.com/Microsoft/vcpkg
On a first build, the vcpkg tools and
From: Jeff Hostetler
It is just called differently in MSVC's headers.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index d336d80670..d7525cf61d 100644
--- a/compat/m
From: Jeff Hostetler
In MS Visual C, the `DEBUG` constant is set automatically whenever
compiling with debug information.
This is clearly not what was intended in `cache-tree.c` nor in
`builtin/blame.c`, so let's use a less ambiguous name there.
Signed-off-by: Jeff Hostetler
Signed-o
From: Jeff Hostetler
Ignore .dll files copied into the top-level directory.
Ignore MSVC incremental compiler output files.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
.gitignore | 5 +
1 file changed, 5 insertions(+)
diff --git a/.gitignore b/.gitignore
index
From: Jeff Hostetler
MS Visual C comes with a few neat features we can use to analyze the
heap consumption (i.e. leaks, max memory, etc).
With this patch, we introduce support via the build-time flag
`USE_MSVC_CRTDBG`.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
From: Jeff Hostetler
VS2015's headers already declare that struct.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 210f1b01a8..a03e40e6e2 100644
--- a/c
From: Jeff Hostetler
This special-cases various signals that are not supported on Windows,
such as SIGPIPE. These cause the UCRT to throw asserts (at least in
debug mode).
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 25 +
1
From: Jeff Hostetler
VS2015 complains when using a const pointer in memcpy()/free().
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 0d8713e515
From: Jeff Hostetler
It is quite common that MS Visual C++ is installed into a location whose
path contains spaces, therefore we need to quote it.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
From: Jeff Hostetler
Teach porcelain V[12] formats to ignore the status.aheadbehind
config setting. They only respect the --[no-]ahead-behind
command line argument. This is for backwards compatibility
with existing scripts.
Signed-off-by: Jeff Hostetler
Signed-off-by: Derrick Stolee
From: Jeff Hostetler
The ahead/behind calculation in 'git status' can be slow in some
cases. Users may not realize that there are ways to avoid this
computation, especially if they are not using the information.
Add a warning that appears if this calculation takes more than
two se
From: Jeff Hostetler
The --[no-]ahead-behind option was introduced in fd9b544a
(status: add --[no-]ahead-behind to status and commit for V2
format, 2018-01-09). This is a necessary change of behavior
in repos where the remote tracking branches can move very
quickly ahead of the local branches
On 6/18/2019 10:31 AM, Vanak, Ibrahim wrote:
Hello ALL again,
Has anyone tested the performance of GIT on HP-UX platform? Can someone please
look into the issue we are seeing.
Thanks,
Ibrahim
You might try setting some of the GIT_TRACE* environment variables
listed in [1] on both your HP
From: Jeff Hostetler
It is just called differently in MSVC's headers.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/msvc.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/msvc.h b/compat/msvc.h
index d336d80670..d7525cf61d 100644
--- a/compat/m
From: Jeff Hostetler
In MSVC, the DEBUG constant is set automatically whenever compiling with
debug information.
This is clearly not what was intended in cache-tree.c, so let's use a less
ambiguous constant there.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
From: Jeff Hostetler
VS2015 complains when using a const pointer in memcpy()/free().
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/compat/mingw.c b/compat/mingw.c
index 0d8713e515
From: Jeff Hostetler
VS2015's headers already declare that struct.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/compat/mingw.h b/compat/mingw.h
index 210f1b01a8..a03e40e6e2 100644
--- a/c
From: Jeff Hostetler
This special-cases various signals that are not supported on Windows,
such as SIGPIPE. These cause the UCRT to throw asserts (at least in
debug mode).
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/mingw.c | 26 ++
1
From: Jeff Hostetler
With this patch, Git can be built using the Microsoft toolchain, via:
make MSVC=1 [DEBUG=1]
Third party libraries are built from source using the open source
"vcpkg" tool set. See https://github.com/Microsoft/vcpkg
On a first build, the vcpkg tools and
From: Jeff Hostetler
Ignore .dll files copied into the top-level directory.
Ignore MSVC incremental compiler output files.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
.gitignore | 5 +
1 file changed, 5 insertions(+)
diff --git a/.gitignore b/.gitignore
index
From: Jeff Hostetler
The ntstatus.h header is only available in MINGW.
Signed-off-by: Jeff Hostetler
Signed-off-by: Johannes Schindelin
---
compat/winansi.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/compat/winansi.c b/compat/winansi.c
index f4f08237f9..11cd9b82cc
On 6/11/2019 7:31 PM, Josh Steadmon wrote:
Define a JSON schema[1] that can be used to validate trace2 event
objects. This can be used to add regression tests to verify that the
event output format does not change unexpectedly.
Two versions of the schema are provided:
* event_schema.json is m
On 6/11/2019 7:31 PM, Josh Steadmon wrote:
Correct the api-trace2 documentation, which lists "signal" as an
expected field for the signal event type, but which actually outputs
"signo" as the field name.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 2 +-
1 fil
On 6/11/2019 11:04 AM, Christian Hesse wrote:
Dear Jeff, dear Junio,
for cgit we use the static git library built into the executable. This used
to work well, but breaks with latest release v2.22.0: Our code unsets HOME
and XDG_CONFIG_HOME to mitigate loading arbitrary configuration.
We have
On 6/10/2019 8:26 AM, SZEDER Gábor wrote:
On Sat, Jun 08, 2019 at 07:42:42AM -0700, Jeff Hostetler via GitGitGadget wrote:
From: Jeff Hostetler
Teach register_rename_src() to see if new file pair
can simply be appended to the rename_src[] array before
performing the binary search to find
On 6/8/2019 10:42 AM, Johannes Schindelin via GitGitGadget wrote:
Just another patch from Git for Windows' branch thicket...
Jeff Hostetler (1):
diffcore-rename: speed up register_rename_src
diffcore-rename.c | 13 +
1 file changed, 13 insertions(+)
base-c
On 6/8/2019 6:27 PM, René Scharfe wrote:
Am 08.06.19 um 16:42 schrieb Jeff Hostetler via GitGitGadget:
From: Jeff Hostetler
Teach register_rename_src() to see if new file pair
can simply be appended to the rename_src[] array before
performing the binary search to find the proper insertion
From: Jeff Hostetler
Teach register_rename_src() to see if new file pair
can simply be appended to the rename_src[] array before
performing the binary search to find the proper insertion
point.
This is a performance optimization. This routine is called
during run_diff_files in status and the
On 6/6/2019 9:08 PM, Emily Shaffer wrote:
Demonstrate how filter specs can be used when performing a revision walk
of all object types. In this case, tree depth is used. Contributors who
are following the revision walking tutorial will be encouraged to run
the revision walk with and without th
On 6/7/2019 2:38 AM, Christian Couder wrote:
On Thu, Jun 6, 2019 at 10:18 PM Emily Shaffer wrote:
I grepped the Git source and found that we only provide a non-NULL
"omitted" when someone calls "git rev-list --filter-print-omitted",
which we verify with a simple test case for "blobs:none"
On 6/6/2019 6:32 PM, Matthew DeVore wrote:
On Mon, Jun 03, 2019 at 05:51:28PM -0400, Jeff Hostetler wrote:
Since we are assuming 'compose' is an AND operation, there may be an
opportunity to short-cut some of this loop for blobs. That is, if the
object is a blob and any filter
On 6/3/2019 4:18 PM, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee
Several advanced config settings are highly recommended for clients
using large repositories. Power users learn these one-by-one and
enable them as they see fit. This could be made simpler, to allow
more users t
-encoding feature in terms of the
repeated flag.
Helped-by: Emily Shaffer
Helped-by: Jeff Hostetler
Helped-by: Junio C Hamano
Signed-off-by: Matthew DeVore
---
list-objects-filter-options.c | 135 ++-
list-objects-filter-options.h | 17 ++-
list-objects-filter.c
On 5/31/2019 8:35 PM, Matthew DeVore wrote:
Here is a roll-up with hopefully all comments applied or responded to. Notable
changes since the last one include:
- Added an ALLOC_GROW_BY which is used twice by this patchset to make growing
arrays safer and cleaner
- Cleaned up the URL-en
On 5/31/2019 4:53 PM, Matthew DeVore wrote:
On Thu, May 30, 2019 at 10:01:47AM -0400, Jeff Hostetler wrote:
BTW, I don't think I've seen this mentioned anywhere and I don't
remember if this got into the code or not. But we discussed having
a repo-local config setting to reme
From: Jeff Hostetler
Signed-off-by: Jeff Hostetler
Signed-off-by: Derrick Stolee
---
advice.c| 2 ++
advice.h| 1 +
wt-status.c | 17 +
3 files changed, 20 insertions(+)
diff --git a/advice.c b/advice.c
index ce5f374ecd..54f8dea30c 100644
--- a/advice.c
+++ b
From: Jeff Hostetler
Teach porcelain V[12] formats to ignore the status.aheadbehind
config setting. They only respect the --[no-]ahead-behind
command line argument. This is for backwards compatibility
with existing scripts.
Signed-off-by: Jeff Hostetler
Signed-off-by: Derrick Stolee
1 - 100 of 1018 matches
Mail list logo
