> One thing I wondered about is whether this should be enabled by
> default or not. Long-time users of git-p4 might be a bit surprised to
> find their git commits suddenly gaining an extra Job: field.
I thought about that too when but then I realized that there's no
switch for the reverse directio
> By the way, you may or may not have noticed that I've been
> reordering the lines of your message quoted in my responses; around
> here, top-posting is frowned upon.
I haven't noticed. Thanks for pointing out.
As for the submitGit cover letter I wanted to raise at least an issue
(if not create
same as for one of the commits.
Maybe submitGit tried to be smart there? Or maybe it just really
doesn't support it (yet?).
On Tue, Apr 19, 2016 at 11:09 PM, Junio C Hamano wrote:
> Jan Durovec writes:
>
>> On Tue, Apr 19, 2016 at 8:50 PM, Jan Durovec wrote:
>>>> Any
Huh... seems that it works :)
v3 sent in 2 parts
On Tue, Apr 19, 2016 at 8:50 PM, Jan Durovec wrote:
>> Any submitGit users? I think it lets you throw multiple-patch
>> series just fine. In this case, you'd prepare a two patch series on
>> a branch, 1/2 being the cle
commit messages on git side).
The jobs are added to the message in the same format as is expected when
migrating in the reverse direction.
Signed-off-by: Jan Durovec
---
git-p4.py | 12 ++
t/lib-git-p4.sh| 9 +
t/t9829-git-p4-jobs.sh | 99
Preliminary clean-up of testing libraries for git-p4.
* spaces added to both sides of () in function definitions in lib-git-p4
* tab indentation added to git-p4 tests when <<- redirection is used
Signed-off-by: Jan Durovec
---
t/lib-git-p4.sh | 24 +++
t
> Any submitGit users? I think it lets you throw multiple-patch
> series just fine. In this case, you'd prepare a two patch series on
> a branch, 1/2 being the clean-up and 2/2 being the new feature, and
> if you give that branch to submitGit as a whole it should do the
> right thing, I'd imagine
owing patch I'll
* add spaces before () for functions in t/lib-git-p4.sh
* remove name local variable in p4_add_job/user in t/lib-git-p4.sh
* fix t/t98* leading tabs where <<- is used
On Tue, Apr 19, 2016 at 7:47 PM, Junio C Hamano wrote:
> Jan Durovec writes:
>
>> given t
Hi,
given the fact that the rest of the code just follows existing
source code style, i.e.
* using %s not %d to add number to string (see git-p4.py:2301)
* no space between function name and parentheses (see all functions
in t/lib-git-p4.sh)
* no tab when specifying in-line expected output (see
commit messages on git side).
The jobs are added to the message in the same format as is expected when
migrating in the reverse direction.
Signed-off-by: Jan Durovec
---
git-p4.py | 12 ++
t/lib-git-p4.sh| 10 +
t/t9829-git-p4-jobs.sh | 99
e advise how to mark it as executable? Does it need to be
added to some configuration file? Or am I interpreting the error
message incorrectly?
Regards,
Jan
On Sat, Apr 16, 2016 at 12:10 AM, Luke Diamand wrote:
> On 15 April 2016 at 21:27, Junio C Hamano wrote:
>> Jan Durovec writes
---
git-p4.py | 12
1 file changed, 12 insertions(+)
diff --git a/git-p4.py b/git-p4.py
index 527d44b..a81795f 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -2320,6 +2320,15 @@ def extractFilesFromCommit(self, commit):
fnum = fnum + 1
return files
+def extract
12 matches
Mail list logo
