[PATCH v2] parse-options: fix the description of defval

OPTION_BIT and OPTION_SET_INT do not store pointers in defval. Signed-off-by: Ivan Ukhov --- parse-options.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/parse-options.h b/parse-options.h index 7940bc7..c71e9da 100644 --- a/parse-options.h +++ b/parse-options.h @@ -95,8

Re: [PATCH] parse-options: fix the description of defval

> Paul Tan writes: > >> On Sun, Mar 29, 2015 at 4:32 PM, Ivan Ukhov wrote: >>> Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. >>> >> >> Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING >> and OPTI

[PATCH] commit: add -f to force creation when no changes or an empty message

. Signed-off-by: Ivan Ukhov --- builtin/commit.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/builtin/commit.c b/builtin/commit.c index da79ac4..fb76aee 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -113,7 +113,7 @@ static char *fixup_message, *squash_message

Re: [PATCH] parse-options: fix the description of defval

Hello Paul, Yes, you are right. Thank you for the clarification! Regards, Ivan > On Mar 29, 2015, at 3:27 PM, Paul Tan wrote: > > Hi, > > On Sun, Mar 29, 2015 at 5:28 PM, Ivan Ukhov wrote: >> I have checked the definitions of the three macros you mentioned, and it

Re: [PATCH] parse-options: fix the description of defval

Hello Paul, > On Mar 29, 2015, at 11:08 AM, Paul Tan wrote: > > Actually, it can contain a pointer for OPTION_CMDMODE, OPTION_STRING > and OPTION_FILENAME. I have checked the definitions of the three macros you mentioned, and it seems that none of them uses defval to store pointers. OPTION_CM

[PATCH] parse-options: fix the description of defval

Since the deletion of OPT_SET_PTR, defval can no longer contain a pointer. Signed-off-by: Ivan Ukhov --- parse-options.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/parse-options.h b/parse-options.h index 7940bc7..c71e9da 100644 --- a/parse-options.h +++ b/parse