Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-08 Thread Harish Karumuthil
Hi all, there is an update: I added necessary error catching code so that, script will not crash if the keybinding code is worng. Instead of crashing it will print error message. The final patch will look something like this. --- lib/tools.tcl | 24 1 file changed, 20 in

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Harish Karumuthil
Hi Johannes Schindelin, Regarding your messages, > However, it might not even need to put in _such_ a lot of work: in my > tests, `Control-,` worked just as well as `Control-comma`. To test this > for yourself, use this snippet (that is slightly modified from the > example at the bottom of https:

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Harish Karumuthil
Hi Pratyush, Regarding your messages, >On Sun, 2019-10-06 at 02:31 +0530, Pratyush Yadav wrote: > You don't need to "set up" an email client with git-send-email. > git-send-email is an email client itself. Well, one which can only send > emails. For now, I am sticking with a mail client ( evolu

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-05 Thread Harish Karumuthil
Hi All, >From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I understood that, my current email client ( that is gmail web ) is not good for submitting patches. So I was tying to setup a mail client which is compatible with `git send-mail`. But I was not able to get a satisfact