[PATCH v5 1/1] sq_quote_buf_pretty: don't drop empty arguments

2019-10-08 Thread Garima Singh via GitGitGadget
From: Garima Singh Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Reported by: Junio Hamano Signed-off-by: Garim

[PATCH v5 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-10-08 Thread Garima Singh via GitGitGadget
Hey, Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Looking forward to your review. Cheers! Garima Singh Reported

[PATCH v4 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-10-07 Thread Garima Singh via GitGitGadget
Hey, Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Looking forward to your review. Cheers! Garima Singh Reported

[PATCH v4 1/1] sq_quote_buf_pretty: don't drop empty arguments

2019-10-07 Thread Garima Singh via GitGitGadget
From: Garima Singh Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Reported by: Junio Hamano Signed-off-by: Garim

[PATCH v3 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-10-07 Thread Garima Singh via GitGitGadget
Hey, The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. ''. Looking forward to

[PATCH v3 1/1] quote: handle numm and empty strings in sq_quote_buf_pretty

2019-10-07 Thread Garima Singh via GitGitGadget
From: Garima Singh The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. ''. We wa

[PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command

2019-08-27 Thread Garima Singh via GitGitGadget
Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, write and verify is a gre

[PATCH 1/1] commit-graph: emit trace2 cmd_mode for each sub-command

2019-08-27 Thread Garima Singh via GitGitGadget
From: Garima Singh Emit trace2_cmd_mode() messages for each commit-graph sub-command. The commit graph commands were in flux when trace2 was making it's way to git. Now that we have enough sub-commands in commit-graph, we can label the various modes within them. Distinguishing between read, writ

[PATCH v2 0/1] commit-graph: add --[no-]progress to write and verify

2019-08-26 Thread Garima Singh via GitGitGadget
Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very glad to have the opportunity to work with this community. I am new to the world of git client development but I did

[PATCH v2 1/1] commit-graph: add --[no-]progress to write and verify.

2019-08-26 Thread Garima Singh via GitGitGadget
From: Garima Singh Add --[no-]progress to git commit-graph write and verify. The progress feature was introduced in 7b0f229 ("commit-graph write: add progress output", 2018-09-17) but the ability to opt-out was overlooked. Signed-off-by: Garima Singh --- Documentation/git-commit-graph.txt | 7

[PATCH v2 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-08-26 Thread Garima Singh via GitGitGadget
Hey, The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. ''. Looking forward to

[PATCH v2 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-08-26 Thread Garima Singh via GitGitGadget
From: Garima Singh The sq_quote_buf_pretty() function does not emit anything when the incoming string is empty, but the function is to accumulate command line arguments, properly quoted as necessary, and the right way to add an argument that is an empty string is to show it quoted, i.e. ''. We wa

[PATCH 1/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-08-20 Thread Garima Singh via GitGitGadget
From: Garima Singh In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg is a zero length string. It should emit quote-quote rather than nothing. This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings. [1] https://public-inbox.org/git/pull.298.git.

[PATCH 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()

2019-08-20 Thread Garima Singh via GitGitGadget
Hey, In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg is a zero length string and how he believes the method should behave. This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings. Looking forward to your review. Cheers! Garima Singh [1] https:

[PATCH 0/1] commit-graph: add --[no-]progress to write and verify

2019-08-20 Thread Garima Singh via GitGitGadget
Hey Git contributors! My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very glad to have the opportunity to work with this community. I am new to the world of git client development but I did

[PATCH 1/1] commit-graph: add --[no-]progress to write and verify.

2019-08-20 Thread Garima Singh via GitGitGadget
From: Garima Singh Add --[no-]progress to git commit-graph write and verify. The progress feature was introduced in 7b0f229 ("commit-graph write: add progress output", 2018-09-17) but the ability to opt-out was overlooked. Signed-off-by: Garima Singh --- Documentation/git-commit-graph.txt | 4