[corrected David Barr's address]
On Monday 18 February 2013 12:42:39 Jeff King wrote:
> And I do not want to blame the students here (some of whom are on the cc
> list ). They are certainly under no obligation to stick around after
> GSoC ends, and I know they have many demands on their time. But
On Friday 14 December 2012 17:11:44 Jeff King wrote:
> [...]
> We can fix it by returning "-1" when no note is found (so on
> a zero return, we always found a valid value).
Good fix. Parsing of the note now always fails if the note doesn't contain the
expected string, as it should.
>
> Signed-
Sorry for reacting so late, I didn't read the list carefully in the last weeks
and my gmail filter somehow didn't trigger on that.
On Tuesday 02 October 2012 16:20:22 Junio C Hamano wrote:
> * fa/remote-svn (2012-09-19) 16 commits
> - Add a test script for remote-svn
> - remote-svn: add marks-f
ntly not reused.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
diff:
- style
- improve error detection while reading notes
- strtol instead of atol
- seperate strbufs in main
contrib/svn-fe/svn-fe.c |3 +-
remote-testsvn.
note. This can be refined as needed.
- "Revision-number"
- "Node-path"
- "Node-kind"
- "Node-action"
- "Node-copyfrom-path"
- "Node-copyfrom-rev"
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
vcs-svn/fast_
es to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
diff:
- style
- seperate strbufs in main.
remote-testsvn.c | 52 +---
1 file changed, 33 insertions(+), 19 deletions(-)
diff
ply to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
diff:
- remove glitch in function declaration.
contrib/svn-fe/svn-fe.c |
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
no diff
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index
-import on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
diff:
- style
- use seperate strbufs instead of sharing one in m
ode_ctx using the
already added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
On Tuesday 28 August 2012 10:49:34 Florian Achleitner wrote:
> Reroll includes fixups by Ramsey. Thanks!
> Diff:
> [..]
> - improve compatibility of integer types.
> [..]
This line is wrong in this series. Just delete it. Sorry.
--
To unsubscribe from this list: send the line "
ply to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.
ntly not reused.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |3 ++-
remote-testsvn.c| 67 ---
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 10 +--
vcs-svn/fast_ex
es to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/remote-testsvn.c b/remote-test
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4
-import on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 174 ++
1 file changed, 174 ins
Reroll includes fixups by Ramsey. Thanks!
Diff:
- Add missing dependency to rule in Makefile.
- improve compatibility of integer types.
- t9020-*.sh: remove excess slash in urls that makes python on windows
interpret it as a network path.
- t9020-*.sh: skip if python isn't available.
- replace g
Hi!
Thanks for your fixups. I'm currently integrating them in a new series.
On what platform did you find that problems?
Tried to reproduce them on 64bit Linux. Anyways the fixes look very reasonable.
Florian
On Thursday 23 August 2012 18:55:39 Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones
On Sunday 26 August 2012 21:32:58 Torsten Bögershausen wrote:
> > The reason is that contrib/svn-fe, where remote-svn is in, is not yet
> > built automatically by the toplevel makefile, so the remote helper can't
> > be found. If you build it manually it should work.
> > Working on it ..
>
> Hi F
ntly not reused.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |3 ++-
remote-testsvn.c| 67 ---
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 10 +--
vcs-svn/fast_ex
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4
note. This can be refined as needed.
- "Revision-number"
- "Node-path"
- "Node-kind"
- "Node-action"
- "Node-copyfrom-path"
- "Node-copyfrom-rev"
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
vcs-svn/fast_
es to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/remote-testsvn.c b/remote-test
ply to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.
-import on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 174 ++
1 file changed, 174 ins
Another improved series with fixups by Junio, and a little by me.
Diff:
- fix inconsistend indent in Documentation/git-remote-helpers.txt
- remove trailing newline in Makefile
- fix argument list and usage of regenerate_marks(void) in remote-svn.c
[PATCH v6 01/16] Implement a remote helper for sv
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
> Junio C Hamano writes:
> > I think you meant something like:
> >
> > init_notes(NULL, notes_ref, NULL, 0);
> >
> > marksfile = fopen(marksfilename, "r");
> > if (!marksfile) {
> > regenerate_marks(marksf
On Monday 20 August 2012 16:20:27 Junio C Hamano wrote:
> Junio C Hamano writes:
> > I think you meant something like:
> > init_notes(NULL, notes_ref, NULL, 0);
> >
> > marksfile = fopen(marksfilename, "r");
> > if (!marksfile) {
> >
> > regenerate_mar
ode_ctx using the
already added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
note. This can be refined as needed.
- "Revision-number"
- "Node-path"
- "Node-kind"
- "Node-action"
- "Node-copyfrom-path"
- "Node-copyfrom-rev"
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
vcs-svn/fast_
es to
open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 55 +++---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/remote-testsvn.c b/remote-test
ply to the 'capabilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.
ntly not reused.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
contrib/svn-fe/svn-fe.c |3 ++-
remote-testsvn.c| 67 ---
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 10 +--
vcs-svn/fast_ex
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4
-import on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner
Signed-off-by: Junio C Hamano
---
remote-testsvn.c | 174 ++
1 file changed, 174 ins
New version with these changes:
- includes fixups and changes by Junio from fa/remote-svn
- move contrib/svn-fe/remote-svn.c to remote-testsvn.c (in toplevel)
- add it to the toplevel Makefile
(needed to copy the linker rule, is there a nicer way?)
- check for prerequisite in test script (probab
On Monday 20 August 2012 22:56:35 Torsten Bögershausen wrote:
> t9020 from pu doesn't work for me (neither linux nor Mac OS)
>
> I haven't been able to find out more than this:
>
> Initialized empty Git repository in /home/tb/projects/git/git.pu/t/trash
> directory.t9020-remote-svn/.git/
> expect
On Monday 20 August 2012 09:45:30 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > Currently, the mark number is equal to the svn revision number the commit
> > corresponds to. I didn't want to break that, but not mandatory. We could
> > also split the mark namespac
On Saturday 18 August 2012 13:13:47 Junio C Hamano wrote:
> That indicates that one necessary patch to add logic to Makefile to
> go and build that subdirectory, at least before running the test,
> but possibly as part of the "all" target, is missing, isn't it?
>
> Or you can add, at the beginning
On Sunday 19 August 2012 23:57:23 Junio C Hamano wrote:
> Florian Achleitner writes:
> >> This change makes me uncomfortable.
> >> We are doubling up on hashing with fast-import.
> >> This introduces git-specific logic into vcs-svn.
>
> IIUC, vcs-svn/fast-ex
On Sunday 19 August 2012 04:37:35 David Michael Barr wrote:
> On Sat, Aug 18, 2012 at 6:40 AM, Florian Achleitner
>
> wrote:
> > Hi!
> >
> > This patch series should prepare vcs-svn/svndump.* for branch
> > detection. When starting with this feature I found th
On Saturday 18 August 2012 23:35:38 Junio C Hamano wrote:
> Junio C Hamano writes:
> [..]
> Just to show how, here is what I did just now.
> [..]
> Thanks.
Thanks for you guidance!
I'll base a new version on your fixups.
Florian
--
To unsubscribe from this list: send the line "unsubscribe git"
On Sunday 19 August 2012 16:29:02 Ramsay Jones wrote:
> In particular, gcc complains thus:
>
> CC vcs-svn/fast_export.o
> vcs-svn/fast_export.c: In function 'fast_export_begin_note':
> vcs-svn/fast_export.c:77: warning: long long unsigned int format, \
> different type arg
On Friday 17 August 2012 21:16:59 Junio C Hamano wrote:
> Comments from mentors and people interested in remote helpers?
>
> I did minimum line wrapping, typofix and small compilation fixes
> and queued these on 'pu'; I think I saw one commit whose message
> I didn't quite get what it was trying t
ually create a commit
and change/add/delete files according to the node_ctx using the already
added blobs.
This can also be used to create commits if the node metadata does not
come from a svndump, but is stored in e.g. notes, for later branch
detection.
Signed-off-by: Florian Achleitner
---
accumulate all Node data of a revision in memory
before processing it.
Signed-off-by: Florian Achleitner
---
vcs-svn/svndump.c | 207 +++--
vcs-svn/svndump.h |2 +
2 files changed, 124 insertions(+), 85 deletions(-)
diff --git a/vcs-svn/svndump.c
ntly not reused.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 67 +--
contrib/svn-fe/svn-fe.c |3 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 10 +--
vcs-svn/fast_export.h |6 ++--
vc
exist yet.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/svnrdump_sim.py | 53
1 file changed, 53 insertions(+)
create mode 100755 contrib/svn-fe/svnrdump_sim.py
diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe/svnrdump_sim.py
new file m
note. This can be refined on purpose, of course.
- "Revision-number"
- "Node-path"
- "Node-kind"
- "Node-action"
- "Node-copyfrom-path"
- "Node-copyfrom-rev"
Signed-off-by: Florian Achleitner
---
vcs-svn/fast_export.c | 14 ++
es to open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 55 ---
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib/svn-fe/remote-svn.c
index b8
ply to the 'capablilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c |4 ++--
vcs-svn/fa
Signed-off-by: Florian Achleitner
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4..5faa48e 100644
--- a/Documentation
The existing function only allows reading from a filename or
from stdin. Allow passing of a FD and an additional FD for
the back report pipe. This allows us to retrieve the name of
the pipe in the caller.
Signed-off-by: Florian Achleitner
---
vcs-svn/svndump.c | 22 ++
vcs
ort on its stdin. It buffers a batch of 'import' command
lines in a string_list before starting to process them.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 174 +++
1 file changed, 174 insertions(+)
create mode 100644 con
Hi!
Thanks for the reviews!
This series contains the follwing improvements.
I decided to summarize them here, sorted by topic instead of
attaching them to the patches.
all:
- remove all merge garbage and debugging legacy (hopefully).
- reviews: style
- reorder patches
remote-svn:
- review: refa
On Wednesday 15 August 2012 22:20:45 Florian Achleitner wrote:
> On Wednesday 15 August 2012 12:52:43 Junio C Hamano wrote:
> > Florian Achleitner writes:
> > > fast-import internally uses marks that refer to an object via its sha1.
> > > Those marks are created durin
On Wednesday 15 August 2012 12:52:43 Junio C Hamano wrote:
> Florian Achleitner writes:
> > fast-import internally uses marks that refer to an object via its sha1.
> > Those marks are created during import to find previously created objects.
> > At exit the accumulated marks
On Wednesday 15 August 2012 12:49:04 Junio C Hamano wrote:
> Florian Achleitner writes:
> > To provide metadata from svn dumps for further processing, e.g.
> > branch detection, attach a note to each imported commit that
> > stores additional information.
> > The notes
On Tuesday 14 August 2012 13:40:20 Junio C Hamano wrote:
> Florian Achleitner writes:
> > The fast-import commands 'cat-blob' and 'ls' can be used by remote-helpers
> > to retrieve information about blobs and trees that already exist in
> > fast-import&#x
On Tuesday 14 August 2012 13:07:32 Junio C Hamano wrote:
> Florian Achleitner writes:
> > Enable basic fetching from subversion repositories. When processing remote
> > URLs starting with svn::, git invokes this remote-helper.
> > It starts svnrdump to extract revision
Forget this patch! It contains some unwanted content. Something with rebasing
went wrong..
On Tuesday 14 August 2012 21:13:18 Florian Achleitner wrote:
> Use svnrdump_sim.py to emulate svnrdump without an svn server.
> Tests fetching, incremental fetching, fetching from file://,
>
On Tuesday 14 August 2012 13:46:43 Junio C Hamano wrote:
> Florian Achleitner writes:
> > Allow execution of git-remote-svn even if the binary
> > currently is located in contrib/svn-fe/.
> >
> > Signed-off-by: Florian Achleitner
> > ---
> >
> > g
On Tuesday 14 August 2012 13:14:12 Junio C Hamano wrote:
> Florian Achleitner writes:
> > Requires some sha.h to be used and the libraries
> > to be linked, this is currently hardcoded.
> >
> > Signed-off-by: Florian Achleitner
> > ---
> &g
Use svnrdump_sim.py to emulate svnrdump without an svn server.
Tests fetching, incremental fetching, fetching from file://,
and the regeneration of fast-import's marks file.
Signed-off-by: Florian Achleitner
---
t/t9020-remote-svn.sh |
one with an effort equal to unconditional regeneration.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 69 ++-
1 file changed, 68 insertions(+), 1 deletion(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib/svn-fe/remote-svn.c
in
exist yet.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/svnrdump_sim.py | 53
1 file changed, 53 insertions(+)
create mode 100755 contrib/svn-fe/svnrdump_sim.py
diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe/svnrdump_sim.py
new file m
ntly not reused.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 66 +--
contrib/svn-fe/svn-fe.c |3 +-
test-svn-fe.c |2 +-
vcs-svn/fast_export.c | 16 ---
vcs-svn/fast_export.h |
note. This can be refined on purpose, of course.
- "Revision-number"
- "Node-path"
- "Node-kind"
- "Node-action"
- "Node-copyfrom-path"
- "Node-copyfrom-rev"
Signed-off-by: Florian Achleitner
---
vcs-svn/fast_export.c | 13 +
es to open that file instead of invoking svnrdump.
Signed-off-by: Florian Achleitner
---
contrib/svn-fe/remote-svn.c | 59 ++-
1 file changed, 36 insertions(+), 23 deletions(-)
diff --git a/contrib/svn-fe/remote-svn.c b/contrib/svn-fe/remote-svn.c
index ce
ply to the 'capablilities' command.
Extend svndump and fast-export to allow passing the target ref.
Update svn-fe to be compatible.
Signed-off-by: Florian Achleitner
---
- fix hard-coded ref in test-svn-fe.c. Broke a testcase.
contrib/svn-fe/svn-fe.c |2 +-
test-svn-fe.c
Signed-off-by: Florian Achleitner
---
Documentation/git-remote-helpers.txt | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-remote-helpers.txt
b/Documentation/git-remote-helpers.txt
index f5836e4..5faa48e 100644
--- a/Documentation
The existing function only allows reading from a filename or
from stdin. Allow passing of a FD and an additional FD for
the back report pipe. This allows us to retrieve the name of
the pipe in the caller.
Fixes the filename could be NULL bug.
Signed-off-by: Florian Achleitner
---
- dup input
Enable basic fetching from subversion repositories. When processing remote URLs
starting with svn::, git invokes this remote-helper.
It starts svnrdump to extract revisions from the subversion repository in the
'dump file format', and converts them to a git-fast-import stream using
the functions of
Hi.
Version 3 of this series adds the 'bidi-import' capability, as suggested
Jonathan.
Diff details are attached to the patches.
04 and 05 are completely new.
[PATCH/RFC v3 01/16] Implement a remote helper for svn in C.
[PATCH/RFC v3 02/16] Integrate remote-svn into svn-fe/Makefile.
[PATCH/RFC v
On Sunday 12 August 2012 09:12:58 Jonathan Nieder wrote:
> Hi again,
>
> Florian Achleitner wrote:
> > back to the pipe-topic.
>
> Ok, thanks.
>
> [...]
>
> >> The way it's supposed to work is that in a bidi-import, the remote
> >> helpe
Hi,
back to the pipe-topic.
On Wednesday 01 August 2012 12:42:48 Jonathan Nieder wrote:
> Hi again,
>
> Florian Achleitner wrote:
> > When the first line arrives at the remote-helper, it starts importing one
> > line at a time, leaving the remaining lines in the pipe.
On Saturday 04 August 2012 23:53:58 Ramkumar Ramachandra wrote:
> Hi,
>
> Florian Achleitner wrote:
> > 1. Import linearly and split later:
> I think this approach will be a lot less messy if you can cleanly
> separate the fetching component from the mapper. Currently, svn
Hi!
I'm playing around in vcs-svn/ to start a framework for detecting and
processing branches in svndumps. So I wanted to let you know about my ideas.
Two approaches:
1. Import linearly and split later:
One idea is to import from svn linearly, i.e. one revision on top of it's
predecessor, like
On Tuesday 31 July 2012 15:43:57 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > I haven't tried that yet, nor do I remember anything where I've already
> > seen two processes writing to the same pipe.
>
> It's a perfectly normal and well supported
On Monday 30 July 2012 11:55:02 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > Hm .. that would mean, that both fast-import and git (transport-helper)
> > would write to the remote-helper's stdin, right?
>
> Yes, first git writes the list of refs to import, and
On Monday 30 July 2012 09:28:27 Junio C Hamano wrote:
> Florian Achleitner writes:
> > Enables basic fetching from subversion repositories. When processing
> > Remote URLs starting with svn::, git invokes this remote-helper.
> > It starts svnrdump to extract revision
On Monday 30 July 2012 14:15:53 Jonathan Nieder wrote:
> Junio C Hamano wrote:
> > Jonathan Nieder writes:
> >>> + /*
> >>> + * If the remote helper advertised the "refspec" capability,
> >>> + * it will have the written result of the import to the refs
> >
> > perhaps s/will have the written r
transport-helpers can advertise the 'refspec' capability,
if not a default refspec *:* is assumed. This explains
the post-processing of refs after fetching with fast-import.
Signed-off-by: Florian Achleitner
---
transport-helper.c | 15 +++
1 file changed, 15 insertion
On Monday 30 July 2012 03:29:52 Jonathan Nieder wrote:
> > Generally I like your prefered solution.
> > I think there's one problem:
> > The pipe needs to be created before the fork, so that the fd can be
> > inherited.
> The relevant pipe already exists at that point: the remote helper's
> stdin.
On Thursday 26 July 2012 10:29:51 Junio C Hamano wrote:
> Of course, if the dispatch loop has to be rewritten so that a
> central dispatcher decides what to call, individual input handlers
> do not need to say NOT_HANDLED nor TERMINATE, as the central
> dispatcher should keep track of the overall s
On Saturday 28 July 2012 02:00:31 Jonathan Nieder wrote:
> Thanks for explaining. Now we've discussed a few different approproaches,
> none of which is perfect.
>
> a. use --cat-blob-fd, no FIFO
>
>Doing this unconditionally would break platforms that don't support
>--cat-blob-fd=(descri
On Thursday 26 July 2012 09:54:26 Jonathan Nieder wrote:
>
> Since the svn remote helper relies on this, it seems worth working on,
> yeah. As for how to spend your time (and whether to beg someone else
> to work on it instead :)): I'm not sure what's on your plate or where
> you are with respect
On Thursday 26 July 2012 04:08:42 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > On Monday 02 July 2012 06:07:41 Jonathan Nieder wrote:
> [...]
>
> >>> +
> >>> +static inline void printd(const char* fmt, ...)
>
> [...]
>
> >
Florian Achleitner wrote:
> fast-import internally uses marks that refer to an object via its sha1.
> Those marks are created during import to find previously created objects.
> At exit the accumulated marks can be exported to a file and reloaded at
> startup, so that the previous marks a
On Thursday 26 July 2012 06:40:39 Jonathan Nieder wrote:
> Steven Michalske wrote:
> > On Jul 2, 2012, at 4:07 AM, Jonathan Nieder wrote:
> >> [...]
> >>
> >>> diff: Use fifo instead of pipe: Retrieve the name of the pipe from env
> >>> and open it for svndump.
> >>
> >> I'd prefer to avoid this
On Thursday 26 July 2012 03:14:43 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > Yes, I incorporated your review in the new version, as far as applicable.
> > But I didn't send you an answer on the detailed points.
> > I will send an answer to the previous review
Hi!
Most of this review went into the new version..
For the remaining points, some comments follow.
On Monday 02 July 2012 06:07:41 Jonathan Nieder wrote:
> Hi,
>
> Florian Achleitner wrote:
>
> > --- /dev/null
> > +++ b/contrib/svn-fe/remote-svn.c
> > @@ -0,0
On Thursday 26 July 2012 02:46:07 Jonathan Nieder wrote:
> Hi,
>
> Florian Achleitner wrote:
> > --- /dev/null
> > +++ b/contrib/svn-fe/remote-svn.c
> > @@ -0,0 +1,219 @@
> > +
> > +#include "cache.h"
> > +#include "remote.h&q
transport-helpers can advertise the 'refspec' capability,
if not a default refspec *:* is assumed. This explains
the post-processing of refs after fetching with fast-import.
Signed-off-by: Florian Achleitner
---
transport-helper.c | 15 +++
1 file changed, 15 insertion
Hi!
I decided to completely rewrite my commit history, I split, dropped, squashed,
and reordered.
And finally rebased it all onto the current master.
Hope this removed a lot of my personal confusion and makes the patches
more useful and understandable.
I think the remote helper does what it shou
On Tuesday 24 July 2012 14:50:49 Jonathan Nieder wrote:
> > It is unclear how this is different from giving the ceiling by
> > specifying it as the "END" in -rSTART:END command line. Is this
> > feature really needed?
>
> I think the idea is that you put this script (or a symlink to it) on
> your
o allow using the same dump file for simulating multiple
incremental imports the highest visible revision can be limited by
setting the environment variable SVNRMAX to that value. This
effectively limits HEAD to simulate the situation where higher
revs don't exist yet.
Signed-off-by:
On Monday 23 July 2012 18:24:40 Matthieu Moy wrote:
> You also have whitespace damages (i.e. line wrapping introduced by your
> mailer). Using git-send-email avoids this kind of problem (there are
> also some advices for some mailers in Documentation/SubmittingPatches).
Damn. That's usually no pro
exist yet.
Signed-off-by: Florian Achleitner
---
I had to fix the missing sign-off anyways..
contrib/svn-fe/svnrdump_sim.py | 53
1 file changed, 53 insertions(+)
create mode 100755 contrib/svn-fe/svnrdump_sim.py
diff --git a/contrib/svn-fe/svnrdum
On Monday 23 July 2012 07:59:21 Jonathan Nieder wrote:
> Florian Achleitner wrote:
> > To ease testing without depending on a reachable svn server, this
> > compact python script mimics parts of svnrdumps behaviour.
>
> Thanks. Mind if I forge your sign-off?
Ups. No proble
1 - 100 of 117 matches
Mail list logo
