Re: [PATCH v3][Outreachy] branch -D: allow - as abbreviation of @{-1}

2016-04-06 Thread elena petrashen
On Thu, Mar 31, 2016 at 10:26 PM, Junio C Hamano wrote: > Elena Petrashen writes: > >> @@ -214,6 +221,9 @@ static int delete_branches(int argc, const char **argv, >> int force, int kinds, >> const char *target; >&g

Re: [PATCH v3][Outreachy] branch -D: allow - as abbreviation of @{-1}

2016-04-06 Thread elena petrashen
On Tue, Apr 5, 2016 at 12:53 AM, Remi Galan Alfonso wrote: > elena petrashen wrote: >> On Thu, Mar 31, 2016 at 6:31 PM, Remi Galan Alfonso >> wrote: >> > Elena Petrashen wrote: >> >> +void delete_branch_advice(const char *name, const char *ref) &g

Re: [PATCH v3][Outreachy] branch -D: allow - as abbreviation of @{-1}

2016-04-04 Thread elena petrashen
On Thu, Mar 31, 2016 at 6:31 PM, Remi Galan Alfonso wrote: > Elena Petrashen wrote: >> +void delete_branch_advice(const char *name, const char *ref) >> +{ >> +const char fmt[] = >> +"\nNote: to restore the deleted branch:\n\ngit branch %s %s\n&qu

Re: [Outreachy] Git remote whitelist/blacklist

2016-04-04 Thread elena petrashen
2016, at 21:24, Lars Schneider wrote: >> >> Hi Elena, >> >> sorry for the late reply. I think it is great that you are interested in the >> Git remote whitelist/blacklist idea. Unfortunately I don't have any >> experience with Outreachy and I wonder what kin

[PATCH v3][Outreachy] branch -D: allow - as abbreviation of @{-1}

2016-03-31 Thread Elena Petrashen
Signed-off-by: Elena Petrashen --- This micro-patch is meant to allow “-“ as a short-hand for “@{-1} for branch -d (Cf. $gmane/230828). Based on feedback for v2: * suppressable advice on restoring if a user deletes a branch via @{-x} or - reference (to ensure safety: if a user deleted the wrong

Re: [Outreachy] Git remote whitelist/blacklist

2016-03-26 Thread elena petrashen
Hi everyone, I think I will submit the application as it is now, but still it would be great to get feedback on it, as I don't think there was no reply because everything was perfect :( Thank you! And have an awesome weekend. On Thu, Mar 24, 2016 at 5:50 PM, elena petrashen wrote:

[Outreachy] Git remote whitelist/blacklist

2016-03-24 Thread elena petrashen
Hi, I'm thinking of applying to Outreachy program this round with Git and the project I'm really interested in is "Git remote whitelist/blacklist" project (http://git.github.io/SoC-2016-Ideas/). I have drafted the description/timeline for this project and it would be great to get feedback/suggesti

Re: [PATCH v2] branch -D: allow - as abbreviation of '@{-1}'

2016-03-24 Thread elena petrashen
On Tue, Mar 22, 2016 at 8:07 PM, Junio C Hamano wrote: > Elena Petrashen writes: > >> +static int expand_dash_shortcut(const char **argv, int dash_position) >> +{ >> + if (!strcmp(argv[dash_position], "-")){ >> + argv[dash_positi

[PATCH v2] branch -D: allow - as abbreviation of '@{-1}'

2016-03-22 Thread Elena Petrashen
Signed-off-by: Elena Petrashen --- This micro-patch is meant to allow “-“ as a short-hand for “@{-1} for branch -D (Cf. $gmane/230828): * based on the discussion on the previous version of the patch, added the advice on how to restore the deleted branch using git branch deleted_name sha1 - to

[PATCH][Outreachy] branch -D: allow - as abbreviation of @{-1}

2016-03-21 Thread Elena Petrashen
Signed-off-by: Elena Petrashen --- This micro-patch is meant to allow “-“ as a short-hand for “@{-1} for branch -D (Cf. $gmane/230828): * git branch (-d | -D) is not supposed to accept any other arguments except for branch name so it makes sense to replace the argv[i] with @{-1}. We will not

Re: [PATCH][Outreachy] branch: allow - as abbreviation of '@{-1}'

2016-03-21 Thread elena petrashen
Hi Eric, Junio, thank you very much for your feedback! I honestly apologize I got so many things wrong. I'll try to minimize the scope a little bit for the next attempt to make sure my approach is good first and then expand: i.e will only teach git branch to delete "-" & give out an error message

[PATCH][Outreachy] branch: allow - as abbreviation of '@{-1}'

2016-03-19 Thread Elena Petrashen
Signed-off-by: Elena Petrashen --- Hi everyone, As my first Outreachy submission micropoject I???ve chosen to try to approach ???Allow ???-??? as a short-hand for ???@{-1}??? in more places.??? (http://git.github.io/SoC-2016-Microprojects/ (Cf. $gmane/230828)) My goal was to teach git branch