Re: [PATCH 1/1] git-prompt.sh: update shell variable instructions.

2019-06-05 Thread Edward D'Souza
Confirming that I can't reproduce this either. Should have done that first before continuing with a PR from two years ago! On Wed, Jun 5, 2019 at 12:07 PM SZEDER Gábor wrote: > > On Wed, Jun 05, 2019 at 08:06:07AM -0700, Edward D'Souza via GitGitGadget > wrote: >

[PATCH 0/1] Improve instructions around how to set git-prompt preference variables.

2019-06-05 Thread Edward D'Souza via GitGitGadget
wo years ago ( https://github.com/git/git/pull/425), back when I didn't know the official process for submitting patches. Luckily, a kind user (@dscho) saw it and pointed me in the right direction to get it submitted. This will be my first time submitting a patch, so hopefully I've figured o

[PATCH 1/1] git-prompt.sh: update shell variable instructions.

2019-06-05 Thread Edward D'Souza via GitGitGadget
From: Edward D'Souza Clarify the need to set variables like GIT_PS1_SHOWDIRTYSTATE before "source ~/.git-prompt.sh" is executed in your shell init process. If you set these preferences too late i.e. after .git-prompt.sh executes, they will silently fail to take effect. Signed