Re: [PATCH 2/4] git-prompt.sh: refactor colored prompt code

2013-06-22 Thread Eduardo D'Avila
2013/6/22 Øystein Walle : > I've gotten the impression it's better to use tput to generate the escape > sequences instead of hardcoding them. So something like: > > local c_red='\['"$(tput setaf 1)"'\]' > local c_green='\['"$(tput setaf 2)"'\]' > local c_green='\['"$(tput setaf 4)"'\]' > local c_cl

Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode

2013-06-22 Thread Eduardo D'Avila
2013/6/22 SZEDER Gábor : > On Thu, Jun 20, 2013 at 11:25:26PM -0300, Eduardo R. D'Avila wrote: >> git-prompt.sh lacks tests for PROMPT_COMMAND mode. >> >> Add tests for: >> * pcmode prompt without colors >> * pcmode prompt with colors for bash >> * pcmode prompt with colors for zsh >> >> Having the