Re: [PATCH] enable core.fsyncObjectFiles by default

2018-01-18 Thread Christoph Hellwig
[adding Chris to the Cc list - this is about the awful ext3 data=ordered behavior of syncing the whole file system data and metadata on each fsync] On Wed, Jan 17, 2018 at 03:57:53PM -0800, Linus Torvalds wrote: > On Wed, Jan 17, 2018 at 3:52 PM, Theodore Ts'o wrote: > > > > Well, let's be fair;

Re: [PATCH] enable core.fsyncObjectFiles by default

2018-01-17 Thread Christoph Hellwig
On Wed, Jan 17, 2018 at 03:55:09PM -0500, Jeff King wrote: > I'm definitely sympathetic, and I've contemplated a patch like this a > few times. But I'm not sure we're "safe by default" here after this > patch. In particular: > > 1. This covers only loose objects. We generally sync pack writes >

Re: [PATCH] enable core.fsyncObjectFiles by default

2018-01-17 Thread Christoph Hellwig
On Wed, Jan 17, 2018 at 11:37:31AM -0800, Matthew Wilcox wrote: > How about this instead? > > This option is enabled by default and ensures data integrity by calling > fsync after writing object files. It is not necessary on filesystems > which journal data writes, but is still necessary on files

Re: [PATCH] enable core.fsyncObjectFiles by default

2018-01-17 Thread Christoph Hellwig
a little to technical for my taste, but I couldn't come up with anything better: --- >From ab8f2d38dfe40e74de5399af0d069427c7473b76 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Wed, 17 Jan 2018 19:42:46 +0100 Subject: enable core.fsyncObjectFiles by default fsync is required for

[PATCH] enable core.fsyncObjectFiles by default

2018-01-17 Thread Christoph Hellwig
with various times countless times due to the lack of this option, and now lost trees on a git server with ext4 as well yesterday. It's time to make git safe by default. Signed-off-by: Christoph Hellwig --- Documentation/config.txt | 6 ++ environment.c| 2 +- 2 files changed, 3

Re: broken repo after power cut

2015-06-21 Thread Christoph Hellwig
On Sun, Jun 21, 2015 at 03:07:41PM +0200, Richard Weinberger wrote: > >> To me it seems like git was creating a new object and got interrupted > >> before fsync/fdatasync'ing it. > >> As the object was referenced before syncing the data to disk the repo > >> broke. Git doesn't fsync by default, a

Re: [ksummit-attendees] [PATCH] commit: Add -f, --fixes option to add Fixes: line

2013-10-28 Thread Christoph Hellwig
Btw, can we please take away this discussion from ksummit-attendees? It's got absolutely nothing to do with kernel summit and is getting fairly annoying. Thanks! -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo

Re: wit 0.0.3 - a web interface for git available

2005-04-20 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 09:18:29PM -0700, Greg KH wrote: > On Wed, Apr 20, 2005 at 02:29:11AM +0200, Christian Meder wrote: > > Hi, > > > > ok it's starting to look like spam ;-) > > > > I uploaded a new version of wit to http://www.absolutegiganten.org/wit > > Why not work together with Kay's t

Re: wit 0.0.3 - a web interface for git available

2005-04-20 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 02:29:11AM +0200, Christian Meder wrote: > Hi, > > ok it's starting to look like spam ;-) > > I uploaded a new version of wit to http://www.absolutegiganten.org/wit Got an url where it can be seen on a live repository? - To unsubscribe from this list: send the line "unsu