Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-56.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
Hi Matheus,
On Mon, Oct 21, 2019 at 7:14 PM Matheus Tavares Bernardino
wrote:
>
> I wrote a small follow-up post to talk about the conclusion of my GSoC
> project. I believe the main remaining tasks are now finally complete
> :) If you would be interested in taking a look, the post is at
> https:
Hi Karina,
Please see my answer below.
On Mon, Oct 21, 2019 at 6:59 PM Karina Saucedo
wrote:
>
> Hello, my name is Karina and I'm and Outreachy applicant.
> I´m interested in applying to the project 'Add did you mean hints´ and
> I was wondering how can I start contributing since there seem to b
Hi Philip,
On Sat, Oct 19, 2019 at 5:30 PM Philip Oakley wrote:
> On 19/10/2019 11:35, Christian Couder wrote:
> > +static void write_reused_pack_one(size_t pos, struct hashfile *out,
> > + struct pack_window **w_curs)
> > +{
> > +
Hi Philip,
On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote:
>
> Hi Christian,
> can I check one thing?
Yeah, sure! Thanks for taking a look at my patches!
> On 19/10/2019 11:35, Christian Couder wrote:
> > +int bitmap_walk_contains(struct bitmap
From: Jeff King
Let's refactor the way we check if an object is packed by
introducing obj_is_packed(). This function is now a simple
wrapper around packlist_find(), but it will evolve in a
following commit.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-obje
From: Jeff King
Let's make it possible to configure if we want pack reuse or not.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
Documentation/config/pack.txt | 4
builtin/pack-objects.c| 8 +++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --
From: Jeff King
To see when packfile reuse kicks in or not, it is useful to
show reused packfile objects statistics in the output of
upload-pack.
Helped-by: James Ramsay
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 6 --
1 file changed, 4
clone, depending on whether --single-branch is set.
However, libgit2 does both.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 214 -
pack-bitmap.c | 150 +
pack-bitmap.h
cated.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
ewah/bitmap.c | 13 +
ewah/ewok.h | 1 +
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/ewah/bitmap.c b/ewah/bitmap.c
index 52f1178db4..b5fed9621f 100644
--- a/ewah/bitmap.c
+++ b/ewah/bit
From: Jeff King
We will no longer compute bitmap_git->reuse_objects in a
following commit, so we cannot rely on it anymore to
terminate the loop early; we have to iterate to the end.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
pack-bitmap.c | 18 +++---
1 f
From: Jeff King
We will use this helper function in a following commit to
tell us if an object is packed.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
pack-bitmap.c | 12
pack-bitmap.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/pack-bitmap.c b/pack
From: Jeff King
We will need this helper function in a following commit
to give us total number of bytes fed to the hashfile so far.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
csum-file.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/csum-file.h b/csum-file.h
From: Jeff King
In a following commit get_delta_base() will be used outside
packfile.c, so let's make it non static and declare it in
packfile.h.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
packfile.c | 10 +-
packfile.h | 3 +++
2 files changed, 8 insertions(
This patch series is rewriting the code that tries to reuse existing
packfiles.
The code in this patch series was written by GitHub, and Peff nicely
provided it in the following discussion:
https://public-inbox.org/git/3e56b0fd-ebe8-4057-a93a-16ebb09fb...@jramsay.com.au/
The first version of thi
On Fri, Oct 11, 2019 at 1:44 AM Jonathan Tan wrote:
>
> > As we now allocate 2 more words than necessary for each
> > bitmap to serve as marks telling us that we can stop
> > iterating over the words, we don't need to rely on
> > bitmap_git->reuse_objects to stop iterating over the words.
>
> As P
On Fri, Oct 11, 2019 at 1:40 AM Jonathan Tan wrote:
>
> > From: Jeff King
> >
> > In a following patch we will allocate a variable number
> > of words in some bitmaps. When iterating over the words we
> > will need a mark to tell us when to stop iterating. Let's
> > always allocate 2 more words,
On Fri, Oct 11, 2019 at 1:59 AM Jonathan Tan wrote:
>
> I'm going to start with pack-bitmap.h, then builtin/pack-objects.c.
>
> > int reuse_partial_packfile_from_bitmap(struct bitmap_index *,
> > struct packed_git **packfile,
> > -
a "preview" of what we would see once such a series
> lands).
Acked-by: Christian Couder
Thanks to everyone involved,
Christian.
On Thu, Oct 3, 2019 at 4:06 AM Junio C Hamano wrote:
>
> Jeff King writes:
>
> > Hmm, I see the early parts of this graduated to 'next'. I'm not sure
> > everything there is completely correct, though. E.g. I'm not sure of the
> > reasoning in df75281e78 (ewah/bitmap: always allocate 2 more words
On Tue, Oct 1, 2019 at 12:03 AM Emily Shaffer wrote:
>
> Previously, when promisor_remote_move_to_tail() is called for a
> promisor_remote which is currently the final element in promisors, a
> cycle is created in the promisors linked list. This cycle leads to a
> double free later on in promisor_
Hi Peff and everyone,
On https://www.outreachy.org/apply/project-selection/#git it looks
like we will only have 1 intern as the title of our section is "Git -
1 intern". I wonder if it's because only funding for 1 intern has been
secured or if there is another reason.
Also I am not sure how peopl
Hi everyone,
The 55th edition of Git Rev News is now published:
https://git.github.io/rev_news/2019/09/25/edition-55/
Thanks a lot to Emily Shaffer, James Ramsay, Pratik Karki and Thomas
Ferris who contributed this month!
Enjoy,
Christian, Jakub, Markus and Gabriel.
PS: An issue for the next
Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-55.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
On Mon, Sep 23, 2019 at 3:35 PM Emily Shaffer wrote:
>
> On Fri, Sep 20, 2019 at 10:04:48AM -0700, Jonathan Tan wrote:
>
> > I'm new to Outreachy and programs like this, so does anyone have an
> > opinion on my draft proposal below? It does not have any immediate
> > user-facing benefit, but it do
On Mon, Sep 23, 2019 at 10:53 AM Jonathan Tan wrote:
>
> > Prospective mentors need to sign up on that site, and should propose a
> > project they'd be willing to mentor.
Yeah, you are very welcome to sign up soon if you haven't already done
so as I think the deadline is really soon.
> > I'm hap
Hi Emily and Dscho,
On Tue, Sep 17, 2019 at 1:28 PM Johannes Schindelin
wrote:
> On Mon, 16 Sep 2019, Emily Shaffer wrote:
>
> > Jonathan Tan, Jonathan Nieder, Josh Steadmon and I met on Friday to
> > talk about projects and we came up with a trimmed list; not sure what
> > more needs to be done
This patch series is rewriting the code that tries to reuse existing
packfiles.
The code in this patch series was written by GitHub and Peff nicely
provided it in the following discussion:
https://public-inbox.org/git/3e56b0fd-ebe8-4057-a93a-16ebb09fb...@jramsay.com.au/
This is an RFC patch seri
From: Jeff King
Let's refactor the way we check if an object is packed by
introducing obj_is_packed(). This function is now a simple
wrapper around packlist_find(), but it will evolve in a
following commit.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-obje
igned-off-by: Christian Couder
---
ewah/bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ewah/bitmap.c b/ewah/bitmap.c
index 143dc71419..eac05485f1 100644
--- a/ewah/bitmap.c
+++ b/ewah/bitmap.c
@@ -41,7 +41,7 @@ void bitmap_set(struct bitmap *self, size_t pos)
From: Jeff King
We will use this helper function in a following patch to
tell us if an object is packed.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
pack-bitmap.c | 12
pack-bitmap.h | 3 +++
2 files changed, 15 insertions(+)
diff --git a/pack-bitmap.c b/pack
From: Jeff King
We will need this helper function in a following patch
to give us total number of bytes fed to the hashfile so far.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
csum-file.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/csum-file.h b/csum-file.h
From: Jeff King
In a following commit get_delta_base() will be used outside
packfile.c, so let's make it non static and declare it in
packfile.h.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
packfile.c | 10 +-
packfile.h | 3 +++
2 files changed, 8 insertions(
From: Jeff King
As we now allocate 2 more words than necessary for each
bitmap to serve as marks telling us that we can stop
iterating over the words, we don't need to rely on
bitmap_git->reuse_objects to stop iterating over the words.
Signed-off-by: Jeff King
Signed-off-by: Christia
From: Jeff King
To see when packfile reuse kicks in or not, it is useful to
show reused packfile objects statistics in the output of
upload-pack.
Helped-by: James Ramsay
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 6 --
1 file changed, 4
From: Jeff King
Let's make it possible to configure if we want pack reuse or not.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-objects.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-obje
From: Jeff King
Let's store the chunks of the packfile that we reuse in
a dynamic array of `struct reused_chunk`, and let's use
a reuse_packfile_bitmap to speed up reusing parts of
packfiles.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
builtin/pack-objec
From: Jeff King
In a following patch we will need to allocate a variable
number of bitmap words, instead of always 32, so let's add
bitmap_word_alloc() for this purpose.
Signed-off-by: Jeff King
Signed-off-by: Christian Couder
---
ewah/bitmap.c | 11 ---
ewah/ewok.h | 1 +
2
On Wed, Sep 4, 2019 at 9:41 PM Jeff King wrote:
>
> Funding is still up in the air, but in the meantime I've tentatively
> signed us up (we have until the 24th to have the funding committed).
> Next we need mentors to submit projects, as well as first-time
> contribution micro-projects.
Great! Th
On Tue, Aug 27, 2019 at 7:17 AM Jeff King wrote:
>
> Do we have interested mentors for the next round of Outreachy?
I am interested to co-mentor.
> The deadline for Git to apply to the program is September 5th. The
> deadline for mentors to have submitted project descriptions is September
> 24th
Hi everyone,
The 54th edition of Git Rev News is now published:
https://git.github.io/rev_news/2019/08/21/edition-54/
Thanks a lot to Elijah Newren, Jeff Hostetler, Andrew Ardill and
Jean-Noël Avila who contributed this month!
Enjoy,
Christian, Jakub, Markus and Gabriel.
Hi Matheus,
On Tue, Aug 20, 2019 at 1:28 PM Olga Telezhnaya
wrote:
>
> вт, 20 авг. 2019 г. в 07:59, Matheus Tavares Bernardino
> :
> >
> > I just posted the penultimate report on my project:
> > https://matheustavares.gitlab.io/posts/going-for-a-too-big-step This
> > week I’ve been working on a v
Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-54.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
Hi Matheus,
On Tue, Aug 13, 2019 at 6:06 AM Matheus Tavares Bernardino
wrote:
>
> I just posted a new update on my project:
> https://matheustavares.gitlab.io/posts/simplified-version-of-parallel-inflation
Great blog post as usual!
> This week I sent a simplified version of the series I was wor
Hi Matheus,
On Tue, Aug 6, 2019 at 4:54 AM Matheus Tavares Bernardino
wrote:
>
> Here's my report from last week:
> https://matheustavares.gitlab.io/posts/week-11-wip-grep-protecting-textconv-and-submodules
Thank you for another great report!
> I'm working to protect the operations I left behin
On Tue, Aug 6, 2019 at 5:35 AM Junio C Hamano wrote:
>
> Emily Shaffer writes:
>
> > In backchannels recently there has been some discussion about the idea
> > of a Git-project-blessed blog written by Git contributors, generally
> > covering usability tips or overviews of the internals of Git whi
On Tue, Jul 30, 2019 at 10:04 PM Junio C Hamano wrote:
>
> Matheus Tavares writes:
> > @@ -598,7 +599,8 @@ static int grep_tree(struct grep_opt *opt, const struct
> > pathspec *pathspec,
> > free(data);
> > } else if (recurse_submodules && S_ISGITLINK(entry.m
Hi Pratyush,
On Wed, Jul 24, 2019 at 11:43 PM Pratyush Yadav wrote:
>
> I have a quick little feature to add to git-gui, and I'm wondering where
> should I discuss it and send patches. The git-gui repo [0] has no readme
> I can see that would point me in the right direction. Googling around
> did
Hi everyone,
The 53rd edition of Git Rev News is now published:
https://git.github.io/rev_news/2019/07/24/edition-53/
Thanks a lot to Jaime Rivas and Carlo Marcelo Arenas Belón who
contributed this month!
Enjoy,
Christian, Jakub, Markus and Gabriel.
Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-53.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
On Mon, Jul 15, 2019 at 1:16 AM Matthew DeVore wrote:
>
> On Fri, Jul 12, 2019 at 02:02:52PM -0700, Junio C Hamano wrote:
> > * md/list-objects-filter-combo (2019-06-28) 10 commits
> > - list-objects-filter-options: make parser void
> > - list-objects-filter-options: clean up use of ALLOC_GROW
>
Hi Matheus,
On Sun, Jul 14, 2019 at 9:38 AM Matheus Tavares Bernardino
wrote:
>
> I just posted a new update about my GSoC project here:
> https://matheustavares.gitlab.io/posts/week-8-a-working-parallel-inflation
> Please, feel free to leave any comments. I've finally solved the race
> condition
Let's make it possible to test oidmap_get_next() by adding a 'get_all'
subcommand that calls oidmap_get() once first and then oidmap_get_next()
several times until there is no more entry with the same oid key.
Signed-off-by: Christian Couder
---
t/helper/test-oidmap.c | 17 +
Let's add a test case to test both the 'add' and 'get_all' subcommand
from "test-oidmap.c", and through them oidmap_add() and
oidmap_get_next() from "oidmap.{c,h}".
Signed-off-by: Christian Couder
---
t/t0016-oidmap.sh | 26 +
Let's making it ppossible to test oidmap_add() by adding an 'add'
subcommand.
Signed-off-by: Christian Couder
---
t/helper/test-oidmap.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/t/helper/test-oidmap.c b/t/helper/test-oidmap.c
index 0acf99931e..c1
ating work in
case someone else needs it before I start sending my reftable work
(hopefully in a few months).
Christian Couder (5):
oidmap: add oidmap_add()
oidmap: add oidmap_get_next()
test-oidmap: add back proper 'add' subcommand
test-oidmap: add 'get_all' subcomma
For now "oidmap.h" gives us no way to get all the entries that have the
same oid key from an oidmap, as oidmap_get() will always return the first
entry. So let's add oidmap_get_next() for this purpose.
Signed-off-by: Christian Couder
---
oidmap.c | 8
oidmap.h | 6
We will need to have more than one entry with the same oid key
in an oidmap, which is not supported yet, as oipmap_put()
replaces an existing entry with the same oid key. So let's add
oidmap_add().
Signed-off-by: Christian Couder
---
oidmap.c | 12
oidmap.h | 6 ++
2
The 'add' subcommand is useless as it is mostly identical
to the 'put' subcommand, so let's remove it.
Helped-by: Derrick Stolee
Signed-off-by: Christian Couder
---
This and 2/2 follow this discussion about test coverage:
htt
Testing the 'remove' subcommand was forgotten when t0016
was created. Let's fix that.
Helped-by: Derrick Stolee
Signed-off-by: Christian Couder
---
t/t0016-oidmap.sh | 18 ++
1 file changed, 18 insertions(+)
diff --git a/t/t0016-oidmap.sh b/t/t0016-oidmap.sh
i
On Thu, Jun 27, 2019 at 7:35 PM Derrick Stolee wrote:
>
> Here are some interesting sections I found when examining the test coverage
> report. I am only highlighting these sections because they seem to include
> non-trivial logic. In some cases, maybe the code isn't needed.
>
> On 6/27/2019 1:05
Hi everyone,
The 52nd edition of Git Rev News is now published:
https://git.github.io/rev_news/2019/06/28/edition-52/
Thanks a lot to Jeff Hostetler, David Pursehouse and Johannes
Schindelin who contributed this month!
Enjoy,
Christian, Jakub, Markus and Gabriel.
Hi Ramsay,
On Thu, Jun 27, 2019 at 12:14 AM Ramsay Jones
wrote:
>
> If you need to re-roll your 'cc/multi-promisor' branch, could you please
> squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
> implement promisor_remote_get_direct()", 2019-06-25).
Sure, I have integrated
Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-52.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
On Fri, May 31, 2019 at 7:10 AM Christian Couder
wrote:
> On Thu, May 30, 2019 at 7:21 PM Derrick Stolee wrote:
> >
> > On 4/9/2019 12:11 PM, Christian Couder wrote:
> > > +{
> > > + int i, missing_nr = 0;
> > > + int *missing = xcalloc(oid
origin, and the origin is likely to be the remote
specified by extensions.partialClone.
This justification is not very strong, but one choice had to
be made, and anyway the long term plan should be to make the
order somehow fully configurable.
Signed-off-by: Christian Couder
---
promisor
As fetch_objects() is now used only in promisor-remote.c
and should't be used outside it, let's move it into
promisor-remote.c, make it static there, and remove
fetch-object.{c,h}.
Signed-off-by: Christian Couder
---
Makefile | 1 -
fetch-object
when cloning or fetching using a partial clone filter,
remote.origin.promisor will be set to "true" instead of
setting extensions.partialClone to "origin". This makes it
possible to use many promisor remote just by fetching from
them.
Signed-off-by: Christian Couder
This makes it possible to specify a different partial clone
filter for each promisor remote.
Signed-off-by: Christian Couder
---
builtin/fetch.c | 2 +-
list-objects-filter-options.c | 27 +++
list-objects-filter-options.h | 3 ++-
promisor-remote.c
As the infrastructure for more than one promisor remote
has been introduced in previous patches, we can remove
code that forbids the registration of more than one
promisor remote.
Signed-off-by: Christian Couder
---
builtin/fetch.c | 20 +---
1 file changed, 5 insertions(+), 15
risc...@tuxfamily.org/
V3: https://public-inbox.org/git/20180713174959.16748-1-chrisc...@tuxfamily.org/
V2: https://public-inbox.org/git/20180630083542.20347-1-chrisc...@tuxfamily.org/
V1: https://public-inbox.org/git/20180623121846.19750-1-chrisc...@tuxfamily.org/
Christian Couder (15):
t0410: remo
Now that we can have a different default partial clone filter for
each promisor remote, let's hide core_partial_clone_filter_default
as a static in promisor-remote.c to avoid it being use for
anything other than managing backward compatibility.
Signed-off-by: Christian Couder
---
ca
Let's not run a git command, especially one with "verify" in its
name, upstream of a pipe, because the pipe will hide the git
command's exit code.
While at it, let's also avoid a useless `cat` command piping
into `sed`.
Helped-by: SZEDER Gábor
Signed-off-by: Chris
From: Christian Couder
We will need to reinitialize the promisor remote configuration
as we will make some changes to it in a later commit.
Signed-off-by: Christian Couder
---
promisor-remote.c | 22 --
promisor-remote.h | 1 +
2 files changed, 21 insertions(+), 2
Signed-off-by: Christian Couder
---
Documentation/config/remote.txt | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/config/remote.txt b/Documentation/config/remote.txt
index 6c4cad83a2..a8e6437a90 100644
--- a/Documentation/config/remote.txt
+++ b/Documentation/config
While at it, let's remove a reference to ODB effort as the ODB
effort has been replaced by directly enhancing partial clone
and promisor remote features.
Signed-off-by: Christian Couder
---
Documentation/technical/partial-clone.txt | 117 --
1 file changed, 84 inser
Now that we have has_promisor_remote() and can use many
promisor remotes, let's hide repository_format_partial_clone
as a static in promisor-remote.c to avoid it being use
for anything other than managing backward compatibility.
Signed-off-by: Christian Couder
---
cache.h
From: Christian Couder
This shows that it is now possible to fetch objects from more
than one promisor remote, and that fetching from a new
promisor remote can configure it as one.
Helped-by: SZEDER Gábor
Signed-off-by: Christian Couder
---
t/t0410-partial-clone.sh | 49
From: Christian Couder
The callers of the fetch_object() and fetch_objects() might
be interested in knowing if these functions succeeded or not.
Signed-off-by: Christian Couder
Signed-off-by: Junio C Hamano
---
fetch-object.c | 13 -
fetch-object.h | 4 ++--
sha1-file.c| 4
From: Christian Couder
This is implemented for now by calling fetch_objects(). It fetches
from all the promisor remotes.
Helped-by: Ramsay Jones
Helped-by: Derrick Stolee
Signed-off-by: Christian Couder
---
promisor-remote.c | 67 +++
promisor
From: Christian Couder
The promisor-remote.{c,h} files will contain functions to
manage many promisor remotes.
We expect that there will not be a lot of promisor remotes,
so it is ok to use a simple linked list to manage them.
Helped-by: Jeff King
Helped-by: SZEDER Gábor
Signed-off-by
On Mon, Jun 24, 2019 at 4:51 AM Jeff King wrote:
>
> On Sun, Jun 23, 2019 at 01:32:16PM -0700, Pedro Larroy wrote:
>
> > Thanks for your answer.
> >
> > I was expecting the HEAD to point to the first bad commit.
> >
> > In mercurial, the exit status tells you information about the
> > bisection pr
Shaffer
Helped-by: Eric Sunshine
Signed-off-by: Christian Couder
---
The only change compared to he previous version is that "[...]" is
used instead of "..." in the synopsis and help message as discussed
with Emily, Eric and Junio.
Documentation/MyFirstContribution.txt |
On Thu, Jun 20, 2019 at 10:52 PM Junio C Hamano wrote:
>
> Christian Couder writes:
>
> > In a review[1] of my "many promisor remotes" patch series[2] and in
> > the following thread, it was suggested that a flag should be passed to
> > tell oid_object_inf
On Thu, Jun 20, 2019 at 11:29 PM Emily Shaffer wrote:
>
> On Thu, Jun 20, 2019 at 12:13:15AM +0200, Christian Couder wrote:
> > SYNOPSIS
> >
> > [verse]
> > -'git-psuh'
> > +'git-psuh ...'
>
> It doesn't require 1
On Thu, Jun 20, 2019 at 2:39 PM Derrick Stolee wrote:
>
> On 6/20/2019 4:50 AM, Jeff King wrote:
> > On Thu, Jun 20, 2019 at 10:30:26AM +0200, Christian Couder wrote:
> >
> >> Currently the OBJECT_INFO_FOR_PREFETCH flag is used to check
> >> if we should fetc
ge.
Let's disambiguate that by adding a new explicit
OBJECT_INFO_NO_FETCH_IF_MISSING flag.
Signed-off-by: Christian Couder
---
object-store.h | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/object-store.h b/object-store.h
index 272e01e452..02c1795d50 100644
--- a
INFO_QUICK.
Signed-off-by: Christian Couder
---
sha1-file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sha1-file.c b/sha1-file.c
index ed5c50dac4..2116ff1e70 100644
--- a/sha1-file.c
+++ b/sha1-file.c
@@ -1379,7 +1379,7 @@ int oid_object_info_extended(struct repository
1: https://public-inbox.org/git/b4d69d2b-dc0d-fffb-2909-c54060fe9...@gmail.com/
2: https://public-inbox.org/git/20190409161116.30256-1-chrisc...@tuxfamily.org/
Christian Couder (2):
object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSING
sha1-file: use OBJECT_INFO_NO_FETCH_IF_MISSING
object-s
On Thu, Jun 20, 2019 at 12:09 AM Jeff King wrote:
>
> On Wed, Jun 19, 2019 at 05:42:13PM -0400, Jeff King wrote:
>
> > I do think that sha1hash() will eventually go away in favor of
> > oidhash(), but we can approach that separately, and convert oidmap along
> > with everyone else.
Yeah, deprecat
We implement a command called git-psuh which accept arguments, so let's
show that it accepts arguments in the doc and the usage string.
While at it, we need to prepare "a NULL-terminated array of usage strings",
not just "a NULL-terminated usage string".
Signed
On Mon, Jun 17, 2019 at 7:31 PM Junio C Hamano wrote:
>
> Christian Couder writes:
>
> > On Mon, Jun 17, 2019 at 6:33 AM Masahiro Yamada
> > wrote:
> >>
> >> On Sat, Jun 15, 2019 at 5:41 PM Christian Couder
> >> wrote:
> >> >
&
On Mon, Jun 17, 2019 at 6:33 AM Masahiro Yamada
wrote:
>
> On Sat, Jun 15, 2019 at 5:41 PM Christian Couder
> wrote:
> >
> > > I do wonder if the trailer code is correct to always respect it, though.
> > > For example, in "git log" output we'd expe
just
focus on the externally visible behavior instead.
Suggested-by: Jeff King
Signed-off-by: Christian Couder
---
t/helper/test-hashmap.c | 9 +
t/t0011-hashmap.sh | 9 -
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/t/helper/test-hashmap.c b/t/helper/test-hash
This new helper is very similar to "test-hashmap.c" and will help
test how `struct oidmap` from oidmap.{c,h} can be used.
Helped-by: SZEDER Gábor
Helped-by: Jeff King
Signed-off-by: Christian Couder
---
Makefile | 1 +
t/helper/test-oidm
amily.org/
V2: https://public-inbox.org/git/20190611082325.28878-1-chrisc...@tuxfamily.org/
V1: https://public-inbox.org/git/20190609044907.32477-1-chrisc...@tuxfamily.org/
This patch series on GitHub:
https://github.com/chriscool/git/commits/oidmap
Christian Couder (4):
t/helper: add test-oid
From: Christian Couder
Get rid of the static hash() function in oidmap.c which is redundant
with sha1hash(). Use sha1hash() directly instead.
Let's be more consistent and not use several hash functions doing
nearly exactly the same thing.
Signed-off-by: Christian Couder
---
oidmap.c
From: Christian Couder
Add actual tests for operations using `struct oidmap` from oidmap.{c,h}.
Helped-by: SZEDER Gábor
Helped-by: Jeff King
Signed-off-by: Christian Couder
---
t/t0016-oidmap.sh | 84 +++
1 file changed, 84 insertions(+)
create
On Fri, Jun 14, 2019 at 5:10 PM Jeff King wrote:
>
> On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote:
>
> > Perhaps, 'git interpret-trailers' should be changed
> > to recognize core.commentChar ?
>
> It looks like the trailer code does respect it, but the
> interpret-trailers progr
On Fri, Jun 14, 2019 at 12:22 AM Junio C Hamano wrote:
>
> Jeff King writes:
>
> >> > I know there are testing philosophies that go to this level of
> >> > white-box testing, but I don't think we usually do in Git. A unit
> >> > test of oidmap's externally visible behavior seems like the right
>
1 - 100 of 3241 matches
Mail list logo
