[PATCH v4 3/3] diff-highlight: add support for --graph output

Signed-off-by: Brian Henderson --- contrib/diff-highlight/diff-highlight| 19 +-- contrib/diff-highlight/t/t9400-diff-highlight.sh | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight

[PATCH v4 0/3] diff-highlight: add support for --graph option

On Mon, Aug 29, 2016 at 02:37:46PM -0700, Junio C Hamano wrote: > Brian Henderson writes: > > > How does this look? > > > > Drawing the graph helped me a lot in figuring out what I was > > actually testing. thanks! > > Yeah, I also am pleased to see the pict

[PATCH v4 2/3] diff-highlight: add failing test for handling --graph output

Signed-off-by: Brian Henderson --- contrib/diff-highlight/t/t9400-diff-highlight.sh | 60 1 file changed, 60 insertions(+) diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh index 7c303f7..54e11fe 100755

[PATCH v4 1/3] diff-highlight: add some tests

Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 +++ contrib/diff-highlight/t/t9400-diff-highlight.sh | 163 +++ 3 files changed, 190 insertions(+) create mode 100644 contrib

[PATCH v4 3/3] diff-highlight: add support for --graph output.

--- contrib/diff-highlight/diff-highlight| 19 +-- contrib/diff-highlight/t/t9400-diff-highlight.sh | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight index ffefc31..928

[PATCH v4 2/3] diff-highlight: add failing test for handling --graph output.

--- contrib/diff-highlight/t/t9400-diff-highlight.sh | 60 1 file changed, 60 insertions(+) diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh index 7c303f7..54e11fe 100755 --- a/contrib/diff-highlight/t/t9400

[PATCH v4 0/3] diff-highlight: add support for --graph option

How does this look? Drawing the graph helped me a lot in figuring out what I was actually testing. thanks! Brian Henderson (3): diff-highlight: add some tests. diff-highlight: add failing test for handling --graph output. diff-highlight: add support for --graph output. contrib/diff

[PATCH v4 1/3] diff-highlight: add some tests.

--- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 +++ contrib/diff-highlight/t/t9400-diff-highlight.sh | 163 +++ 3 files changed, 190 insertions(+) create mode 100644 contrib/diff-highlight/Makefile create m

[PATCH] diff-highlight: add some tests.

Jeff, I love your idea. how's this looking? Junio, I wasn't meaning to be stubborn, although definitely a fault of mine. I understand a lot better now, thanks for your patience. --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 +

[PATCH] diff-highlight: add some tests.

Junio, how does this look? Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 contrib/diff-highlight/t/t9400-diff-highlight.sh | 122 +++ 3 files changed, 149 insertions

Re: [PATCH v3 1/3] diff-highlight: add some tests.

On Fri, Aug 19, 2016 at 11:10:55AM -0700, Junio C Hamano wrote: > > > +# vim: set noet > > We tend to avoid cluttering the source with editor specific insns > like this. oops. Anyone have any suggestions for project level vim settings? -- To unsubscribe from this list: send the line "unsubscrib

[PATCH v3 3/3] diff-highlight: add support for --graph output.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/diff-highlight| 19 +-- contrib/diff-highlight/t/t9400-diff-highlight.sh | 2 +- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight

[PATCH v3 2/3] diff-highlight: add failing test for handling --graph output.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/t/t9400-diff-highlight.sh | 54 1 file changed, 54 insertions(+) diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh index 6b8a461..3b3c831 100755

[PATCH v3 0/3] diff-highlight: add support for git log --graph output.

I cleaned up the graph test, hopefully it's better. Brian Henderson (3): diff-highlight: add some tests. diff-highlight: add failing test for handling --graph output. diff-highlight: add support for --graph output. contrib/diff-highlight/Makefile | 5 + contrib

[PATCH v3 1/3] diff-highlight: add some tests.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 + contrib/diff-highlight/t/Makefile| 22 contrib/diff-highlight/t/t9400-diff-highlight.sh | 150 +++ 3 files changed, 177 insertions(+) create mode 100644 contrib

Re: [PATCH v2 1/3] diff-highlight: add some tests.

On Fri, Aug 19, 2016 at 10:51:23AM -0400, Jeff King wrote: > On Fri, Aug 19, 2016 at 07:42:35AM -0700, Brian Henderson wrote: > > > > > +# PERL is required, but assumed to be present, although not > > > > necessarily modern > > > > +# some tests req

Re: [PATCH v2 1/3] diff-highlight: add some tests.

On Wed, Aug 17, 2016 at 12:09:25PM -0700, Junio C Hamano wrote: > Brian Henderson writes: > > > + > > +# PERL is required, but assumed to be present, although not necessarily > > modern > > +# some tests require 5.8 > > +test_expect_success PERL 'nam

[PATCH v2 1/3] diff-highlight: add some tests.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/Makefile | 5 ++ contrib/diff-highlight/t/Makefile| 22 contrib/diff-highlight/t/t9400-diff-highlight.sh | 62 + contrib/diff-highlight/t/test-diff-highlight.sh | 69

[PATCH v2 2/3] diff-highlight: add failing test for handling --graph output.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/t/t9400-diff-highlight.sh | 13 +++ contrib/diff-highlight/t/test-diff-highlight.sh | 43 2 files changed, 56 insertions(+) diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff

[PATCH v2 3/3] diff-highlight: add support for --graph output.

Signed-off-by: Brian Henderson --- contrib/diff-highlight/diff-highlight | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight index ffefc31..9364423 100755 --- a/contrib/diff-highlight

[PATCH v2 0/3] diff-highlight: add support for git log --graph output.

Changes made per Eric. On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > Brian Henderson wrote: > > Hi Brian, > > A few minor portability/style nits below, but contrib/ probably > (still?) has laxer rules than the rest of git... > > I think we still requir

Re: [PATCH 1/3] diff-highlight: add some tests.

On Wed, Aug 10, 2016 at 08:56:35AM +, Eric Wong wrote: > Typically, we expect a reroll in a few days, and I guess there's > no rush (so you can squash your comment patch in addressing > Junio's concern into 3/3). > > Thanks. thanks, (slowly) working on an update. -- To unsubscribe from thi

[PATCH] diff-highlight: Add comment for our assumption about --graph output.

--- contrib/diff-highlight/diff-highlight | 3 +++ 1 file changed, 3 insertions(+) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight index ec31356..9364423 100755 --- a/contrib/diff-highlight/diff-highlight +++ b/contrib/diff-highlight/diff-highlight @@ -

[PATCH 1/3] diff-highlight: add some tests.

--- contrib/diff-highlight/Makefile | 5 ++ contrib/diff-highlight/t/Makefile| 19 +++ contrib/diff-highlight/t/t9400-diff-highlight.sh | 63 ++ contrib/diff-highlight/t/test-diff-highlight.sh | 69 4 files changed

[PATCH 0/3] diff-highlight: add support for git log --graph output.

econd digit. As there were limited tests in the contrib directory (only t93xx and one t7900) I just chose the next number in the 9xxx range. Please let me know if I need to change it. I'm also not super happy about my test case for the graph option. If anyone has any better ideas, please

[PATCH 2/3] diff-highlight: add failing test for handling --graph output.

--- contrib/diff-highlight/t/t9400-diff-highlight.sh | 13 contrib/diff-highlight/t/test-diff-highlight.sh | 42 2 files changed, 55 insertions(+) diff --git a/contrib/diff-highlight/t/t9400-diff-highlight.sh b/contrib/diff-highlight/t/t9400-diff-highlight.sh i

[PATCH 3/3] diff-highlight: add support for --graph output.

--- contrib/diff-highlight/diff-highlight | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight index ffefc31..ec31356 100755 --- a/contrib/diff-highlight/diff-highlight +++ b/contrib/diff-hi

[PATCH 0/3] diff-highlight: add support for git log --graph output.

ge it. I'm also not super happy about my test case for the graph option. If anyone has any better ideas, please let me know! Brian Henderson (3): diff-highlight: add some tests. diff-highlight: add failing test for handling --graph output. diff-highlight: add support for --graph output.

[PATCH 0/3] diff-highlight: add support for git log --graph output.

test case for the graph option. If anyone has any better ideas, please let me know! Brian Henderson (3): diff-highlight: add some tests. diff-highlight: add failing test for handling --graph output. diff-highlight: add support for --graph output. contrib/diff-highlight/Makefile