Re: [PATCH v4] completion: ignore chpwd_functions when cding on zsh

On Thu, Oct 9, 2014 at 5:11 PM, Junio C Hamano wrote: > Actually the patch was slightly wrong. It did not quite matter as > "cd ''" is a no-op, but "git -C '' cmd" is not that lenient (which > may be something we may want to fix) and breaks t9902 by exposing > an existing breakage in the callchai

Re: [PATCH v4] completion: ignore chpwd_functions when cding on zsh

On Thu, Oct 9, 2014 at 3:45 PM, Junio C Hamano wrote: > > Bugs are mine; as I do not use zsh myself, some testing is very much > appreciated. I've tested this patch in zsh and it fixes the original problem. I've also tested various scenarios in bash and zsh (CDPATH set, different places within r

[PATCH v4] completion: ignore chpwd_functions when cding on zsh

Software, such as RVM (ruby version manager), may set chpwd functions that result in an endless loop when cding. chpwd functions should be ignored. As I've only seen this so far on ZSH, I'm applying this change only to the git-completion.zsh overrides. Signed-off-by: Brandon Turn

Re: [PATCH] completion: ignore chpwd_functions when cding

On Wed, Oct 8, 2014 at 1:12 PM, Junio C Hamano wrote: > > > Can you mention that this is abomination limited only to zsh > somewhere in the log message? Or does bash share the same glitch? > > If this is limited to zsh, I wonder if we can take advantage of the > fact that we have git-completion.b

[PATCH v3] completion: ignore chpwd_functions when cding on zsh

Software, such as RVM (ruby version manager), may set chpwd functions that result in an endless loop when cding. chpwd functions should be ignored. As I've only seen this so far on ZSH, I'm applying this change only to the git-completion.zsh overrides. Signed-off-by: Brandon Turner

[PATCH v2] completion: ignore chpwd_functions when cding

what functions users add to chpwd_functions. Signed-off-by: Brandon Turner --- This addresses Junio's request to update the log message. The patch still applies to bash and zsh. For more information on the RVM bug, see: https://github.com/wayneeseguin/rvm/issues/3076 contrib/completio

[PATCH] completion: ignore chpwd_functions when cding

Software, such as RVM (ruby version manager), may set chpwd functions that result in an endless loop when cding. chpwd functions should be ignored. Signed-off-by: Brandon Turner --- For an example of this bug, see: https://github.com/wayneeseguin/rvm/issues/3076 contrib/completion/git