[RFC PATCH] userdiff: ship built-in driver config file

2019-06-17 Thread Boxuan Li
.*.regIcase. Signed-off-by: Boxuan Li --- A few notes and questions: 1. In [diff "tex"] section, \x80 and \xff cannot be parsed by git config parser. I have no idea why this is happening. I changed them to \\x80 and \\xff as a workaround, which resulted in t4034 failure (See https://travis

[PATCH] userdiff: fix grammar and style issues

2019-05-29 Thread Boxuan Li
Signed-off-by: Boxuan Li --- Based on 'next' branch --- Documentation/gitattributes.txt | 2 +- userdiff.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt index

[PATCH v6] userdiff: add Octave

2019-05-21 Thread Boxuan Li
octave under t/t4018 are added. Signed-off-by: Boxuan Li Acked-by: Johannes Sixt --- Thanks to review from Johannes, update from v5: Fix grammar and style --- Documentation/gitattributes.txt | 2 +- t/t4018/matlab-class-definition | 5 + t/t4018/matlab-function | 4 t/t4018/matlab-oct

[PATCH v5] userdiff: add Octave

2019-05-17 Thread Boxuan Li
octave under t/t4018 are added. Signed-off-by: Boxuan Li --- v1: use matlab pattern for octave v2: add a new octave pattern v3: fix indentation problem of v2 v4: improve doc and commit message v5: merge octave pattern into matlab and add test cases --- Documentation/gitattributes.txt | 2 +- t/t40

[PATCH v4] userdiff.c & doc/gitattributes.txt: add Octave

2019-05-14 Thread Boxuan Li
Octave pattern is almost the same as matlab, except that '%%%' and '##' can also be used to begin code sections, in addition to '%%' that is understood by both. Signed-off-by: Boxuan Li --- Thanks to all the reviewers above, this is the fourth version: v1: use matla

[PATCH v3] userdiff.c & doc/gitattributes.txt: add Octave

2019-05-10 Thread Boxuan Li
Octave pattern is almost the same as matlab. Besides, octave also uses '%%%' or '##' to begin code sections. Signed-off-by: Boxuan Li --- Update from v2: fix indentation --- Documentation/gitattributes.txt | 2 ++ userdiff.c | 5 + 2 files changed, 7

[PATCH v2] userdiff.c & doc/gitattributes.txt: add Octave

2019-05-10 Thread Boxuan Li
Octave pattern is almost the same as matlab. Besides, octave also uses '%%%' or '##' to begin code sections. Signed-off-by: Boxuan Li --- v1: use matlab pattern for octave language --- Documentation/gitattributes.txt | 2 ++ userdiff.c | 5 +

[PATCH] doc/gitattributes: add Octave

2019-05-09 Thread Boxuan Li
`matlab` pattern is also suitable for source code in the GNU Octave language. Signed-off-by: Boxuan Li --- Documentation/gitattributes.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt index 4fb20cd0e9

[PATCH v2] t4253-am-keep-cr-dos: avoid using pipes

2019-05-05 Thread Boxuan Li
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Boxuan Li --- Thanks to Eric Sunshine's review, I've removed spaces after '

[PATCH] t4253-am-keep-cr-dos: avoid using pipes

2019-05-04 Thread Boxuan Li
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Signed-off-by: Boxuan Li --- t/t4253-am-keep-cr-dos.sh | 6 -- 1 file changed, 4 insertions(+), 2