Hi Johannes,
On Thu, Oct 17, 2019 at 7:33 AM Johannes Sixt wrote:
> FWIW, I would prefer to experiment with the feature for a few weeks
> before it (or a configuration that enables it by default) is baked in.
Yes please do. Obviously I'm glad someone other than me will be
actually testing it.
(A
Hi Pratyush,
On Wed, Oct 16, 2019 at 9:28 PM Pratyush Yadav wrote:
> I mentioned this earlier, and I'll mention this again: I'm not sure
> whether this feature would be a good thing for the larger population. So
> this _might_ not end up being accepted depending on how people react to
> the propo
Hi Pratyush,
Thanks for reviewing. How does this work, do I send a re-roll of the patch(es)?
Birger
Hi Pratyush,
On Tue, Oct 8, 2019 at 7:59 PM Pratyush Yadav wrote:
> On 07/10/19 06:52PM, Birger Skogeng Pedersen wrote:
> > So I kinda got this working, but only when focusing the commit message
> > widget.
>
> Isn't this the point of your feature? You change the view
When the user focuses the Commit Message widget (to write a message), the
diff view may be blank.
With this patch a staged file is automatically selected when the Commit
Message widget is focused, if no other file is selected (i.e. diff view
is blank).
Signed-off-by: Birger Skogeng Pedersen
Signed-off-by: Birger Skogeng Pedersen
---
git-gui.sh | 32 +++-
1 file changed, 19 insertions(+), 13 deletions(-)
diff --git a/git-gui.sh b/git-gui.sh
index fd476b6..b7f4d1e 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2669,25 +2669,31 @@ proc show_less_context
So I kinda got this working, but only when focusing the commit message widget.
I did not manage to get it working when invoking "do_add_all", (e.g.
when pressing CTRL/CMD+i). I added this:
bind $ui_comm <$M1B-Key-i> {do_add_all;select_staged_file;break}
bind $ui_comm <$M1B-Key-I> {do_add_all;sele
It seems this topic has kindof derailed(?). But I feel like voicing my
opinion nonetheless.
I have to say I absolutely agree with Johannes Schindelin here. I
would really prefer a more modern way of contributing to this project
(any software project, really) than using emails. Be that Github,
Gitl
On Tue, Oct 1, 2019 at 8:00 PM Pratyush Yadav wrote:
> So here's what I propose: why don't we try to do something similar? What
> about running `git-gc --auto` in the background when the user makes a
> commit (which I assume is the most common operation in git-gui). This
> would be disabled when t
On Thu, Sep 26, 2019 at 9:30 PM Pratyush Yadav wrote:
> Why are you changing the Alt+4 binding?
I couldn't really find an easier way before.
> This means your feature won't
> work for people who use the mouse to move around in the UI (which I
> suppose would be a majority).
True. I would much p
On Thu, Sep 26, 2019 at 9:15 PM Pratyush Yadav wrote:
> Talking about auto compression, would it be a better idea to let users
> disable the dialog, and then if they do want auto compression, they can
> just run a cron job (or the Windows equivalent) to do this on their
> repos?
Personally I woul
Hi Johannes,
On Thu, Sep 26, 2019 at 8:54 PM Johannes Sixt wrote:
> I dislike the popup, too. But I want total control over my repository:
> No automatic compression behind my back, in particular, when that
> expires reflogs, and git-gui does that.
I understand what you mean. In my opinion, An o
Honestly I'll need some help to get this one implemented. The only
implementation I've got working currently, is to change Alt+4 key bind
to do the following:
- Focus the "Staged Changes" widget (which will select a path in the
list, if it isn't focused already), then
- Focus the "Commit Message" w
Hi,
Every once in a while, I get the "This repository currently has
approximately (some number) loose objects." popup dialog.
I don't want to sound arrogant, but I find this popup along with the
dialog showing after that prints the result of the compression,
immensely annoying. And I've seen peo
Doing some more experimenting with these, I realize I was completely
wrong about them. Please disregard my previous email :-)
Birger
Hi,
It looks to me like there are a lot of key binds duplicated in the
git-gui source.
For instance, Ctrl/Cmd+Enter are bound in two lines:
bind $ui_comm <$M1B-Key-Return> {do_commit;break}
and
bind . <$M1B-Key-Return> do_commit
I guess the first one is specified to work in the commit message
Hi Pratyush,
I was comparing your git-gui repo[1] with the source code of
git/git-gui[2]. There seems to be a couple of things missing.
For example, I created a patch back in March 2018[3]. Junio pulled it
so the changes are really there in git/git-gui/git-gui.sh (see this[4]
line). This was whi
Just saw this[0] issue discussed about GNU Make. It seems Make don't
play with path with spaces (at all). I guess my best solution is just
to make a symbolic link so there's a path without spaces.
I guess this issue can be ignored.
[0] http://savannah.gnu.org/bugs/?712
Best regards,
Birger
Hi,
I ran into som issues when compiling git-gui on Windows. Turns out
that the "sharedir" variable gets an incorrect value when "gitexecdir"
contains a space.
For instance when
gitexecdir is set to "/c/Program Files/Git/mingw64/libexec",
sharedir becomes "/c/ Files/Git/mingw64/share".
Perhaps
Hi,
On Sat, Sep 14, 2019 at 7:48 PM Pratyush Yadav wrote:
> You missed labelling the menu item of "Amend Last Commit" with the
> shortcut, like we do for other menu items bound to a hotkey like F5 for
> rescan, Ctrl-T for stage, etc. I added that locally.
Sorry about that. Thanks!
Birger
Hi Pratyush,
On Sat, Sep 14, 2019 at 11:15 PM Pratyush Yadav wrote:
> Why should it only happen when the commit message widget is selected?
> What's wrong with directly switching focus when all the files are
> staged?
>
> What I have in mind is once there are no more files to stage, the focus
> d
Hi everyone,
I personally prefer to have the changes I am about to commit visible
in the diff view, while I write my commit message. So usually I do
this:
1. Stage the file(s) I've been working on.
2. Select a file I just staged, so I can see the changes in the diff widget.
3. Jump to the "Commit
Selecting whether to "Amend Last Commit" or not does not have a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Rebased-by: Bert Wesarg
---
git-gui.sh | 8
1 file changed, 8 insertions(+)
diff -
Thanks, I really appreciate you taking time to explain it thoroughly.
On Sat, Sep 14, 2019 at 12:11 AM Pratyush Yadav wrote:
> So while my advice above was to work on top of "master", that does not
> apply in this case since your patch is dependent on someone's patch
> which isn't in master yet.
On Fri, Sep 13, 2019 at 4:37 PM Pratyush Yadav wrote:
> Hi Birger,
>
> I'm afraid you are working on an older version of this patch. You should
> be re-rolling [0], which works well with Bert's "amend check button"
> change.
>
> [0]
> https://public-inbox.org/git/b82a00441ff1a6a9cea3fd235c1c33729
Selecting whether to "Amend Last Commit" or not does not have a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Rebased-by: Bert Wesarg
---
git-gui.sh | 9 +
1 file changed, 9 insertions(+)
diff -
Hi Marc and Philip,
On 12/09/2019 22:34, Marc Branchaud wrote:
> I disagree! Who expects anything to work properly when capslock is on?
Me :-)
On Fri, Sep 13, 2019 at 12:23 AM Philip Oakley wrote:
> I'd tend to agree. In other areas the use of shift is often used as the
> complement of the u
Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
Hi Pratyush,
On Wed, Sep 11, 2019 at 10:55 PM Pratyush Yadav wrote:
> Also, I notice that the bindings for other letters have the same
> function bound for both small and capital letters (IOW, same behavior
> with shift held and released).
>
> I don't necessarily think that is a great idea. It is
Hi Pratyush,
I'm hoping this will be merged, even without changing the radio
selectors to a checkbox(?). The patch from Bert resolves the issue I
raised about wanting the hotkey.
What do you think?
Birger
Hi Pratyush,
On Tue, Sep 10, 2019 at 9:12 PM Pratyush Yadav wrote:
> This patch LGTM, but I'm not sure how to resolve the keybindings
> problem. Junio suggested we have configurable keybindings, and I agree
> with him, but until we do, something has to be agreed upon. And we also
> need to come u
Hi Bert,
We should probably distinguish between what is wrapped in git-gui
(i.e. purely visual), and what is actually wrapped in the commit
message.
I believe the former is referred to as "soft wrap", while the latter
is "hard wrap".
On Thu, Sep 5, 2019 at 7:46 PM Bert Wesarg wrote:
> Please e
On Thu, Sep 5, 2019 at 12:48 AM Pratyush Yadav wrote:
> I'll chime in with what I think would be a great solution: auto word
> wrapping. This way, the users can set the text width, and not have to
> worry about manually formatting it. Long "words" like URLs would still
> get to be on one line, and
Hi Johannes,
On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
> Many keyboards do not have a right Alt-key. That means that Alt+1 to
> Alt+4 combinations must be typed single-handed with the left hand. This
> is mildly awkward for Alt+4. Can we please have the very important
> commit widget *n
Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 40 +++
Hi,
You could argue that A (as in "amend") makes quite an intuitive hotkey.
But personally I'm also leaning towards CTRL/CMD+E. The ALT+(letter)
combination is used to open a menu, for instance ALT+R opens
"Repository", ALT+E opens "Edit", etc. That's the behaviour on
Windows, anyways. So the hotk
;Staged Changes" widgets, using
ALT+1 or ALT+2.
The user may also set the ui focus to the diff view widget with
ALT+3, or to the commit message widget with ALT+4.
This enables the user to select/unselect files, view the diff and create a
commit in git-gui using keyboard-only.
Signed-off-by: Bir
Hi Pratyush,
So how does this work? Should I email the patch that Bert has created?
Or is it okay that it just remains on Github. (Considering the git
mail archives)
Birger
Hi Pratyush,
Just wanted to chime in on this one:
On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
> On second thought, wouldn't it make more sense to expand the commit
> message buffer instead? The point of resizing that pane is to see more
> of the commit message. So it makes more sense t
Hi Pratyush,
I just realised I had forgotten about the local variable prefixed with
an underscore. So v5 of the patch will be coming up.
Also I got quite uncertain, should I have added you in the commit msg
somehow? I've seen elsewhere that people add the "Signed-off-by" line
with the name of the
Hi,
(Sorry that I hadn't used the proper version in the subject before,
I'm new (as you could probably tell already))
In addition to your changes, I removed the unused ui_workdir variable
and modified the bindings to be ALT+1/2/3/4.
Shoud I have listed you in the commit? Or did I do it according t
;Staged Changes" widgets, using
ALT+1 or ALT+2.
The user may also set the ui focus to the diff view widget with
ALT+3, or to the commit message widget with ALT+4.
This enables the user to select/unselect files, view the diff and create a
commit in git-gui using keyboard-only.
Signed-off-by: Bir
Hi Bert,
On Mon, Sep 2, 2019 at 9:42 PM Bert Wesarg wrote:
> So we only remember the lno in the widget, that could mean, that we
> select the wrong file after a rescan, which shifted the previous path
> one down. Can we remember the pathname instead, and try to find this
> again in the file list
Hi Pratyush,
On Tue, Sep 3, 2019 at 2:45 PM Pratyush Yadav wrote:
> Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it
> immediately takes me to the "Amend last commit" option. Then I can press
> space to select it and Tab again to get back to the commit message.
It seems th
On Mon, Sep 2, 2019 at 10:15 PM Bert Wesarg wrote:
> does Control-Tab works for traversal?
Bert,
Control+Tab works for traversal, but as a means to toggle new/amend
it's very tedious. I have to press Ctrl+Tab 9 times to select "new"
and 10 times to select "Amend"(!). Then 1 or 2 more times to g
Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui.sh | 11 +++
1 file changed, 11 insertions(+)
dif
Hi Bert,
On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote:
> I think with your "focus" patch, this is not needed anymore:
>
> After focusing the commit message widget, you can focus the radio
> buttons with Tab/Shift+Tab and press Space.
>
> I think this is short enough, so that wasting a Letter
Bert,
Works great now. Thanks a lot for fixing this!
Birger
Ah, sorry I misunderstood you.
Thanks,
Birger
On Mon, Sep 2, 2019 at 7:58 PM Bert Wesarg wrote:
> up to now, git-gui does not hide any scrollbars, if they are not
> needed. IMHO, I would keep it that way, as I don't like the flicker
> when it appears and disappears. Imagine you are typing in the bottom
> line and than you typed too much. The
On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote:
> You missed removing this extra blank line. Will fix it up locally.
>
> > + set _index $file_lists_last_clicked($widget)
> [snip]
To be honest I felt the blank line there was appropriate, in an
attempt to follow the same code styl
On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg wrote:
> I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6:
>
> https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ
On Mon, Sep 2, 2019 at 8:12 PM Pratyush Yadav wrote:
> Hmm, it looks fine for me. Which platform are you using? I am running it
> o
it message text input
area.
Here's a screenshot: https://i.imgur.com/721axUX.png
Birger
On Mon, Sep 2, 2019 at 2:06 PM Bert Wesarg wrote:
>
> Hi Birger,
>
> On Mon, Sep 2, 2019 at 11:13 AM Birger Skogeng Pedersen
> wrote:
> >
> > Hi,
> >
> > I just n
I just now realized what a terrible suggestion CTRL+Z was.
I propose CTRL/CMD+E to toggle between amend/new commit.
On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
wrote:
>
> In my pursuit to fully utilize git-gui with only using a keyboard, I
> suggest that there is a hotkey
Hi,
I just noticed that long lines in the commit message widget does in
fact not show a horizontal scrollbar.
So if a line in the commit message is more than 75 characters, it gets
a bit confusing.
Should it not have a scrollbar?
Example shown here: https://i.imgur.com/I3d6nBJ.png
igned-off-by: Birger Skogeng Pedersen
---
git-gui.sh | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/git-gui.sh b/git-gui.sh
index 5bc21b8..ce620f1 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2495,7 +2495,7 @@ proc force_first_di
Hello Bert,
> But I don't understand this in full. Does this mean pressing CTRL+1 or
> +2 does also changes the file selection? Why isn't it sufficient to
> just focus the respective file list widget? And than have bindings to
> change the selection?
>
> Bert
I don't think it's feasible to focus
Hello Pratyush,
(New patch according to our discussion coming up)
On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote:
> In case you haven't been following the list, Pat has been inactive
> recently, so I am acting as the interim maintainer of git-gui for now,
> because no one else stepped up
In my pursuit to fully utilize git-gui with only using a keyboard, I
suggest that there is a hotkey to toggle between selecting "New
Commit" and "Amend Last Commit".
Not sure which key-combination that fits this purpose best, but my
suggestion is CTRL/CMD+Z.
Best regards,
Birger
(Finally picking this up again)
I've been using this feature for about one year now. If I may say so,
I think it is actually really great. It's really helpful for me to be
able to use git-gui with just the keyboard, and I'm hoping others will
find it useful, too.
Let me know what you guys think.
d Changes", the diff view or the
commit message dialog widgets, respectively. This enables the user to
select/unselect files, view the diff and create a commit in git-gui
using keyboard-only.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui/git-gui.sh | 57 ++
irger,
>
> On Wed, 28 Feb 2018, Birger Skogeng Pedersen wrote:
>
>> The user cannot change focus between the list of files, the diff view
>> and the commit message widgets without using the mouse (clicking either of
>> the four widgets ).
>>
>> Hotkey
My apologies.
Seems there was some error causing this, I see now that paths are
automatically re-selected by default. Can't reproduce the error.
Please disregard this thread.
Birger
CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the
(numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER)
to yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound
to do_commit.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui/git-gui.sh | 1
Sorry about that. Version 2 coming right up.
On Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine wrote:
> On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen
> wrote:
>> ---
>
> Please sign-off on your patch. See Documentation/SubmittingPatches.
>
> Also, it would be hel
---
git-gui/git-gui.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 91c00e648..6de74ce63 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
bind . <$M1B-Key-plus>
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
using the numpad ENTER does not invoke the same command.
I propose that both numpad ENTER and "regular" ENTER should invoke the
same command.
When a path is selected in "Unstaged Changes", it can be staged
(obviously). When it is staged, the path goes to the "Staged Changes"
list, and no (new) path is selected. I propose that this action should
re-select a new path, from the list of paths in "Unstaged Changes".
Steps to reproduce (in gi
the diff view or the
commit message dialog widgets, respectively. This enables the user to
select/unselect files, view the diff and create a commit in git-gui
using keyboard-only.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui/git-gui.sh | 37 +
1 file ch
Hi,
I've discovered a bug, I'll be sending a new version soon.
br
Birger
On Fri, Feb 23, 2018 at 11:22 AM, Birger Skogeng Pedersen
wrote:
> The user cannot change focus between the list of files, the diff view
> and the commit message widgets without using the mouse (clicking
the diff view or the
commit message dialog widgets, respectively. This enables the user to
select/unselect files, view the diff and create a commit in git-gui
using keyboard-only.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui/git-gui.sh | 34 ++
1 file ch
System: Ubuntu 17.10 Gnome
When opening git-gui from a directory which is a repository, minimize
and maximize buttons are showing and functional in git-gui.
However, if I open git-gui in a non-repo directory, git-gui opens a
dialog where I can "Create New Repository", "Clone Existing
Repository",
git-gui, all without using the mouse.
I propose that CTRL+(number) could be used as hotkeys to change the
focus between the four widgets I've mentioned.
Best regards,
Birger Skogeng Pedersen
In git-gui, multiple files from the "Unstaged Changes" widget can be
selected. Once multiple files are selected, they can be staged by
clicking (toolbar) "Commit"->"Stage To Commit". All the files that
were selected then gets staged for the commit. The "Stage To Commit"
hotkey (CTRL+T) behaves like
74 matches
Mail list logo
