Re: Stable GnuPG interface, git should use GPGME

2017-03-13 Thread Bernhard Reiter
tial issues with directly calling a gpg binary, using libgpgme by default probably has other advantages as well. And if there are important functions missing the GnuPG-devs would like to hear about them. Regards, Bernhard -- www.intevation.de/~bernhard   +49 541 33 508 3-3 Intevation GmbH, Osnabrück, DE; Amtsgericht Osnabrück, HRB 18998 Geschäftsführer Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner signature.asc Description: This is a digitally signed message part.

Re: [PATCH] git-imap-send: use libcurl for implementation

2014-11-09 Thread Bernhard Reiter
Am 2014-11-09 um 14:00 schrieb Torsten Bögershausen: > On 2014-08-27 00.40, Bernhard Reiter wrote: >> Use libcurl's high-level API functions to implement git-imap-send >> instead of the previous low-level OpenSSL-based functions. >> > This doesn't seem to ful

Re: [PATCH] imap-send: use libcurl for implementation

2014-11-07 Thread Bernhard Reiter
Zitat von Junio C Hamano : > Bernhard Reiter writes: > >> @@ -25,7 +25,6 @@ Typical usage is something like: >> >> git format-patch --signoff --stdout --attach origin | git imap-send >> >> - >> OPTIONS > > Why? By mistake when rebasing

[PATCH] imap-send: use libcurl for implementation

2014-11-06 Thread Bernhard Reiter
es of "PLAIN" and "LOGIN" for the authMethod. Signed-off-by: Bernhard Reiter --- Fixed according to , and based upon master with f1a35295c2b66d2501f034d864afb2c5d8bb0e08 cherry-picked. Documentation/git-imap-send.txt | 18 - INSTALL | 15 ++-- Ma

[PATCH v2] imap-send: Use parse options API to determine verbosity

2014-11-05 Thread Bernhard Reiter
Signed-off-by: Bernhard Reiter --- In reply to . Thanks for bearing with me. I should've given the corresponding verbosity values more thought myself in the first place. Documentation/git-imap-send.txt | 14 +- imap-send.c | 25 +++-- 2

imap-send: Use parse options API to determine verbosity

2014-11-05 Thread Bernhard Reiter
Signed-off-by: Bernhard Reiter --- As requested per . Documentation/git-imap-send.txt | 14 +- imap-send.c | 25 +++-- 2 files changed, 28 insertions(+), 11 deletions(-) diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap

[PATCH] git-imap-send: use libcurl for implementation

2014-10-29 Thread Bernhard Reiter
Resending this once more, as indicated by Hope my formatting and posting style is now conformant. Sorry for the noise. Am 2014-08-27 um 19:20 schrieb Junio C Hamano: > Bernhard Reiter writes: > >> [...] For now, >> the old ones are wrapped in #ifdefs, and the new functions

Fwd: Re: [PATCH] git-imap-send: use libcurl for implementation

2014-10-22 Thread Bernhard Reiter
0 Von: Bernhard Reiter An: Junio C Hamano Kopie (CC): git@vger.kernel.org, Jonathan Nieder , Jeff King , 434...@bugs.debian.org, René Scharfe , Tony Finch , Tanay Abhra , Dan Albert , Jeremy Huddleston , David Aguilar , Michael Haggerty , Oswald Buddenhagen Sorry for not getting back to thi

Re: [PATCH] git-imap-send: use libcurl for implementation

2014-10-12 Thread Bernhard Reiter
Sorry for not getting back to this any sooner, I've been pretty busy recently with Other Projects(tm). Am 2014-08-27 um 19:20 schrieb Junio C Hamano: > Bernhard Reiter writes: > >> [...] For now, >> the old ones are wrapped in #ifdefs, and the new functions are enabl

[PATCH] git-imap-send: use libcurl for implementation

2014-08-26 Thread Bernhard Reiter
ave access to that many IMAP servers, I haven't been able to test the new code with a wide variety of parameter combinations. I did test both secure and insecure (imaps:// and imap://) connections and values of "PLAIN" and "LOGIN" for the authMethod. Signed-off-by: Bern

Re: [PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-25 Thread Bernhard Reiter
$(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \ - $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL) $(LIB_4_CRYPTO) + $(LIBS) $(IMAP_SEND_LDFLAGS) git-http-fetch$X: http.o http-walker.o http-fetch.o GIT-LDFLAGS $(GITLIBS) $(QUIET_LINK)$(CC) $(ALL_CFLA

[PATCH] imap-send.c: imap_folder -> imap_server_conf.folder

2014-08-19 Thread Bernhard Reiter
Rename the imap_folder variable to folder and make it a member of struct imap_server_conf. Signed-off-by: Bernhard Reiter --- As discussed in http://www.mail-archive.com/git@vger.kernel.org/msg57019.html Bernhard imap-send.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

Re: [PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-19 Thread Bernhard Reiter
Am 2014-08-17 um 20:42 schrieb Jeff King: > [...] > >>> I'm not sure I understand this comment. Even if SSL is not in use, >>> wouldn't we be passing a regular pipe to curl, which would break? >> >> Yeah, we can't do that, and thus would have to keep the handwritten IMAP >> implementation just for

Re: [PATCH] git-imap-send: simplify tunnel construction

2014-08-18 Thread Bernhard Reiter
Am 2014-08-18 um 19:00 schrieb Junio C Hamano: > Bernhard Reiter writes: > >> Signed-off-by: Bernhard Reiter >> --- >> imap-send.c | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) > > Oy. Where is the patch? > > Please avoid multip

Re: [PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-17 Thread Bernhard Reiter
Am 2014-08-17 um 10:30 schrieb Jeff King: > On Tue, Aug 12, 2014 at 06:59:17PM -0700, Jonathan Nieder wrote: > >>> + curl_socket_t sockfd = tunnel.out; // what about tunnel.in ? >> >> Hmm. curl expects to get a socket it can send(), recv(), setsockopt(), >> etc on instead of a pair of f

Re: [PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-14 Thread Bernhard Reiter
ave access to that many IMAP servers, I haven't been able to test the new code with a wide variety of parameter combinations. I did test both secure and insecure (imaps:// and imap://) connections and values of "PLAIN" and "LOGIN" for the authMethod. Signed-off-by: Bernhar

[PATCH] http.c: die if curl_*_init fails

2014-08-13 Thread Bernhard Reiter
Signed-off-by: Bernhard Reiter --- http.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/http.c b/http.c index c8cd50d..afe4fc5 100644 --- a/http.c +++ b/http.c @@ -300,6 +300,9 @@ static CURL *get_curl_handle(void) { CURL *result = curl_easy_init(); + if

[PATCH] git-imap-send: simplify tunnel construction

2014-08-13 Thread Bernhard Reiter
Signed-off-by: Bernhard Reiter --- imap-send.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/imap-send.c b/imap-send.c index 524fbab..fb01a9c 100644 --- a/imap-send.c +++ b/imap-send.c @@ -961,17 +961,16 @@ static struct imap_store *imap_open_store(struct

[PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-12 Thread Bernhard Reiter
Use libcurl's high-level API functions to implement git-imap-send instead of the previous low-level OpenSSL-based functions. Signed-off-by: Bernhard Reiter --- Since version 7.30.0, libcurl's API has been able to communicate with IMAP servers. Using those high-level functions inst