On 11.10.19 16:43, Daniel Lezcano wrote:
>
> Hi all,
>
> Is there a way to specify a line to be added in the change-log after the
> SOB with git-am ?
>
> I would like to do something:
>
> git am -s -l "Link: https://lore.kernel.org/r/"
>
> Which will give:
>
> blabla
>
> Signed-off-by: aut..
This macro has been available globally since b4f2a6ac92 ("Use #define
ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))", 2006-03-09), so let's use it.
Signed-off-by: Beat Bolli
---
Brown paperbag fix. Sorry!
It's idle to speculate about why the macro wasn't used in the original
The parameter marker for x was garbled in its introduction in 89c855ed3c
("git-compat-util.h: implement a different ARRAY_SIZE macro for for
safely deriving the size of array", 2015-04-30).
Signed-off-by: Beat Bolli
---
git-compat-util.h | 2 +-
1 file changed, 1 insertion(+),
This macro has been available globally since b4f2a6ac92 ("Use #define
ARRAY_SIZE(x) (sizeof(x)/sizeof(x[0]))", 2006-03-09), so let's use it.
Signed-off-by: Beat Bolli
---
It's idle to speculate about why the macro wasn't used in the original
9e83266525 ("commi
This information is useful and not visible anywhere else, so show it.
Signed-off-by: Beat Bolli
Suggested-by: Johannes Schindelin
---
This applies on top of 'ab/pcre-jit-fixes', currently in pu.
grep.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/grep.c b/gr
Hi Dscho,
On 23.07.19 21:19, Johannes Schindelin wrote:
> Hi Beat,
>
> On Mon, 22 Jul 2019, Beat Bolli wrote:
>
>> When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value
>> of pcre1_jit_on.
>>
>> Print the value of pcre2_jit_on inst
When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value
of pcre1_jit_on.
Print the value of pcre2_jit_on instead.
Signed-off-by: Beat Bolli
---
grep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/grep.c b/grep.c
index f7c3a5803e..cd952ef5d3 100644
--- a
On 11.07.19 20:25, Ariadne Conill wrote:
> Hello,
>
> On Thu, Jul 11, 2019 at 1:24 PM Beat Bolli wrote:
>>
>> On 11.07.19 19:26, Ariadne Conill wrote:
>>> When mailmap is enabled by default or by configuration, it may be
>>> useful to override the
On 11.07.19 19:26, Ariadne Conill wrote:
> When mailmap is enabled by default or by configuration, it may be
> useful to override the default behaviour. Previously, it was
> possible to enable the mailmap feature when it was disabled by
> default or in the configuration, but it was not possible to
On 11.07.19 19:26, Ariadne Conill wrote:
> In order to prove that the --no-use-mailmap option works as expected,
> we add a test for it which runs with -Dlog.mailmap=true to ensure that
s/-D/-c /
This ain't Java :-)
> the option successfully negates the configured default.
>
> Signed-off-by: Ar
Hi Dscho
On 04.07.19 23:52, Johannes Schindelin wrote:
> Hi Beat,
>
> On Thu, 4 Jul 2019, Beat Bolli wrote:
>
>> On 27.06.19 11:37, Johannes Schindelin via GitGitGadget wrote:
>>> From: Johannes Schindelin
>>>
>>> Previously, we would have o
On 27.06.19 11:37, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin
>
> Previously, we would have obtained the user name encoded in whatever the
> current code page is.
>
> Note: the "user name" here does not denote the full name but instead the
> short logon name.
>
> Si
On 31.05.19 13:31, David wrote:
> # Summary
>
> I was trying to clone the AOSP source tree (Android Open Source Project)
> and I finally was able to formally identify what seems to be a severe
> regression (one that is blocking usage) in the last version of git
> (2.21.0).
>
> # Steps to reproduc
Now that Unicode 12.1 has been announced[0], update the character
width tables to the new version.
[0] http://blog.unicode.org/2019/05/unicode-12-1-en.html
Signed-off-by: Beat Bolli
---
unicode-width.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/unicode-width.h b
On 08.05.19 19:31, Denton Liu wrote:
> Hi Beat,
>
> On Wed, May 08, 2019 at 07:18:18PM +0200, Beat Bolli wrote:
>> On 08.05.19 17:02, Denton Liu wrote:
>>> In git-format-patch, notes can be appended with the `--notes` option.
>>> However, this must be specified by
On 08.05.19 17:02, Denton Liu wrote:
> In git-format-patch, notes can be appended with the `--notes` option.
> However, this must be specified by the user on an
> invocation-by-invocation basis. If a user is not careful, it's possible
> that they may forget to include it and generate a patch series
Now that Unicode 12 has been announced[0], update the character
width tables to the new version.
[0] http://blog.unicode.org/2019/03/announcing-unicode-standard-version-120.html
Signed-off-by: Beat Bolli
---
unicode-width.h | 38 +-
1 file changed, 25
On 07.10.18 13:36, Beat Bolli wrote:
> On 02.10.18 22:18, Jacob Keller wrote:
>> On Tue, Oct 2, 2018 at 1:07 PM Jacob Keller wrote:
>>>
>>> From: Jacob Keller
>>>
>>> make coccicheck is used in order to apply coccinelle semantic patches,
>>&
On 02.10.18 22:18, Jacob Keller wrote:
> On Tue, Oct 2, 2018 at 1:07 PM Jacob Keller wrote:
>>
>> From: Jacob Keller
>>
>> make coccicheck is used in order to apply coccinelle semantic patches,
>> and see if any of the transformations found within contrib/coccinelle/
>> can be applied to the curr
Jonathan Nieder
Signed-off-by: Beat Bolli
---
packfile.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.h b/packfile.h
index 51383774ec72..28318c5c7c42 100644
--- a/packfile.h
+++ b/packfile.h
@@ -1,12 +1,12 @@
#ifndef PACKFILE_H
#define PACKFILE_H
+#include
to include this in the next
version of the cc/remote-odb topic.
Beat Bolli (1):
packfile: drop a repeated enum declaration
packfile.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.18.0
On 25.07.18 18:57, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> In the interest of code hygiene, make it easier to compile Git with the
>> flag -pedantic.
>>
>> Pure pedantic compilation with GCC 7.3 results in one warning per use of
>> the translation
Hi Jonathan
On 24.07.18 23:59, Jonathan Nieder wrote:
> Hi,
>
> Beat Bolli wrote:
>
>> When compiling under Apple LLVM version 9.1.0 (clang-902.0.39.2) with
>> "make DEVELOPER=1 DEVOPTS=pedantic", the compiler says
>>
>> remote-odb.c:87:2:
Following up on my previous series bb/pedantic for gcc, here are two
fixes for pedantic compilation under MacOS 10.13.6 (High Sierra) with
the command line tools of Xcode Version 9.4.1 (9F2000).
Beat Bolli (2):
packfile: drop a repeated enum declaration
remote-odb: un-inline function
-inline]
Remove the inline specifier that would only make sense if
remote_odb_reinit were defined in the header file. Moving it into the
header is not possible because the called function remote_odb_do_init is
static and thus not visible from the includers of the header.
Signed-off-by: Beat Bolli
-
um before
including packfile.h.
Signed-off-by: Beat Bolli
---
packfile.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/packfile.h b/packfile.h
index 51383774ec72..9b6198c4c7e0 100644
--- a/packfile.h
+++ b/packfile.h
@@ -6,7 +6,6 @@
/* in object-store.h */
struct packed_git;
struct
parenthesising of i18n strings with
-DUSE_PARENS_AROUND_GETTEXT_N=0.
Signed-off-by: Beat Bolli
---
Now with -DUSE_PARENS_AROUND_GETTEXT_N=0 instead of =No.
This is the convenience knob for all developers that led to the series
bb/pedantic[1]. It does not depend on this series, though.
[1] https
On 24.07.18 20:50, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> On 24.07.18 20:22, Junio C Hamano wrote:
>>
>>>> This was already fixed (differently) in
>>>> <20180705183445.30901-1-dev+...@drbeat.li>.
>>>
>>> Thanks for sa
On 24.07.18 20:22, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> Hi Jeff
>>
>> On 24.07.18 17:30, g...@jeffhostetler.com wrote:
>>> From: Jeff Hostetler
>>>
>>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
>>>
Hi Jeff
On 24.07.18 17:30, g...@jeffhostetler.com wrote:
> From: Jeff Hostetler
>
> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
> to builtin/config.c to define a new function and a forward declaration
> for an array of unknown size. This causes a compile error under MSVC.
Hi Jeff
On 24.07.18 16:42, g...@jeffhostetler.com wrote:
> From: Jeff Hostetler
>
> Replace non-standard "\e" escape sequence with "\x1B".
This was already fixed in <20180708144342.11922-4-dev+...@drbeat.li>.
Cheers,
Beat
>
> In commit 7a17918c34f4e83982456ffe22d880c3cda5384f a trace messag
parenthesising of i18n strings with
-DUSE_PARENS_AROUND_GETTEXT_N=no.
Signed-off-by: Beat Bolli
---
Now with -DUSE_PARENS_AROUND_GETTEXT_N=0 instead of =No.
This is the convenience knob for all developers that led to the series
bb/pedantic[1]. It does not depend on this series, though.
[1
On 23.07.18 20:53, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> In the interest of code hygiene, make it easier to compile Git with the
>> flag -pedantic.
>>
>> Pure pedantic compilation with GCC 7.3 results in one warning per use of
>> the translation
parenthesising of i18n strings with
-DUSE_PARENS_AROUND_GETTEXT_N=no.
Signed-off-by: Beat Bolli
---
This is the convenience knob for all developers that led to the series
bb/pedantic[1]. It does not depend on this series, though.
[1] https://public-inbox.org/git/20180708144342.11922-1-dev
.
Signed-off-by: Beat Bolli
---
This is the convenience knob for all developers that led to the series
bb/pedantic[1]. It does not depend on this series, though.
[1] https://public-inbox.org/git/20180708144342.11922-1-dev+...@drbeat.li/T/#u
Makefile | 4
config.mak.dev | 4
2
The macro GIT_PATH_FUNC expands to a function definition that ends with
a closing brace. The extra semicolon produces a warning when compiling
with -pedantic.
Signed-off-by: Beat Bolli
---
Junio, this applies on top of pk/rebase-in-c.
Thanks, Beat
builtin/rebase.c | 4 ++--
1 file changed, 2
On 17.07.18 23:49, Beat Bolli wrote:
> On 06.07.18 14:08, Pratik Karki wrote:
>> +static GIT_PATH_FUNC(apply_dir, "rebase-apply");
>> +static GIT_PATH_FUNC(merge_dir, "rebase-merge");
>
> Maybe fix this up with
>
> -static GIT_PATH_FUNC(appl
On 06.07.18 14:08, Pratik Karki wrote:
> +static GIT_PATH_FUNC(apply_dir, "rebase-apply");
> +static GIT_PATH_FUNC(merge_dir, "rebase-merge");
Maybe fix this up with
-static GIT_PATH_FUNC(apply_dir, "rebase-apply");
-static GIT_PATH_FUNC(merge_dir, "rebase-merge");
+static GIT_PATH_FUNC(apply_dir
Hi Junio
Am 09.07.2018 23:45, schrieb Junio C Hamano:
Beat Bolli writes:
While developing 6aaded550 ("builtin/config: work around an unsized
array forward declaration", 2018-07-05), I have compiled Git with
CFLAGS="-std=c99 -pedantic".
Nicely done.
With the
On 09.07.18 23:45, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> While developing 6aaded550 ("builtin/config: work around an unsized
>> array forward declaration", 2018-07-05), I have compiled Git with
>> CFLAGS="-std=c99 -pedantic".
>
>
On 09.07.18 23:34, Junio C Hamano wrote:
> Beat Bolli writes:
>
>> The marco GIT_PATH_FUNC expands to a complete statement including the
>> semicolon. Remove two extra trailing semicolons.
>
> Wait a bit. The observation in the log message and the
> implementatio
On 09.07.18 21:25, Beat Bolli wrote:
> While developing 6aaded550 ("builtin/config: work around an unsized
> array forward declaration", 2018-07-05), I have compiled Git with
> CFLAGS="-std=c99 -pedantic".
>
> This series fixes a few compiler warnings when co
Now that Unicode 11 has been announced[0], update the character
width tables to the new version.
[0] http://blog.unicode.org/2018/06/announcing-unicode-standard-version-110.html
Signed-off-by: Beat Bolli
---
unicode-width.h | 41 -
1 file changed, 28
On 09.07.18 20:46, Jeff King wrote:
> On Sun, Jul 08, 2018 at 04:43:38PM +0200, Beat Bolli wrote:
>
>> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
>> index dd834314bd..a78b5cb803 100644
>> --- a/refs/refs-internal.h
>> +++ b/refs/refs-internal.h
ISO C forbids the conversion of void pointers to function pointers.
Introduce a context struct that encapsulates the function pointer.
Signed-off-by: Beat Bolli
---
string-list.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/string-list.c b/string
The macro GIT_PATH_FUNC expands to a function definition that ends with
a closing brace. Remove two extra semicolons.
While at it, fix the example in path.h.
Signed-off-by: Beat Bolli
---
path.h | 2 +-
sequencer.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a
In ISO C, char constants must be in the range -128..127. Change the BOM
constants to char literals to avoid overflow.
Signed-off-by: Beat Bolli
---
utf8.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/utf8.c b/utf8.c
index d55e20c641..982217eec9 100644
--- a/utf8.c
Include iterator.h to define enum iterator_selection.
Signed-off-by: Beat Bolli
---
refs/refs-internal.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index dd834314bd..a78b5cb803 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
The "\e" escape is not defined in ISO C.
While on this line, add a missing space after the comma.
Signed-off-by: Beat Bolli
---
convert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/convert.c b/convert.c
index 64d0d30e08..edebb946f5 100644
--- a/conve
Include protocol.h to define enum protocol_version.
Signed-off-by: Beat Bolli
---
connect.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/connect.h b/connect.h
index 0e69c6709c..c86f862f2f 100644
--- a/connect.h
+++ b/connect.h
@@ -1,6 +1,8 @@
#ifndef CONNECT_H
#define CONNECT_H
is worth the trouble.
6) utf8.c: overflow of char values.
Used proper char literals for the BOM constants.
This series has patches for 2) to 6).
Regards,
Beat
[0]
https://public-inbox.org/git/53ab8626-f862-a732-b369-abeab69a4...@ramsayjones.plus.com/T/
Beat Bolli (6):
connect.h
On 09.07.18 18:33, Junio C Hamano wrote:
> Beat Bolli writes:
>
>>>> -static const char utf16_be_bom[] = {0xFE, 0xFF};
>>>> -static const char utf16_le_bom[] = {0xFF, 0xFE};
>>>> -static const char utf32_be_bom[] = {0x00, 0x00, 0xFE, 0xFF};
>>&g
Am 09.07.2018 16:48, schrieb Beat Bolli:
Hi Dscho
Am 09.07.2018 15:14, schrieb Johannes Schindelin:
Hi Beat,
On Sun, 8 Jul 2018, Beat Bolli wrote:
In ISO C, char constants must be in the range -128..127. Change the
BOM
constants to unsigned char to avoid overflow.
Signed-off-by: Beat
Hi Dscho
Am 09.07.2018 15:14, schrieb Johannes Schindelin:
Hi Beat,
On Sun, 8 Jul 2018, Beat Bolli wrote:
In ISO C, char constants must be in the range -128..127. Change the
BOM
constants to unsigned char to avoid overflow.
Signed-off-by: Beat Bolli
---
utf8.c | 10 +-
1 file
The "\e" escape is not defined in ISO C.
While on this line, add a missing space after the comma.
Signed-off-by: Beat Bolli
---
convert.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/convert.c b/convert.c
index 64d0d30e08..edebb946f5 100644
--- a/conve
ISO C forbids the conversion of void pointers to function pointers.
Introduce a context struct that encapsulates the function pointer.
Signed-off-by: Beat Bolli
---
string-list.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/string-list.c b/string
Include iterator.h to define enum iterator_selection.
Signed-off-by: Beat Bolli
---
refs/refs-internal.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index dd834314bd..a78b5cb803 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
In ISO C, char constants must be in the range -128..127. Change the BOM
constants to unsigned char to avoid overflow.
Signed-off-by: Beat Bolli
---
utf8.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/utf8.c b/utf8.c
index d55e20c641..833ce00617 100644
--- a
The marco GIT_PATH_FUNC expands to a complete statement including the
semicolon. Remove two extra trailing semicolons.
Signed-off-by: Beat Bolli
---
sequencer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index 5354d4d51e..66e7073995 100644
Include protocol.h to define enum protocol_version.
Signed-off-by: Beat Bolli
---
connect.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/connect.h b/connect.h
index 0e69c6709c..c86f862f2f 100644
--- a/connect.h
+++ b/connect.h
@@ -1,6 +1,8 @@
#ifndef CONNECT_H
#define CONNECT_H
While developing 6aaded550 ("builtin/config: work around an unsized
array forward declaration", 2018-07-05), I have compiled Git with
CFLAGS="-std=c99 -pedantic".
This is an RFC patch series that fixes a few compiler warnings when
compiling with these options, always assuming that this is a worthw
Hi Peff
On 05.07.18 21:38, Jeff King wrote:
> On Thu, Jul 05, 2018 at 08:34:45PM +0200, Beat Bolli wrote:
>
>> As reported here[0], Microsoft Visual Studio 2017.2 and "gcc -pedantic"
>> don't understand the forward declaration of an unsized static array
e usage_with_options() is
called with the same arguments.
[0]: https://github.com/git-for-windows/git/issues/1735
[1]: https://groups.google.com/forum/#!topic/comp.lang.c.moderated/bmiF2xMz51U
Fixes https://github.com/git-for-windows/git/issues/1735
Reported-By: Karen Huang (via GitHub)
On 25.04.18 02:32, Lev wrote:
> Hi list,
>
>
> I'm struggling with git connecting to Github.
>
> The problem might be SSL/TLS related.
>
> https://githubengineering.com/crypto-removal-notice/
>
> I suspect that my setup still uses tlsv1 or tlsv1.1.
>
> I've tried to explicitly set git to use
On Wed, Apr 25, 2018 at 09:05:56AM +0900, Junio C Hamano wrote:
> Johannes Sixt writes:
>
> > In modern setups, less, the pager, uses alternate screen to show
> > the content. When it is closed, it switches back to the original
> > screen, and all content is gone.
> >
> > It is not uncommon to re
On Mon, Apr 23, 2018 at 11:13:41AM -0500, Jason B. Nance wrote:
> Hello all,
>
> We are seeing intermittent errors with Git 2.16.2.windows.1 on Windows
> 7 connecting to TFS 2017 (running in a Jenkins slave process):
>
> ERROR: Error cloning remote repo 'origin'
> hudson.plugins.git.GitEx
-for-windows/git/issues/1487 and subseqently in
https://public-inbox.org/git/f65780f29e48994380e2bce87c6f071101146...@deerlm99ex2msx.ww931.my-it-solutions.net/
Signed-off-by: Beat Bolli
---
Cc: Alexander Gavrilov
Cc: Pat Thoyts
git-gui/lib/sshkey.tcl | 5 -
1 file changed, 4 insertions(+), 1
In 89a70b80 ("t0302 & t3900: add forgotten quotes", 2018-01-03), quotes
were added to protect against spaces in $HOME. In the test_when_finished
handler, two files are deleted which must be quoted individually.
Signed-off-by: Beat Bolli
---
Diff to v1:
s/hander/handler/ in th
In 89a70b80 ("t0302 & t3900: add forgotten quotes", 2018-01-03), quotes
were added to protect against spaces in $HOME. In the test_when_finished
hander, two files are deleted which must be quoted individually.
Signed-off-by: Beat Bolli
---
t/t3900-i18n-commit.sh | 8
1 f
Add the configuration option "jump.grepCmd" that allows to configure the
command that is used to search in grep mode. This allows the users of
git-jump to use ag(1) or ack(1) as search engines.
Signed-off-by: Beat Bolli
---
contrib/git-jump/README | 3 +++
contrib/git-jump/gi
Add the configuration option "jump.grepCmd" that allows to configure the
command that is used to search in grep mode. This allows the users of
git-jump to use ag(1) or ack(1) as search engines.
Signed-off-by: Beat Bolli
---
contrib/git-jump/README | 3 +++
contrib/git-jump/gi
--
„It takes love over gold” — Dire Straits
> On 7 Jul 2017, at 17:43, Junio C Hamano wrote:
>
> Beat Bolli writes:
>
>> Now that the Unicode 10 has been announced[0], update the character
>> width tables to the new version.
Typo! Could you drop the first "t
Now that the Unicode 10 has been announced[0], update the character
width tables to the new version.
[0] http://blog.unicode.org/2017/06/announcing-unicode-standard-version-100.html
Signed-off-by: Beat Bolli
---
unicode_width.h | 42 +-
1 file changed
Hi Dscho
On 2016-12-23 10:30, Johannes Schindelin wrote:
Hi Beat,
On Fri, 23 Dec 2016, Beat Bolli wrote:
On 22.12.16 18:08, Johannes Schindelin wrote:
> diff --git a/compat/winansi.c b/compat/winansi.c
> index cb725fb02f..590d61cb1b 100644
> --- a/compat/winansi.c
> +++ b/comp
On 22.12.16 18:08, Johannes Schindelin wrote:
> When determining whether a handle corresponds to a *real* Win32 Console
> (as opposed to, say, a character device such as /dev/null), we use the
> GetConsoleOutputBufferInfo() function as a tell-tale.
>
> However, that does not work for *input* handl
On 14.12.16 00:31, Beat Bolli wrote:
> [PATCH v2 4/6] update-unicode.sh: automatically download newer definition
> files
Dang! And again I'm not capable of putting an underline instead of the
dash...
Junio, would you please reword the subject to
Re: [PATCH v2 4/6] update
The uniset upstream has accepted my patches that eliminate the Unicode
plane offsets from the output in '--32' mode.
Remove the corresponding filter in update_unicode.sh.
This also fixes the issue that the plane offsets were not removed from
the second uniset call.
Signed-off-by:
The uniset upstream has added more commits that for example change the
hexadecimal output in '--32' mode to decimal. Let's pin the repo to a
commit that still outputs the width tables in the format we want.
Signed-off-by: Beat Bolli
---
contrib/update-unicode/update_unicode.sh
As it's used only by a tiny minority of the Git developer population,
this script does not belong into the main Git source directory.
Move it into contrib/ and adjust the paths to account for the new
location.
Signed-off-by: Beat Bolli
---
.gitignore
Checking just for the unicode data files' existence is not sufficient;
we should also download them if a newer version exists on the Unicode
consortium's servers. Option -N of wget does this nicely for us.
Reviewed-by: Torsten Bögershausen
Signed-off-by: Beat Bolli
---
contrib/upda
After the move into contrib/update-unicode, we no longer create the
unicode directory to have a clean working folder. Instead, the directory
of the script is used. This means that the subshell can be removed.
Signed-off-by: Beat Bolli
---
contrib/update-unicode/update_unicode.sh | 53
This is v2 of my Unicode 9.0 series. After a short discussion [1], we
decided to move the generator script into contrib. This is what this
series now does first. The script is then updated in contrib.
Diff to v1:
- complete commit reordering
- fix nits in the commit messages
.gitignore
Rerunning update-unicode.sh that we fixed in the previous commits
produces these new tables.
Signed-off-by: Beat Bolli
---
unicode_width.h | 131 +---
1 file changed, 107 insertions(+), 24 deletions(-)
diff --git a/unicode_width.h b
On 12.12.16 19:33, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> If I run ./update_unicode.sh on the latest master of
>> https://github.com/depp/uniset.git , commit
>> a5fac4a091857dd5429cc2d, I get a diff in unicode_width.h like
>> this:
>>
>> -{ 0x0300, 0x036F },
>>
>> +{ 768, 879 }
On 12.12.16 19:12, Torsten Bögershausen wrote:
>
>>> Minor question, especially to the next commit:
>>> Should we make sure to checkout the exact version, which has been tested?
>>> In this case cb97792880625e24a9f581412d03659091a0e54f
>>>
>>> And this is for both a fresh clone and the git pull
>
On 2016-12-12 06:53, Torsten Bögershausen wrote:
On 2016-12-12 00:34, Beat Bolli wrote:
We need to track the new commits in uniset, otherwise their and our
code
get out of sync.
Signed-off-by: Beat Bolli
---
Junio, these go on top of my bb/unicode-9.0 branch, please.
Thanks
We need to track the new commits in uniset, otherwise their and our code
get out of sync.
Signed-off-by: Beat Bolli
---
Junio, these go on top of my bb/unicode-9.0 branch, please.
Thanks!
update_unicode.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/update_unicode.sh b
The uniset upstream has decided that decimal numbers are The True Way, so
let's convert them back to the usual format that's closer to the U+
standard.
The generated unicode_widths.h file again looks exactly the same as two
commits ago.
Signed-off-by: Beat Bolli
---
update_unic
The uniset upstream has accepted my patches that eliminate the Unicode
plane offsets from the output in '--32' mode.
Remove the corresponding filter in update_unicode.sh.
Signed-off-by: Beat Bolli
---
update_unicode.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
di
On 05.12.16 21:31, Junio C Hamano wrote:
> Torsten Bögershausen writes:
>
>> On Sat, Dec 03, 2016 at 10:00:47PM +0100, Beat Bolli wrote:
>>> Checking just for the unicode data files' existence is not sufficient;
>>> we should also download them if a
Rerunning update-unicode.sh that we fixed in the two previous commits
produces these new tables.
Signed-off-by: Beat Bolli
---
unicode_width.h | 131 +---
1 file changed, 107 insertions(+), 24 deletions(-)
diff --git a/unicode_width.h b
Bögershausen
Signed-off-by: Beat Bolli
---
update_unicode.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/update_unicode.sh b/update_unicode.sh
index 3c84270..4c1ec8d 100755
--- a/update_unicode.sh
+++ b/update_unicode.sh
@@ -30,7 +30,7 @@ fi &&
Checking just for the unicode data files' existence is not sufficient;
we should also download them if a newer version exists on the Unicode
consortium's servers. Option -N of wget does this nicely for us.
Reviewed-by: Torsten Boegershausen
Signed-off-by: Beat Bolli
---
Diff to v3:
On 03.12.16 17:40, Torsten =?unknown-8bit?Q?B=C3=B6gershausen?= wrote:
> On Sat, Dec 03, 2016 at 02:19:31PM +0100, Beat Bolli wrote:
>> Checking just for the unicode data files' existence is not sufficient;
>> we should also download them if a newer version exists on the Uni
Checking just for the unicode data files' existence is not sufficient;
we should also download them if a newer version exists on the Unicode
consortium's servers. Option -N of wget does this nicely for us.
Cc: Torsten Bögershausen
Signed-off-by: Beat Bolli
---
Diff to v2:
- r
Bögershausen
Signed-off-by: Beat Bolli
---
update_unicode.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/update_unicode.sh b/update_unicode.sh
index 3c84270..4c1ec8d 100755
--- a/update_unicode.sh
+++ b/update_unicode.sh
@@ -30,7 +30,7 @@ fi &&
grep
Rerunning update-unicode.sh that we fixed in the two previous commits
produces these new tables.
Signed-off-by: Beat Bolli
---
unicode_width.h | 131 +---
1 file changed, 107 insertions(+), 24 deletions(-)
diff --git a/unicode_width.h b
Checking just for the unicode data files' existence is not sufficient;
we should also download them if a newer version exists on the Unicode
consortium's servers. Option -N of wget does this nicely for us.
Cc: Torsten Bögershausen
Signed-off-by: Beat Bolli
---
Diff to v1:
- reword
Rerunning update-unicode.sh fixed in the previous commit produces these new
tables.
Signed-off-by: Beat Bolli
---
Diff to v1:
- reword the commit message
unicode_width.h | 122 +++-
1 file changed, 111 insertions(+), 11 deletions(-)
diff
.
Cc: Torsten Bögershausen
Signed-off-by: Beat Bolli
---
Diff to v1:
- add Thorsten's Cc:
unicode_width.h | 17 -
update_unicode.sh | 2 +-
2 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/unicode_width.h b/unicode_width.h
index 73b5fd6..02207be 100644
1 - 100 of 137 matches
Mail list logo
