Re: obsolete index in wt_status_print after pre-commit hook runs

2016-08-05 Thread Andrew Keller
Am 04.08.2016 um 12:45 nachm. schrieb Junio C Hamano : > Andrew Keller writes: > >> In summary, I think I prefer #2 from a usability point of view, however I’m >> having >> trouble proving that #1 is actually *bad* and should be disallowed. > > Yeah, I agr

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-08-03 Thread Andrew Keller
age template [2] and possibly create a patch that teaches builtin/commit.c to detect changes to the index after the pre-commit hook runs Thanks, - Andrew Keller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.o

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
Am 15.07.2016 um 6:03 nachm. schrieb Junio C Hamano : > Junio C Hamano writes: >> On Fri, Jul 15, 2016 at 1:30 PM, Andrew Keller wrote: >>> Am 15.07.2016 um 12:34 nachm. schrieb Andrew Keller : >>> >>>> I pulled out the source for version 2.9.1 and b

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
Am 15.07.2016 um 5:19 nachm. schrieb Junio C Hamano : > > On Fri, Jul 15, 2016 at 1:30 PM, Andrew Keller wrote: >> Am 15.07.2016 um 12:34 nachm. schrieb Andrew Keller : >> >>> I pulled out the source for version 2.9.1 and briefly skimmed how >>> run_commit

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
Am 15.07.2016 um 12:34 nachm. schrieb Andrew Keller : > I pulled out the source for version 2.9.1 and briefly skimmed how run_commit > and > prepare_to_commit work. It seems that Git already understands that a > pre-commit > hook can change the index, and it rereads the index

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
Definitely interested — Sounds like a great learning experience. Thanks, - Andrew Keller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
changes that the user didn't tell "git commit" to make. Ah! Good to know, then. I’ll rewrite my hook to behave more correctly. Thanks, - Andrew Keller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org

obsolete index in wt_status_print after pre-commit hook runs

2016-07-15 Thread Andrew Keller
ior is not intentional. I’d wager that this change is for the better, but since this behavior has been around so long (I stopped checking at 1.6.0), it doesn’t hurt to make sure. Any comments, concerns, or advice? Thanks, - Andrew Keller

Re: Handling empty directories in Git

2014-04-08 Thread Andrew Keller
On Apr 8, 2014, at 1:02 PM, Andrew Keller wrote: > On Apr 8, 2014, at 10:47 AM, Olivier LE ROY wrote: > >> Hello, >> >> I have a project under SVN with contains empty directories. >> >> I would like to move this project on a Git server, still handli

Re: Handling empty directories in Git

2014-04-08 Thread Andrew Keller
s create the folders on demand? Or, could your scripts interpret a missing folder as an empty folder? Thanks, Andrew Keller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] gitweb: Improve diffs when filenames contain problem characters

2014-03-30 Thread Andrew Keller
d-by: Dongsheng Song Signed-off-by: Andrew Keller --- Steps to reproduce: 1) Create a repository that contains a commit that adds a file: * with an ampersand in the filename * with binary contents 2) Make the repository visible to gitweb 3) In gitweb, navigate to the page that shows the

Re: Borrowing objects from nearby repositories

2014-03-28 Thread Andrew Keller
On Mar 26, 2014, at 1:29 PM, Junio C Hamano wrote: > Andrew Keller writes: > >> On Mar 25, 2014, at 6:17 PM, Junio C Hamano wrote: >> ... >>>> I think that the standard practice with the existing toolset is to >>>> clone with reference and then

Re: Borrowing objects from nearby repositories

2014-03-26 Thread Andrew Keller
t to undo. You would need a new parameter to disable the automatic adding of reference repositories, and a new parameter to undo '--auto-repack', and you'd have to remember to actually undo both of those settings. In contrast, if the new feature was '--borrow', and th

Re: Borrowing objects from nearby repositories

2014-03-25 Thread Andrew Keller
On Mar 24, 2014, at 5:21 PM, Ævar Arnfjörð Bjarmason wrote: > On Wed, Mar 12, 2014 at 4:37 AM, Andrew Keller wrote: >> Hi all, >> >> I am considering developing a new feature, and I'd like to poll the group >> for opinions. >> >> Background: A cou

Borrowing objects from nearby repositories

2014-03-11 Thread Andrew Keller
know how to set up a scheduled task on their computer, so this might become a maintenance problem for the user. This kind of problem I think brings into question the viability of the underlying design here, assuming that the ultimate goal is to clone faster, with very little or no change in the use o

Re: [PATCH/RFC] Documentation: Say that submodule clones use a separate gitdirs.

2014-03-09 Thread Andrew Keller
git clone the_project /media/usb/the_project > > Or at least I had understand what happened quicker. > > I have nothing against also adding something in repository-layout but I am > pretty sure normal users never read repository-layout as it is not a command > they use. And it

Re: [PATCH/RFC] Documentation: Say that submodule clones use a separate gitdirs.

2014-03-07 Thread Andrew Keller
in a submodule, for example, the directory name is the name of the module. Also, this file contains mostly high-level documentation, and this addition feels technical in nature. Is there a location for more technical documentation? Or, perhaps it can be reworded to sound less technical? >

Re: submodules: reuse .git/modules/... for multiple checkouts of same URL

2014-03-03 Thread Andrew Keller
b:refs/remotes/origin/contrib', which will cause only the objects pertaining to that branch will be downloaded. This has the most benefit when the commit graph is orphaned in some way. However, this approach requires manual labor every time you initialize a submodule. - Andrew Keller

Re: gitweb.cgi bug - XML Parsing Error: not well-formed

2014-02-18 Thread Andrew Keller
On Feb 18, 2014, at 6:41 AM, Dongsheng Song wrote: > Here is gitweb generated XHTML fragment: > > … You're going to have to be more specific. - Andrew -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info a

[PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-17 Thread Andrew Keller
than it is to see every pixel without zooming (previous behavior). Signed-off-by: Andrew Keller --- This is an updated copy of this patch. Could I request a thumbs up, thumbs down, or thumbs sideways from those who develop gitweb? Thanks, Andrew Keller gitweb/gitweb.perl |2 +- g

Re: gitweb.cgi bug

2014-02-09 Thread Andrew Keller
On Feb 8, 2014, at 10:19 PM, Dongsheng Song wrote: > On Sun, Feb 9, 2014 at 12:29 AM, Andrew Keller wrote: >> On Feb 8, 2014, at 8:37 AM, Dongsheng Song wrote: >> >>> I have an git repo PROJECT.git, the full path is /srv/repo/git/PROJECT.git, >>> when I set

Re: gitweb.cgi bug

2014-02-08 Thread Andrew Keller
On Feb 8, 2014, at 8:37 AM, Dongsheng Song wrote: > I have an git repo PROJECT.git, the full path is /srv/repo/git/PROJECT.git, > when I set git_base_url_list in gitweb.conf: > > @git_base_url_list = qw(https://192.168.30.239/repo/git >git@192.168.30.239:repo/git); >

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 7, 2014, at 7:35 AM, Vincent van Ravesteijn wrote: > On Fri, Feb 7, 2014 at 4:31 AM, Andrew Keller wrote: >> I recently used Git to archive a set of scanned photos, and I used gitweb to >> provide access to them. Overall, everything worked well, but I found it >&g

Re: [PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-07 Thread Andrew Keller
On Feb 6, 2014, at 10:31 PM, Andrew Keller wrote: > When displaying a blob in gitweb, if it's an image, specify constraints for > maximum display width and height to prevent the image from overflowing the > frame of the enclosing page_body div. > > This change assumes that

[PATCH] gitweb: Avoid overflowing page body frame with large images

2014-02-06 Thread Andrew Keller
When displaying a blob in gitweb, if it's an image, specify constraints for maximum display width and height to prevent the image from overflowing the frame of the enclosing page_body div. This change assumes that it is more desirable to see the whole image without scrolling (new behavior) than it

Re: Questions on local clone and push back

2014-01-30 Thread Andrew Keller
On Jan 30, 2014, at 12:43 AM, Arshavir Grigorian wrote: > 1) is this a good approach to achieving what I need If you do not intend to track the parent projects in Git, then yes - that is a good approach. With that said, I recommend tracking each parent project in its own Git repository, and t

Re: Conceptual Question for git usage ...

2014-01-22 Thread Andrew Keller
On Jan 22, 2014, at 9:20 AM, John McIntyre wrote: > … > > So basically, what I'd like to do is this. I want to write code, > write blg posts, write essays for university, whatever. And I want to > use git to maintain revisions, but where do I store them? Do I make > the Mac my hub? I have a

Re: Installing GIT Server

2012-08-10 Thread Andrew Keller
es. I'd guess that git-daemon might have similar problems. In the past, I have had problems with programs with programs in general accessing shared resources on file shares. I've had permission problems, update problems, and corruption problems when the network fails. I have