On 6/15/19 1:26 PM, Thomas Gummerer wrote:
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index ea30d5f6a0..3973cbda0e 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -708,6 +708,24 @@ test_expect_success 'invalid ref of the form "n", n >=
> N' '
> git stash drop
> '
>
On Mon, 1 Apr 2019 16:27:02 +0700, Duy Nguyen wrote:
> On Mon, Apr 1, 2019 at 5:03 AM Andrei Rybak wrote:
>> Support UTF-8 encoding of '✂' in function is_scissors_line, for 'git am
>> --scissors' to be able to cut at Unicode perforation lines in emails.
>
s://www.unicode.org/Public/reconstructed/1.0.0/UnicodeData.txt
2. https://unicode.org/Public/emoji/1.0/emoji-data.txt
Signed-off-by: Andrei Rybak
---
mailinfo.c| 7 +++
t/t4150-am.sh | 26 +-
2 files changed, 32 insertions(+), 1 deletion(-)
diff --git a/
which copies
this behavior without realizing substring length requirement. So use
starts_with() instead, which will stop at NUL regardless of the length
of the prefix. Remove extra pair of parentheses while we are here.
Helped-by: Jeff King
Signed-off-by: Andrei Rybak
---
On Mon, Apr 01, 2019 at 06
.unicode.org/versions/Unicode1.0.0/CodeCharts1.pdf
https://www.unicode.org/Public/reconstructed/1.0.0/UnicodeData.txt
2. https://unicode.org/Public/emoji/1.0/emoji-data.txt
Signed-off-by: Andrei Rybak
---
This applies on top of ar/t4150-remove-cruft merged into next in
commit a0106a8d5c,
On 3/21/19 2:16 PM, Nguyễn Thái Ngọc Duy wrote:
> ...
>
> diff --git a/advice.c b/advice.c
> index b224825637..27e39e6514 100644
> --- a/advice.c
> +++ b/advice.c
> @@ -191,20 +191,20 @@ void NORETURN die_conclude_merge(void)
> void detach_advice(const char *new_name)
> {
> const char *fmt
On 2019-03-12 16:48, Eric Sunshine wrote:
> Thanks. A few comments:
>
> In patch 1/2:
>
> * drop the full stop from the first line of the commit message
>
> * s/futur/future/ in the commit message
>
> * s/There are false/& positives/ in the commit message
>
> * s/both, It/both, it/
Also,
* s/inco
In commit 735285b403 ("am: fix signoff when other trailers are present",
2017-08-08) tests using variable $signoff were rewritten and it is no
longer used, so just remove it from the test setup.
Signed-off-by: Andrei Rybak
---
t/t4150-am.sh | 4 +---
1 file changed, 1 insertion(+), 3
On 3/8/19 10:57 AM, Nguyễn Thái Ngọc Duy wrote:
> ---
> t/t2060-switch.sh | 87 +++
> 1 file changed, 87 insertions(+)
> create mode 100755 t/t2060-switch.sh
>
> diff --git a/t/t2060-switch.sh b/t/t2060-switch.sh
> new file mode 100755
> index
On 3/8/19 11:16 AM, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> t/lib-patch-mode.sh | 12
> t/t2070-restore.sh (new +x) | 77 ++
> t/t2071-restore-patch.sh (new +x) | 105 ++
> 3 files changed
A couple of code style issues:
On 2/26/19 9:09 PM, Brandon wrote:
> From: Brandon Richardson
>
> Rather than parse options manually, which is both difficult to
> read and error prone, parse options supplied to commit-tree
> using the parse-options api.
>
> It was discovered that the --no-gpg-si
On 2/16/19 12:36 PM, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> Signed-off-by: Junio C Hamano
> ---
> Documentation/diff-options.txt | 7 ++
> diff.c | 39 +-
> 2 files changed, 36 insertions(+), 10 deletions(-
Subject line: s/i18n/index/
On 20/10/2018 14:38, Nguyễn Thái Ngọc Duy wrote:
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> Documentation/config.txt | 11 +--
> Documentation/index-config.txt | 10 ++
> 2 files changed, 11 insertions(+), 10 deletions(-)
> create mode 10064
On 2018-09-26 21:16, Junio C Hamano wrote:
> While at it, update the way to creatd these scripts to use the
s/creatd/create/
Or rewording as "... update the way these scripts are created ..."
> write_script wrapper, so that we do not have to worry about writing
> the she-bang line and making the
On 2018-08-29 12:02, Eric Wong wrote:
> Anyways I hope to teach public-inbox to auto-linkify Message-ID-looking
> strings "" into URLs for domain-portability,
> (but it's ambiguous with email addresses). But yeah, I don't
> like things being tied to domain names.
This would be very useful for peo
On 2018-08-27 19:32, Andrei Rybak wrote:
>
> How about just using unconditional includes?
>
> global.gitconfig (synced across machines):
>
> [include]
> path = platform-specific.gitconfig
>
> And two version of file named "platform-specific.gitconf
On 2018-08-27 17:52, Duy Nguyen wrote:
> On Mon, Aug 27, 2018 at 5:37 PM Torsten Bögershausen wrote:
>>> In those cases, when it falls back to
>>> configuration for line ending management, I want it to be
>>> automatically configured based on the host platform.
>>
>
> An alternative is supporting
On 25/08/18 10:05, Jeff King wrote:
> The main comparison functions we provide for comparing
> object ids are hashcmp() and oidcmp(). These are more
> flexible than a strict equality check, since they also
> express ordering. That makes them them useful for sorting
s/them them/them/
> We can solv
On 19/08/18 22:32, Jeff King wrote:
> On Sun, Aug 19, 2018 at 07:50:42PM +0200, Andrei Rybak wrote:
>
>> 1. Check both files at the same time (combination with Gábor's
>> function):
>>
>> test_cmp () {
>> if test
On 17/08/18 22:09, Junio C Hamano wrote:
> Andrei Rybak writes:
>>
>> I'll try something like the following on the weekend:
>>
>> test_cmp () {
>> if test "$1" != - && ! test -s "$1"
>> then
&
On 17/08/18 19:39, SZEDER Gábor wrote:
>
> See, we have quite a few tests that extract repetitive common tasks
> into helper functions, which sometimes includes preparing the expected
> results and running 'test_cmp', e.g. something like this
> (oversimplified) example:
>
> check_cmd () {
>
On 14/08/18 13:47, SZEDER Gábor wrote:
> ... both
> invocations produce empty 'pack{a,b}.objects' files, and the
> subsequent 'test_cmp' happily finds those two empty files identical.
Is test_cmp ever used for empty files? Would it make sense for
test_cmp to issue warning when an empty file is bei
line-log.[ch] use left-closed, right-open interval logic. Update
comments and debug output to use square brackets+parentheses notation
to help developers avoid off-by-one errors.
Signed-off-by: Andrei Rybak
---
Applies on top of c0babbe69 (range-set: publish API for re-use by
git-blame -L, 2013
line-log.[ch] use left-closed, right-open interval logic. Change comment
and debug output to square brackets+parentheses notation to help
developers avoid off-by-one errors.
---
Original idea for this change in recent thread about line-log changes:
https://public-inbox.org/git/9776862d-18b2-43e
On 2018-08-06 22:14, Junio C Hamano wrote:
> Andrei Rybak writes:
>>
>> Only changes since v2 are more clear tag names.
>
> ... and updated log message, which I think makes it worthwhile to
> replace the previous one plus the squash/fixup with this version.
My bad, t
on of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d3dd (Merge branch 'pt/am-tests', 2015-08-03).
This patch is also available at
https:/
med `commit-with-scissors-line`?
How about "expected-for-scissors" and "expected-for-no-scissors"?
Junio, I'll send out v3 with updated tag names, if that's OK.
Also, squash-able patch below.
> So, this patch fixes the 3 problems with the tests, and so looks c
On 2018-08-05 00:18, Johannes Schindelin via GitGitGadget wrote:
>
> Now, I am fairly certain that the changes are correct, but given my track
> record with off-by-one bugs (and once even an off-by-two bug), I would
> really appreciate some thorough review of this code, in particular the
> second
of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d3dd (Merge branch 'pt/am-tests', 2015-08-03).
This patch is also available at
https://gi
On 2018-08-04 01:04, Junio C Hamano wrote:
> Hmph, I am not quite sure what is going on. Is the only bug in the
> original that scissors-patch.eml and no-scissors-patch.eml files were
> incorrectly named? IOW, if we fed no-scissors-patch.eml (which has
> a scissors line in it) with --scissors opt
le--with scissors line, and
by using it both for --scissors and --no-scissors. To clarify the
intention of the test, give files and tags more explicit names.
[1]: introduced in bf72ac17d (t4150: tests for am --[no-]scissors,
2015-07-19)
Signed-off-by: Andrei Rybak
---
Applies on top of 980a3d
-scissors should check that the eml file with a scissor
line inside will be cut up and only the part under the cut will be
turned into commit.
However, the test for --scissors generates eml file without such line.
Fix the test for --scissors option.
Signed-off-by: Andrei Rybak
---
t
On 2018-08-02 21:17, René Scharfe wrote:
> Don't translate the argument specification for --chmod; "+x" and "-x"
> are the literal strings that the commands accept.
> > [...]
>
> - OPT_STRING( 0 , "chmod", &chmod_arg, N_("(+/-)x"), N_("override the
> executable bit of the listed files")),
> +
ns(-)
Would it make sense to mention new option in the cover letter section of
Documentation/SubmittingPatches?
--
Best regards, Andrei Rybak
On 2018-07-17 01:05, Stefan Beller wrote:
>
> This patch brings some challenges, related to the detection of blocks.
> We need a white net the catch the possible moved lines, but then need to
The s/white/wide/ was already suggested by Brandon Williams in previous
iteration, but it seems this also
Add missing colon in two places to fix formatting of options.
Signed-off-by: Andrei Rybak
---
Done on top of maint.
The earliest this patch applies is on top of commit aebd23506e ("Merge
branch 'jk/ui-color-always-to-auto-maint' into
jk/ui-color-always-to-auto", 2017-10-
On Wed, 11 Jul 2018 at 22:34, Andrei Rybak wrote:
>
> Is -1 an OK initial value for timezone if local_time_tzoffset returns
> negative values as well? It looks like it doesn't matter for from functional
>
meant to say: "It looks like it doesn't matter from the functional
point of view".
5 @@ const char *show_date(timestamp_t time, int tz, const
> struct date_mode *mode)
> return timebuf.buf;
> }
>
> + if (mode->type == DATE_HUMAN) {
> + struct timeval now;
> +
> + gettimeofday(&now, NULL);
> +
> + /* F
it-for-windows/git/issues/1751
--
Best regards, Andrei Rybak
On 2018-07-08 20:01, Pratik Karki wrote:
> +
> +static int use_builtin_rebase(void)
> +{
> + struct child_process cp = CHILD_PROCESS_INIT;
> + struct strbuf out = STRBUF_INIT;
> + int ret;
> +
> + argv_array_pushl(&cp.args,
> + "config", "--bool", "rebase.usebui
On 2018-06-24 12:36, Daniel Penkin wrote:
> Hello,
>
Hi,
> I believe I found a bug in how Git represents a diff when invoked with
> "--find-copies-harder" parameter.
> Specifically, the unified diff header of a hunk contains an extra
> piece of text which appears to be a line from the context (i
On 01.03.2018 0:54, Junio C Hamano wrote:
> Andrei Rybak writes:
>
>> Is this part of guidelines obsolete, or am I not understanding this
>> correctly?
>
> I am merely being nice (but only on "time-permitting" basis).
>
Does that mean that the integration
ot;Send your patch with "To:" set to the mailing list, with "cc:"
listing people who are involved in the area you are touching"
--
Best regards, Andrei Rybak
43 matches
Mail list logo