From: Adam Roben
If Git were installed in a path containing non-ASCII characters,
commands such as `git am` and `git submodule`, which are implemented as
externals, would fail to launch with the following error:
> fatal: 'am' appears to be a git command, but we were not
> ab
...
-Original Message-
From: Jeff King
Sent: Monday, July 22, 2019 5:12 PM
To: Raitanen, Adam
Cc: James Knight ; git@vger.kernel.org
Subject: [**EXTERNAL**] Re: Possible bug in Makefile when executing curl-config
[+cc the author of that patch]
On Mon, Jul 22, 2019 at 07:46:37PM +
quot;$(/path/to/curl/curl-config --libs)".
I reproduced the problem in the latest version 2.22.0.
Thanks,
Adam
On 25.06.19 13:31, Philip Oakley wrote:
only one minor point...
>>> + - For example, a pattern `doc/frotz/` matches `doc/frotz` directory,
>>> + but not `a/doc/frotz` directory; however `frotz/` matches `frotz`
>
> her I misread this as: "but not a `doc/frotz` directory;"
> i.e. the leadin
Hi everyone,
any comments about the patch note from 04.06 ?
All the best,
Adam
On 04.06.19 19:34, Dr. Adam Nielsen wrote:
gitignore.txt: make slash-rules more readable
Renew paragraphs relevant for pattern with slash.
Aim to make it more clear and to avoid possible
pitfalls for the reader
gitignore.txt: make slash-rules more readable
Renew paragraphs relevant for pattern with slash.
Aim to make it more clear and to avoid possible
pitfalls for the reader. Add some examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 66
s.
I will create a new patch.
All the best,
Adam
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve or add paragraphs relevant
for pattern with slash. Add some slash examples
in example section.
Signed-off-by: Dr. Adam
Hi Philip,
On 01.06.19 11:33, Philip Oakley wrote:
From a user perspective, implementation issues shouldn't be part of the
description unless absolutely essential.
Most user aren't aware of the implementation so don't grok/understand
what the fuss is about and ignore it...
I agree with tha
leading slash and asterix in
example section.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 75 ++---
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0
---
Documentation/gitignore.txt | 75 ++---
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..ce944779a5 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.
On 31.05.19 18:30, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve paragraph for pattern without slash.
Remov
leading slash and asterix in
example section.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 71 ++---
1 file changed, 50 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0
On 19.05.19 19:42, Philip Oakley wrote:
Hi Adam,
Hi Philip
a) keep going. the documentation does need improving!
Thank you for the encouragement!
b) also have a look at the `git help glossary` for 'glob' pattern
descriptions for other ideas.
The glob entry looks very famili
te thoughts are around (a) PATH handling and (b) third-party
dependencies like what SSH library is being used. So I can rule those
out, can you give me (a) the standard Cygwin diagnostic package from
running "cygcheck -s -v -r > cygcheck.out" in a Cygwin terminal
(off-list, if you prefer), and (b) details of the remote repository
you're pushing to?
Cheers,
Adam
On 18.05.19 21:34, Philip Oakley wrote:
Hi Adam
Hi Philip
On 18/05/2019 15:07, Dr. Adam Nielsen wrote:
This "Otherwise" below could be the complement to the initial "If", or
could be part of a "matches" pair of example sentences. At least on my
initial readin
some examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 57 +++--
1 file changed, 36 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..925bf767b1 100644
--- a
some examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 58 +++--
1 file changed, 37 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..584c82c7df 100644
--- a
On 18.05.19 08:42, Johannes Sixt wrote:
Am 17.05.19 um 23:43 schrieb Dr. Adam Nielsen:
Another thing that I noticed is that its not mentioned anywhere that
the pattern use a slash as a directory separator (instead of a
backslash), its only clear from the examples. Maybe its worth to
mention
railing slash, [...].
Otherwise (when it contains a non-trailing slash) the pattern
is matched [...].
All the best,
Adam
On 08.05.19 07:33, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
+ - A pattern that contains a non-trailing slash is matched relative to the
location of the `.gitignore` file.
+ For example, `doc/frotz/` matches `doc/frotz` directory, but not
+ `a/doc/frotz` (relativ
examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..7d7fbd202e 100644
--- a/Documentation
On 07.05.19 12:07, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add paragraph for pattern
with
examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..3a6fb9117c 100644
--- a/Documentation
---
Documentation/gitignore.txt | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..3a6fb9117c 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.
I think its maybe hard to track all the changes that we have discussed
so far. Should I create a new PATCH request including all the changes
from the recent mails and then we continue the discussion from there?
Best regards,
Adam
Am Mi., 10. Apr. 2019 um 09:39 Uhr schrieb Dr. Adam Nielsen
the leading slash is
now a sub-case of `A pattern with a non-trailing slash`
so we might just get rid of the above paragraph?
--
Thank you for explaining me how the algorithm works procedurally.
It gave some inside of the origin of "If the pattern ends with a slash, it is
removed for the purpose of the following description.."
-
All the best,
Adam
the case
that the reader confuses the line with "If the pattern contains no
trailing slash". Alternatively I would suggest:
If the pattern contains a slash "`/`"
that is not a trailing slash,
it matches the beginning of the pathname.
For example, the pattern `doc/frotz/` matches
`doc/frotz` that is a directory
but does not match `a/doc/frotz`.
This might be addressing the problem of my first proposal:
>> + - If the pattern contains a slash "`/`" other then a trailing slash, then
>The same comment applies to this first line about the ambiguity of a
>pattern without any slash anywhere.
All the best,
Adam
Am Mo., 8. Apr. 2019 um 09:51 Uhr schrieb Junio C Hamano :
>
> "Adam Nielsen" writes:
>
> A few notes on the form.
>
> > From: Adam Nielsen
>
> This "author" identity and the name-email on the Signed-off-by: line
> should match, at least fo
From: Adam Nielsen
gitignore.txt: make slash-rules more readable
Remove the addition `it is removed for the purpose of the following
description` and
make clear in which situations a trailing slash is used or not. Increase
readability
and make all paragraphs valid, even if they are not read
> Please send plain text mails. HTML mails are dropped by
> git@vger.kernel.org so other people will not see them.
Okay sorry.
>
> On Sun, Mar 31, 2019 at 6:27 PM Dr. Adam Nielsen wrote:
> >
> > Thank you for your quick response.
> >
> > I will create a p
a directory foo and paths underneath it, but will not match a
>regular file or a
>symbolic link foo.
What do you think?
Best regards,
Adam
On Sun, 12 Aug 2018 at 09:19, Nguyễn Thái Ngọc Duy wrote:
Hi,
> + trace_performance_leave("cache_tree_update");
I would suggest trace_performance_leave() calls use __func__ instead.
That way, there's no ambiguity if the function name ever changes.
Kindly,
Thomas
Hey!
My name is Adam Milton I am a team leader at " Inovit" animation studio.
Our company creates professional 2d animation explainer videos that
help to tell your business story in an engaging way, increase
conversions, maximize your business exposure and boost sales.
R
Somewhere upthread, Brian refers to me as a cryptographer. That's
flattering (thank you), but probably not really true even on a good
day. And certainly not true next to Joan Daemen. I do have experience
with crypto at scale and in ecosystems, though.
Joan's count of cryptanalysis papers is a reas
urces
as it already queried them, and is smarter than us (can handle multiple
adapters).
Reported by: Xin Li
Signed-off-by: Adam Borowski
---
v2: improved commit message
contrib/hooks/pre-auto-gc-battery | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/hooks/pre-auto-gc-batt
On Wed, Feb 28, 2018 at 10:16:21AM -0800, Junio C Hamano wrote:
> Adam Borowski writes:
>
> > Desktops and servers tend to have no power sensor, thus on_ac_power returns
> > 255 ("unknown").
> >
> > If that tool returns "unknown", there'
Desktops and servers tend to have no power sensor, thus on_ac_power returns
255 ("unknown").
If that tool returns "unknown", there's no point in querying other sources
as it already queried them, and is smarter than us (can handle multiple
adapters).
Reported by: Xi
("cat-file: tests for new
atoms added", 2018-02-12), as the culprit.
I'm afraid I'm not going to have the time to investigate the failure
any further in the immediate future, but I wanted to report it
promptly in case you / someone else can see what's going wrong.
Adam
implementing every test twice, as we have
here, then I agree, but I don't think there's much value in doing that
except as a proof of concept, as in this immediate discussion. The
obvious-to-me way to do this would be following the precedent of the
core code: gradually migrate things away from shell code to C code.
Adam
On Wednesday 03 January 2018 at 08:14 pm +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jan 03 2018, Adam Dinwoodie jotted:
>
> > On Wednesday 03 January 2018 at 02:31 pm +0100, Ævar Arnfjörð Bjarmason
> > wrote:
> >> Does the fixup above in <878tdm8k2d.
On Wednesday 03 January 2018 at 02:31 pm +0100, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jan 03 2018, Adam Dinwoodie jotted:
>
> > On Monday 25 December 2017 at 12:28 am +, Ævar Arnfjörð Bjarmason wrote:
> >> There has never been any full roundtrip testing of wh
xit 1
++ eval_ret=1
++ :
+ test_eval_ret_=0
+ want_trace
+ test t = t
+ test t = t
+ set +x
not ok 490 - wildmatch(ls): match '00' '\'
#
# wildtest_file_setup &&
# printf '%s' '\' >expect &&
# git --glob-pathspecs ls-files -z --
'00' >actual.raw 2>actual.err &&
# wildtest_stdout_stderr_cmp
#
I'm digging into the failures myself now, but wanted to report the
problem in the name of getting more eyes on it.
Adam
[0]: https://gist.github.com/me-and/04443bcb00e12436f0eacce079b56d02
On Saturday 30 December 2017 at 02:40 pm +, Adam Dinwoodie wrote:
> On Saturday 30 December 2017 at 02:21 pm +, Ramsay Jones wrote:
> > Hi Junio, Adam,
> >
> > Just a quick note about the failure of the test-suite on cygwin.
> > In particular, test t5580-cl
On Saturday 30 December 2017 at 02:21 pm +, Ramsay Jones wrote:
> Hi Junio, Adam,
>
> Just a quick note about the failure of the test-suite on cygwin.
> In particular, test t5580-clone-push-unc.sh #3, like so:
>
>
>
> Adam, are you running the tests on Windows
ore perl modules. Every
perl program does this, and they don't go down this route of having copies of
various CPAN modules just in case. So why should we? We're not a special
snowflake.
-- Thomas Adam
n spare time hacking ;-)
>
> I guess the full solution is to make Mail::Address a hard dependency?
This is what I was suggesting, and then as a follow-up, addressing the point
that there's a bunch of require() hacks to also get around needing
hard-dependencies.
-- Thomas Adam
On Thu, Nov 30, 2017 at 03:12:17PM -0500, Jeff King wrote:
> On Wed, Nov 29, 2017 at 06:35:16PM +, Thomas Adam wrote:
>
> > On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schnei...@autodesk.com wrote:
> > > + if (print_waiting_for_editor) {
> > > +
On Thu, Nov 30, 2017 at 02:55:35PM +0100, Lars Schneider wrote:
>
> > On 29 Nov 2017, at 19:35, Thomas Adam wrote:
> >
> > On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schnei...@autodesk.com wrote:
> >> + if (print_waiting_for_editor) {
> >> +
ypically unbuffered on most systems I've used, and
although the call to fflush() is harmless, I suspect it's not having any
effect. That said, there's plenty of other places in Git which seems to think
fflush()ing stderr actually does something.
-- Thomas Adam
On Tuesday 21 November 2017 at 12:00 am -0800, Elijah Newren wrote:
>
>
> merge-recursive.c | 1243 +++-
> merge-recursive.h | 17 +
> t/t3501-revert-cherry-pick.sh |5 +-
> t/t6043-merge-rename-directories.sh | 3821
>
On Wednesday 22 November 2017 at 05:21 pm +0100, Christian Couder wrote:
> On Wed, Nov 22, 2017 at 3:39 PM, Adam Dinwoodie wrote:
> > In trying to do a bisect on the Git repository, I seem to have come
> > across surprising behavior where the order in which `git bisect` appears
>
In trying to do a bisect on the Git repository, I seem to have come
across surprising behavior where the order in which `git bisect` appears
to forget that previous commits were marked as new.
You can see this behaviour in the following commands, run on the Git
repository, where the order of the `
ay not
have additional functionality depending on which modules are installed. Given
the pretty good state of packaging across those platforms which Git runs on, I
would argue we're now in a much better position to explicitly check for
non-core modules at BEGIN{} time, and moan loudly if they're not installed.
-- Thomas Adam
to the
> appropriate bits. Maybe Matthieu or Remi (CC'ed) might want to chime in
> on other options?
Trying to come up with a reinvention of regexps for email addresses is asking
for trouble, not to mention a crappy rod for your own back. Don't do that.
This is why people use Mail::Address.
https://metacpan.org/pod/distribution/MailTools/lib/Mail/Address.pod
-- Thomas Adam
On Monday 20 November 2017 at 08:16 pm +, Ramsay Jones wrote:
> For several days, I have been staring at some 'unexpected passes' in
> the t3512-cherry-pick-submodule.sh and t3513-revert-submodule.sh test
> files (tests #11-13 in both cases).
>
> I finally found time tonight to 'git bisect' th
his commit merely reduces those separate
steps to a single step.
Signed-off-by: Adam Dinwoodie
---
builtin/bisect--helper.c | 3 ++-
git-bisect.sh| 18 ++
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--help
- I'm not entirely happy with the error handling, primarily as I
couldn't seem to find a consensus on what best practice is for
handling errors between the existing shell code in this script and
git-rebase--interactive.sh.
- There aren't yet any tests or documentation cha
In order to allow a git bisect log file to be replayed without using all
the surrounding code to do things like clean the repository state, split
out the file-parsing part of bisect_replay into a separate function.
Signed-off-by: Adam Dinwoodie
---
git-bisect.sh | 9 -
1 file changed, 8
as what appears
to be the more common pratice on the mailing list, is to use "[RFC
PATCH]", not "[PATCH/RFC]".
Update the SubmittingPatches article to match and to reference the
`format-patch` helper arguments, and also make some minor text
clarifications in the area.
Signe
On Friday 10 November 2017 at 12:14 pm +0900, Junio C Hamano wrote:
> Eric Sunshine writes:
>
> > or against the change:
> >
> > - synonym bloat; balloons documentation
> > - steals command verbs from potential future features
> > - ...
>
> I tend to agree with these two (and if I we
Add `git notes rm` and `git notes delete` as alternative ways of saying
`git notes remove`.
Signed-off-by: Adam Dinwoodie
---
Documentation/git-notes.txt | 4 +++-
builtin/notes.c | 8 +---
t/t3301-notes.sh| 6 +++---
3 files changed, 11 insertions(+), 7 deletions
as what appears
to be the more common pratice on the mailing list, is to use "[RFC
PATCH]", not "[PATCH/RFC]".
Update the SubmittingPatches article to match, and to reference the
`format-patch` helper arguments.
Signed-off-by: Adam Dinwoodie
Helped-by: Eric Sunshine
---
Documen
On Wednesday 08 November 2017 at 09:10 am -0500, Eric Sunshine wrote:
> On Wed, Nov 8, 2017 at 8:47 AM, Adam Dinwoodie wrote:
> > +e-mail discussions. Use of markers in addition to PATCH within
> > +the brackets to describe the nature of the patch is also
> > +encouraged.
is causes some repo corruption tests to fail.
Confirmed: I see this patch, or at least f7e0dbc38 ("clone, fetch-pack,
index-pack, transport: partial clone", 2017-11-02), causing t5300.26 to
fail on 64-bit Cygwin.
For the sake of anyone trying to reproduce this, I needed to cherry pick
66d4c7a58 ("fixup! upload-pack: add object filtering for partial clone",
2017-11-08) onto that commit before I was able to get it to compile.
Adam
On Wednesday 08 November 2017 at 05:15 pm +0100, Christian Couder wrote:
> >> +git bisect replay "$GIT_BISECT_LOG_TMP"
> >> +rm -f "$GIT_BISECT_LOG_TMP"
>
> While at it, is there a reason for the -f option above?
I was following the lead of git-bisect.sh, which has used `rm -f` for
such things ev
On Wednesday 08 November 2017 at 05:12 pm +0100, Christian Couder wrote:
> On Wed, Nov 8, 2017 at 2:59 PM, Adam Dinwoodie wrote:
> > +git bisect reset HEAD
>
> I guess that using "reset HEAD" could be cheaper than just "reset" and
> that's the reas
Add a short script, vaguely inspired by `git rebase --interactive`, to
ease the process described in the `git bisect` documentation of saving
off a bisect log, editing it, then replaying it.
Signed-off-by: Adam Dinwoodie
---
When I'm bisecting, I find I need to semi-regularly go back and c
as what appears
to be the more common pratice on the mailing list, is to use "[RFC
PATCH]", not "[PATCH/RFC]".
Update the SubmittingPatches article to match.
Signed-off-by: Adam Dinwoodie
---
I'm re-rolling this patch with some more substantive changes, as a bit
more resea
Signed-off-by: Adam Dinwoodie
---
git-rebase--interactive.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh
index 2563dc52d..437815669 100644
--- a/git-rebase--interactive.sh
+++ b/git-rebase--interactive.sh
@@ -722,7
r the
closing bracket.
Signed-off-by: Adam Dinwoodie
---
Documentation/SubmittingPatches | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 558d465b6..e91ce8269 100644
--- a/Documentation/Submitt
id;
Oops. This was my typo from my original suggestion. The hash is
'%namespace_id', not '%namespaces_id'. However, how did this slip through
testing? I'm assuming you blindly copied this from my example, which although
quick to do, is only being caught because of my sharp eyes...
-- Thomas Adam
; s/_/ /g; $_;
} split(/[ \n]/, run_git("config --get-all
remote.${remotename}.namespaces"));
This would, once again, avoid creating @tracked_namespaces, and iterating over
it.
Note that this isn't about trying to 'golf' this; it's a performance
consideration.
Kindly,
Thomas Adam
paces) { s/ /_/g; }
I am sure we can improve upon the need to process @namespaces twice:
my @namespaces = map { s/ /_/g; $_; } sort keys %namespaces_id;
-- Thomas Adam
bly wiser to
transition this to using Carp in the long run -- it would decrease the
round-trip time to debugging should there be a situation where that was
needed, and hence I would recommend using "warn" for less-severe
errors/debugging.
-- Thomas Adam
On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote:
> On 2017-11-02 22:18:07, Thomas Adam wrote:
> > Hi,
> >
> > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
> >> +print {*STDERR} "$#{$mw_pages} found in namespace
>
Hi,
On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
> +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace
> ($namespace_id)\n";
How is this any different to using warn()? I appreciate you're using a
globbed filehandle, but it seems superfluous to me.
Ki
On Wed, Nov 01, 2017 at 10:44:22AM +0900, Junio C Hamano wrote:
> Adam Dinwoodie writes:
>
> > t5580 tests that specifying Windows UNC paths works with Git. Cygwin
> > supports UNC paths, albeit only using forward slashes, not backslashes,
> > so run the compatible te
t suitable for calculating the UNC path to the
current directory. Instead use Cygwin's `cygpath` utility to get the
Windows-style path.
Signed-off-by: Adam Dinwoodie
---
t/t5580-clone-push-unc.sh | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/t/t5580-clone-
:' -k2 -nr
Given this, I then did some maths on the total lines from each of those files
and to work out a percentage by file, and over all.
What I'm curious to know is whether this approach of using "git blame" is a
good approach or not.
Thanks for your time.
-- Thomas Adam
On Thu, Oct 12, 2017 at 01:27:57AM +0100, Ramsay Jones wrote:
> On 11/10/17 23:34, Adam Dinwoodie wrote:
> [snip]
> > Hi Ramsay,
> >
> > I assume, given you're emailing me, that this is a Cygwin failure?
>
> Yes, sorry, I should have made that clear.
>
On Wed, Oct 11, 2017 at 11:15:57PM +0100, Ramsay Jones wrote:
> Hi Adam,
>
> I had a test failure on the v2.15.0-rc1 build tonight.
> The test in question being t0021-conversion.sh #15
> ('required process filter should filter data'). I didn't
> have any test fai
Leaving spaces around the `-delimeters for commands means asciidoc fails
to parse them as the start of a literal string. Remove an extraneous
space that is causing a literal to not be formatted as such.
Signed-off-by: Adam Dinwoodie
---
Documentation/git.txt | 2 +-
1 file changed, 1 insertion
On Wed, Sep 27, 2017 at 10:07:41PM -0700, Eric Rannaud wrote:
> The checkpoint command cycles packfiles if object_count != 0, a sensible
> test or there would be no pack files to write. Since 820b931012, the
> command also dumps branches, tags and marks, but still conditionally.
> However, it is po
On Sat, Sep 09, 2017 at 02:13:32PM +0100, Ramsay Jones wrote:
> I ran the test-suite on the 'pu' branch last night (simply because
> that was what I had built at the time!), which resulted in a PASS,
> but t6120 was showing a 'TODO passed' for #52.
Confirmed, I also see this unexpected pass.
> Th
On Sun, Aug 27, 2017 at 03:06:31AM +0100, Ramsay Jones wrote:
> On 26/08/17 22:11, Adam Dinwoodie wrote:
> > On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote:
> >> Interesting. I find it a little hard to believe there's so obvious a bug
> >> as "
On Sat, Aug 26, 2017 at 11:53:37AM -0700, Jeff King wrote:
> On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote:
>
> > > diff --git a/run-command.c b/run-command.c
> > > index 98621faca8..064ebd1995 100644
> > > --- a/run-command.c
> > > +++ b/run-command.c
> > > @@ -641,7 +641,6 @@ int
On Sat, Aug 26, 2017 at 01:57:18AM +0100, Ramsay Jones wrote:
> On 25/08/17 16:08, Jeff King wrote:
> > On Fri, Aug 25, 2017 at 12:25:29PM +0100, Adam Dinwoodie wrote:
> >
> >> As of v2.10.0-rc1-4-g321459439 ("cat-file: support --textconv/--filters
> >> in b
As of v2.10.0-rc1-4-g321459439 ("cat-file: support --textconv/--filters
in batch mode"), t8010-cat-file-filters.sh has been failing on Cygwin.
Digging into this, the test looks to expose a timing window: it appears
that if `git cat-file --textconv --batch` receives input on stdin too
quickly, it fa
On 23 August 2017 at 16:47, Jeff King wrote:
> On Wed, Aug 23, 2017 at 02:46:30PM +0100, Adam Spiers wrote:
>> >> Done at least once already:
>> >>
>> >> http://comments.gmane.org/gmane.comp.version-control.git/201591
>> [...]
>>
>> but sa
I got a helpful response to the following question almost 5 years ago:
On 12 November 2012 at 23:09, Adam Spiers wrote:
> On Mon, Nov 12, 2012 at 6:18 PM, Drew Northup wrote:
>> On Mon, Nov 12, 2012 at 11:37 AM, Adam Spiers wrote:
>>> As it turned out to be fairly easy,
On Mon, 14 Aug 2017, René Scharfe wrote:
> Am 13.08.2017 um 06:53 schrieb David Adam:
> > I think I have a bug in git (tested 2.11.0 on Debian 8, 2.14.1 on OS X and
> > 2.14.1.145.gb3622a4 on OS X).
> >
> > Given a repository with an export-ignore dire
like to avoid.
This is a reduced testcase; my goal is to end up with two archives, one
containing directory b only, and one containing everything except for
directory b - so I can't just add 'b export-ignore' to gitattributes.
Thanks
David Adam
zanc...@ucc.gu.uwa.edu.au
On Tue, Aug 08, 2017 at 06:25:24PM +0100, Adam Dinwoodie wrote:
> I'm running a bisect overnight to try to isolate the commit on the left
> merge parent that seems to be interacting badly with the commit on the
> right, and will send in the results from that when I have them.
F
On Tue, Aug 08, 2017 at 05:32:21PM +0200, René Scharfe wrote:
> Am 08.08.2017 um 17:18 schrieb Adam Dinwoodie:
> > The t3700-add.sh test is currently failing on the pu branch on Cygwin.
> > To my surprise, the problem appears to have been introduced by a merge,
> > 867fa1d6a.
The t3700-add.sh test is currently failing on the pu branch on Cygwin.
To my surprise, the problem appears to have been introduced by a merge,
867fa1d6a. Both parents of that merge have the test succeeding, but
it's failing on that merge commit.
Failing test output below:
$ ./t3700-add.sh -i
On 31 July 2017 at 23:18, Junio C Hamano wrote:
> Adam Spiers writes:
>
> > Therefore there is a risk that each new UI for higher-level workflows
> > will end up re-implementing these mid-level operations. This
> > undesirable situation could be avoided if git itsel
All feedback is of course very welcome!
Thanks,
Adam
Adam Spiers (1):
add git-splice command for non-interactive branch splicing
.gitignore | 1 +-
Documentation/git-splice.txt | 125 ++-
Makefile | 1 +-
git-splice.sh| 737 ++
te is persisted to disk, and
thereby supports standard --abort and --continue semantics just like
git's other extended workflow commands. It also handles more complex
cases, as described in the manual page.
Signed-off-by: Adam Spiers
---
.gitignore | 1 +-
Documentation/git-
ed spare time, though, and not something I've done
before, so it's taking a little while to get going.
Adam
1 - 100 of 416 matches
Mail list logo
