Re: Re: [PATCH v2 0/1] pack-refs: always refreshing after take the lock file

2019-08-20 Thread 16657101987
From: Sun Chao --- Jeff King writes: > I'm undecided on this. I think reftables are still a while off, and even > once they are here, many people will still be using the older format. So > it makes sense to still apply fixes to the old code. Got it, thanks for explainning. > What I wonder, t

[PATCH v2 1/1] pack-refs: always refreshing after take the lock file

2019-07-31 Thread 16657101987
From: Sun Chao <16657101...@163.com> When a packed ref is deleted, the whole packed-refs file is rewrite and omit the ref that no longer exists. However if another gc command is running and call `pack-refs --all` simultaneously, there is a chance that a ref just updated will lost the newly commits

[PATCH v2 0/1] pack-refs: always refreshing after take the lock file

2019-07-31 Thread 16657101987
From: Sun Chao <16657101...@163.com> On Tue, 30 Jul 2019 02:36:35 -0400, Jeff King wrote: > You can do this step without the fetch, which makes it hit the race more > quickly. :) Try this: > > # prime it with a single commit > git commit --allow-empty -m foo > while true; do > us=$(git

[PATCH v1 1/1] pack-refs: pack expired loose refs to packed_refs

2019-07-21 Thread 16657101987
From: Sun Chao When a packed ref is deleted, the whole packed-refs file is rewrite and omit the ref that no longer exists. However if another gc command is running and call `pack-refs --all` simultaneously, there is a change that a ref just updated will lost the newly commits. Through these step

[PATCH v1 0/1] pack-refs: pack expired loose refs to packed_refs

2019-07-21 Thread 16657101987
From: Sun Chao When a packed ref is deleted, the whole packed-refs file is rewrite and omit the ref that no longer exists. However if another gc command is running and call `pack-refs --all` simultaneously, there is a change that a ref just updated will lost the newly commits. There are two vali

[PATCH v8 1/1] pack-redundant: delete redundant code

2019-01-30 Thread 16657101987
From: Sun Chao The objects in alt-odb are removed from `all_objects` twice in `load_all_objects` and `scan_alt_odb_packs`, remove it from the later function. Signed-off-by: Sun Chao --- builtin/pack-redundant.c | 1 - 1 file changed, 1 deletion(-) diff --git a/builtin/pack-redundant.c b/buil

Re: [PATCH v4 0/1] pack-redundant: remove unused functions

2019-01-08 Thread 16657101987
> 16657101...@163.com writes: > >> From: Sun Chao >> >> I'm particularly grateful to Junio and JiangXin for fixing the patches, >> and I noticed Junio send a new commit to remove more unused codes and >> suggest to SQUASH it. >> >> So I create this new version of patches to do this work, I also h

[PATCH v4 0/1] pack-redundant: remove unused functions

2019-01-08 Thread 16657101987
From: Sun Chao I'm particularly grateful to Junio and JiangXin for fixing the patches, and I noticed Junio send a new commit to remove more unused codes and suggest to SQUASH it. So I create this new version of patches to do this work, I also have checked the left codes and remove a unused struc

[PATCH v4 0/1] pack-redundant: remove unused functions

2019-01-08 Thread 16657101987
From: Sun Chao I'm particularly grateful to Junio and JiangXin for fixing the patches, and I noticed Junio send a new commit to remove more unused codes and suggest to SQUASH it. So I create this new version of patches to do this work, I also have checked the left codes and remove a unused struc

[PATCH v4 1/1] pack-redundant: remove unused functions

2019-01-08 Thread 16657101987
From: Sun Chao Remove unused functions to find `min` packs, such as `get_permutations`, `pll_free`, etc. Signed-off-by: Sun Chao Signed-off-by: Jiang Xin Signed-off-by: Junio C Hamano --- builtin/pack-redundant.c | 86 1 file changed, 86 delet