[PATCH] change contract between system_path and it's callers

2014-11-24 Thread 0xAX
Now system_path returns path which is allocated string to callers; It prevents memory leaks in some places. All callers of system_path are owners of path string and they must release it. Signed-off-by: Alexander Kuleshov --- attr.c| 8 +++--- builtin/config.c | 73 +

Re: [PATCH] exec_cmd: system_path memory leak fix

2014-11-23 Thread 0xAX
eep in git source code. Hope i will be useful for community. Thank you. 0xAX @ 2014-11-23 19:56 ALMT: > Signed-off-by: 0xAX > --- > exec_cmd.c | 25 - > exec_cmd.h | 4 ++-- > git.c | 12 +--- > 3 files changed, 27 insertions(+), 14 d

[PATCH] exec_cmd: system_path memory leak fix

2014-11-23 Thread 0xAX
Signed-off-by: 0xAX --- exec_cmd.c | 25 - exec_cmd.h | 4 ++-- git.c | 12 +--- 3 files changed, 27 insertions(+), 14 deletions(-) diff --git a/exec_cmd.c b/exec_cmd.c index 698e752..08f8f80 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -6,7 +6,7 @@ static

GIT: [PATCH] exec_cmd: system_path memory leak fix

2014-11-23 Thread 0xAX
Hello All, I found memory leak at exec_cmd.c in system_path function with valgrind. After this patch valgrind doesn't show any memory leaks, but I'm not sure that it is the best way to solve this problem. There are a couple of places that uses system_path, if this way will be good, i'll make anothe

[PATCH 1/1] git-config: git-config --list fixed when GIT_CONFIG value starts with ~/

2014-11-14 Thread 0xAX
-list call. Signed-off-by: Alex Kuleshov Signed-off-by: 0xAX --- builtin/config.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/builtin/config.c b/builtin/config.c index 7bba516..df1bee0 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -540,6 +540,8 @@ int cmd_config(int argc, const c

[PATCH 1/1] gitk: po/ru.po russian translation typo fixed

2014-11-14 Thread 0xAX
Signed-off-by: 0xAX --- po/ru.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/ru.po b/po/ru.po index 5987303..0a0754d 100644 --- a/po/ru.po +++ b/po/ru.po @@ -863,7 +863,7 @@ msgid "" "(discard ALL local changes)" msgstr "" "Ж