Re: [PATCH v3 4/4] git-gui: allow undoing last revert

2019-10-23 Thread Pratyush Yadav
On 22/10/19 09:46AM, Bert Wesarg wrote: > On Mon, Oct 21, 2019 at 9:35 PM Johannes Sixt wrote: > > > > Am 21.10.19 um 11:16 schrieb Bert Wesarg: > > > Dear Pratyush, > > > > > > I just noticed that the 'Revert Last Hunk' menu entry is enabled in > > > the stage-list. But I think it should be disab

Re: [PATCH v3 4/4] git-gui: allow undoing last revert

2019-10-23 Thread Pratyush Yadav
On 22/10/19 10:17AM, Bert Wesarg wrote: > On Mon, Oct 21, 2019 at 9:04 PM Pratyush Yadav wrote: > > > > On 21/10/19 11:16AM, Bert Wesarg wrote: > > > Dear Pratyush, > > > > > > I just noticed that the 'Revert Last Hunk' menu entry is enabled in > > > the stage-list. But I think it should be disabl

[RFC] Proposal for a new config-based git signing interface

2019-10-23 Thread Ibrahim El
Hello, This is a follow-up on my previous emails related to the proposal of a new signing interface: https://public-inbox.org/git/CACi-FhDeAZecXSM36zroty6kpf2BCWLS=0r+duwub96lqfk...@mail.gmail.com/T/#r43cbf31b86642ab5118e6e7b3d4098bade5f5a0a https://public-inbox.org/git/Z2XOTcGuVovMKhcdrrO08KWI2

Selection Notice (Official Notification).

2019-10-23 Thread GIC Notification, EU
GIC Corporate Headquarter, Ref: 732828-928/EU Congratulations, You are our WINNER. Regards, Tom Schraer. Chairman, GIC 2019. GIC Corporate Headquarter, Ref: 732828-928/EU Congratulations, You are our WINNER. Regards, Tom Schraer. Chairman, GIC 2019.

Selection Notice (Official Notification).

2019-10-23 Thread GIC Notification, EU
GIC Corporate Headquarter, Ref: 732828-928/EU Congratulations, You are our WINNER. Regards, Tom Schraer. Chairman, GIC 2019.

Re: Git Test Coverage Report (October 11)

2019-10-23 Thread Derrick Stolee
On 10/23/2019 1:00 PM, Torsten Bögershausen wrote: > On Fri, Oct 11, 2019 at 09:33:11AM -0400, Derrick Stolee wrote: >> Here is today's test coverage report. The usual report format is >> available online [1], [2]. The report listed below is a new format >> that groups lines by the commit that intr

Re: [PATCH 2/5] t4108: remove git command upstream of pipe

2019-10-23 Thread Denton Liu
On Wed, Oct 23, 2019 at 09:32:26AM -0400, Eric Sunshine wrote: > On Wed, Oct 23, 2019 at 8:04 AM Denton Liu wrote: > > Before, the output of `git diff HEAD` would always be piped to > > sanitize_conflicted_diff(). However, since the Git command was upstream > > of the pipe, in case the Git command

Re: Git Test Coverage Report (October 11)

2019-10-23 Thread Torsten Bögershausen
On Fri, Oct 11, 2019 at 09:33:11AM -0400, Derrick Stolee wrote: > Here is today's test coverage report. The usual report format is > available online [1], [2]. The report listed below is a new format > that groups lines by the commit that introduced them [3]. Thanks > Peff for the feedback on that

Re: [PATCH v3 1/1] ci(osx): use new location of the `perforce` cask

2019-10-23 Thread SZEDER Gábor
On Wed, Oct 23, 2019 at 07:05:04PM +0900, Junio C Hamano wrote: > "Johannes Schindelin via GitGitGadget" > writes: > > > From: Johannes Schindelin > > > > The Azure Pipelines builds are failing for macOS due to a change in the > > location of the perforce cask. The command outputs the following

Re: [PATCH 5/5] path.c: don't call the match function without value in trie_find()

2019-10-23 Thread SZEDER Gábor
On Wed, Oct 23, 2019 at 01:01:00PM +0900, Junio C Hamano wrote: > SZEDER Gábor writes: > > >> - b9317d55a3 added two new keys to the trie: 'logs/refs/rewritten' > >> and 'logs/refs/worktree', next to the already existing > >> 'logs/refs/bisect'. This resulted in a trie node with the pa

Draft of Git Rev News edition 56

2019-10-23 Thread Christian Couder
Hi everyone! A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-56.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this

Re: [PATCH] pretty: Add "%aU"|"%au" option to output author's username

2019-10-23 Thread Prarit Bhargava
On 10/23/19 1:02 AM, Jeff King wrote: > On Tue, Oct 22, 2019 at 07:28:47PM -0400, Prarit Bhargava wrote: > >> In many projects the number of contributors is low enough that users know >> each other and the full email address doesn't need to be displayed. >> Displaying only the author's username

Re: [PATCH] pretty: Add "%aU"|"%au" option to output author's username

2019-10-23 Thread Prarit Bhargava
On 10/22/19 7:48 PM, brian m. carlson wrote: > On 2019-10-22 at 23:28:47, Prarit Bhargava wrote: >> In many projects the number of contributors is low enough that users know >> each other and the full email address doesn't need to be displayed. >> Displaying only the author's username saves a lo

Re: [PATCH v2 2/2] commit-graph: fix writing first commit-graph during fetch

2019-10-23 Thread SZEDER Gábor
On Wed, Oct 23, 2019 at 01:01:35PM +, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The previous commit includes a failing test for an issue around > fetch.writeCommitGraph and fetching in a repo with a submodule. Here, we > fix that bug and set the test to "test_expect_su

Re: [PATCH] pretty: Add "%aU"|"%au" option to output author's username

2019-10-23 Thread Prarit Bhargava
On 10/22/19 7:46 PM, Junio C Hamano wrote: > Prarit Bhargava writes: > >> Subject: Re: [PATCH] pretty: Add "%aU"|"%au" option to output author's >> username > > Downcase "Add" (see "git shortlog --no-merges -100 master" and > mimick the project convention). I'll fix that. > >> Add a "%aU"

Re: [PATCH v2 1/2] t5510-fetch.sh: demonstrate fetch.writeCommitGraph bug

2019-10-23 Thread SZEDER Gábor
On Wed, Oct 23, 2019 at 01:01:34PM +, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > While dogfooding, Johannes found a bug in the fetch.writeCommitGraph > config behavior. His example initially happened during a clone with > --recurse-submodules, we found that this happens

Re: [PATCH 08/12] t5520: use test_cmp_rev where possible

2019-10-23 Thread Eric Sunshine
On Fri, Oct 18, 2019 at 2:52 PM Denton Liu wrote: > On Thu, Oct 17, 2019 at 07:41:44PM -0400, Eric Sunshine wrote: > > On Thu, Oct 17, 2019 at 7:17 PM Denton Liu wrote: > > > - test "$COPY" = "$(git rev-parse --verify me/copy)" && > > > + test_cmp_rev "$COPY" me/copy && > > > > This t

Re: [PATCH 4/5] t4108: demonstrate bug in apply

2019-10-23 Thread Eric Sunshine
On Wed, Oct 23, 2019 at 8:04 AM Denton Liu wrote: > Currently, apply does not respect the merge.conflictStyle setting. > Demonstrate this by making the 'apply with --3way' test case generic and > extending it to show that the configuration of > merge.conflictStyle = diff3 causes a breakage. > > Ch

[PATCH v2 2/2] commit-graph: fix writing first commit-graph during fetch

2019-10-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The previous commit includes a failing test for an issue around fetch.writeCommitGraph and fetching in a repo with a submodule. Here, we fix that bug and set the test to "test_expect_success". The prolem arises with this set of commands when the remote repo at has a submodu

[PATCH v2 0/2] [v2.24.0-rc0 BUG] fetch.writeCommitGraph fails on first fetch

2019-10-23 Thread Derrick Stolee via GitGitGadget
UPDATE for V2: We now know the full repro, and a test is added. Thanks Szeder and Peff for your insights! While dogfooding, Johannes found a bug in the fetch.writeCommitGraph config behavior. While his example initially happened during a clone with --recurse-submodules, (UPDATE) and the submodule

[PATCH v2 1/2] t5510-fetch.sh: demonstrate fetch.writeCommitGraph bug

2019-10-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee While dogfooding, Johannes found a bug in the fetch.writeCommitGraph config behavior. His example initially happened during a clone with --recurse-submodules, we found that this happens with the first fetch after cloning a repository that contains a submodule: $ git

Re: [BUG] "--show-current-patch" return a mail instead of a patch

2019-10-23 Thread Jerome Pouiller
On Wednesday 23 October 2019 13:09:51 CEST Denton Liu wrote: > On Wed, Oct 23, 2019 at 10:15:15AM +, Jerome Pouiller wrote: > > On Wednesday 23 October 2019 10:55:03 CEST Denton Liu wrote: > > > I am currently have a WIP patchset that will print the location of the > > > failed patch file (.git

Re: [PATCH v5 13/17] read-tree: show progress by default

2019-10-23 Thread Derrick Stolee
On 10/22/2019 11:48 PM, Junio C Hamano wrote: > Derrick Stolee writes: > >>> I'm slightly wary of changing the output of plumbing commands >>> like this. If a script wants progress output it can already get >>> it by passing --verbose. With this change a script that does not >>> want that output

[PATCH 1/5] t4108: replace create_file with test_write_lines

2019-10-23 Thread Denton Liu
Since the locally defined create_file() duplicates the functionality of the test_write_lines() helper function, remove create_file() and replace all instances with test_write_lines(). While we're at it, move redirection operators to the end of the command which is the more conventional place to put

[PATCH 3/5] t4108: use `test_config` instead of `git config`

2019-10-23 Thread Denton Liu
Since `git config` leaves the configurations set even after the test case completes, use `test_config` instead so that the configurations are reset once the test case finishes. Signed-off-by: Denton Liu --- t/t4108-apply-threeway.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH 2/5] t4108: remove git command upstream of pipe

2019-10-23 Thread Denton Liu
Before, the output of `git diff HEAD` would always be piped to sanitize_conflicted_diff(). However, since the Git command was upstream of the pipe, in case the Git command fails, the return code would be lost. Rewrite into separate statements so that the return code is no longer lost. Since only t

[PATCH 0/5] apply: fix merge.conflictStyle bug in --3way

2019-10-23 Thread Denton Liu
This fixes a bug where even if `merge.conflictStyle = diff3`, running `git apply --3way` would not output the base. Patches 1-3 are general cleanup for t4108, 4 demonstrates the bug and 5 actually fixes it. Denton Liu (5): t4108: replace create_file with test_write_lines t4108: remove git com

[PATCH 4/5] t4108: demonstrate bug in apply

2019-10-23 Thread Denton Liu
Currently, apply does not respect the merge.conflictStyle setting. Demonstrate this by making the 'apply with --3way' test case generic and extending it to show that the configuration of merge.conflictStyle = diff3 causes a breakage. Change print_sanitized_diff() to also sanitize `|||` conflic

[PATCH 5/5] apply: respect merge.conflictStyle in --3way

2019-10-23 Thread Denton Liu
Before, when doing a 3-way merge, the merge.conflictStyle option was not respected and the "merge" style was always used, even if "diff3" was specified. Call git_xmerge_config() at the end of git_apply_config() so that the merge.conflictStyle config is read. Signed-off-by: Denton Liu --- apply.

Re: [BUG] "--show-current-patch" return a mail instead of a patch

2019-10-23 Thread Denton Liu
On Wed, Oct 23, 2019 at 10:15:15AM +, Jerome Pouiller wrote: > On Wednesday 23 October 2019 10:55:03 CEST Denton Liu wrote: > > I am currently have a WIP patchset that will print the location of the > > failed patch file (.git/rebase-apply/patch) in the case of a failure as > > well as the line

Re: [BUG] "--show-current-patch" return a mail instead of a patch

2019-10-23 Thread Jerome Pouiller
On Wednesday 23 October 2019 10:55:03 CEST Denton Liu wrote: > On Wed, Oct 23, 2019 at 08:49:41AM +, Jerome Pouiller wrote: > > On Wednesday 23 October 2019 04:24:58 CEST Junio C Hamano wrote: > > > Jerome Pouiller writes: > > > > I try to use "git am" to apply a patch sent using "git send-ema

Re: [RFC/WIP] range-diff: show old/new blob OIDs in comments

2019-10-23 Thread Eric Wong
Eric Wong wrote: > Johannes Schindelin wrote: > > I guess your patch won't hurt. > > Cool, will update tests and resend. Turns out the t3206 "trivial reordering" case is way too noisy. I might need to change diff.c to support this case; will update in a few days or week.

Re: [PATCH v3 1/1] ci(osx): use new location of the `perforce` cask

2019-10-23 Thread Junio C Hamano
"Johannes Schindelin via GitGitGadget" writes: > From: Johannes Schindelin > > The Azure Pipelines builds are failing for macOS due to a change in the > location of the perforce cask. The command outputs the following error: > > + brew install caskroom/cask/perforce > Error: caskroom/cas

Re: Issue: "Could not access submodule" error when pulling recursively with Git 2.22.0

2019-10-23 Thread SZEDER Gábor
On Wed, Oct 23, 2019 at 07:22:12AM +, Aleksey Mikhaylov wrote: > "Could not access submodule" error when pulling recursively with Git 2.22.0. > This issue causes if there is submodule in submodule. > Please use my simple test repository to reproduce the problem: > https://github.com/agmikhailo

Re: [BUG] "--show-current-patch" return a mail instead of a patch

2019-10-23 Thread Denton Liu
Hi Jerome, On Wed, Oct 23, 2019 at 08:49:41AM +, Jerome Pouiller wrote: > On Wednesday 23 October 2019 04:24:58 CEST Junio C Hamano wrote: > > Jerome Pouiller writes: > > > I try to use "git am" to apply a patch sent using "git send-email". This > > > patch does not apply properly. I try to u

Re: [BUG] "--show-current-patch" return a mail instead of a patch

2019-10-23 Thread Jerome Pouiller
On Wednesday 23 October 2019 04:24:58 CEST Junio C Hamano wrote: > Jerome Pouiller writes: > > I try to use "git am" to apply a patch sent using "git send-email". This > > patch does not apply properly. I try to use "git am --show-current-patch" > > to understand the problem. However, since origin

[PATCH v2 0/1] [Outreachy] documentation: remove empty doc files

2019-10-23 Thread Heba Waly via GitGitGadget
Remove empty and redundant documentation files from the Documentation/technical/ directory. The empty doc files included only TODO messages with no documentation for years. Instead an approach is being taken to keep all doc beside the code in the relevant header files. Having empty doc files is co

[PATCH v2 1/1] documentation: remove empty doc files

2019-10-23 Thread Heba Waly via GitGitGadget
From: Heba Waly Remove empty and redundant documentation files from the Documentation/technical/ directory. The empty doc files included only TODO messages with no documentation for years. Instead an approach is being taken to keep all doc beside the code in the relevant header files. Having emp

Re: [PATCH 1/1] documentation: remove empty doc files

2019-10-23 Thread Heba Waly
On Wed, Oct 23, 2019 at 12:52 PM Junio C Hamano wrote: > > Emily Shaffer writes: > > > As for the content of this change, I absolutely approve. I've stumbled > > across some of these empty docs while looking for answers before and > > found it really demoralizing - the community is so interested

Re: [PATCH 1/1] documentation: remove empty doc files

2019-10-23 Thread Heba Waly
On Wed, Oct 23, 2019 at 10:05 AM Emily Shaffer wrote: > > On Tue, Oct 22, 2019 at 06:19:35PM +, Heba Waly via GitGitGadget wrote: > > From: Heba Waly > > > > Remove empty and redundant documentation files from the > > Documentation/technical/ directory. > > > > As part of moving the documenta

Issue: "Could not access submodule" error when pulling recursively with Git 2.22.0

2019-10-23 Thread Aleksey Mikhaylov
PROBLEM DESCRIPTION "Could not access submodule" error when pulling recursively with Git 2.22.0. This issue causes if there is submodule in submodule. At first, we reported this problem for Git for Windows: https://github.com/git-for-windows/git/issues/2361 But we received the answer that it was