On Thu, Sep 19, 2019 at 1:45 PM Derrick Stolee via GitGitGadget
wrote:
>
> From: Derrick Stolee
>
> The sparse-checkout feature can have quadratic performance as
> the number of patterns and number of entries in the index grow.
> If there are 1,000 patterns and 1,000,000 entries, this time can
>
On Thu, Sep 19, 2019 at 10:15 AM Jeff Hostetler via GitGitGadget
wrote:
>
> From: Jeff Hostetler
>
> When Git updates the working directory with the sparse-checkout
> feature enabled, the unpack_trees() method calls clear_ce_flags()
> to update the skip-wortree bits on the cache entries. This
> c
On Thu, Sep 19, 2019 at 1:46 PM Derrick Stolee via GitGitGadget
wrote:
>
> From: Derrick Stolee
>
> The instructions for disabling a sparse-checkout to a full
> working directory are complicated and non-intuitive. Add a
> subcommand, 'git sparse-checkout disable', to perform those
> steps for the
> >> ...
> >> Luke, does this look good?
> >>
> >> I know Mazo is the only other contributor who has multiple commits
> >> to git-p4.py in the past 2 years, to make Reviewed-by carry some
> >> weight ;-) but as we have so small number of people touching this
> >> script anyway, I'd rather see
Bert Wesarg writes:
> + switch
> (safe_create_leading_directories_const(output_directory)) {
> + case SCLD_OK:
> + case SCLD_EXISTS:
> + break;
> + default:
> + die(_("could not create leading directories "
>
René Scharfe writes:
> Strip "UTF" and an optional dash from the start of 'upper' without
> passing a NULL pointer to skip_prefix() in the second call, as it cannot
> handle that.
Did the original meant to say "skip UTF- from the beginning of upper
and store it to stripped, or if that cannot be
On Sat, Oct 5, 2019 at 3:44 PM Elijah Newren wrote:
>
> On Thu, Sep 19, 2019 at 3:07 PM Derrick Stolee via GitGitGadget
> wrote:
> > +static int write_patterns_and_update(struct pattern_list *pl)
> > +{
> > + char *sparse_filename;
> > + FILE *fp;
> > +
> > + sparse_filename = g
"Johannes Schindelin via GitGitGadget"
writes:
> Changes since v2:
>
> * The overflow check introduced in v1 was consolidated into a single
>helper.
Looks good to me.
> Range-diff vs v2:
>
> 1: 4d0b38125a = 1: 4d0b38125a push: do not pretend to return `int` from
> `die_push_simple()`
Eric Wong writes:
> That said, there could be other compilers which don't set
> __GNUC__ and have the same problem as clang. But maybe those
> compilers are too buggy and we already ignore invalid warnings
> on those compilers.
Perhaps.
Johannes Schindelin writes:
>> IMHO, if you don't accompany insert_pos_as_negative_offset() with a
>> corresponding extract_pos_and_found_condition() and use it everywhere,
>> it is more obfuscating than necessary.
>
> I do disagree here. No overflow checking needs to be performed for `-1 -
> `.
René Scharfe writes:
> It works best for changes whose effects are constrained to within the
> affected functions, but have crucial information located outside the
> three default lines of context. An example would be a change at the end
> of a function for which a reviewer might need to know th
Phillip Wood writes:
>> * ra/rebase-i-more-options (2019-09-09) 6 commits
>> ...
>> Is this ready for 'next'.
>
> Nearly, but not quite I think cf [1]. Also I'm still not convinced
> that having different behaviors for --ignore-whitespace depending on
> the backend is going to be helpful but ma
Junio C Hamano writes:
>> if (len <= 0) {
>> free(fragment);
>> -return error(_("corrupt patch at line %d"),
>> state->linenr);
>> +return error(_("corrupt patch at %s:%d"),
>> state->patch_input_file, state->linenr);
>>
On Thu, Sep 19, 2019 at 3:07 PM Derrick Stolee via GitGitGadget
wrote:
> +static int write_patterns_and_update(struct pattern_list *pl)
> +{
> + char *sparse_filename;
> + FILE *fp;
> +
> + sparse_filename = get_sparse_checkout_filename();
> + fp = fopen(sparse_filename, "w
Junio C Hamano writes:
>> An alternate design was considered which involved printing the line
>> numbers relative to the output of `git am --show-current-patch` (in
>> other words, the actual mail file that's provided to am). This design
>> was not chosen because am does not store the whole mail
This test produces pseudo-collisions and tests git diff's behavior with
them, and is therefore sensitive to the hash in use. Update the test to
compute the collisions for both SHA-1 and SHA-256 using appropriate
constants. Move the heredocs inside the setup block so that all of the
setup code can b
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson
---
t/t4010-diff-pathspec.sh | 20
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/t/t4010-diff-pathspec.sh b/t/t4010-diff-pathspec
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson
---
t/t4039-diff-assume-unchanged.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/t4039-diff-assume-unchanged.sh b/t/t4039-diff-assume-uncha
This test passes successfully with SHA-256, so remove the annotation
which limits it to SHA-1.
Signed-off-by: brian m. carlson
---
t/t3429-rebase-edit-todo.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t3429-rebase-edit-todo.sh b/t/t3429-rebase-edit-todo.sh
index 76f6d
A repository using a hash other than SHA-1 will need to have an
extension in the config file. Ignore any extensions when comparing
config files, since they don't usefully contribute to the goal of the
test.
Signed-off-by: brian m. carlson
---
t/t1305-config-include.sh | 2 +-
1 file changed, 1
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes. Move some expected result heredocs around so
that they can use computed variables.
Signed-off-by: brian m. carlson
---
t/t4034-diff-words.sh | 93 +--
1 file
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson
---
t/t4015-diff-whitespace.sh | 89 +++---
1 file changed, 53 insertions(+), 36 deletions(-)
diff --git a/t/t4015-diff-whitespace.sh
Instead of hard-coding the length of an object ID, look this value up
using the translation tables. Similarly, compute input data for invalid
submodule entries using the tables as well.
Signed-off-by: brian m. carlson
---
t/t4027-diff-submodule.sh | 16
1 file changed, 8 insert
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson
---
t/t4011-diff-symlink.sh | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/t/t4011-diff-symlink.sh b/t/t4011-dif
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.
Signed-off-by: brian m. carlson
---
t/t4048-diff-combined-binary.sh | 58 ++---
1 file changed, 32 insertions(+), 26 deletions(-)
diff --git a/t/t4048-diff-combined-binar
Add an option to print the object format used for input, output, or
storage. This allows shell scripts to discover the hash algorithm in
use.
Since the transition plan allows for multiple input algorithms, document
that we may provide multiple results for input, and the format that the
results may
Replace a hard-coded all-zeros object ID with a use of $ZERO_OID.
Signed-off-by: brian m. carlson
---
t/t4045-diff-relative.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4045-diff-relative.sh b/t/t4045-diff-relative.sh
index 36f8ed8a81..258808708e 100755
--- a/t/t4045
Compute several object IDs that exist in expected output, since we don't
care about the specific object IDs, only that the format of the output
is syntactically correct.
Signed-off-by: brian m. carlson
---
t/t4038-diff-combined.sh | 19 +--
1 file changed, 13 insertions(+), 6 del
This series consists mostly of additional test fixes for SHA-256, plus
some test framework improvements and a new option to rev-parse.
Up until now, most of the test changes have been directly related to
fixing hash values or sizes in some way. In other words, previous test
fixes would be require
The test_oid function provides a mechanism for looking up hash algorithm
information, but it doesn't specify a way to discover the hash algorithm
name. Knowing this information is useful if one wants to invoke the
test-tool helper for the algorithm in use, such as in our pack
generation library.
The testsuite will eventually learn how to run using an algorithm other
than SHA-1. In preparation for this, teach the test_oid family of
functions how to look up the empty blob and empty tree values so they
can be used.
Signed-off-by: brian m. carlson
---
t/oid-info/hash-info | 6 ++
1 file
On 05/10/19 12:51PM, Bert Wesarg wrote:
> On Sat, Oct 5, 2019 at 12:10 AM Pratyush Yadav wrote:
> > +# Contributing
> > +
> > +The project is currently maintained by Pratyush Yadav over at
> > +https://github.com/prati0100/git-gui. Even though the project is hosted at
> > +GitHub, the development
Hi Johannes,
On 05/10/19 09:56PM, Johannes Schindelin wrote:
> Hi Pratyush,
>
> On Sat, 5 Oct 2019, Pratyush Yadav wrote:
>
> > It is a good idea to have a readme so people finding the project can
> > know more about it, and know how they can get involved.
> >
> > Signed-off-by: Pratyush Yadav
On 06/10/19 01:46AM, Harish Karumuthil wrote:
> Hi All,
>
> From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I
> understood that, my current email client ( that is gmail web ) is not good
> for submitting patches. So I was tying to setup a mail client which is
> compatible wi
Hi All,
>From https://www.kernel.org/doc/html/v4.10/process/email-clients.html, I
understood that, my current email client ( that is gmail web ) is not good
for submitting patches. So I was tying to setup a mail client which is
compatible with `git send-mail`. But I was not able to get a satisfact
Hi Pratyush,
On Sat, 5 Oct 2019, Pratyush Yadav wrote:
> It is a good idea to have a readme so people finding the project can
> know more about it, and know how they can get involved.
>
> Signed-off-by: Pratyush Yadav
> ---
>
> I don't have much experience writing this kind of readme or
> docume
Hi Elijah
On 05/10/2019 01:40, Elijah Newren wrote:
On Fri, Oct 4, 2019 at 4:49 AM Phillip Wood wrote:
Hi Junio
On 03/10/2019 06:04, Junio C Hamano wrote:
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'
On Thu, Sep 19, 2019 at 3:06 PM Derrick Stolee via GitGitGadget
wrote:
> During the 'git sparse-checkout init' call, we must first look
> to see if HEAD is valid, or else we will fail while trying to
> update the working directory. The first checkout will actually
> update the working directory c
On Thu, Sep 19, 2019 at 3:06 PM Derrick Stolee via GitGitGadget
wrote:
>
> From: Derrick Stolee
>
> Getting started with a sparse-checkout file can be daunting. Help
> users start their sparse enlistment using 'git sparse-checkout init'.
> This will set 'core.sparseCheckout=true' in their config,
On Thu, Sep 19, 2019 at 1:45 PM Derrick Stolee via GitGitGadget
wrote:
>
> From: Derrick Stolee
>
> The sparse-checkout feature is mostly hidden to users, as its
> only documentation is supplementary information in the docs for
> 'git read-tree'. In addition, users need to know how to edit the
>
I saw with sadness that pd/fetch-jobs went nowhere, and read in the most
recent What's Cooking mail that it was even dropped.
This is my attempt to resurrect the idea (although without the overhead of
trying to support a first-class UI to control submodule and multiple-remote
fetches independently
From: Johannes Schindelin
So far, `--jobs=` only parallelizes submodule fetches/clones, not
`--multiple` fetches, which is unintuitive, given that the option's name
does not say anything about submodules in particular.
Let's change that. With this patch, also fetches from multiple remotes
are pa
On Fri, Oct 4, 2019 at 2:29 AM Phillip Wood wrote:
>
> Hi Rohit
>
> On 07/09/2019 12:50, Rohit Ashiwal wrote:
> > There are two backends available for rebasing, viz, the am and the
> > interactive. Naturally, there shall be some features that are
> > implemented in one but not in the other. One su
On 05/10/2019 17:14, Alexander Litvinov wrote:
unsibscribe git
try sending to majordomo, see http://vger.kernel.org/vger-lists.html#git
Am 04.10.19 um 01:15 schrieb Junio C Hamano:
> René Scharfe writes:
>
>> Found with "git grep '^#include ' '*.c' | sort | uniq -d".
>>
>> Signed-off-by: René Scharfe
>> ---
>> Patch formatted with --function-context for easier review.
>
> I have a mixed feelings about that.
>
> The only audience
unsibscribe git
Am 04.10.19 um 23:30 schrieb Stephen Boyd:
> While reviewing some dts diffs recently I noticed that the hunk header
> logic was failing to find the containing node. This is because the regex
> doesn't consider properties that may span multiple lines, i.e.
>
> property = ,
>
Signed-off-by: Pratyush Yadav
---
Changes in v2:
- Only link the repo, instead of having instructions to "clone" and
"browse online".
Do note that I am using single quotes around git gui instead of
backticks like you suggested because the rest of the man page does the
same.
Interdiff against
On Sat, Oct 5, 2019 at 12:10 AM Pratyush Yadav wrote:
>
> It is a good idea to have a readme so people finding the project can
> know more about it, and know how they can get involved.
>
> Signed-off-by: Pratyush Yadav
> ---
>
> I don't have much experience writing this kind of readme or
> docume
Denton Liu writes:
> The synopsis section in git-rev-list.txt has grown to be a huge list
> that probably needs its own synopsis. Since the list is huge, users may
> be given the false impression that the list is complete, however it is
> not. It is missing many of the available options.
>
> Sinc
Pratyush Yadav writes:
> Signed-off-by: Pratyush Yadav
> ---
> Documentation/git-gui.txt | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/git-gui.txt b/Documentation/git-gui.txt
> index 5f93f8003d..98337b69f1 100644
> --- a/Documentation/git-gui.txt
The 'format.outputDirectory' configuration is only able to store constant
directory names. Though some may use
$ git format-patch -o $(createdir) …
to name the directory dynamically. Provide a new configuration to be able
to store such a command too.
Signed-off-by: Bert Wesarg
---
ChangeL
Signed-off-by: Bert Wesarg
---
ChangeLog:
v2:
* squashed and base new tests on 'dl/format-patch-doc-test-cleanup'
Cc: Denton Liu
---
Documentation/config/format.txt| 2 +-
Documentation/git-format-patch.txt | 3 ++-
builtin/log.c | 8
t/t4014-format-pat
Denton Liu writes:
> When `git am` runs into a corrupt patch, it'll error out and give a
> message such as,
>
> error: corrupt patch at line 87
>
> Casual users of am may assume that this line number refers to the
> file that they provided on the command-line. This assumption, however,
> i
54 matches
Mail list logo
