Hi git contributors!
I'm Kunal Tyagi. While I was choosing the relevant patches for a commit
using the git add -p command, I found that there was no feedback regarding
how many hunks from the current file had been processed and how many were
left. So I decided to add a small change to the prompt w
From: Kunal Tyagi
Adds a feedback regarding how many hunks from the current file have been
processed and total number of hunks
Also included: changes to the test script due to change in expected
output string
Change in UI: displays '(${current-hunk-id} + 1/${total-hunks-in-file})' before
display
A check into the history of this code revealed no particular reason for
the code to be written in this way. All popular compilers are capable of
unrolling loops if it benefits performance, and once this code is
replaced with a loop, the magic number 6 used in multiple places in this
function can be
The variable g was being set to the same value both at the beginning of
the function and before the loop. The assignment before the loop was
kept because it helps clarify what the loop does, and the redundant
assignment at the beginning of the function was removed.
Reviewed-by: Derrick Stolee
Sig
The condition "if (q->nr <= j)" checks whether the loop exited normally
or via a break statement. This check can be avoided by replacing the
jump to the end of the loop with a jump to the end of the function.
With the break replaced by a goto, the two diff_q calls then can be
replaced with a singl
On Thu, Sep 26, 2019 at 8:50 PM Jeff King wrote:
>
> On Thu, Sep 26, 2019 at 10:14:17PM +0200, Johannes Schindelin wrote:
>
> > However, I think that this patch should at least be accompanied by a
> > commit message that suggests that some thought was put into it, and that
> > concerns like mine w
On 2019-09-28 at 23:31:33, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> > On 2019-09-07 at 17:26:53, Junio C Hamano wrote:
> >> * bc/object-id-part17 (2019-08-19) 26 commits
> >> ...
> >> - builtin/replace: make hash size independent
> >>
> >> Preparation for SHA-256 upgrade continue
"brian m. carlson" writes:
> On 2019-09-07 at 17:26:53, Junio C Hamano wrote:
>> * bc/object-id-part17 (2019-08-19) 26 commits
>> ...
>> - builtin/replace: make hash size independent
>>
>> Preparation for SHA-256 upgrade continues.
>>
>> Looked mostly OK, with a possible update.
>> cf. <201
"Johannes Schindelin via GitGitGadget"
writes:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index d1ba33745a..f21c781e68 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -695,7 +695,7 @@ test_failure_ () {
> say_color error "not ok $test_count - $1"
> shift
> printf '%s
Signed-off-by: Bert Wesarg
---
builtin/submodule--helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 909e77e802..89d6f02969 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1874
"Johannes Schindelin via GitGitGadget"
writes:
> ---
> Makefile | 2 +-
> compat/mingw.c| 5 -
> git-compat-util.h | 4 +++-
> compat/qsort.c => qsort.c | 2 +-
> 4 files changed, 5 insertions(+), 8 deletions(-)
> rename compat/qsort.c => qsort.c (97%)
Thomas Gummerer writes:
>> I thought it was to be 1700 UTC, which currently is 1800 BST her in UK, and
>> 1900 CST in Europe.
>
> That's my recollection as well, and what the calendar should say.
> Thanks for flagging this!
>
> I don't know. I'd be happy to keep it at 17:00 UTC, but that might b
12 matches
Mail list logo
