Re: [PATCH 1/3] Makefile: use $(ALL_CFLAGS) in $(HCO) target

2019-09-27 Thread Junio C Hamano
Johannes Schindelin writes: > The only problem is that my patch made it into `next` already, according > to https://github.com/gitgitgadget/git/pull/129 (look for the labels on > the right side, or for the comments on the bottom), and > https://github.com/gitster/git/commit/a3f332f4fb10 agrees (l

Re: [PATCH v3 2/2] t0028: add more tests

2019-09-27 Thread Junio C Hamano
"Alexandr Miloslavskiy via GitGitGadget" writes: > From: Alexandr Miloslavskiy > > After I discovered that UTF-16-LE-BOM test was bugged, I decided that s/bugged/buggy/ perhaps? Usually people do not place hidden listening devices in tests ;-) > better tests are required. Possibly the best op

Re: [RFC PATCH 0/3] grep: don't add subrepos to in-memory alternates

2019-09-27 Thread Matheus Tavares Bernardino
On Sat, Sep 28, 2019 at 12:24 AM Junio C Hamano wrote: > > Matheus Tavares Bernardino writes: > > > Right, this would be the best way of doing it. However, I think this > > is not how it's currently implemented. I if correctly understood the > > code in this call chain: > > > > grep_source_load_d

Re: [PATCH 01/15] t6120-describe: correct test repo history graph in comment

2019-09-27 Thread Junio C Hamano
SZEDER Gábor writes: >> Hmm... >> >> > +# ,---ooo-. >> > +# / D,R e \ >> > +# o--o-o-o---ox >> > +# \B/ >> > +# `---ooo-' >> > +#Ac >> >> What's the first parent of the merge between

Re: Git in Outreachy December 2019?

2019-09-27 Thread Junio C Hamano
Eric Wong writes: > C is fine for unit tests, and maybe we can use more unit tests > and less integration tests. Nicely put. I often find it somewhat disturbing that what some of the t/helper/ tests are trying to exercise is at too low a level that the distance from the real-world observable ef

Re: Git in Outreachy December 2019?

2019-09-27 Thread Junio C Hamano
Jeff King writes: > On Tue, Sep 24, 2019 at 04:25:45PM +0200, Johannes Schindelin wrote: > >> > I think it could make sense for merge-index to be able to directly run >> > the merge-one-file code[1]. But I think we'd want to keep its ability to >> > run an arbitrary script, and for people to call

Re: [PATCH v2 2/6] midx: add progress to write_midx_file Add progress to write_midx_file. Progress is displayed when the MIDX_PROGRESS flag is set.

2019-09-27 Thread Junio C Hamano
William Baker writes: > On 9/20/19 1:10 PM, Junio C Hamano wrote: >>> diff --git a/midx.c b/midx.c >>> index b2673f52e8..54e4e93b2b 100644 >>> --- a/midx.c >>> +++ b/midx.c >>> @@ -449,6 +449,8 @@ struct pack_list { >>> uint32_t nr; >>> uint32_t alloc; >>> struct multi_pack_index *m;

Re: [PATCH v2 1/6] midx: add MIDX_PROGRESS flag

2019-09-27 Thread Junio C Hamano
SZEDER Gábor writes: > On Fri, Sep 20, 2019 at 09:53:48AM -0700, William Baker via GitGitGadget > wrote: >> diff --git a/midx.h b/midx.h >> index f0ae656b5d..e6fa356b5c 100644 >> --- a/midx.h >> +++ b/midx.h >> @@ -37,6 +37,8 @@ struct multi_pack_index { >> char object_dir[FLEX_ARRAY]; >>

Re: [RFC PATCH 0/3] grep: don't add subrepos to in-memory alternates

2019-09-27 Thread Junio C Hamano
Matheus Tavares Bernardino writes: > Right, this would be the best way of doing it. However, I think this > is not how it's currently implemented. I if correctly understood the > code in this call chain: > > grep_source_load_driver() > userdiff_find_by_path() > > git_check_attr() > collect_some_

Privatkreditangebot

2019-09-27 Thread Guido Niggli
Brauchen Sie dringend einen Kredit fur geschaftliche und private Angelegenheiten? Ich bin ein privater Kreditgeber und kann Ihren Kredit finanzieren. Ich gebe alle Arten von Darlehen zu einem gunstigen Zinssatz aus. Solange Sie das Darlehen zuruckzahlen konnen, ist keine Bonitatsprufung erfo

Re: Feature request: different exit codes for git stash depending on whether stash was created or not

2019-09-27 Thread brian m. carlson
On 2019-09-27 at 12:55:27, Ian Kemp wrote: > Hi, > > Currently, git stash's exit code is 0 regardless of whether it > performed a stash operation or not. Third parties invoking git stash > are therefore unable to determine whether a stash was actually made or > not. > > It would be helpful if the

Re: Git in Outreachy December 2019?

2019-09-27 Thread Jeff King
On Thu, Sep 26, 2019 at 11:44:48PM +0200, SZEDER Gábor wrote: > All that was over a year and a half ago, and these limitations weren't > a maintenance burden at all so far, and nobody needed that escape > hatch. > > Well, nobody except me, that is :) When I saw back then that t1510 > saves the s

Re: Common thread pool API in Git?

2019-09-27 Thread Jeff King
On Wed, Sep 25, 2019 at 05:33:00PM -0700, Jonathan Tan wrote: > Does anyone have ideas or plans for this? I know that (at least) "grep" > and "index-pack" have their own implementations, and it would be great > to just have one that all code can use. > [..] > Searching reveals [2], but I don't thi

Re: [PATCH] CODE_OF_CONDUCT: mention individual project-leader emails

2019-09-27 Thread CB Bailey
On 26/09/2019 08:20, Jeff King wrote: > On Tue, Sep 24, 2019 at 04:52:56PM -0700, Emily Shaffer wrote: >> I helped my other FOSS project to adopt a Code of Conduct earlier in >> the year (https://github.com/openbmc/docs/blob/master/code-of-conduct.md) >> and we got around this by asking for volunte

Re: [PATCH 1/2] commit-graph: don't show progress percentages while expanding reachable commits

2019-09-27 Thread Linus Torvalds
I was going to make a bug-report about this funny behavior, but decided to search the list first. Yeah, I smiled at Expanding reachable commits in commit graph: 139276% (870481/625), done. when I did the "git gc --prune=now" on the kernel, and apparently actually looked at the noise for the

Re: [BUG] git is segfaulting, was [PATCH v4 04/12] dir: also check directories for matching pathspecs

2019-09-27 Thread Denton Liu
On Fri, Sep 27, 2019 at 04:17:46AM +0200, SZEDER Gábor wrote: > On Fri, Sep 27, 2019 at 03:09:30AM +0200, SZEDER Gábor wrote: > > On Wed, Sep 25, 2019 at 01:39:19PM -0700, Denton Liu wrote: > > > Hi Elijah, > > > > > > I ran into a segfault on MacOS. I managed to bisect it down to > > > 404ebceda0

Re: Feature request: different exit codes for git stash depending on whether stash was created or not

2019-09-27 Thread Eric Sunshine
On Fri, Sep 27, 2019 at 8:55 AM Ian Kemp wrote: > Currently, git stash's exit code is 0 regardless of whether it > performed a stash operation or not. Third parties invoking git stash > are therefore unable to determine whether a stash was actually made or > not. > > It would be helpful if there w

Re: RFC: Cryptographic attestation for email-based patch workflows

2019-09-27 Thread dwh
On 10.09.2019 08:13, Konstantin Ryabitsev wrote: # Proposed approach I recommend that we provide a way to include cryptographic signature information natively using git-format-patch, using roughly the following process: - generate a signify-compatible cryptographic signature of the verbatim pa

Re: [PATCH v1 0/5] Use complete_action’s todo list to do the rebase

2019-09-27 Thread Phillip Wood
Hi Alban On 25/09/2019 21:13, Alban Gruin wrote: This can be seen as a continuation of ag/reduce-rewriting-todo. Currently, complete_action() releases its todo list before calling sequencer_continue(), which reloads the todo list from the disk. This series removes this useless round trip. Pat

Ahoj

2019-09-27 Thread Edith Brown
-- Ahoj drahý ako sa máš? volám sa Edith Brownová Som vojenská žena z USA je mi potešením stretnúť sa tu S Pozdravom

Re: [PATCH v1 4/5] rebase: fill `squash_onto' in get_replay_opts()

2019-09-27 Thread Phillip Wood
Hi Alban On 25/09/2019 21:13, Alban Gruin wrote: get_replay_opts() did not fill `squash_onto' if possible, meaning that I'm not sure what you mean by 'if possible' here, I think the sentance makes sense without that. this field should be read from the disk by the sequencer through read_pop

Re: [PATCH v1 5/5] sequencer: directly call pick_commits() from complete_action()

2019-09-27 Thread Phillip Wood
Hi Alban Thanks for removing some more unnecessary work reloading the the todo list. On 25/09/2019 21:13, Alban Gruin wrote: Currently, complete_action() calls sequencer_continue() to do the rebase. Even though the former already has the todo list, the latter loads it from the disk and parses

Re: [PATCH 1/1] respect core.hooksPath, falling back to .git/hooks

2019-09-27 Thread Pratyush Yadav
On 27/09/19 08:10AM, Bert Wesarg wrote: > On Fri, Sep 27, 2019 at 12:40 AM Pratyush Yadav > wrote: > > > > Hi, > > > > On 26/09/19 02:17PM, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin > > > > > > Since v2.9.0, Git knows about the config variable core.hookspath > >

Feature request: different exit codes for git stash depending on whether stash was created or not

2019-09-27 Thread Ian Kemp
Hi, Currently, git stash's exit code is 0 regardless of whether it performed a stash operation or not. Third parties invoking git stash are therefore unable to determine whether a stash was actually made or not. It would be helpful if there were different exit codes for the case when a stash was

Re: [PATCH v2] commit-graph: remove a duplicate assignment

2019-09-27 Thread Derrick Stolee
On 9/27/2019 8:21 AM, Johannes Schindelin wrote: > Hi, > > > On Thu, 26 Sep 2019, Alex Henrie wrote: > >> Signed-off-by: Alex Henrie > > Hrm, the commit message should reflect Stolee's careful consideration, > no? An empty commit message won't be helpful e.g. when cherry-picking on > top of a

Re: [PATCH v2] commit-graph: remove a duplicate assignment

2019-09-27 Thread Johannes Schindelin
Hi, On Thu, 26 Sep 2019, Alex Henrie wrote: > Signed-off-by: Alex Henrie Hrm, the commit message should reflect Stolee's careful consideration, no? An empty commit message won't be helpful e.g. when cherry-picking on top of a branch that already has your v1. Ciao, Johannes > --- > commit-gr

Re: Possible bug in git describe, additional commits differs when cloned with --depth

2019-09-27 Thread SZEDER Gábor
On Fri, Sep 27, 2019 at 11:51:07AM +0200, Anders Janmyr wrote: > Hi, > > I'm not sure if this is a bug or not but `git describe` gives > different results when the repo has been cloned with `--depth` or not. > > In the example below from the git repository the number of additional > commits since

Re: [PATCH 3/3] wrapper: use a loop instead of repetitive statements

2019-09-27 Thread Derrick Stolee
On 9/26/2019 10:45 PM, Jeff King wrote: > On Tue, Sep 24, 2019 at 08:01:58PM -0600, Alex Henrie wrote: > >> diff --git a/wrapper.c b/wrapper.c >> index c55d7722d7..c23ac6adcd 100644 >> --- a/wrapper.c >> +++ b/wrapper.c >> @@ -469,13 +469,12 @@ int git_mkstemps_mode(char *pattern, int suffix_len,

Re: [PATCH v4 5/6] rebase -i: support --ignore-date

2019-09-27 Thread Phillip Wood
Hi Rohit This is an improvement but there are a couple of outstanding issues from the previous round with regard to handing --ignore-date when GIT_COMMITTER_DATE is set. I'll try and look at the rest of the series soon. On 07/09/2019 12:50, Rohit Ashiwal wrote: rebase am already has this fla

Possible bug in git describe, additional commits differs when cloned with --depth

2019-09-27 Thread Anders Janmyr
Hi, I'm not sure if this is a bug or not but `git describe` gives different results when the repo has been cloned with `--depth` or not. In the example below from the git repository the number of additional commits since the last tag differs 256 vs. 265. ``` $ git clone https://github.com/git/gi

Re: [git issue] git am failed for patches of converting the format of source codes from dos to unix

2019-09-27 Thread Thomas Gummerer
On 09/27, Beyondhorizon Zheng wrote: > [git issue] git am failed for patches of converting the file format of > source codes from dos to unix > > Git version: git version 2.23.0 > Host PC: ubuntu 16.04.10 > Reporter: Shuang Zheng > > I have submitted a patch which convert the file format of sourc

[git issue] git am failed for patches of converting the format of source codes from dos to unix

2019-09-27 Thread Beyondhorizon Zheng
[git issue] git am failed for patches of converting the file format of source codes from dos to unix Git version: git version 2.23.0 Host PC: ubuntu 16.04.10 Reporter: Shuang Zheng I have submitted a patch which convert the file format of source file from dos to unix with command: dos2unix misc/a