How to see command line arguments passed to program in core.sshcommand?

2019-09-22 Thread Jeffrey Walton
Hi Everyone, I'm working in an unusual setup on WIndows. I need to 'git clone' over SSH, but a third party program has to handle the tunnel. It happens by using this git configuration: git config --global core.sshcommand "tunnel.exe ... " After I execute the 'git config' command, I open ~/.g

Re: [PATCH] name-rev: avoid cutoff timestamp underflow

2019-09-22 Thread brian m. carlson
On 2019-09-22 at 18:01:43, SZEDER Gábor wrote: > diff --git a/builtin/name-rev.c b/builtin/name-rev.c > index c785fe16ba..a4d8d312ab 100644 > --- a/builtin/name-rev.c > +++ b/builtin/name-rev.c > @@ -9,7 +9,11 @@ > #include "sha1-lookup.h" > #include "commit-slab.h" > > -#define CUTOFF_DATE_SLO

Re: [PATCH v4 0/3] use mailmap by default in git log

2019-09-22 Thread CB Bailey
On Thu, Jul 11, 2019 at 01:37:24PM -0500, Ariadne Conill wrote: > It is not uncommon for people to change their name or e-mail address. > To facilitate this, Git provides support for the `.mailmap` file, > which contains a list of identities and previously used e-mail > addresses that are associate

Re: [PATCH] name-rev: avoid cutoff timestamp underflow

2019-09-22 Thread Johannes Sixt
Am 22.09.19 um 21:53 schrieb SZEDER Gábor: > On Sun, Sep 22, 2019 at 07:57:36PM +0100, Phillip Wood wrote: >> On 22/09/2019 19:01, SZEDER Gábor wrote: >>> +/* >>> + * One day. See the 'name a rev close to epoch' test in t6120 when >>> + * changing this value >>> + */ >>> +#define CUTOFF_DATE_SLOP

Re: [PATCH] name-rev: avoid cutoff timestamp underflow

2019-09-22 Thread SZEDER Gábor
On Sun, Sep 22, 2019 at 07:57:36PM +0100, Phillip Wood wrote: > On 22/09/2019 19:01, SZEDER Gábor wrote: > >When 'git name-rev' is invoked with commit-ish parameters, it tries to > >save some work, and doesn't visit commits older than the committer > >date of the oldest given commit minus a one day

Re: [PATCH] name-rev: avoid cutoff timestamp underflow

2019-09-22 Thread Phillip Wood
Hi Gábor On 22/09/2019 19:01, SZEDER Gábor wrote: When 'git name-rev' is invoked with commit-ish parameters, it tries to save some work, and doesn't visit commits older than the committer date of the oldest given commit minus a one day worth of slop. Since our 'timestamp_t' is an unsigned type,

Re: [PATCH 08/15] name-rev: pull out deref handling from the recursion

2019-09-22 Thread SZEDER Gábor
On Sat, Sep 21, 2019 at 02:37:18PM +0200, René Scharfe wrote: > Am 21.09.19 um 11:57 schrieb SZEDER Gábor: > > On Fri, Sep 20, 2019 at 08:14:07PM +0200, SZEDER Gábor wrote: > >> On Fri, Sep 20, 2019 at 08:13:02PM +0200, SZEDER Gábor wrote: > If the (re)introduced leak doesn't impact performanc

[PATCH] name-rev: avoid cutoff timestamp underflow

2019-09-22 Thread SZEDER Gábor
When 'git name-rev' is invoked with commit-ish parameters, it tries to save some work, and doesn't visit commits older than the committer date of the oldest given commit minus a one day worth of slop. Since our 'timestamp_t' is an unsigned type, this leads to a timestamp underflow when the committ

[PATCH 4/4] user-manual.txt: render ASCII art correctly under Asciidoctor

2019-09-22 Thread Martin Ågren
This commit is similar to 379805051d ("Documentation: render revisions correctly under Asciidoctor", 2018-05-06) and is a no-op with AsciiDoc. When creating a literal block from an indented block without any sort of delimiters, Asciidoctor strips off all leading whitespace, resulting in a misrende

[PATCH 3/4] asciidoctor-extensions.rb: handle "book" doctype in linkgit

2019-09-22 Thread Martin Ågren
user-manual.txt is the only file we process using the "book" doctype. When we use AsciiDoc, user-manual.conf ensures that the linkgit macro expands into something like git-foo(1) in user-manual.xml, which we then process into a clickable link, both in user-manual.html and user-manual.pdf. With

[PATCH 0/4] fix user-manual with Asciidoctor

2019-09-22 Thread Martin Ågren
This series makes user-manual.html and user-manual.pdf render well with Asciidoctor. The first patch is a while-at-it. The other three patches then align Asciidoctor-rendering with AsciiDoc, first with two bigger-scope patches, then with a local ASCII-art fix. I was happily surprised that there we

[PATCH 1/4] user-manual.txt: add missing section label

2019-09-22 Thread Martin Ågren
We provide a label for each chapter and section except for the "Pitfalls with submodules" section. Since we're doing it everywhere else, let's do it here, too. Signed-off-by: Martin Ågren --- Documentation/user-manual.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/user-man

[PATCH 2/4] user-manual.txt: change header notation

2019-09-22 Thread Martin Ågren
When AsciiDoc processes user-manual.txt, it generates a book containing chapters containing sections. So for example, we have chapter 6, "Advanced branch management", which contains four relatively short sections, 6.1-6.4. Asciidoctor generates a book containing *parts* containing *chapters* instea

[PATCH] name-rev: rewrite create_or_update_name()

2019-09-22 Thread Martin Ågren
This code was moved straight out of name_rev(). As such, we inherited the "goto" to jump from an if into an else-if. We also inherited the fact that "nothing to do -- return NULL" is handled last. Rewrite the function to first handle the "nothing to do" case. Then we can handle the conditional all