On Tue, Sep 03, 2019 at 11:04:55AM -0700, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee
>
> The first consumer of pattern-matching filenames was the
> .gitignore feature. In that context, storing a list of patterns
> as a list of 'struct exclude' items makes sense. However, the
>
On Thu, Sep 5, 2019 at 12:48 AM Pratyush Yadav wrote:
> I'll chime in with what I think would be a great solution: auto word
> wrapping. This way, the users can set the text width, and not have to
> worry about manually formatting it. Long "words" like URLs would still
> get to be on one line, and
On Wed, Sep 04, 2019 at 05:18:47PM -0400, Taylor Blau wrote:
> All of this makes sense to me, so I'm wondering what part(s) of this you
> feel are worth addressing in this first patch series. Presumably, there
> is a longer series that we _could_ write which would introduce a new
> 'corrupt' field
Am 04.09.19 um 22:43 schrieb Bert Wesarg:
> these people did not saw the entered text anyway. they would have
> needed to change the option (default to 75 characters) to see what
> they have typed. which could have been garbage to begin with.
Huh? When I type overly long line, all text scrolls out
On Wed, Sep 04, 2019 at 05:21:21PM -0400, Taylor Blau wrote:
> > I like the idea of completely bailing if the commit can't be parsed too.
> > Only question: Is there a reason you chose to die() instead of BUG() like
> > the other two places in that function? What is the criteria of choosing one
>
On Wed, Sep 04, 2019 at 01:55:00PM -0400, Taylor Blau wrote:
> I often find myself parsing the output of 'git diff' (which I spell 'g
> di') in less, and then wanting to jump to some specific diff in a file,
> i.e., by running 'git jump diff -- '.
>
> But, I am so used to typing 'di' instead of '
Hi Dscho,
On Wed, Sep 04, 2019 at 11:43:06PM +0200, Johannes Schindelin wrote:
> Hi Denton,
>
> On Wed, 4 Sep 2019, Denton Liu wrote:
>
> > In 554544276a (*.[ch]: remove extern from function declarations using
> > spatch, 2019-04-29), we removed externs from function declarations using
> > spatc
Pratyush Yadav writes:
> On 04/09/19 11:39PM, Johannes Sixt wrote:
>> Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen:
>> > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
>> >> Many keyboards do not have a right Alt-key. That means that Alt+1 to
>> >> Alt+4 combinations must be typed s
Johannes Schindelin writes:
> Hi Denton,
>
> On Wed, 4 Sep 2019, Denton Liu wrote:
>
>> After running Coccinelle on all sources inside compat/ that were created
>> by us[1], it was found that compat/mingw.c violated an array.cocci rule
>> in two places and, thus, a patch was generated. Apply this
Jonathan Tan writes:
> When cherry-picking (for example), new trees may be constructed. During
> this process, Git constructs the new tree in a struct strbuf, computes
> the OID of the new tree, and checks if the new OID already exists on
> disk. However, in a partial clone, the disk check causes
Eric Sunshine writes:
> On Wed, Sep 4, 2019 at 5:38 PM Johannes Schindelin via GitGitGadget
> wrote:
>> Just like with other Git commands, this option makes it read the paths
>> from the standard input. It comes in handy when resetting many, many
>> paths at once and wildcards are not an option
On 04/09/19 10:43PM, Bert Wesarg wrote:
[snip]
> > > fixed width to avoid creating too wide commit messages. Though
> > > this was
> > > only enforced in the GUI. Now we also check the commit message at commit
> > > time for long lines and ask the author for confirmation if it exceeds the
> > > co
On 04/09/19 09:39PM, Bert Wesarg wrote:
> On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav wrote:
> >
> > On 02/09/19 09:13PM, Bert Wesarg wrote:
[snip]
> >
> > One more observation:
> >
> > If I write a particularly long line (and consequently the scrollbar
> > becomes active), and then hit Ctrl+A t
> On 9/3/2019 3:42 PM, Jonathan Tan wrote:
> > When cherry-picking (for example), new trees may be constructed. During
> > this process, Git checks whether these trees exist. However, in a
> > partial clone, this causes a lazy fetch to occur, which is both
> > unnecessary (because Git has already c
Changes since v5 (full range-diff below):
* Dropped patch 3 (which was rebased on top of js/rebase-r-strategy and
submitted separately)[1]
* Updated t6006 to include both an empty commit message and a commit
message with just a line feed
* Made the two small tweaks Junio suggested to
Test t6006.71 ("oneline with empty message") was creating two commits
with simple commit messages, and then running filter-branch to rewrite
the commit messages to be "empty". This test was introduced in commit
1fb5fdd25f0 ("rev-list: fix --pretty=oneline with empty message",
2010-03-21) and writt
filter-branch suffers from a deluge of disguised dangers that disfigure
history rewrites (i.e. deviate from the deliberate changes). Many of
these problems are unobtrusive and can easily go undiscovered until the
new repository is in use. This can result in problems ranging from an
even messier h
t9902 had a list of three random porcelain commands as a sanity check,
one of which was filter-branch. Since we are recommending people not
use filter-branch, let's update this test to use rebase instead of
filter-branch.
Signed-off-by: Elijah Newren
---
t/t9902-completion.sh | 12 ++--
On 04/09/19 11:39PM, Johannes Sixt wrote:
> Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen:
> > On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
> >> Many keyboards do not have a right Alt-key. That means that Alt+1 to
> >> Alt+4 combinations must be typed single-handed with the left hand
On Wed, Sep 4, 2019 at 5:38 PM Johannes Schindelin via GitGitGadget
wrote:
> Just like with other Git commands, this option makes it read the paths
> from the standard input. It comes in handy when resetting many, many
> paths at once and wildcards are not an option (e.g. when the paths are
> gene
Am 04.09.19 um 21:55 schrieb Bert Wesarg:
> I use my left thumb to press the left Alt key and it does not feel
> mildly awkward. As Alt is also used for the mnemonics, there will
> probably more of mildly awkward key combinations, wont there?
That may well be the case. However, it is the commit me
Hi Denton,
On Wed, 4 Sep 2019, Denton Liu wrote:
> In 554544276a (*.[ch]: remove extern from function declarations using
> spatch, 2019-04-29), we removed externs from function declarations using
> spatch but we intentionally excluded files under compat/ since some are
> directly copied from an u
Hi Denton,
On Wed, 4 Sep 2019, Denton Liu wrote:
> After running Coccinelle on all sources inside compat/ that were created
> by us[1], it was found that compat/mingw.c violated an array.cocci rule
> in two places and, thus, a patch was generated. Apply this patch so that
> all compat/ sources cr
fast-export and fast-import can easily handle the simple rewrite that
was being done by filter-branch, and should be faster on systems with a
slow fork. Measuring the overall time taken for all of t3427 (not just
the difference between filter-branch and fast-export/fast-import) shows
a speedup of
Am 04.09.19 um 21:20 schrieb Birger Skogeng Pedersen:
> On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
>> Many keyboards do not have a right Alt-key. That means that Alt+1 to
>> Alt+4 combinations must be typed single-handed with the left hand. This
>> is mildly awkward for Alt+4. Can we plea
Especially in 3rd-party tools, where the shape of the repository/worktree is
unpredictable, it is a wise thing to have an option to pass pathspec
parameters via stdin rather than via the command line, as the latter has
size restrictions that the former does not have.
Johannes Schindelin (1):
res
From: Johannes Schindelin
Just like with other Git commands, this option makes it read the paths
from the standard input. It comes in handy when resetting many, many
paths at once and wildcards are not an option (e.g. when the paths are
generated by a tool).
Note: we first parse the entire list
Hi Garima,
On Wed, Sep 04, 2019 at 02:25:55PM -0400, Garima Singh wrote:
>
> On 9/3/2019 10:22 PM, Taylor Blau wrote:
> > Hi,
> >
> > I was running some of the new 'git commit-graph' commands, and noticed
> > that I could consistently get 'git commit-graph write --reachable' to
> > segfault when a
Hi Peff,
On Tue, Sep 03, 2019 at 11:04:56PM -0400, Jeff King wrote:
> On Tue, Sep 03, 2019 at 10:22:57PM -0400, Taylor Blau wrote:
>
> > When we write a commit graph chunk, we process a given list of 'struct
> > commit *'s and parse out the parent(s) and tree OID in order to write
> > out its info
Hello Did you Receive my previous email , regarding the proposal ?
On Wed, Sep 04, 2019 at 01:55:03PM -0400, Taylor Blau wrote:
> @@ -68,7 +70,7 @@ if test $# -lt 1; then
> usage >&2
> exit 1
> fi
> -mode=$1; shift
> +mode="$(git config --default "$1" --get -- "alias.$1")"; shift
>
> trap 'rm -f "$tmp"' 0 1 2 3 15
> tmp=`mktemp -t git-jump.XX` |
On Wed, Sep 4, 2019 at 10:31 PM Eric Sunshine wrote:
>
> On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> > While the commit message widget has a configurable fixed width, it
> > nevertheless allows to write commit messages which exceed this limit.
> > Though it does not show this content beca
On Wed, Sep 4, 2019 at 10:30 PM Eric Sunshine wrote:
>
> On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> > The commit message widget does not wrap the next and has a configurable
>
> s/next/text/
fixed
>
> > fixed width to avoid creating too wide commit messages. Though this was
> > only en
On Tue, Sep 3, 2019 at 3:46 PM Junio C Hamano wrote:
>
> Junio C Hamano writes:
>
> > Elijah Newren writes:
> >
> >> +extract_files_subtree () {
> >> +git fast-export --no-data HEAD -- files_subtree/ |
> >> +sed -e "s%\([0-9a-f]\{40\} \)files_subtree/%\1%" |
> >> +git
On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> While the commit message widget has a configurable fixed width, it
> nevertheless allows to write commit messages which exceed this limit.
> Though it does not show this content because there is not scrollbar for
> this widget. No it is.
"No it
On Tue, Sep 3, 2019 at 2:40 PM Junio C Hamano wrote:
>
> Elijah Newren writes:
>
> > diff --git a/git-filter-branch.sh b/git-filter-branch.sh
> > index 5c5afa2b98..f805965d87 100755
> > --- a/git-filter-branch.sh
> > +++ b/git-filter-branch.sh
> > @@ -83,6 +83,19 @@ set_ident () {
> > finis
On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg wrote:
> The commit message widget does not wrap the next and has a configurable
s/next/text/
> fixed width to avoid creating too wide commit messages. Though this was
> only enforced in the GUI. Now we also check the commit message at commit
> time for
On Tue, Sep 3, 2019 at 11:04 AM Derrick Stolee via GitGitGadget
wrote:
>
> The exclude library defined in dir.h was originally written for the
> .gitignore feature, but has since been used for .gitattributes and
> sparse-checkout. In the later applications, these patterns are used for
> inclusion
On Tue, Sep 3, 2019 at 11:04 AM Derrick Stolee via GitGitGadget
wrote:
>
> From: Derrick Stolee
>
> The first consumer of pattern-matching filenames was the
> .gitignore feature. In that context, storing a list of patterns
> as a 'struct exclude_list' makes sense. However, the
> sparse-checkout
For some context: Documentation/MyFirstContribution.txt was added
recently by peff (https://github.com/git/git-scm.com/pull/1362) and
can be seen at https://git-scm.com/docs/MyFirstContribution
But tbh I don't see how to reach to that page, there may be something
failing while indexing:
https://gi
The commit message widget does not wrap the next and has a configurable
fixed width to avoid creating too wide commit messages. Though this was
only enforced in the GUI. Now we also check the commit message at commit
time for long lines and ask the author for confirmation if it exceeds the
configur
While the commit message widget has a configurable fixed width, it
nevertheless allows to write commit messages which exceed this limit.
Though it does not show this content because there is not scrollbar for
this widget. No it is.
There seems to be a bug in at least up to Tcl/Tk 8.6.8, which does
Dear Hannes,
On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
>
> Am 04.09.19 um 16:30 schrieb Birger Skogeng Pedersen:
> > The user cannot change focus between the list of files, the diff view and
> > the commit message widgets without using the mouse (clicking either of
> > the four widgets)
On Tue, Sep 03, 2019 at 09:59:13PM -0300, Matheus Tavares Bernardino wrote:
> > It may be interesting to add a link on
> > https://git-scm.com/community, what do you think @peff ?
>
> Nice :) I think a link to `Documentation/MyFirstContribution.txt`
> could also be added to the "Contributing to G
On Tue, Aug 27, 2019 at 01:17:57AM -0400, Jeff King wrote:
> Do we have interested mentors for the next round of Outreachy?
>
> The deadline for Git to apply to the program is September 5th. The
> deadline for mentors to have submitted project descriptions is September
> 24th. Intern applications
On Tue, Sep 3, 2019 at 7:15 PM Pratyush Yadav wrote:
>
> On 02/09/19 09:13PM, Bert Wesarg wrote:
> > On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg
> > wrote:
> > >
> [snip]
> > > > On second thought, wouldn't it make more sense to expand the
> > > > commit
> > > > message buffer instead? The point
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with
FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you
regarding an extremely important and urgent matter. If you would oblige me the
opportunity, I shall provide you with details upon your respons
Hi Johannes,
On Wed, Sep 4, 2019 at 8:59 PM Johannes Sixt wrote:
> Many keyboards do not have a right Alt-key. That means that Alt+1 to
> Alt+4 combinations must be typed single-handed with the left hand. This
> is mildly awkward for Alt+4. Can we please have the very important
> commit widget *n
On Wed, Sep 4, 2019 at 8:52 PM Johannes Sixt wrote:
>
> Am 04.09.19 um 19:46 schrieb Pratyush Yadav:
> > On 04/09/19 08:24AM, Johannes Sixt wrote:
> >> That is worth a try. The check box title offers a natural hotkey then:
> >> "_A_mend last commit", Alt-a.
> >
> > Right now, the binding proposed
Am 04.09.19 um 16:30 schrieb Birger Skogeng Pedersen:
> The user cannot change focus between the list of files, the diff view and
> the commit message widgets without using the mouse (clicking either of
> the four widgets).
>
> With this patch, the user may set ui focus to the previously selected
On Wed, Sep 4, 2019 at 7:36 PM Pratyush Yadav wrote:
>
> On 04/09/19 07:58AM, Birger Skogeng Pedersen wrote:
> > Hi Pratyush,
> >
> >
> > So how does this work? Should I email the patch that Bert has created?
> > Or is it okay that it just remains on Github. (Considering the git
> > mail archives)
Am 04.09.19 um 19:46 schrieb Pratyush Yadav:
> On 04/09/19 08:24AM, Johannes Sixt wrote:
>> That is worth a try. The check box title offers a natural hotkey then:
>> "_A_mend last commit", Alt-a.
>
> Right now, the binding proposed is Ctrl-e. My mental model for the key
> bindings as of now is h
On 9/3/2019 10:22 PM, Taylor Blau wrote:
Hi,
I was running some of the new 'git commit-graph' commands, and noticed
that I could consistently get 'git commit-graph write --reachable' to
segfault when a commit's root tree is corrupt.
I have an extremely-unfinished fix attached as an RFC PATCH
Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
Signed-off-by: Bert Wesarg
---
git-gui.sh | 40 +++-
1
Hi,
I have been meaning to send this patch for a while, which teaches the
'git-jump' script how to respect user aliases for commands like 'diff',
'merge', and 'grep'.
I often find myself parsing the output of 'git diff' (which I spell 'g
di') in less, and then wanting to jump to some specific dif
When a caller of 'git-jump' has, say, the alias 'di' assigned to 'diff',
it can be cumbersome to remember to type 'git jump diff' instead of the
shorthand '... di' that they are used to.
Let's teach 'git-jump' to expand these aliases before calling the
mode-specific subroutine. Do so by fetching t
Hi,
You could argue that A (as in "amend") makes quite an intuitive hotkey.
But personally I'm also leaning towards CTRL/CMD+E. The ALT+(letter)
combination is used to open a menu, for instance ALT+R opens
"Repository", ALT+E opens "Edit", etc. That's the behaviour on
Windows, anyways. So the hotk
On 04/09/19 08:24AM, Johannes Sixt wrote:
> Am 03.09.19 um 14:45 schrieb Pratyush Yadav:
> > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it
> > immediately takes me to the "Amend last commit" option. Then I can press
> > space to select it and Tab again to get back to the
On 04/09/19 07:58AM, Birger Skogeng Pedersen wrote:
> Hi Pratyush,
>
>
> So how does this work? Should I email the patch that Bert has created?
> Or is it okay that it just remains on Github. (Considering the git
> mail archives)
I think it would be a good idea to send it on the list once before
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with
FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you
regarding an extremely important and urgent matter. If you would oblige me the
opportunity, I shall provide you with details upon your respons
The user cannot change focus between the list of files, the diff view and
the commit message widgets without using the mouse (clicking either of
the four widgets).
With this patch, the user may set ui focus to the previously selected path
in either the "Unstaged Changes" or "Staged Changes" widget
On 04/09/19 07:42AM, Birger Skogeng Pedersen wrote:
> Hi Pratyush,
>
>
> Just wanted to chime in on this one:
>
> On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
> > On second thought, wouldn't it make more sense to expand the commit
> > message buffer instead? The point of resizing that p
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with
FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you
regarding an extremely important and urgent matter. If you would oblige me the
opportunity, I shall provide you with details upon your respons
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with
FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you
regarding an extremely important and urgent matter. If you would oblige me the
opportunity, I shall provide you with details upon your respons
Hi Junio,
I see that "dl/format-patch-doc-test-cleanup" currently has the comment
"Expecting a reroll." This should be the reroll that you're expecting ;)
Also, since there haven't been any comments on the topic in a while, I
propose that it should be ready for inclusion.
Thanks,
Denton
On Tue
In 554544276a (*.[ch]: remove extern from function declarations using
spatch, 2019-04-29), we removed externs from function declarations using
spatch but we intentionally excluded files under compat/ since some are
directly copied from an upstream and we should avoid churning them so
that manually
After running Coccinelle on all sources inside compat/ that were created
by us[1], it was found that compat/mingw.c violated an array.cocci rule
in two places and, thus, a patch was generated. Apply this patch so that
all compat/ sources created by us follows all cocci rules.
[1]: Do not run Cocci
Sources under compat/ were excluded from cleanup using spatch since some
of them were taken from an upstream and we didn't want to modify them so
that merging in future updates would be simpler. However, most of the
files in compat/ were created by us so it should be safe to apply
cleanup to those
On 8/25/2019 1:44 PM, René Scharfe wrote:
Let warning() format the message instead of using an intermediate strbuf
for that. This is shorter, easier to read and avoids an allocation.
Signed-off-by: René Scharfe
---
trace2/tr2_dst.c | 9 ++---
1 file changed, 2 insertions(+), 7 deleti
On Thu, Aug 29, 2019 at 01:33:36PM -0400, randall.s.bec...@rogers.com wrote:
> I don't know whether this is new behaviour following changes to stash, but
> here goes.
>
> Suppose I have files a,b,c,d modified, but only file d is in the index.
> After stash push (or save) --include-untracked, sta
70 matches
Mail list logo
