Hi Johannes, hello Thomas,
Currently, I'm approaching a release deadline and there are some tasks with
higher priority waiting for me and creating a MCVE takes some time. Creating
the stacktrace and ensuring I don't leak proprietary code also takes more time
than I can currently afford.
In two
On Mon, Sep 2, 2019 at 10:15 PM Bert Wesarg wrote:
> does Control-Tab works for traversal?
Bert,
Control+Tab works for traversal, but as a means to toggle new/amend
it's very tedious. I have to press Ctrl+Tab 9 times to select "new"
and 10 times to select "Amend"(!). Then 1 or 2 more times to g
Hi, everyone
I've been writing a blog post based on what I learned during GSoC to
help other students here at FLUSP[1] start contributing as well.
In the meantime `Documentation/MyFirstContribution.txt` was released,
so I've pointed my interested colleagues to it. But since I was
already pretty c
Instead of waiting for a non-trivial GC command to write the commit-graph,
write one during 'git fetch'. By using the equivalent method for 'git
commit-graph write --split --reachable', we create a commit-graph chain that
includes all reachable commits. Most of the time, these writes only add the
n
From: Derrick Stolee
The commit-graph feature is now on by default, and is being
written during 'git gc' by default. Typically, Git only writes
a commit-graph when a 'git gc --auto' command passes the gc.auto
setting to actualy do work. This means that a commit-graph will
typically fall behind th
Hi Junio,
On Mon, Sep 02, 2019 at 06:21:33PM -0700, Junio C Hamano wrote:
> "brian m. carlson" writes:
>
> > I like the idea of using existing tooling for this and not needing an
> > additional verb.
> >
> > My gut tells me folks may want a bit more control over *which* branches
> > are rebased,
"brian m. carlson" writes:
> I like the idea of using existing tooling for this and not needing an
> additional verb.
>
> My gut tells me folks may want a bit more control over *which* branches
> are rebased, but I don't have a personal need for that, so I'm not going
> to request it or propose a
On Tue, 3 Sep 2019 at 04:11, Bert Wesarg wrote:
> On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen
> wrote:
> > On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
> > wrote:
> > > In my pursuit to fully utilize git-gui with only using a keyboard, I
> > > suggest that there is a ho
On 2019-09-02 at 23:41:08, Warren He wrote:
> Sometimes people have to rebase multiple related branches. One way to do that
> quickly, when there are branches pointing to ancestors of a later branch
> (which
> happens a lot if you try hard to pad your PR count on GitHub--I mean if you
> try
> to
Rebasing normally updates the current branch to the rewritten version.
If any other branches point to commits rewritten along the way, those
remain untouched. This commit adds an `--update-branches` option, which
instructs the command to update any such branches that it encounters to
point to the r
Sometimes people have to rebase multiple related branches. One way to do that
quickly, when there are branches pointing to ancestors of a later branch (which
happens a lot if you try hard to pad your PR count on GitHub--I mean if you try
to make small, logically separate changes), is to rebase that
Hi Elijah,
On Sat, 17 Aug 2019, Elijah Newren wrote:
> * t3030-merge-recursive.h: this test has always been broken in that it
> didn't make sure to make index match head before running. But, it
> didn't care about the index or even the merge result, just the
> verbose output while
When applying multiple patches with git am, or when rebasing using the
am backend, it's possible that one of our patches has updated a
gitattributes file. Currently, we cache this information, so if a
file in a subsequent patch has attributes applied, the file will be
written out with the attribute
We have a function to strip the path suffix from a commit, but we don't
have one to check for a path suffix. For a plain filename, we can use
basename, but that requires an allocation, since POSIX allows it to
modify its argument. Refactor strip_path_suffix into a helper function
and a new function
This series makes rebase --am honor the .gitattributes file for
subsequent patches when a patch changes it.
Changes from v5:
* Avoid leaking memory from already parsed filter rules.
Changes from v4:
* Wrap lines in apply.c.
* Handle merge and conflict-marker-size attributes.
* Add tests for am an
On 02/09/2019 22:47, Matt Rogers wrote:
I can redo the commit, I had thought that I had previously fixed the
author but I guess I was mistaken.
As for issues with non utf-8 encodings, I don't know of any simple way
to check for those except for restricting to asci alphanumeric characters
If
On 02/09/2019 19:29, Junio C Hamano wrote:
I see there are "lets make sure it is unique by suffixing "-%d" in
other codepaths; would that help if this piece of code yields a
label that is not unique?
maybe use a trailing 4 characters of the oid to get a reasonably unique
label?
Oh, just seen
On Mon, Sep 2, 2019 at 10:12 PM Bert Wesarg wrote:
>
> On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen
> wrote:
> >
> > Hi Bert,
> >
> >
> > On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg
> > wrote:
> > > I think with your "focus" patch, this is not needed anymore:
> > >
> > > After focusing
On 2019-09-02 at 18:29:56, Junio C Hamano wrote:
> Phillip Wood writes:
>
> > Being picking I'll point out that ':' is not a valid in refs
> > either. Looking at
> > https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file I
> > think only " and | are not allowed on NTFS/FAT but are va
On Mon, Sep 2, 2019 at 9:49 PM Birger Skogeng Pedersen
wrote:
>
> Hi Bert,
>
>
> On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote:
> > I think with your "focus" patch, this is not needed anymore:
> >
> > After focusing the commit message widget, you can focus the radio
> > buttons with Tab/Shift+
Selecting whether to do a "New Commit" or "Amend Last Commit" does not have
a hotkey.
With this patch, the user may toggle between the two options with
CTRL/CMD+e.
Signed-off-by: Birger Skogeng Pedersen
---
git-gui.sh | 11 +++
1 file changed, 11 insertions(+)
diff --git a/git-gui.sh b
On Mon, 02 Sep 2019 12:25:37 -0700
Junio C Hamano wrote:
> Jeff King writes:
>
> > But it still risks losing a case where some code path relies on the crud
> > cleanup for odd cases (mismatched delimiters, or interleaved delimiters,
> > or non-delimiter crud mixed in with delimiters).
> > ...
>
Hi Bert,
On Mon, Sep 2, 2019 at 8:08 PM Bert Wesarg wrote:
> I think with your "focus" patch, this is not needed anymore:
>
> After focusing the commit message widget, you can focus the radio
> buttons with Tab/Shift+Tab and press Space.
>
> I think this is short enough, so that wasting a Letter
Hi Phillip,
On Mon, 2 Sep 2019, Phillip Wood wrote:
> This is definitely worth fixing, I've got a couple of comments below
>
> On 02/09/2019 15:01, Matt R via GitGitGadget wrote:
> > From: Matt R
I just noticed that the surname is abbreviated. The full name of the
author is "Matt Rogers". (Matt
On Sun, Sep 1, 2019 at 9:37 PM Birger Skogeng Pedersen
wrote:
>
> The user cannot change focus between the list of files, the diff view and
> the commit message widgets without using the mouse (clicking either of
> the four widgets).
>
> With this patch, the user may set ui focus to the previously
Bert,
Works great now. Thanks a lot for fixing this!
Birger
Jeff King writes:
> But it still risks losing a case where some code path relies on the crud
> cleanup for odd cases (mismatched delimiters, or interleaved delimiters,
> or non-delimiter crud mixed in with delimiters).
> ...
> So I dunno. There is no patch to be discussed, and I am not volunteeri
On Mon, Sep 2, 2019 at 9:03 PM Bert Wesarg wrote:
>
> On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
> >
> > On 03/09/19 12:14AM, Pratyush Yadav wrote:
> > > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> > > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg
> > > > wrote:
> > > > > I c
Ah, sorry I misunderstood you.
Thanks,
Birger
On Mon, Sep 2, 2019 at 8:58 PM Pratyush Yadav wrote:
>
> On 03/09/19 12:14AM, Pratyush Yadav wrote:
> > On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> > > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg
> > > wrote:
> > > > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6:
> >
On 03/09/19 12:14AM, Pratyush Yadav wrote:
> On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> > On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg
> > wrote:
> > > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6:
> > >
> > > https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ
> >
> > On Mon
On 02/09/19 08:35PM, Birger Skogeng Pedersen wrote:
> On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote:
> > You missed removing this extra blank line. Will fix it up locally.
> >
> > > + set _index $file_lists_last_clicked($widget)
> > [snip]
>
>
> To be honest I felt the blank li
On Mon, Sep 2, 2019 at 7:58 PM Bert Wesarg wrote:
> up to now, git-gui does not hide any scrollbars, if they are not
> needed. IMHO, I would keep it that way, as I don't like the flicker
> when it appears and disappears. Imagine you are typing in the bottom
> line and than you typed too much. The
On 02/09/19 08:22PM, Birger Skogeng Pedersen wrote:
> On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg wrote:
> > I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6:
> >
> > https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ
>
> On Mon, Sep 2, 2019 at 8:12 PM Pratyush Yadav wrote:
> > Hmm, it lo
On Mon, Sep 2, 2019 at 8:19 PM Pratyush Yadav wrote:
> You missed removing this extra blank line. Will fix it up locally.
>
> > + set _index $file_lists_last_clicked($widget)
> [snip]
To be honest I felt the blank line there was appropriate, in an
attempt to follow the same code styl
Phillip Wood writes:
> Being picking I'll point out that ':' is not a valid in refs
> either. Looking at
> https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file I
> think only " and | are not allowed on NTFS/FAT but are valid in refs
> (see the man page for git check-ref-format for
On Mon, Sep 2, 2019 at 8:05 PM Bert Wesarg wrote:
> I cannot test windows easily, it looks good on Linux Tcl /Tk 8.6:
>
> https://kgab.selfhost.eu/s/f38GX4caCZBj4mZ
On Mon, Sep 2, 2019 at 8:12 PM Pratyush Yadav wrote:
> Hmm, it looks fine for me. Which platform are you using? I am running it
> o
Hi Birger,
Other than a minor change that I can do locally, this looks good. I'll
test it a bit and then merge it. Thanks.
On 01/09/19 09:36PM, Birger Skogeng Pedersen wrote:
[snip]
> +proc select_path_in {widget} {
> + global file_lists last_clicked selected_paths ui_workdir
> + global
> -Original Message-
> From: Philip Oakley
> Sent: September 2, 2019 11:56 AM
> To: 002901d55e8f$e4a4af70$adee0e50$@rogers.com;
> randall.s.bec...@rogers.com
> Cc: git@vger.kernel.org
> Subject: Re: [BUG} stash show does not show untracked files stashed
> (reposted)
>
> On 02/09/2019 14:0
On 02/09/19 07:04PM, Birger Skogeng Pedersen wrote:
> Hi Bert,
>
>
> Thanks for picking this up.
> I just gave your patch a go, and I think there are a couple of issues.
>
>
> Applying the patch yields:
>
> $ git apply patch1.patch
> patch1.patch:18: indent with spaces.
>-yscrollcomman
Birger,
On Mon, Sep 2, 2019 at 6:25 PM Birger Skogeng Pedersen
wrote:
>
> I just now realized what a terrible suggestion CTRL+Z was.
> I propose CTRL/CMD+E to toggle between amend/new commit.
>
> On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
> wrote:
> >
> > In my pursuit to fully uti
On 08/20, Filippo Valsorda wrote:
> When used in a repository cloned with --mirror, git push with refs on
> the command line deletes all unmentioned refs.
>
> This was investigated by @saleemrash1d on Twitter. I'm reporting
> their findings here and a reproduction below.
>
> > seems to be a regre
On Mon, Sep 2, 2019 at 7:35 PM Junio C Hamano wrote:
>
> Bert Wesarg writes:
>
> > the old reasoning was, that you should not create commit messages
> > which are too wide.
>
> True, and that reasoning would justify hiding scrollbar when not
> necessary to gain vertical space. Can we arrange the
Hi Matt
This is definitely worth fixing, I've got a couple of comments below
On 02/09/2019 15:01, Matt R via GitGitGadget wrote:
From: Matt R
The `label` todo command in interactive rebases creates temporary refs
in the `refs/rewritten/` namespace. These refs are stored as loose refs,
i.e. as
On Sat, Aug 24, 2019 at 1:40 AM Elijah Newren wrote:
> My $0.02: I think `git worktree add` should not only adopt the setting
> of core.sparseCheckout from the current worktree, but it should also
> adopt the $GIT_DIR/info/sparse-checkout file too.
As another example in favor of imbuing "git work
Bert Wesarg writes:
> the old reasoning was, that you should not create commit messages
> which are too wide.
True, and that reasoning would justify hiding scrollbar when not
necessary to gain vertical space. Can we arrange the scrollbar to
appear only when needed?
Ben writes:
>> As long as you make it clear that you are 100% happy with the
>> fixed-up result that appeared in 'pu', there is no need to resend
>> (if you want to make any other changes, I do want to avoid me
>> screwing up by listening to you and hand applying those changes; I'd
>> rather want
On 02/09/2019 13:25, Pratyush Yadav wrote:
On 01/09/19 11:27PM, Philip Oakley wrote:
Hi Pratyus,
On 01/09/2019 12:32, Pratyush Yadav wrote:
Hi Birger,
In case you haven't been following the list, Pat has been inactive
recently, so I am acting as the interim maintainer of git-gui for now,
becau
On 08/30, Junio C Hamano wrote:
> Martin Ågren writes:
>
> > There's a difference in behavior that I'm not sure about: We used
> > to ignore the return value of `refresh_cache()`, i.e. we didn't care
> > whether it had any errors. I have no idea whether that's safe to do --
> > especially as we g
Hi Bert,
Thanks for picking this up.
I just gave your patch a go, and I think there are a couple of issues.
Applying the patch yields:
$ git apply patch1.patch
patch1.patch:18: indent with spaces.
-yscrollcommand {.vpane.lower.commarea.buffer.frame.sby set} \
patch1.patch:19: indent wit
I just now realized what a terrible suggestion CTRL+Z was.
I propose CTRL/CMD+E to toggle between amend/new commit.
On Sat, Aug 31, 2019 at 12:51 PM Birger Skogeng Pedersen
wrote:
>
> In my pursuit to fully utilize git-gui with only using a keyboard, I
> suggest that there is a hotkey to toggle b
On 02/09/2019 14:01, Giuseppe Crinò wrote:
Suppose I have files a,b,c,d modified, but only file d is in the index.
After stash push (or save) --include-untracked, stash show only displays
file d. A subsequent pop will restore files a,b,c,d. So functionally push
and pop are fine, but stash show a
On Sun, Sep 01, 2019 at 01:07:44PM +0200, Reino Wijnsma wrote:
> git clone https://github.com/mstorsjo/fdk-aac.git
> [...]
>
> git describe --tags
> v2.0.0-185-gcc5c85d
>
> git clone --depth 1 https://github.com/mstorsjo/fdk-aac.git
>
> git describe --tags
> fatal: No names found, cannot descri
Hi Reino
On 01/09/2019 12:07, Reino Wijnsma wrote:
Hello git@vger.kernel.org,
Two days ago I started https://github.com/mstorsjo/fdk-aac/issues/107, asking
how to retrieve the fdk-aac version-string on a shallow clone.
My question was of course not fdk-aac related, so Martin Storsjö suggested
On Sat, Aug 31, 2019 at 01:17:48PM +, Giuseppe Crinò wrote:
> On Mon, Aug 26, 2019 at 03:14:55PM -0400, Jeff King wrote:
> > We'd still want to keep the low-level removal of "<>\n", since those are
> > syntactically significant to Git (i.e., if they sneak in you end up with
> > a broken commit
Hi Elijah,
On Thu, 29 Aug 2019, Elijah Newren wrote:
> Despite only being one piece of the 71st test and there being 73 tests
> overall, this small change to just this one test speeds up the overall
> execution time of t6006 (as measured by the best of 3 runs of `time
> ./t6006-rev-list-format.sh
Hi Elijah,
On Thu, 29 Aug 2019, Elijah Newren wrote:
> fast-export and fast-import can easily handle the simple rewrite that
> was being done by filter-branch, and should be significantly faster on
> systems with a slow fork. Timings from before and after on two laptops
> that I have access to (
> I'd figure one of these options would be to clone everything from tag
> v2.0.0 onward, but if so how would I do that?
> As another option I was thinking; maybe it's possible to do git describe
> --tags on the remote repo?
To my understanding both questions are solved by
* https://stackoverflow
Those labels must be valid ref names, and therefore valid file names.
This just came in via Git for Windows.
Matt R (1):
rebase -r: let `label` generate safer labels
sequencer.c | 12 +++-
t/t3430-rebase-merges.sh | 5 +
2 files changed, 16 insertions(+), 1 deletion(
From: Matt R
The `label` todo command in interactive rebases creates temporary refs
in the `refs/rewritten/` namespace. These refs are stored as loose refs,
i.e. as files in `.git/refs/rewritten/`, therefore they have to conform
with file name limitations on the current filesystem.
This poses a
Hi Eric,
On Fri, 30 Aug 2019, Eric Wong wrote:
> Johannes Schindelin wrote:
> >
> > On Tue, 27 Aug 2019, Derrick Stolee wrote:
> >
> > > On 8/25/2019 10:43 PM, Eric Wong wrote:
> > > > C compilers do type checking to make life easier for us. So
> > > > rely on that and update all hashmap_entry_
> Suppose I have files a,b,c,d modified, but only file d is in the index.
> After stash push (or save) --include-untracked, stash show only displays
> file d. A subsequent pop will restore files a,b,c,d. So functionally push
> and pop are fine, but stash show appears to ignores files in the stash.
On 01/09/19 11:27PM, Philip Oakley wrote:
> Hi Pratyus,
> On 01/09/2019 12:32, Pratyush Yadav wrote:
> > Hi Birger,
> >
> > In case you haven't been following the list, Pat has been inactive
> > recently, so I am acting as the interim maintainer of git-gui for now,
> > because no one else stepped
Hi Birger,
On Mon, Sep 2, 2019 at 11:13 AM Birger Skogeng Pedersen
wrote:
>
> Hi,
>
> I just noticed that long lines in the commit message widget does in
> fact not show a horizontal scrollbar.
> So if a line in the commit message is more than 75 characters, it gets
> a bit confusing.
> Should it
Cher utilisateur,
Dans le cadre de nos messages de sécurité, nous mettons régulièrement à jour
toutes les adresses électroniques dans notre système de base de données. Nous
ne pouvons pas mettre à jour votre adresse électronique. Par conséquent, nous
allons suspendre temporairement votre accès
Hi Elijah,
On Fri, 30 Aug 2019, Elijah Newren wrote:
> On Fri, Aug 30, 2019 at 1:40 PM Johannes Schindelin
> wrote:
>
> > [...]
> > In my most recent instance of this, I wanted to publish the script I
> > used to use for submitting patch series to the Git mailing list,
> > maintaining tags for i
Hi,
I just noticed that long lines in the commit message widget does in
fact not show a horizontal scrollbar.
So if a line in the commit message is more than 75 characters, it gets
a bit confusing.
Should it not have a scrollbar?
Example shown here: https://i.imgur.com/I3d6nBJ.png
Hello there,
I am trying to migrate from SVN to GIT. I have a custom layout. The
thing is that a have several tags created from branches of trunk. But
the code of those branches can not be merged into trunk. When using
"git-svn" branches are migrated with no problem, but not the tags
created from
Cher utilisateur,
Dans le cadre de nos messages de sécurité, nous mettons régulièrement à jour
toutes les adresses électroniques dans notre système de base de données. Nous
ne pouvons pas mettre à jour votre adresse électronique. Par conséquent, nous
allons suspendre temporairement votre accès
Hi dear,
I'm Capt Katie Higgins, from the United States,please i wish to have a
communication with you.
I am waiting for your answer,
Capt Katie Higgins.
Hi!
Reading the (somewhat older) manual page GIT-STASH(1) for "show" I found:
show []
Show the changes recorded in the stash as a diff between the
stashed state and its original parent. When no is given,
shows the latest one. By default, the command shows
71 matches
Mail list logo
