Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Philip Oakley
Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork

[PATCH] [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
The user cannot change focus between the list of files, the diff view and the commit message widgets without using the mouse (clicking either of the four widgets). With this patch, the user may set ui focus to the previously selected path in either the "Unstaged Changes" or "Staged Changes" widget

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Bert, > But I don't understand this in full. Does this mean pressing CTRL+1 or > +2 does also changes the file selection? Why isn't it sufficient to > just focus the respective file list widget? And than have bindings to > change the selection? > > Bert I don't think it's feasible to focus

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > > + > > +proc select_first_unstaged_changes_path {} { > > + global ui_workdir > > + select_first_path $ui_workdir > > +} > > + > > +proc select_first_staged_changes_path {} { > > + global ui_index > > + select_first_path $ui_in

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Bert Wesarg
Hi Birger, On Sat, Aug 31, 2019 at 2:23 PM Birger Skogeng Pedersen wrote: > > The user cannot change focus between the list of files, the diff view and > the commit message widgets without using the mouse (clicking either of > the four widgets ). that bugged me two, but never come up with a good

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Birger Skogeng Pedersen
Hello Pratyush, (New patch according to our discussion coming up) On Sun, Sep 1, 2019 at 1:32 PM Pratyush Yadav wrote: > In case you haven't been following the list, Pat has been inactive > recently, so I am acting as the interim maintainer of git-gui for now, > because no one else stepped up

Re: [PATCH v6 1/2] builtin/rebase.c: make sure the active branch isn't moved when autostashing

2019-09-01 Thread Ben
On 01-09-2019 18:01, Junio C Hamano wrote: > Ben writes: > >> >> Would you like me to send in another patch or leave it like this? > > As long as you make it clear that you are 100% happy with the > fixed-up result that appeared in 'pu', there is no need to resend > (if you want to make any o

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Junio C Hamano
Pratyush Yadav writes: > ... I am acting as the interim maintainer of git-gui for now, > ... > You can find my fork over at https://github.com/prati0100/git-gui. I am aware of three topics (call-do-quit-before-exit, reload-config and revert-hunks-lines) of your own, plus your 'master' over ther

Re: [PATCH v6 1/2] builtin/rebase.c: make sure the active branch isn't moved when autostashing

2019-09-01 Thread Junio C Hamano
Ben writes: > On 30-08-2019 22:15, Junio C Hamano wrote: >> Ben Wijen writes: >> >>> + >>> struct commit *head = >>> - lookup_commit_reference(the_repository, >>> - &options.orig_head); >>> +

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Pratyush Yadav
Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui for now, because no one else stepped up and Junio would rather not maintain it. You can find my fork over at https://github.com/prati0100/git-gui. I munge

interested in your products

2019-09-01 Thread Selfridges & Co
Dear Sir/Madam, We are looking to buy your products and partner with your company, can you please send us your Catalog or your website to learn more about your products or prices list by email and if we can make some order with you and start a long-term partnership. Can your company supply u

Retrieve version-string on shallow clone

2019-09-01 Thread Reino Wijnsma
Hello git@vger.kernel.org, Two days ago I started https://github.com/mstorsjo/fdk-aac/issues/107, asking how to retrieve the fdk-aac version-string on a shallow clone. My question was of course not fdk-aac related, so Martin Storsjö suggested I'd try here. It basicly comes down to this: git clo