Re: [PATCH v2 0/4] git-gui: Add ability to revert selected hunks and lines

2019-08-23 Thread Bert Wesarg
On Sat, Aug 24, 2019 at 1:43 AM David Aguilar wrote: > > I have a very strong opinion about the confirmation dialog, so I'll just > mention that here since Hannes is on this thread. > > In cola we do have a confirmation dialog, and I strongly believe this is > the correct behavior because it's an

Re: [PATCH v2 0/4] git-gui: Add ability to revert selected hunks and lines

2019-08-23 Thread Bert Wesarg
On Sat, Aug 24, 2019 at 1:43 AM David Aguilar wrote: > > On Fri, Aug 23, 2019 at 03:31:03AM +0530, Pratyush Yadav wrote: > > Hi, > > > > This series adds the ability to revert selected lines and hunks in > > git-gui. Partially based on the patch by Bert Wesarg [0]. > > > > The commits can be found

Re: [PATCH 0/9] [RFC] New sparse-checkout builtin and "cone" mode

2019-08-23 Thread Elijah Newren
On Thu, Aug 22, 2019 at 6:10 AM Derrick Stolee wrote: > > On 8/21/2019 5:52 PM, Elijah Newren wrote: > > On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget > > wrote: > >> Here are some more specific details: > >> > >> * git sparse-checkout init enables core.sparseCheckout and pop

Re: [PATCH 9/9] sparse-checkout: init and add in cone mode

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget wrote: > Perhaps "sparse-checkout: modify 'init' and 'add' for cone mode" for the summary? > From: Derrick Stolee > > To make the cone pattern set easy to use, update the behavior of > 'git sparse-checkout [init|add]'. Maybe switc

Re: [PATCH 8/9] sparse-checkout: use hashmaps for cone patterns

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The parent and recursive patterns allowed by the "cone mode" > option in sparse-checkout are restrictive enough that we > can avoid using the regex parsing. Everything is based on > prefix matches,

LOAN

2019-08-23 Thread Morgan Leo
-- Hello Do you need personal loan? Does your firm,company or industry need financial assistance? Do you need finance to start your business? Do you need finance to expand your business? We give out loan to interested individuals who are seeking loan with good faith. Are you seriously in need of

[Question] clone performance

2019-08-23 Thread randall.s.becker
Hi All, I'm trying to answer a question for a customer on clone performance. They are doing at least 2-3 clones a day, of repositories with about 2500 files and 10Gb of content. This is stressing the file system. I have tried to convince them that their process is not reasonable and should stick w

What's cooking in git.git (Aug 2019, #06; Fri, 23)

2019-08-23 Thread Junio C Hamano
Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The tip of 'next' has been rewound

Re: [PATCH 7/9] sparse-checkout: add 'cone' mode

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:13 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The sparse-checkout feature can have quadratic performance as > the number of patterns and number of entries in the index grow. > If there are 1,000 patterns and 1,000,000 entries, this time can >

Re: [PATCH 6/9] trace2:experiment: clear_ce_flags_1

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:12 AM Jeff Hostetler via GitGitGadget wrote: > > From: Jeff Hostetler Can the commit summary be turned into English? > The clear_ce_flags_1 method is used by many types of calls to > unpack_trees(). Add trace2 regions around the method, including > some flag informatio

Re: [PATCH 5/9] sparse-checkout: create 'disable' subcommand

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:14 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The instructions for disabling a sparse-checkout to a full > working directory are complicated and non-intuitive. Add a > subcommand, 'git sparse-checkout disable', to perform those > steps for the

Re: [PATCH v2 0/4] git-gui: Add ability to revert selected hunks and lines

2019-08-23 Thread David Aguilar
On Fri, Aug 23, 2019 at 03:31:03AM +0530, Pratyush Yadav wrote: > Hi, > > This series adds the ability to revert selected lines and hunks in > git-gui. Partially based on the patch by Bert Wesarg [0]. > > The commits can be found in the topic branch 'py/revert-hunks-lines' > at https://github.com

Re: [PATCH 4/9] sparse-checkout: 'add' subcommand

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > The 'git sparse-checkout add' subcommand takes a list of patterns > over stdin and writes them to the sparse-checkout file. Then, it > updates the working directory using 'git read-tree -mu HEAD'.

Re: [PATCH 3/9] clone: add --sparse mode

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:12 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > When someone wants to clone a large repository, but plans to work > using a sparse-checkout file, they either need to do a full > checkout first and then reduce the patterns they included, or > clo

Re: [PATCH 2/9] sparse-checkout: create 'init' subcommand

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:13 AM Derrick Stolee via GitGitGadget wrote: > > From: Derrick Stolee > > Getting started with a sparse-checkout file can be daunting. Help > users start their sparse enlistment using 'git sparse-checkout init'. > This will set 'core.sparseCheckout=true' in their config,

Re: [PATCH 1/9] sparse-checkout: create builtin with 'list' subcommand

2019-08-23 Thread Elijah Newren
On Tue, Aug 20, 2019 at 8:13 AM Derrick Stolee via GitGitGadget wrote: > The documentation provided is adapted from the "git read-tree" > documentation with a few edits for clarity in the new context. > Extra sections are added to hint toward a future change to > a moer restricted pattern set. s

[Feature Request] Option to make .git not read-only in cloned repos

2019-08-23 Thread Albert Vaca Cintora
Hi git folks, Honestly I'm not aware of the reason behind .git being read-only, but I'm sure there is one. However, I'm sure that a large percentage of developers out there will agree with me that having to use force (-f) to delete every cloned repo is annoying, and even worse, it creates the bad

Re: [PATCH v3 00/13] format-patch: learn --infer-cover-subject option (also t4014 cleanup)

2019-08-23 Thread Junio C Hamano
Denton Liu writes: > For housekeeping, since this patchset now exists as two branches > (dl/format-patch-cover-letter-subject and > dl/format-patch-doc-test-cleanup), would you prefer any new revisions > exist as one big patchset or two separate patchsets targeting each > individual branch? I th

Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option

2019-08-23 Thread Junio C Hamano
Philip Oakley writes: > Perhaps the `--infer-cover-subject` the config option needs to be > multi-valued to include: > "subject" (always expect short first lines) or > "message" (always the long paragraph description, still use > ***Subject Here***), > with the "true" being used wh

Re: [PATCH 2/3] git-gui: Add the ability to revert selected lines

2019-08-23 Thread Johannes Sixt
Am 23.08.19 um 19:03 schrieb Pratyush Yadav: > So how about we keep a copy of the diff in another variable. This allows > us to enable undoing of reverts. The obvious limitations are that > firstly, unless we use a stack/deque that means only one undo is > allowed. I'm not sure if using an undo

Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option

2019-08-23 Thread Philip Oakley
On 23/08/2019 19:15, Denton Liu wrote: Having said that, I suspect that in the longer term, people would want to see this new behaviour with a bit of tweak become the new default. The "tweak" I suspect is needed is to behave sensibly when "the first line" ends up to be too long a subject. Wh

Re: RFC: Proposing git-filter-repo for inclusion in git.git

2019-08-23 Thread Elijah Newren
On Fri, Aug 23, 2019 at 11:06 AM Elijah Newren wrote: > Safety: Ooh, and another one I remembered just after hitting 'send': * If the user provides a --tag-name-filter that maps multiple tags to the same name, no warning or error is provided; filter-branch simply overwrites each tag in some u

Re: [PATCH v3 00/13] format-patch: learn --infer-cover-subject option (also t4014 cleanup)

2019-08-23 Thread Denton Liu
On Thu, Aug 22, 2019 at 01:18:08PM -0700, Junio C Hamano wrote: > Denton Liu writes: > > > While we're at it, perform some major cleanup of t4014 including some > > stylistic cleanup and also, unmasking of Git return codes. > > Wow. It seems that "while we're at it" grew quite large and (from >

Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option

2019-08-23 Thread Denton Liu
On Wed, Aug 21, 2019 at 12:32:19PM -0700, Junio C Hamano wrote: > Denton Liu writes: > > > Teach format-patch to use the first line of the branch description as > > the Subject: of the generated cover letter, rather than "*** SUBJECT > > I would not say "the first line", as I do not think that i

Re: RFC: Proposing git-filter-repo for inclusion in git.git

2019-08-23 Thread Elijah Newren
Hi Eric! On Thu, Aug 22, 2019 at 8:01 PM Eric Wong wrote: > > Elijah Newren wrote: > > * Remove git-filter-branch from git.git. Mention in the release > > notes where people can go to get it.[1] > > > > filter-branch is not merely a slow or difficult-to-use tool, it's one > > that *fosters* m

[RFC] Add config option corresponding to --rebase-merges

2019-08-23 Thread Dakota Hawkins
I'd like to work on a patch to add config options that correspond to rebase's --rebase-merges flag. In my workflow, while it's uncommon to encounter merge commits during a rebase operation, when they are encountered I pretty much always want this behavior. Since it's rare, I pretty much always for

Re: [PATCH 2/3] git-gui: Add the ability to revert selected lines

2019-08-23 Thread Pratyush Yadav
+Cc Bert. This has the suggestion I was talking about in one of my previous replies. On 23/08/19 09:28AM, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Maybe the direction taken by this discussion merely suggests that the > > design is a bit unfortunate. Why "revert"? Why not "stash

Re: Bug Report: notes disassociated after history edits

2019-08-23 Thread Junio C Hamano
Jeff King writes: > ... > --commit-filter ' > commit=$(git commit-tree "$@") > git notes copy $GIT_COMMIT $commit > echo $commit > ' Thanks. I was writing the same "git notes copy $this $that" based response, but TIL we had --stdin to fe

Re: [BUG] builtin "stash apply" does not refresh index

2019-08-23 Thread Junio C Hamano
Jeff King writes: > This started with 8a0fc8d19d (stash: convert apply to builtin, > 2019-02-25), which is in v2.22.0. Interestingly, do_stash_apply() does > in fact call refresh_cache(). But it looks like we don't ever write it > out to disk. So when we later call merge_recursive(), it presumabl

Re: [PATCH v2 3/4] git-gui: Add the ability to revert selected lines

2019-08-23 Thread Pratyush Yadav
On 23/08/19 08:29AM, Bert Wesarg wrote: > On Fri, Aug 23, 2019 at 12:01 AM Pratyush Yadav > wrote: > > > > Just like the user can select lines to stage or unstage, add the > > ability to revert selected lines. > > > > Signed-off-by: Pratyush Yadav > > --- > > git-gui.sh | 25 +

Re: [PATCH v2 0/4] git-gui: Add ability to revert selected hunks and lines

2019-08-23 Thread Pratyush Yadav
On 23/08/19 08:04AM, Bert Wesarg wrote: > On Fri, Aug 23, 2019 at 12:51 AM Pratyush Yadav > wrote: > > > > On 22/08/19 03:34PM, Junio C Hamano wrote: [...] > as I'm the one who use this feature for more than 7 years, I can only > object to this. I'm happy to have the confirmation dialog for the

Re: bug: interactive rebase's 'edit' insn copies notes to newly inserted commit

2019-08-23 Thread Junio C Hamano
SZEDER Gábor writes: > ... However, once > rebase stops for the 'edit' instruction the user can do just about > anything, so I'm not sure how rebase could figure out when to copy the > note and when not. True. > This doesn't happen when inserting a 'break' instruction between > picking the "se

Re: [PATCH 2/3] git-gui: Add the ability to revert selected lines

2019-08-23 Thread Junio C Hamano
Johannes Schindelin writes: > Maybe the direction taken by this discussion merely suggests that the > design is a bit unfortunate. Why "revert"? Why not "stash" instead? Then > you don't need to have that annoying confirmation dialog. Interesting, but it would need a bit more tweak than a simple

Re: [PATCH v2 0/4] git-gui: Add ability to revert selected hunks and lines

2019-08-23 Thread Junio C Hamano
Bert Wesarg writes: > The thing is, that the partial revert "just don't happen by accident". > Here are the minimum user actions needed to get to this dialog: > > 1. whole-file revert > > - do a Ctrl+J, more or less anywhere in the GUI > > 2. hunk revert/revert one unselected line > > - right cli

Re: [PATCH v3 2/6] sequencer: add NULL checks under read_author_script

2019-08-23 Thread Junio C Hamano
Rohit Ashiwal writes: > read_author_script reads name, email and author date from the author > script. However, it does not check if the arguments are NULL. Adding > NULL checks will allow us to selectively get the required value,... I had a hard time understanding the argument here without know

bug: interactive rebase's 'edit' insn copies notes to newly inserted commit

2019-08-23 Thread SZEDER Gábor
I noticed that somehow two commits on the same branch ended up with the same note attached. I believe that this is the result of me using interactive rebase's 'edit' instruction to insert new commits, and then it copied the note from the edited commit to the commit from from where I 'git rebase --

Re: [PATCH 2/3] git-gui: Add the ability to revert selected lines

2019-08-23 Thread Johannes Schindelin
Hi, On Thu, 22 Aug 2019, Pratyush Yadav wrote: > On 20/08/19 11:19PM, Johannes Sixt wrote: > > Am 20.08.19 um 21:29 schrieb Pratyush Yadav: > > > On 20/08/19 09:21PM, Johannes Sixt wrote: > > >> Please don't do this. This confirmation dialog is unacceptable in my > > >> workflow. I use reversals

Re: RFC: Proposing git-filter-repo for inclusion in git.git

2019-08-23 Thread Derrick Stolee
On 8/22/2019 5:12 PM, Elijah Newren wrote: > On Thu, Aug 22, 2019 at 1:24 PM Junio C Hamano wrote: >> >> Elijah Newren writes: >> >>> Questions, comments, or concerns with this proposal? Alternative >>> proposals? If inclusion is acceptable, are there any other tasks that >>> need to be complet

Re: [PATCH 26/26] midx: switch to using the_hash_algo

2019-08-23 Thread Derrick Stolee
On 8/22/2019 10:17 PM, brian m. carlson wrote: > On 2019-08-22 at 14:04:16, Derrick Stolee wrote: >> On 8/18/2019 4:04 PM, brian m. carlson wrote: >>> diff --git a/midx.c b/midx.c >>> index d649644420..f29afc0d2d 100644 >>> --- a/midx.c >>> +++ b/midx.c >>> @@ -19,8 +19,7 @@ >>> #define MIDX_BYTE_

Please Respond Urgently.

2019-08-23 Thread Ahmed
Hello, I need your urgent assistance in transferring the sum of Eleven Million Three Hundred Thousand United States Dollars immediately to your account. The money has been here in our Bank lying dormant for years now without anybody coming for the claim of it. I want to release the money to yo

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread SZEDER Gábor
On Fri, Aug 23, 2019 at 11:35:48AM +0200, Giuseppe Crinò wrote: > On Fri, Aug 23, 2019 at 10:29 AM SZEDER Gábor wrote: > > If we go down this route, then someone might want to write ő as o" or > > ű as u", which still supposed to be used in pairs, but what if someone > > wants to write ä as a:, ö

Re: [PATCH 2/2] line-log: avoid unnecessary full tree diffs

2019-08-23 Thread SZEDER Gábor
On Thu, Aug 22, 2019 at 10:41:58AM +0200, SZEDER Gábor wrote: > On Wed, Aug 21, 2019 at 07:35:15PM +0200, SZEDER Gábor wrote: > Subject: [PATCH 3/2] WIP line-log: stop diff-ing after first TREESAME merge > parent > # linux.git, ~7% of all commits are merges > $ time ~/src/git/git --no-pager l

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread Giuseppe Crinò
On Fri, Aug 23, 2019 at 10:29 AM SZEDER Gábor wrote: > If we go down this route, then someone might want to write ő as o" or > ű as u", which still supposed to be used in pairs, but what if someone > wants to write ä as a:, ö as o:, ü as u:, ç as "c,", ş as "s,", etc. I don't know any language th

Re: [PATCH v2] t0021: make sure clean filter runs

2019-08-23 Thread SZEDER Gábor
On Thu, Aug 22, 2019 at 08:22:40PM +0100, Thomas Gummerer wrote: > v2 adds the comment as suggested by Szeder. > + # Make sure that the file appears dirty, so checkout below has > to > + # run the configured filter. Yeah, but that comment only really applied when setting

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread SZEDER Gábor
On Fri, Aug 23, 2019 at 12:13:12AM +0530, Pratyush Yadav wrote: > > Does it make more sense to replace this strbuf_addstr_without_crud() > > setup with something more intelligent (i.e. checking for matching crud > > on either end, like ^[$crudchars].*\1$? We already check for matched <>. > > Sound

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread SZEDER Gábor
On Thu, Aug 22, 2019 at 10:08:17AM -0700, Emily Shaffer wrote: > On Thu, Aug 22, 2019 at 09:58:48AM -0700, Bryan Turner wrote: > > If your goal is an accented "e", wouldn't it be better to set your > > name using é, rather than a trailing apostrophe? "git commit" would > > likely preserve that with

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread Michal Suchánek
On Fri, 23 Aug 2019 09:20:47 +0200 Giuseppe Crinò wrote: > On Thu, Aug 22, 2019 at 6:24 PM Junio C Hamano wrote: > > The logic there exists in order to remove cruft around the name on a > > typical e-mail header (remember, most of the very core-ish part of > > the Git was written and got solidif

Re: [BUG] You can't have single quote in your username

2019-08-23 Thread Giuseppe Crinò
On Thu, Aug 22, 2019 at 6:24 PM Junio C Hamano wrote: > The logic there exists in order to remove cruft around the name on a > typical e-mail header (remember, most of the very core-ish part of > the Git was written and got solidified back when the Linux kernel > was the primary client of the syst