t1410.3 ("corrupt and checks") fails when run using dash versions
before 0.5.8, with a cryptic message:
mv: cannot stat '.git/objects//e84adb2704cbd49549e52169b4043871e13432':
No such file or directory
The function generating that path:
test_oid_to_path () {
echo
From: Phil Hord
'git tag -d' accepts one or more tag refs to delete, but each deletion
is done by calling `delete_ref` on each argv. This is painfully slow
when removing from packed refs. Use delete_refs instead so all the
removals can be done inside a single transaction with a single write.
I h
On Wed, Aug 7, 2019 at 6:03 AM René Scharfe wrote:
>
> Am 07.08.19 um 11:49 schrieb Carlo Arenas:
> > was hoping will perform better but it seems that testing can be done
> > only in windows
>
> nedmalloc works on other platforms as well.
I meant[1] it works reliably enough to be useful for perfo
The git-blame(1) man page says that the .. range specifier can be used
to exclude changes "older than" a certain revision. It goes on to say
that it collapses all lines "not changed since the range boundary" into
the boundary revision. This is the same thing --since= would
do, and the man page even
Carlo Marcelo Arenas Belón writes:
As we already have such an ifdef block here...
> +#ifdef USE_LIBPCRE2
> +static pcre2_general_context *pcre2_global_context;
> +
> +#ifdef USE_NED_ALLOCATOR
> +static void *pcre2_malloc(PCRE2_SIZE size, MAYBE_UNUSED void *memory_data)
> +{
> + return xmall
Pratyush Yadav writes:
> I think you misunderstood me. I do not mean to create a GitHub pull
> request, because as you say, no one other than me and you will look at
> it. What I meant was that I can pile up a bunch of commits, and send
> them on this list here for you to merge. I can explain tho
63e7e9d8b6 ("git-grep: Learn PCRE", 2011-05-09) didn't include a way
to override the system alocator, and so it is incompatible with
USE_NED_ALLOCATOR as reported by Dscho[1] (in similar code from PCRE2)
Make the minimum change possible to ensure this combination is supported
by extending grep_ini
94da9193a6 ("grep: add support for PCRE v2", 2017-06-01) introduced
a small memory leak visible with valgrind in t7813.
Complete the creation of a PCRE2 specific variable that was missing from
the original change and free the generated table just like it is done
for PCRE1.
Signed-off-by: Carlo Ma
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) didn't include
a way to override the system allocator, and so it is incompatible with
USE_NED_ALLOCATOR. The problem was made visible when an attempt to
avoid a leak in a data structure that is created by the library was
passed to NED's free f
This series is a candidate reroll for cb/pcre2-chartables-leakfix, that
hopefully addresses the root cause of the problem reported by Dscho in
Windows, where the PCRE2 library wasn't aware of the custom allocator and
was returning a pointer created with the system malloc but passing it to
NED's fre
On 8/7/19 11:20 PM, Junio C Hamano wrote:
Pratyush Yadav writes:
So if I fork the project, will you pull from my fork? If yes, what
exactly would I have to do? Make a set of changes and then ask on the
list for you to pull from my fork?
I am a relatively inexperienced programmer, and it feels
Jeff Hostetler writes:
> On 8/1/2019 5:34 PM, Junio C Hamano wrote:
>> "Jeff Hostetler via GitGitGadget" writes:
>>
>>> From: Jeff Hostetler
>>>
>>> Trim leading/trailing whitespace from the command line
>>> printed in the "start" message in the perf target format.
>>>
>>> We use `sq_quote_argv
Hi Junio and Dscho
On Thu, Aug 8, 2019 at 1:52 AM Junio C Hamano wrote:
>
> Johannes Schindelin writes:
>
> > On Tue, 6 Aug 2019, Rohit Ashiwal wrote:
> >
> >> @@ -1046,6 +1066,8 @@ static int run_git_commit(struct repository *r,
> >> argv_array_push(&cmd.args, "--amend");
> >>
Hi Junio
On Wed, Aug 7, 2019 at 11:08 AM Junio C Hamano wrote:
>
> Rohit Ashiwal writes:
>
> > diff --git a/builtin/rebase.c b/builtin/rebase.c
> > index db6ca9bd7d..3c195ddc73 100644
> > --- a/builtin/rebase.c
> > +++ b/builtin/rebase.c
> > ...
> > @@ -511,6 +523,8 @@ int cmd_rebase__interactiv
On 8/1/2019 5:34 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
Trim leading/trailing whitespace from the command line
printed in the "start" message in the perf target format.
We use `sq_quote_argv_pretty()` to format the message
and it adds a l
Johannes Schindelin writes:
> On Tue, 6 Aug 2019, Rohit Ashiwal wrote:
>
>> @@ -1046,6 +1066,8 @@ static int run_git_commit(struct repository *r,
>> argv_array_push(&cmd.args, "--amend");
>> if (opts->gpg_sign)
>> argv_array_pushf(&cmd.args, "-S%s", opts->gpg_sign);
Hi Rohit,
On Tue, 6 Aug 2019, Rohit Ashiwal wrote:
> @@ -1046,6 +1066,8 @@ static int run_git_commit(struct repository *r,
> argv_array_push(&cmd.args, "--amend");
> if (opts->gpg_sign)
> argv_array_pushf(&cmd.args, "-S%s", opts->gpg_sign);
> + if (opts->igno
Derrick Stolee writes:
> On 8/7/2019 7:15 AM, René Scharfe wrote:
>> Signed-off-by: René Scharfe
>> ---
>> Patch generated with --function-context for easier review. That makes
>> it look a lot bigger than it actually is, though.
>
> Thanks for the --function-context. It really does clarify wha
Emily Shaffer writes:
> Since v3, only a couple of minor changes from Jonathan Tan - thanks.
>
> I'm dropping the updates for the RFC set, since they're incremental from
> now. Next time you all see them they will be in a form which we would
> hope to maintain over a long period of time, checked
From: Michael J Gruber
git-merge does not honor the pre-commit hook when doing automatic merge
commits, and for compatibility reasons this is going to stay.
Introduce a pre-merge-commit hook which is called for an automatic merge
commit just like pre-commit is called for a non-automatic merge co
From: Michael J Gruber
f8b863598c ("builtin/merge: honor commit-msg hook for merges", 2017-09-07)
introduced the no-verify flag to merge for bypassing the commit-msg
hook, though in a different way from the implementation in commit.c.
Change the implementation in merge.c to be the same as in com
This series adds a new pre-merge-commit hook, similar in usage to
pre-commit. It also improves hook testing in t7503, by verifying that
the correct hooks are run or bypassed as expected.
The original series was done by Michael J Gruber . I have
addressed the outstanding review comments, and noted
From: Michael J Gruber
Analogous to commit, introduce a '--no-verify' option which bypasses the
pre-merge-commit hook. The shorthand '-n' is taken by '--no-stat'
already.
[js: * reworded commit message to reflect current state of --no-stat flag
and new hook name
* fixed flag document
t7503 did not verify that the expected hooks actually ran during
testing. Fix that by making the hook scripts write their $0 into a file
so that we can compare actual execution vs. expected execution.
While we're at it, do some test style cleanups, such as using
write_script() and doing setup insi
--
Hello dear Friend My spirit ask me to contact you,please i will like
you to write me back once you read my message Okay.
Carlo Arenas writes:
>> > +#ifdef USE_NED_ALLOCATOR
>> > +static void *pcre2_malloc(PCRE2_SIZE size, MAYBE_UNUSED void *memory_data)
>> > +{
>> > + return malloc(size);
>>
>> Should this be xmalloc() to get consistent out-of-memory handling?
>
> good point, note though that since it is inside
On 2019.08.06 11:14, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > t7503 did not verify that the expected hooks actually ran during
> > testing. Fix that by making the hook scripts write their $0 into a file
> > so that we can compare actual execution vs. expected execution.
> >
> > While w
Pratyush Yadav writes:
> So if I fork the project, will you pull from my fork? If yes, what
> exactly would I have to do? Make a set of changes and then ask on the
> list for you to pull from my fork?
>
> I am a relatively inexperienced programmer, and it feels like a kinda
> big responsibility t
On Wed, Aug 07, 2019 at 10:15:43AM -0700, Junio C Hamano wrote:
> Taylor Blau writes:
>
> >> It would also be helpful to have a post for every major release
> >> highlighting new features and giving users examples of how to use them.
> >> Taylor has been writing these on the GitHub blog [1], but m
Junio C Hamano writes:
> Pratyush Yadav writes:
>
>> I'm not too optimistic on finding someone to run this project. I asked
>> on the list who the maintainer is [0], and no one came up. The repo at
>> [1] also seems abandoned.
>
> In the meantime until somebody steps up, I might run my own copy.
Taylor Blau writes:
>> It would also be helpful to have a post for every major release
>> highlighting new features and giving users examples of how to use them.
>> Taylor has been writing these on the GitHub blog [1], but maybe he
>> would be interested in writing them for this new venue?
>>
>>
Hi Emily,
On Tue, Aug 06, 2019 at 02:00:15PM -0700, Emily Shaffer wrote:
> On Tue, Aug 06, 2019 at 08:19:15AM -0400, Derrick Stolee wrote:
> > On 8/6/2019 12:52 AM, Andrew Ardill wrote:
> > > On Tue, 6 Aug 2019 at 11:51, Emily Shaffer
> > > wrote:
> > >
> > >> Are folks interested in writing and
Hi Stolee,
On Tue, Aug 06, 2019 at 08:19:15AM -0400, Derrick Stolee wrote:
> On 8/6/2019 12:52 AM, Andrew Ardill wrote:
> > On Tue, 6 Aug 2019 at 11:51, Emily Shaffer wrote:
> >
> >> Are folks interested in writing and reviewing this kind of content?
>
> I am interested in writing and reviewing!
On Tue, Aug 06, 2019 at 09:27:30AM -0400, Jeff King wrote:
> On Tue, Aug 06, 2019 at 06:59:21AM +0200, Christian Couder wrote:
>
> > When Git Rev News was started I thought that there could be such a
> > group effort to encourage each other to publish articles in it, but I
> > must say that outside
On Wed, Aug 07, 2019 at 04:17:49AM +, brian m. carlson wrote:
> On 2019-08-06 at 23:43:20, Jeff King wrote:
> > On Tue, Aug 06, 2019 at 10:58:53PM +, brian m. carlson wrote:
> > > Sorry, I hadn't had a chance to look at this series in depth, but I was
> > > wondering: could we not just acce
On 8/7/2019 7:15 AM, René Scharfe wrote:
> Avoid allocating and leaking a strbuf for holding a verbatim copy of the
> path argument and pass the latter directly to dir_iterator_begin()
> instead.
>
> Signed-off-by: René Scharfe
> ---
> This test helper was added after v2.22.0 (2019-06-07) by 1507
On 8/7/2019 7:15 AM, René Scharfe wrote:
> Signed-off-by: René Scharfe
> ---
> Patch generated with --function-context for easier review.
Thanks again. LGTM.
-Stolee
Here is today's test coverage report.
Thanks,
-Stolee
[1] https://derrickstolee.github.io/git-test-coverage/reports/2019-08-07.htm
[2] https://derrickstolee.github.io/git-test-coverage/reports/2019-08-07.txt
---
pu 6e4c1a0bf4bbb62125a3a213c7417ff2d2c7d12d
jch 2965e59c16454ff427f464cbab
I hope this is the right mailing list, hope someone will redirect me if not...
The git documentation (git help config) for core.autocrlf doesn't mention that
false is a valid option; it only mentions true and input.
Further, the docs for "input" are misleading, in that they lead the reader to
ass
On 8/7/2019 7:15 AM, René Scharfe wrote:
> Signed-off-by: René Scharfe
> ---
> Patch generated with --function-context for easier review. That makes
> it look a lot bigger than it actually is, though.
Thanks for the --function-context. It really does clarify what's going on,
especially in the ca
Cast the evaluated value of the macro INITIAL_LOCK to void to instruct
the compiler that we're not interested in said value nor the following
warning:
In file included from compat/nedmalloc/nedmalloc.c:63:
compat/nedmalloc/malloc.c.h: In function ‘init_user_mstate’:
compat/nedmalloc/malloc.c.h:170
Avoid the following compiler warning:
In file included from compat/nedmalloc/nedmalloc.c:63:
compat/nedmalloc/malloc.c.h: In function ‘pthread_release_lock’:
compat/nedmalloc/malloc.c.h:1759:5: error: ISO C90 forbids mixed declarations
and code [-Werror=declaration-after-statement]
1759 | vo
Am 07.08.19 um 11:49 schrieb Carlo Arenas:
> was hoping will perform better but it seems that testing can be done
> only in windows
nedmalloc works on other platforms as well. On Debian Testing with GCC
9.1.0 I need two changes to suppress some compiler warnings, though.
Will post them as replies
On Wed, Aug 07, 2019 at 01:15:25PM +0200, René Scharfe wrote:
> Signed-off-by: René Scharfe
> ---
> Patch generated with --function-context for easier review.
>
> The plugged leak was added by a10a17877b (for_each_alternate_ref:
> replace transport code with for-each-ref, 2017-02-08) and showed
Signed-off-by: René Scharfe
---
Patch generated with --function-context for easier review.
The plugged leak was added after v2.22.0 (2019-06-07) by 3012397e03
(dir-iterator: refactor state machine model, 2019-07-10).
refs/files-backend.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Signed-off-by: René Scharfe
---
Patch generated with --function-context for easier review.
The plugged leak was added by a10a17877b (for_each_alternate_ref:
replace transport code with for-each-ref, 2017-02-08) and showed up in
709dfa6990 (object-store.h: move for_each_alternate_ref() from
transp
Avoid allocating and leaking a strbuf for holding a verbatim copy of the
path argument and pass the latter directly to dir_iterator_begin()
instead.
Signed-off-by: René Scharfe
---
This test helper was added after v2.22.0 (2019-06-07) by 150791adbf
(dir-iterator: add tests for dir-iterator API, 2
Signed-off-by: René Scharfe
---
Patch generated with --function-context for easier review. That makes
it look a lot bigger than it actually is, though.
The plugged leaks were added after v2.22.0 (2019-06-07) by the following
commits:
5c84b3396c 2019-06-18 commit-graph: load commit-graph chains
Subject was meant to be "gettext: fix is_utf8_locale() when not using
NO_GETTEXT" and affects mainly PCRE by using UTF-8 flag even when the
locale was ISO.
somehow it doesn't break any tests though, but PCRE strongly advices
against doing both UTF and chartables and we might end up doing that
more
in environments where the build running wasn't installed and wasn't
using NO_GETTEXT the initialization of charset will be skipped, breaking
is_utf_locale()
Split the init function on two, so the initialization of charset could
be done before a decision to abort was made and therefore keeping most
On Tue, Aug 6, 2019 at 10:38 PM René Scharfe wrote:
>
> Am 06.08.19 um 18:36 schrieb Carlo Marcelo Arenas Belón:
> > Move some of the logic that was before done per thread (in the workers)
> > into an earlier phase to avoid degrading performance
>
> Which logic is moved? In the patch I basically
51 matches
Mail list logo
