Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0

2019-08-04 Thread Jeff King
On Sun, Aug 04, 2019 at 01:01:51PM +0200, Jean-Noël AVILA wrote: > This one is not about typos. > > My original fix was more concerning the second sequence, where the > sentence is broken in the middle, simply for better rendering but this > does not make sense either, because the lines are too l

[RFC PATCH 1/2] p7810: add more grep performance relevant cases

2019-08-04 Thread Carlo Marcelo Arenas Belón
Add a baseline for a matching regex and make clear the distinction between fixed (now using kwset) and a real simple expression. Signed-off-by: Carlo Marcelo Arenas Belón --- t/perf/p7810-grep.sh | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/t/per

[RFC PATCH 2/2] grep: make default number of threads reflect runtime

2019-08-04 Thread Carlo Marcelo Arenas Belón
5b594f457a (Threaded grep, 2010-01-25) added a hardcoded number of threads(8) to use in grep and 89f09dd34e (grep: add --threads= option and grep.threads configuration, 2015-12-15) made it configurable through a knob as a workaround for systems where that default was not effective. Use instead the

[RFC PATCH 0/2] grep: make threading smarter

2019-08-04 Thread Carlo Marcelo Arenas Belón
833e3df171 (pack-objects: Add runtime detection of online CPU's, 2008-02-22) added the capability to check the number of online CPUs at runtime to do better threading, so use that as well with grep. Testing with a large (more than 4) number of cores and no grep.threads configuration in real hardwa

Re: [PATCH 0/6] Port git to Plan 9

2019-08-04 Thread Jonathan Nieder
Hi, Kyohei Kadota wrote: > I think it is possible to replace rc with ape/sh, ape/sh is POSIX > shell in Plan 9. > > However Plan 9 don't have recent versions of Unix tools, > such as gcc, g++, autotools, gmake or perl, > so it is VERY hard to use Makefile instead of mkfile. The default Git build

Re: [PATCH] git-gui: Perform rescan on window focus-in

2019-08-04 Thread Pratyush Yadav
Hi Johannes, I sense that I'm starting to test your patience. So first off, thanks for the advice you've given so far. It has been really valuable. Feel free to let me know if you don't want me to prod you further about this, and I'll stop :). Also let me know if you don't want me to cc you

Re: [PATCH] test-lib-functions: show the test name at the start of verbose output

2019-08-04 Thread Johannes Schindelin
Hi, On Sat, 3 Aug 2019, SZEDER Gábor wrote: > So the dummy test above would start like this: > > expecting success of 'commit works': > echo content >file && > [...] Maybe it would make sense to also mention the test and test case number, like so? expecting success of t987

Re: [PATCH] git-gui: Perform rescan on window focus-in

2019-08-04 Thread Johannes Schindelin
Hi, On Sun, 4 Aug 2019, Pratyush Yadav wrote: > On 8/4/19 2:04 AM, Johannes Schindelin wrote: > > > > On Sat, 3 Aug 2019, Pratyush Yadav wrote: > > > > > On 8/2/19 6:09 PM, Johannes Schindelin wrote: > > > > > > > > On Fri, 2 Aug 2019, Pratyush Yadav wrote: > > > > > > > > > On 8/1/19 1:12 AM, Jo

Re: [PATCH] git-gui: Perform rescan on window focus-in

2019-08-04 Thread Johannes Schindelin
Hi, On Sat, 3 Aug 2019, Pratyush Yadav wrote: > On 8/2/19 10:17 PM, Junio C Hamano wrote: > > Pratyush Yadav writes: > > > > > All right, the patch in its current state can't fly. So what is > > > the correct way to do this? I see the following options: > > > > > > 1. Add this as an option that

Re: Default Clone Dir?

2019-08-04 Thread johnywhy
Thx! The alias is super.

Re: Default Clone Dir?

2019-08-04 Thread brian m. carlson
On 2019-08-04 at 17:13:36, johny...@gmail.com wrote: > hi, > Is there a way to set default clone destination directory on linux? > Currently, seems to clone to the active dir. It sounds like you want to always clone repositories to a single directory. git clone doesn't have a configuration setting

Default Clone Dir?

2019-08-04 Thread johnywhy
hi, Is there a way to set default clone destination directory on linux? Currently, seems to clone to the active dir. -thx!

[PATCH] git-gui: Call do_quit before destroying the main window

2019-08-04 Thread Pratyush Yadav
If the toplevel window for the window being destroyed is the main window (aka "."), then simply destroying it means the cleanup tasks are not executed like saving the commit message buffer, saving window state, etc. All this is handled by do_quit so, call it instead of directly destroying the main

Re: [PATCH] git-gui: Perform rescan on window focus-in

2019-08-04 Thread Pratyush Yadav
On 8/4/19 2:04 AM, Johannes Schindelin wrote: Hi, On Sat, 3 Aug 2019, Pratyush Yadav wrote: On 8/2/19 6:09 PM, Johannes Schindelin wrote: On Fri, 2 Aug 2019, Pratyush Yadav wrote: On 8/1/19 1:12 AM, Johannes Schindelin wrote: I would be _extremely_ cautious to base an argument on one par

Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0

2019-08-04 Thread Jean-Noël AVILA
On Sunday, 4 August 2019 01:45:22 CEST Jeff King wrote: > On Sat, Aug 03, 2019 at 09:59:07PM +0200, Jean-Noël Avila wrote: > > > - N_("where the checkout from")), > > + N_("where the checkout is from")), > > I think your original "where to checkout from"

Re: [RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal

2019-08-04 Thread Carlo Arenas
PROs: * it works (only for PCRE2) and tested in OpenBSD, NetBSD, macOS, Linux (Debian) * it applies everywhere (even pu) without conflicts * it doesn't introduce any regressions in tests (tested in Debian with SElinux in enforcing mode) * it is simple CONs: * HardenedBSD still segfaults (bugfix pr