[RFC PATCH v3] grep: treat PCRE2 jit compilation memory error as non fatal

2019-08-03 Thread Carlo Marcelo Arenas Belón
94da9193a6 (grep: add support for PCRE v2, 2017-06-01) uses the JIT fast path unless JIT support has not been compiled in the linked library. Starting from 10.23 of PCRE2, pcre2grep ignores any errors from pcre2_jit_cpmpile as a workaround for their bug1749[1] and we should do too, so that the int

Re: [PATCH 0/6] Port git to Plan 9

2019-08-03 Thread Kyohei Kadota
2019-08-04(Sun) 9:38 brian m. carlson : > > On 2019-08-03 at 23:52:08, KADOTA, Kyohei via GitGitGadget wrote: > > I ported git, and git subcommands only written in C to Plan 9. This pull > > request contains patches for existing codes, and new files to build git in > > Plan 9. > > > > All build opt

Re: [PATCH 5/6] Add plan9/wrap.c

2019-08-03 Thread Kyohei Kadota
2019-08-04(Sun) 9:03 brian m. carlson : > > On 2019-08-03 at 23:52:12, lufia via GitGitGadget wrote: > > From: lufia > > > > Plan 9 has bind(1) instead of ln(1), but bind isn't persisted to the disk. > > However it isn't efficient to copy git to git- subcommands such as git-add. > > Therefore Plan

Re: [PATCH 0/6] Port git to Plan 9

2019-08-03 Thread brian m. carlson
On 2019-08-03 at 23:52:08, KADOTA, Kyohei via GitGitGadget wrote: > I ported git, and git subcommands only written in C to Plan 9. This pull > request contains patches for existing codes, and new files to build git in > Plan 9. > > All build options such as NO_PERL are not supported yet, and also

Re: [RFC PATCH v2] grep: allow for run time disabling of JIT in PCRE

2019-08-03 Thread Carlo Arenas
On Wed, Jul 31, 2019 at 7:57 AM Ævar Arnfjörð Bjarmason wrote: > What hasn't been supported is all of that saying "yes, I support JIT" > and the feature then fail whaling. I had not encountered that before. > > So far that seems like because Carlo just built a completely broken PCRE > v2 package,

Re: [PATCH 5/6] Add plan9/wrap.c

2019-08-03 Thread brian m. carlson
On 2019-08-03 at 23:52:12, lufia via GitGitGadget wrote: > From: lufia > > Plan 9 has bind(1) instead of ln(1), but bind isn't persisted to the disk. > However it isn't efficient to copy git to git- subcommands such as git-add. > Therefore Plan 9 needs wrap.c to switch behavior by executable name

Re: [PATCH 0/1] Fix two documentation typos

2019-08-03 Thread Jeff King
On Sat, Aug 03, 2019 at 07:48:20AM -0700, Junio C Hamano wrote: > > Then I noticed a "can not" and updated that and other occurrences in > > Documentation to cannot. The glossary sentence with "can not" was > > "Consequently, an object can not be changed." To me, that reads like "it is > > Hmph,

[PATCH 6/6] Add mkfile to build git and subcommands for Plan 9

2019-08-03 Thread lufia via GitGitGadget
From: lufia Signed-off-by: lufia --- mkfile | 195 + 1 file changed, 195 insertions(+) create mode 100644 mkfile diff --git a/mkfile b/mkfile new file mode 100644 index 00..f0b06437ed --- /dev/null +++ b/mkfile @@ -0,0 +1,195 @@

[PATCH 2/6] Fix C syntactic errors for the Plan 9 C compiler

2019-08-03 Thread lufia via GitGitGadget
From: lufia Signed-off-by: lufia --- compat/plan9/openssl/crypto.h | 5 + compat/regex/regex_internal.h | 3 +++ config.c | 3 ++- git-compat-util.h | 9 - parse-options.h | 18 +- remove-bitfields.rc | 14

[PATCH 4/6] Port generate-cmdline.sh to rc

2019-08-03 Thread lufia via GitGitGadget
From: lufia Signed-off-by: lufia --- generate-cmdlist.rc | 102 1 file changed, 102 insertions(+) create mode 100755 generate-cmdlist.rc diff --git a/generate-cmdlist.rc b/generate-cmdlist.rc new file mode 100755 index 00..18699ea9c4 --- /d

[PATCH 5/6] Add plan9/wrap.c

2019-08-03 Thread lufia via GitGitGadget
From: lufia Plan 9 has bind(1) instead of ln(1), but bind isn't persisted to the disk. However it isn't efficient to copy git to git- subcommands such as git-add. Therefore Plan 9 needs wrap.c to switch behavior by executable name. Signed-off-by: lufia --- plan9/wrap.c | 16 1

[PATCH 3/6] GIT-VERSION-GEN: Use sed instead of expr

2019-08-03 Thread lufia via GitGitGadget
From: lufia Plan 9 don't have expr(1). Signed-off-by: lufia --- GIT-VERSION-GEN | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GIT-VERSION-GEN b/GIT-VERSION-GEN index a0766f64ed..754d4486f5 100755 --- a/GIT-VERSION-GEN +++ b/GIT-VERSION-GEN @@ -26,7 +26,7 @@ else V

[PATCH 1/6] Change HOME, PATH, and .gitconfig paths to be customizable

2019-08-03 Thread lufia via GitGitGadget
From: lufia In Plan 9, almost environment variables are not capitalized. Signed-off-by: lufia --- Makefile | 26 +- builtin/config.c | 2 +- config.c | 2 +- credential-cache.c | 2 +- credential-store.c | 2 +- exec-cmd.c | 4 ++-- gi

[PATCH 0/6] Port git to Plan 9

2019-08-03 Thread KADOTA, Kyohei via GitGitGadget
I ported git, and git subcommands only written in C to Plan 9. This pull request contains patches for existing codes, and new files to build git in Plan 9. All build options such as NO_PERL are not supported yet, and also some git subcommands written not in C is not available yet. But git can sync

Re: [PATCH v2] l10n: reformat some localized strings for v2.23.0

2019-08-03 Thread Jeff King
On Sat, Aug 03, 2019 at 09:59:07PM +0200, Jean-Noël Avila wrote: > Signed-off-by: Jean-Noël Avila > --- > builtin/checkout.c | 2 +- > builtin/fetch.c| 15 +++ > 2 files changed, 12 insertions(+), 5 deletions(-) > > diff --git a/builtin/checkout.c b/builtin/checkout.c > index 9

Re: Weird behavior with git grep --recurse-submodules

2019-08-03 Thread Brandon Williams
On Mon, Jul 29, 2019 at 1:27 PM Matheus Tavares Bernardino wrote: > > On Tue, Jul 16, 2019 at 3:09 PM Daniel Zaoui wrote: > > > > Hi Matheus, > > Hi, Daniel > > I'm sorry, your last message went to my spam folder for some reason :( > > > Thank you for your response. > > > > I really hope the chan

[PATCH] restore: fix typo in docs

2019-08-03 Thread William Chargin
Signed-off-by: William Chargin --- Assuming this is a typo, because I can't parse the sentence; if not, perhaps it can be reworded for clarity? Documentation/git-restore.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-restore.txt b/Documentation/git-rest

Re: [GSoC] Blogging with Rohit

2019-08-03 Thread Rohit Ashiwal
Hi Everyone! Here[1] is an update about my last week and some insight on the future work. Thanks Rohit [1]: https://rashiwal.me/2019/the-discussion/

Re: [PATCH v3 0/3] Add a JSON Schema for trace2 events

2019-08-03 Thread Johannes Schindelin
Hi Jonathan, On Fri, 2 Aug 2019, Jonathan Nieder wrote: > SZEDER Gábor wrote: > > On Fri, Aug 02, 2019 at 09:59:13AM -0700, Jonathan Nieder wrote: > > >> In the short term, we can run tests internally to check that Git keeps > >> following the schema. Let's not block patches 1 and 2 by this ---

Re: [PATCH 1/1] commit: add signoff config variable

2019-08-03 Thread Liam Beguin
Hi, Sorry for sending this without checking the archives before... I understand why this would not be such a good idea given the legal meaning attached to it. Thanks, Liam On Sat, Aug 3, 2019 at 5:12 PM brian m. carlson wrote: > > On 2019-08-03 at 19:34:36, Liam Beguin wrote: > > Add a configur

Re: [PATCH 1/1] commit: add signoff config variable

2019-08-03 Thread brian m. carlson
On 2019-08-03 at 19:34:36, Liam Beguin wrote: > Add a configuration variable, based on format.signoff, to automatically > signoff commit messages. > > Signed-off-by: Liam Beguin This has been proposed several times. It may be interesting to look through the history of the list and examine why it

Git for Windows v2.23.0-rc1, was Re: [ANNOUNCE] Git v2.23.0-rc1

2019-08-03 Thread Johannes Schindelin
Team, On Fri, 2 Aug 2019, Junio C Hamano wrote: > A release candidate Git v2.23.0-rc1 is now available for testing > at the usual places. It is comprised of 471 non-merge commits > since v2.22.0, contributed by 63 people, 23 of which are new faces. > > The tarballs are found at: > > https://

Re: [PATCH] git-gui: Perform rescan on window focus-in

2019-08-03 Thread Johannes Schindelin
Hi, On Sat, 3 Aug 2019, Pratyush Yadav wrote: > On 8/2/19 6:09 PM, Johannes Schindelin wrote: > > > > On Fri, 2 Aug 2019, Pratyush Yadav wrote: > > > > > On 8/1/19 1:12 AM, Johannes Schindelin wrote: > > > > > > > > I would be _extremely_ cautious to base an argument on one > > > > particular set

Re: js/visual-studio, was Re: What's cooking in git.git (Aug 2019, #01; Thu, 1)

2019-08-03 Thread Johannes Schindelin
Hi Junio, On Fri, 2 Aug 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > > > On Thu, 1 Aug 2019, Junio C Hamano wrote: > > > >> * js/visual-studio (2019-07-29) 23 commits > >> - git: avoid calling aliased builtins via their dashed form > >> - bin-wrappers: append `.exe` to targe

[PATCH v2] l10n: reformat some localized strings for v2.23.0

2019-08-03 Thread Jean-Noël Avila
Signed-off-by: Jean-Noël Avila --- builtin/checkout.c | 2 +- builtin/fetch.c| 15 +++ 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index 91f8509f85..08e19ed1ed 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@

[PATCH 1/1] commit: add signoff config variable

2019-08-03 Thread Liam Beguin
Add a configuration variable, based on format.signoff, to automatically signoff commit messages. Signed-off-by: Liam Beguin --- Documentation/config/commit.txt | 7 +++ builtin/commit.c| 4 2 files changed, 11 insertions(+) diff --git a/Documentation/config/commit.txt b

Re: [PATCH v2] grep: avoid leak of chartables in PCRE2

2019-08-03 Thread Carlo Arenas
Junio Thanks for fixing the conflicts in pu as well; apologize if I could had made it easier by doings things differently Carlo

Re: [patch 16/17] memremap: move from kernel/ to mm/

2019-08-03 Thread Linus Torvalds
[ Adding git people due to On Sat, Aug 3, 2019 at 10:24 AM Andrew Morton wrote: > > Aside. I guess renames are just a wee bit dangerous. There's no > guarantee that the file which you rename is exactly the same as the one > which I renamed, which could result in breakage. Such as, ummm, if > s

Re: [PATCH 0/1] Fix two documentation typos

2019-08-03 Thread Junio C Hamano
"Mark Rushakoff via GitGitGadget" writes: > I noticed a couple typos while reading through some manpages. > > First was "...if it is does not..." which just contained an extraneous "is". Thanks. > Then I noticed a "can not" and updated that and other occurrences in > Documentation to cannot. T

Re: Simplify-by-decoration with decorate-refs-exclude

2019-08-03 Thread Junio C Hamano
René Scharfe writes: > Sure, but we'd need to move the code to handle the raw format as well, no? > Perhaps like this? It depends on callers of parse_revision_opt() calling > setup_revisions() before using decorations. And it may have other side > effects; I'm not comfortable with this change.

Re: [RFC] l10n: fix some typos for v2.23.0

2019-08-03 Thread Jiang Xin
Jean-Noël Avila 于2019年8月3日周六 下午6:18写道: > > Signed-off-by: Jean-Noël Avila > --- > builtin/checkout.c | 2 +- > builtin/fetch.c| 8 > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/builtin/checkout.c b/builtin/checkout.c > index 91f8509f85..75efc37bc7 100644 > ---

[RFC] l10n: fix some typos for v2.23.0

2019-08-03 Thread Jean-Noël Avila
Signed-off-by: Jean-Noël Avila --- builtin/checkout.c | 2 +- builtin/fetch.c| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/checkout.c b/builtin/checkout.c index 91f8509f85..75efc37bc7 100644 --- a/builtin/checkout.c +++ b/builtin/checkout.c @@ -1769,7 +1

Re: git-log on a file, and merges

2019-08-03 Thread Piotr Krukowiecki
On Fri, Aug 2, 2019 at 9:32 PM Junio C Hamano wrote: > > Piotr Krukowiecki writes: > > > At this moment I'm not sure myself if I consider this a bug or not. > > This definitely is not a bug but is a designed and intended > behaviour. (generally speaking) By "bug" I mean wrong behaviour. Designs

[PATCH] test-lib-functions: show the test name at the start of verbose output

2019-08-03 Thread SZEDER Gábor
The verbose output of every test looks something like this: expecting success: echo content >file && git add file && git commit -m "add file" [master (root-commit) d1fbfbd] add file Author: A U Thor 1 file changed, 1 insertion(+) create mode 100644 file

Re: [PATCH v3 0/3] Add a JSON Schema for trace2 events

2019-08-03 Thread SZEDER Gábor
On Sat, Aug 03, 2019 at 09:35:49AM +0200, SZEDER Gábor wrote: > - Limit it to 'git/git's 'pu' branch, so others can have their own > 'pu' branch without suffering from the consequences. > It seems easy to do so, on Travis CI these are available in the > TRAVIS_BRANCH and TRAVIS_REPO_S

Re: [PATCH v3 0/3] Add a JSON Schema for trace2 events

2019-08-03 Thread SZEDER Gábor
On Fri, Aug 02, 2019 at 04:06:50PM -0700, Jonathan Nieder wrote: > SZEDER Gábor wrote: > > On Thu, Aug 01, 2019 at 06:52:47PM -0700, Jonathan Nieder wrote: > > >> Gábor, if we introduce such a parameter, do you think it would make > >> sense for us to set up a worker that passes it? > > > > That w