01.08.2019, 11:30, "Philip McGraw" :
>> From: Andrey
>> Sent: Wednesday, 31 July, 2019 21:35
>> To: Philip McGraw
>> Cc: git@vger.kernel.org; l...@diamand.org
>> Subject: Re: [PATCH] git-p4: close temporary file before removing
>>
>> 31.07.2019, 17:52, "Philip McGraw" :
>> > 2019.07.31
01.08.2019, 17:39, "Philip McGraw via GitGitGadget" :
> Take new approach using the NamedTemporaryFile() file-like object as input
> to the ZipFile() which auto-deletes after implicit close leaving with scope.
>
> Original code produced double-open problems on Windows platform from using
> alrea
On Thu, Aug 01, 2019 at 07:43:22PM -0700, Jonathan Nieder wrote:
> Hi,
>
> Bryan Turner wrote:
>
> > Promisor remotes and other in-flight changes might help provide some
> > of what you're looking for, but I'm not aware of any already-available
> > solution.
>
> You can do
>
> git clone -
(cc: Duy, who might enjoy this walk through history)
Hi,
Alexander Mills wrote:
> git clone --single-branch=
>
> doesn't seem to work?
I've occasionally wanted something like this (actually, I've wanted to
pass a refname like "refs/meta/config"). builtin/clone.c contains
static struct
Hi,
Bryan Turner wrote:
> Promisor remotes and other in-flight changes might help provide some
> of what you're looking for, but I'm not aware of any already-available
> solution.
You can do
git clone --no-checkout --filter=blob:none $url repo
cd repo
git checkout $commi
Junio C Hamano wrote:
> I suspect that you may have misread the "is interactive" bit in the
> original; that was used only to decide if we are going to warn.
Ah. That was indeed confusing. Anyway, it's nice to see the complexity
go away.
[...]
> +++ b/builtin/log.c
[...]
> @@ -214,12 +204,8 @@
Josh Steadmon wrote:
> On 2019.07.26 15:03, Josh Steadmon wrote:
>> [ajv-cli] can validate the full 1.7M line trace output in just over a
>> minute. Moreover, it has helpful output when validation fails. So I
>> would be happy to re-implement this using ajv-cli.
>
> Unfortunately, ajv on Travis is
Ping :)
On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote:
>
> The bash completion script knows some options to "git log" and
> "git show" only in the positive form, (e.g. "--abbrev-commit"), but not
> in their negative form (e.g. "--no-abbrev-commit"). Add them.
>
> Also, the bash completion scr
On 2019.07.31 13:04, Jeff Hostetler via GitGitGadget wrote:
> This patch series contains a few column alignment and whitespace fixes for
> perf target format. This should make it a little easier to read.
>
> Jeff Hostetler (3):
> trace2: cleanup column alignment in perf target format
> trace2:
On Thu, Aug 1, 2019 at 1:52 PM Alexander Mills
wrote:
>
> Looking for help with this problem:
>
> https://stackoverflow.com/questions/57316783/git-clone-single-branch-does-not-work-for-sha-commit-ids
>
> Essentially looking for:
>
> git clone --single-commit
There's no such option, which will be
This series adds a new pre-merge-commit hook, similar in usage to
pre-commit. It also improves hook testing in t7503, by verifying that
the correct hooks are run or bypassed as expected.
The original series was done by Michael J Gruber . I have
addressed the outstanding review comments, and noted
t7503 did not verify that the expected hooks actually ran during
testing. Fix that by making the hook scripts write their $0 into a file
so that we can compare actual execution vs. expected execution.
While we're at it, do some test style cleanups, such as using
write_script() and doing setup insi
git-merge does not honor the pre-commit hook when doing automatic merge
commits, and for compatibility reasons this is going to stay.
Introduce a pre-merge-commit hook which is called for an automatic merge
commit just like pre-commit is called for a non-automatic merge commit
(or any other commit
f8b863598c ("builtin/merge: honor commit-msg hook for merges", 2017-09-07)
introduced the no-verify flag to merge for bypassing the commit-msg
hook, though in a different way from the implementation in commit.c.
Change the implementation in merge.c to be the same as in commit.c so
that both do the
Analogous to commit, introduce a '--no-verify' option which bypasses the
pre-merge-commit hook. The shorthand '-n' is taken by '--no-stat'
already.
[js: * reworded commit message to reflect current state of --no-stat flag
and new hook name
* fixed flag documentation to reflect new hook
Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Jeff King writes:
>>
+ if (mailmap < 0)
mailmap = 0;
- }
>>>
>>> This should be "mailmap = 1" to match the commit message, no? (Which
>>> also implies we may want a new test).
>>
[...]
> +test_expect_success 'log.mai
Junio C Hamano writes:
> Jeff King writes:
>
>>> + if (mailmap < 0)
>>> mailmap = 0;
>>> - }
>>
>> This should be "mailmap = 1" to match the commit message, no? (Which
>> also implies we may want a new test).
>
> Gaa, of course.
-- >8 --
From: Junio C Hamano
Date: Thu, 1 Aug 20
+Junio
On 8/1/19 1:12 AM, Johannes Schindelin wrote:
Hi,
On Mon, 29 Jul 2019, Pratyush Yadav wrote:
On 29/07/19 7:58 AM, Mark Levedahl wrote:
On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at
22:10:29, Pratyush Yadav wrote:
The function is not documented, and I only started spel
On Thu, Aug 01, 2019 at 09:07:56AM -0700, Varun Naik wrote:
> It is possible to delete a committed file from the index and then add it
> as intent-to-add. After `git checkout HEAD`, the file should be
> identical in the index and HEAD. The command already works correctly if
> the file has contents
Jeff King writes:
>> +if (mailmap < 0)
>> mailmap = 0;
>> -}
>
> This should be "mailmap = 1" to match the commit message, no? (Which
> also implies we may want a new test).
Gaa, of course.
> I'd also be OK with leaving it at "0" for now, making a note of the
> upcoming cha
On Thu, Aug 01, 2019 at 01:05:12PM -0700, Junio C Hamano wrote:
> [Graduated to "master"]
> [...]
> * jk/repack-silence-auto-bitmap-warning (2019-07-31) 3 commits
> (merged to 'next' on 2019-07-31 at 3aa218347c)
> + repack: simplify handling of auto-bitmaps and .keep files
> + repack: silence
Hi Bryan,
On Wed, 31 Jul 2019, Bryan Turner wrote:
> On Wed, Jul 31, 2019 at 5:43 AM Johannes Schindelin
> wrote:
> >
> > Hi,
> >
> > On Mon, 29 Jul 2019, Junio C Hamano wrote:
> >
> > > An early preview release Git v2.23.0-rc0 is now available for
> > > testing at the usual places. It is compr
Hi,
On Wed, 31 Jul 2019, Ariadne Conill wrote:
> Hello,
>
> On Wed, Jul 31, 2019 at 10:21 PM Junio C Hamano wrote:
> >
> > Jeff King writes:
> >
> > > This seems OK to me, though I kind of wonder if anybody really wants
> > > "auto". Unlike log.decorate, which changes the syntax, there is no re
Take new approach using the NamedTemporaryFile() file-like object as input
to the ZipFile() which auto-deletes after implicit close leaving with scope.
Original code produced double-open problems on Windows platform from using
already open NamedTemporaryFile() generated filename instead of object.
On Thu, Aug 01, 2019 at 08:45:54AM -0700, Junio C Hamano wrote:
> While I think "revert to hardcoded default" may be a good idea, I do
> not think the hardcoded default you implemented that changes the
> behaviour based on the output destination makes much sense. If I
> want to eradicate jun...@c
"Jeff Hostetler via GitGitGadget" writes:
> From: Jeff Hostetler
>
> Trim leading/trailing whitespace from the command line
> printed in the "start" message in the perf target format.
>
> We use `sq_quote_argv_pretty()` to format the message
> and it adds a leading space to the output. Trim tha
Looking for help with this problem:
https://stackoverflow.com/questions/57316783/git-clone-single-branch-does-not-work-for-sha-commit-ids
Essentially looking for:
git clone --single-commit
since
git clone --single-branch=
doesn't seem to work?
any help appreciated.
-alex
--
Alexander D. M
On 01.08.2019 22:45, Junio C Hamano wrote:
That does not mean that any patch along that line will automatically
be accepted, of course, so the answer to "am I ready to accept"
question is a definite no. No, I am not ready---we will have to
look at the actual patches before deciding.
That's why
Alexandr Miloslavskiy writes:
> On 01.08.2019 17:56, Junio C Hamano wrote:
>> So, reading paths from a file (which could be "-" as you suggest)
>> would be a good solution for that.
>
> To summarize:
> 1) Implement --paths-file for high-level commands.
> 2) '--paths-file -' would mean reading fro
On 01.08.2019 22:26, Junio C Hamano wrote:
All true. Perhaps we need a separate tutorial for scripters to
teach them how to properly combine the plumbing commands?
@Phillip thanks for your effort!
However, I must admit that for us, this cure is worse then the problem.
We're not exactly scrip
Phillip Wood writes:
> No but it only takes paths not pathspecs, can you filter out the
> ignored paths first? From a UI point of view it would be better not to
> allow users to select ignored files if you don't want to be able to
> add them. If you want to use a pathspec then you can do 'git ls-
Mateusz Loskot writes:
> Is there any other way, without remembering to `git merge` with `--log`?
"git config merge.log true"?
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
You can find the changes described
Hi,
When cherry-picking a merge with `cherry-pick -x -m 1 `,
is it possible to populate the log message with (short) log of all
commits that have been merged by the merge commit ?
The only workaround to copy the log messages along with
cherry-picked changes is to always merge copying all log
mess
On Thu, 1 Aug 2019 at 17:57, Junio C Hamano wrote:
>
> Martin Ågren writes:
>
> > Fix the spelling of the new "--no-show-forced-updates" option that "git
> > fetch/pull" learned. Similarly, spell "--function-context" correctly and
> > fix a few typos, grammos and minor mistakes.
> >
> > One of th
On 7/31/2019 11:01 AM, Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, Jul 30 2019, Derrick Stolee via GitGitGadget wrote:
>
>> +feature.*::
>> +The config settings that start with `feature.` modify the defaults of
>> +a group of other config settings. These groups are created by the Git
>> +
SZEDER Gábor writes:
> On Thu, Aug 01, 2019 at 05:53:09PM +0200, SZEDER Gábor wrote:
>> Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific
>> tests at the end
>
> This subject line kind of sucks, doesn't it?!
>
> Alas I had a bit of a hard time coming up with something bet
On 7/31/2019 12:38 AM, Jeff King wrote:
> We store and manipulate the cumulative traverse_info.pathlen as an
> "int", which can overflow when we are fed ridiculously long pathnames
> (e.g., ones at the edge of 2GB or 4GB, even if the individual tree entry
> names are smaller than that). The results
On 2019.07.26 15:03, Josh Steadmon wrote:
[snip]
> [ajv-cli] can validate the full 1.7M line trace output in just over a
> minute. Moreover, it has helpful output when validation fails. So I
> would be happy to re-implement this using ajv-cli.
Unfortunately, ajv on Travis is much slower than on my
On 8/1/2019 11:53 AM, SZEDER Gábor wrote:
> 't5510-fetch.sh' sources 'lib-httpd.sh' near the end to run a
> httpd-specific test, but 'lib-httpd.sh' skips all the rest of the test
> script if the dependencies for running httpd tests are not fulfilled.
> Alas, recently cdbd70c437 (fetch: add --[no-]s
On Thu, Aug 01, 2019 at 05:53:09PM +0200, SZEDER Gábor wrote:
> Subject: Re: [PATCH 3/3] tests: warn against appending non-httpd-specific
> tests at the end
This subject line kind of sucks, doesn't it?!
Alas I had a bit of a hard time coming up with something better. So
far the best (well, leas
On 01/08/2019 14:25, Alexandr Miloslavskiy wrote:
On 31.07.2019 19:19, Jeff King wrote:
I don't have any real objection to adding stdin support for more
commands. Bu tin the specific case you're discussing, it seems like
using "git update-index" might already solve your problem. It's the
intende
Varun Naik writes:
> It is possible to delete a committed file from the index and then add it
> as intent-to-add. After `git checkout HEAD`, the file should be
> identical in the index and HEAD.
We should write this as `git checkout HEAD `; with the
command without the form, the files changed i
On 7/31/2019 8:49 PM, Jeff King wrote:
On Wed, Jul 31, 2019 at 07:12:57PM -0400, Jeff King wrote:
Hrm. But common-main calls initialize_the_repository(), which points it
at &the_repo. And I can't find any other assignments. So how does it
become NULL? And is every caller of have_git_dir() at
94da9193a6 ("grep: add support for PCRE v2", 2017-06-01) introduced
a small memory leak visible with valgrind in t7813.
Complete the creation of a PCRE2 specific variable that was missing from
the original change and free the generated table just like it is done
for PCRE1.
The table cleanup use f
It is possible to delete a committed file from the index and then add it
as intent-to-add. Certain forms of `git diff` should show the file.
After `git reset HEAD`, the file should be identical in the index and
HEAD. The commands already work correctly if the file has contents in
HEAD. This patch p
Hello,
On Thu, Aug 1, 2019 at 10:46 AM Junio C Hamano wrote:
>
> Jonathan Nieder writes:
>
> > Although as Dscho mentions, it's particularly irritating because it is
> > not part of the paginated output.
> > ...
> > Let's bite the bullet and jump straight to --use-mailmap in case (4).
> >
> > Wh
`git restore --staged` uses the same machinery as `git checkout HEAD`,
so there should be a similar test case for "restore" as the existing
test case for "checkout" with deleted ita files.
Helped-by: Jeff King
Signed-off-by: Varun Naik
---
This is the "restore" patch based on the merge of the "c
It is possible to delete a committed file from the index and then add it
as intent-to-add. After `git checkout HEAD`, the file should be
identical in the index and HEAD. The command already works correctly if
the file has contents in HEAD. This patch provides the desired behavior
even when the file
On 01.08.2019 17:56, Junio C Hamano wrote:
So, reading paths from a file (which could be "-" as you suggest)
would be a good solution for that.
To summarize:
1) Implement --paths-file for high-level commands.
2) '--paths-file -' would mean reading from stdin.
Is that something you're ready to
Martin Ågren writes:
> Fix the spelling of the new "--no-show-forced-updates" option that "git
> fetch/pull" learned. Similarly, spell "--function-context" correctly and
> fix a few typos, grammos and minor mistakes.
>
> One of these is also in 2.22.1.txt, so fix it there too.
>
> Signed-off-by:
Martin Ågren writes:
> Fix the spelling of the new "--no-show-forced-updates" option that "git
> fetch/pull" learned. Similarly, spell "--function-context" correctly and
> fix a few typos, grammos and minor mistakes.
>
> One of these is also in 2.22.1.txt, so fix it there too.
>
> Signed-off-by:
René Scharfe writes:
> Would it make sense to have a --paths-file parameter instead that allows
> reading paths from a given file and honors the convention of reading
> from stdin with the special argument "-"? Reading from stdin would
> still only work for one parameter at a time, but paths cou
't5703-upload-pack-ref-in-want.sh' sources 'lib-httpd.sh' near the end
to run a couple of httpd-specific tests, but 'lib-httpd.sh' skips all
the rest of the test script if the dependencies for running httpd
tests are not fulfilled. However, the last six tests in 't5703' are
not httpd-specific, but
We have a couple of test scripts that are not completely
httpd-specific, but do run a few httpd-specific tests at the end.
These test scripts source 'lib-httpd.sh' somewhere mid-script, which
then skips all the rest of the test script if the dependencies for
running httpd tests are not fulfilled.
> Hrm... It looks like there is nothing httpd-specific in this test
> case, at all, so we could run it even if a webserver is not available.
> Moving this test case earlier in the script seems to confirm it, as it
> still succeeds.
It turns out 't5510' is not the only test script that contains
no
't5510-fetch.sh' sources 'lib-httpd.sh' near the end to run a
httpd-specific test, but 'lib-httpd.sh' skips all the rest of the test
script if the dependencies for running httpd tests are not fulfilled.
Alas, recently cdbd70c437 (fetch: add --[no-]show-forced-updates
argument, 2019-06-18) appended
Jonathan Nieder writes:
> Although as Dscho mentions, it's particularly irritating because it is
> not part of the paginated output.
> ...
> Let's bite the bullet and jump straight to --use-mailmap in case (4).
>
> While at it, add a new log.mailmap setting "auto" that can be used to
> explicitly
> From: Andrey
> Sent: Wednesday, 31 July, 2019 21:35
> To: Philip McGraw
> Cc: git@vger.kernel.org; l...@diamand.org
> Subject: Re: [PATCH] git-p4: close temporary file before removing
>
> 31.07.2019, 17:52, "Philip McGraw" :
> > 2019.07.31 10:09 Andrey
> >> 31.07.2019, 09:53, "Philip McGraw"
On 01.08.2019 16:26, René Scharfe wrote:
Would it make sense to have a --paths-file parameter instead
Both approaches (stdin or file) will work well for us. File sounds
easier from programming perspective. However, in previous discussion,
there was some concern about possible security problems
Am 31.07.19 um 17:45 schrieb Alexandr Miloslavskiy:
> Our suggestion is to change commands such as 'commit', 'add', etc to
> also work with --stdin-paths. If a command already supports stdin for
> any purpose, then trying to use both options will return an error.
Would it make sense to have a --pa
Fix the spelling of the new "--no-show-forced-updates" option that "git
fetch/pull" learned. Similarly, spell "--function-context" correctly and
fix a few typos, grammos and minor mistakes.
One of these is also in 2.22.1.txt, so fix it there too.
Signed-off-by: Martin Ågren
---
Documentation/Re
Hi all,
The test finally finished, and the only failures where:
t0016 (reported), t0066 (reported), t9001 (no valid sendmail, expected to
fail), t9020 (no SVN expected to fail)
Looking forward to rc1.
Cheers,
Randall
On 31.07.2019 19:19, Jeff King wrote:
I don't have any real objection to adding stdin support for more
commands. Bu tin the specific case you're discussing, it seems like
using "git update-index" might already solve your problem. It's the
intended plumbing for scripted index updates, and it alrea
Zdravstvujte! Vas interesuyut klientskie bazy dannyh?
65 matches
Mail list logo
