On Fri, Jul 26, 2019 at 1:57 AM Jeff King wrote:
>
> On Thu, Jul 25, 2019 at 09:56:45PM -0700, Varun Naik wrote:
>
> > It is possible to delete a committed file from the index and then add it
> > as intent-to-add. After `git checkout HEAD` or `git restore --staged`,
> > the file should be identica
On Fri, Jul 26, 2019 at 11:20 AM Junio C Hamano wrote:
>
> Varun Naik writes:
>
> > It is possible to delete a committed file from the index and then add it
> > as intent-to-add. After `git reset HEAD`, the file should be identical
> > in the index and HEAD. This patch provides the desired behavi
On Sun, Jul 28, 2019 at 9:57 PM Junio C Hamano wrote:
>
> I am not sure I like a config-only knob like this,
> though---shouldn't we have a command line knob to turn jit off
> first, and then for those who gets tired of having to type it all
> the time add the configuration to flip the default for
Christopher Head writes:
> On July 27, 2019 1:57:18 PM PDT, Junio C Hamano wrote:
> ...
>>In the reverse direction, I think "git fetch" supports the notion of
>> of repositories, so that fetch from multiple remotes can be
>>initiated with a single command, but I am not sure if we added the
>>sam
"brian m. carlson" writes:
> These are probably pretty cheap on all but the largest repositories. I
> was worried we were enumerating all refs or all history or something
> like that.
>
>> ui_do_rescan changes the focus to the first diff. It is executed when you
>> press F5 or choose Rescan from
Carlo Marcelo Arenas Belón writes:
> PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never
> had one, forcing the use of JIT if -P was requested.
>
> After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15)
> the PCRE2 engine will be used more broadly and therefore add
Jeff King writes:
> On Sun, Jul 28, 2019 at 01:07:19PM -0700, Carlo Marcelo Arenas Belón wrote:
>
>> This series is a reroll of jk/no-system-includes-in-dot-c with
>> cb/xdiff-no-system-includes-in-dot-c applied on top with minor
>> fixes for the commit message based on feedback from Johannes
>>
Elijah Newren writes:
> I thought about that briefly yesterday, but the fact that the
> write_locked_index() call only happens if !cache_tree_fully_valid()
> meant refactoring slightly more to get the helper to also return that
> boolean value, and since I was a little unsure of myself with
> cac
On Fri, Jul 26, 2019 at 8:09 AM Ævar Arnfjörð Bjarmason
wrote:
>
> This patch does nothing to fix that, instead we sneak in support for
> fixed patterns starting with "(*NO_JIT)", this disables the PCRE v2
> jit with implicit fixed-string matching for testing, see
> pcre2syntax(3) the syntax.
Alt
On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at 22:10:29,
Pratyush Yadav wrote:
>> The function is not documented, and I only started spelunking the code a
>> couple days back, so I'll try to answer with what I know. It might
not be
>> the full picture.
>>
>> Running git-gui --tra
On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at 22:10:29,
Pratyush Yadav wrote:
>> The function is not documented, and I only started spelunking the code a
>> couple days back, so I'll try to answer with what I know. It might
not be
>> the full picture.
>>
>> Running git-gui --tra
On 7/28/19 6:49 PM, brian m. carlson wrote:> On 2019-07-28 at 22:10:29,
Pratyush Yadav wrote:
>> The function is not documented, and I only started spelunking the code a
>> couple days back, so I'll try to answer with what I know. It might
not be
>> the full picture.
>>
>> Running git-gui --tra
On Fri, Jul 26, 2019 at 8:09 AM Ævar Arnfjörð Bjarmason
wrote:
>
> It's less confusing to use that variable consistently that switch back
> & forth between the two.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason
> ---
> grep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/
On Fri, Jul 26, 2019 at 8:09 AM Ævar Arnfjörð Bjarmason
wrote:
>
> It will also implicitly re-enable UTF-8 validation for PCRE v1. As
> noted in [1] we now have cases as a result where PCRE v1 is more eager
> to error out. Subsequent patches will fix that for v2, and I think
> it's fair to tell v1
On Fri, Jul 26, 2019 at 8:08 AM Ævar Arnfjörð Bjarmason
wrote:
>
> As noted in [3] there are known regexes that will fail with the lower
> stack limit, the way GNU grep fixed it is interesting, although I
> believe the implementation is overly verbose, they could make PCRE v2
> handle that gradual
On Sun, Jul 28, 2019 at 4:54 PM Carlo Marcelo Arenas Belón
wrote:
> @@ -125,6 +126,12 @@ int grep_config(const char *var, const char *value, void
> *cb)
> return 0;
> }
>
> + if (!strcmp(var, "pcre.jit")) {
> + int is_bool;
> + opt->pcre_j
PCRE1 allowed for a compile time flag to disable JIT, but PCRE2 never
had one, forcing the use of JIT if -P was requested.
After ed0479ce3d (Merge branch 'ab/no-kwset' into next, 2019-07-15)
the PCRE2 engine will be used more broadly and therefore adding this
knob will give users a fallback for si
On Fri, Jul 26, 2019 at 02:10:58PM -0400, James Ramsay wrote:
> While investigating improvements to clone performance at GitLab we've been
> looking at how to trigger packfile reuse during clones. A challenge of the
> investigation and a future challenge of rolling out changes to encourage
> more
On 2019-07-28 at 22:10:29, Pratyush Yadav wrote:
> The function is not documented, and I only started spelunking the code a
> couple days back, so I'll try to answer with what I know. It might not be
> the full picture.
>
> Running git-gui --trace, these commands are executed during a rescan:
>
>
On 29/07/19 3:40 AM, Pratyush Yadav wrote:
Hi Brian,
On 29/07/19 3:06 AM, brian m. carlson wrote:
On 2019-07-28 at 15:17:26, Pratyush Yadav wrote:
If any changes are made to the tree while git-gui is open, the user has
to manually rescan to see those changes in the gui. With this change, a
res
On Sun, Jul 28, 2019 at 01:07:19PM -0700, Carlo Marcelo Arenas Belón wrote:
> This series is a reroll of jk/no-system-includes-in-dot-c with
> cb/xdiff-no-system-includes-in-dot-c applied on top with minor
> fixes for the commit message based on feedback from Johannes
> and the example put forward
Hi Brian,
On 29/07/19 3:06 AM, brian m. carlson wrote:
On 2019-07-28 at 15:17:26, Pratyush Yadav wrote:
If any changes are made to the tree while git-gui is open, the user has
to manually rescan to see those changes in the gui. With this change, a
rescan will be performed whenever the window co
Playing with it for some time, I see some problems with the patch.
Firstly, "bind ." binds that event for the root window and all
subwindows. This means we rescan multiple times on a single FocusIn
event, once for every window. This can be fixed easily with a check for
the root window (aka "."
On 2019-07-28 at 15:17:26, Pratyush Yadav wrote:
> If any changes are made to the tree while git-gui is open, the user has
> to manually rescan to see those changes in the gui. With this change, a
> rescan will be performed whenever the window comes in focus, removing
> the need for manual rescans
On Thu, Jul 25, 2019 at 5:19 PM Junio C Hamano wrote:
> [Stalled]
>
> * cb/xdiff-no-system-includes-in-dot-c (2019-06-19) 1 commit
> - xdiff: avoid accidental redefinition of LFS feature in OpenIndiana
>
> Compilation fix.
>
> Will be rerolled together with patches from the
> jk/no-system-incl
This series is a reroll of jk/no-system-includes-in-dot-c with
cb/xdiff-no-system-includes-in-dot-c applied on top with minor
fixes for the commit message based on feedback from Johannes
and the example put forward by Peff with his own patches.
The changes proposed shouldn't affect any systems (ex
After b46054b374 ("xdiff: use git-compat-util", 2019-04-11), two system
headers added with 6942efcfa9 ("xdiff: load full words in the inner loop
of xdl_hash_record", 2012-04-06) to xutils.c are no longer needed and
could conflict as shown below from an OpenIndiana build:
In file included from xdif
From: Jeff King
There's no reason verify-tag.c needs to include signal.h. It's already
in git-compat-util.h, which we properly include as the first header.
And there doesn't seem to be a particular reason for this include; it's
just an artifact from the file creation in 2ae68fcb78 (Make verify-ta
8c912eea94 ("teach --histogram to diff", 2011-07-12) included them, but
were already part of xinclude.h
Signed-off-by: Carlo Marcelo Arenas Belón
---
xdiff/xhistogram.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xdiff/xhistogram.c b/xdiff/xhistogram.c
index ec85f5992b..c7b35a9667 10064
From: Jeff King
We started including stdio.h to pick up the declaration of "FILE" in
f26a001226 (Enable wt-status output to a given FILE pointer.,
2007-09-17). But there's no need, since headers can assume that
git-compat-util.h has been included, which covers stdio.
This should just be redundan
92b7de93fb (Implement the patience diff algorithm, 2009-01-07) added them
but were already part of xinclude.h
Signed-off-by: Carlo Marcelo Arenas Belón
---
xdiff/xpatience.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/xdiff/xpatience.c b/xdiff/xpatience.c
index f3573d9f00..3c5601b602 10
If any changes are made to the tree while git-gui is open, the user has
to manually rescan to see those changes in the gui. With this change, a
rescan will be performed whenever the window comes in focus, removing
the need for manual rescans in most cases. A manual rescan will still be
needed when
On Sun, Jul 28, 2019 at 09:23:18AM +0200, Matthias Beyer wrote:
>
> So what I am looking for is tools to automate contributor and maintainer
> workflow, especially:
>
> 1) Repliying to each emailpatch of a set of patches with
>"Reviewed-by: " (or other trailers)
>
>Szenario: I see a patc
Hello git community,
I write this email because after several attempts over several months of
searching the internet for this, I still fail to find a proper documentation
and/or tools for the workflow. So this is my last resort.
So what I am looking for is tools to automate contributor and mainta
34 matches
Mail list logo
