Re: [PATCH] grep: skip UTF8 checks explicitally

2019-07-22 Thread Carlo Arenas
On Mon, Jul 22, 2019 at 12:42 PM Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jul 22 2019, Johannes Schindelin wrote: > > > So I am fine with this patch. > > I'm not, not because I dislike the approach. I haven't made up my mind > yet. my bad, I should had explained better the regression I was tryi

[PATCH] archive: Store checksum correctly

2019-07-22 Thread Matt Turner
tar2sqfs (part of https://github.com/topics/tar2sqfs) rejects tarballs made with git archive with the message invalid tar header checksum! tar2sqfs recomputes the tarball's checksum to verify it. Its checksum implementation agrees with GNU tar, which contains a comment that states Fill i

Re: [GSoC] My project blog

2019-07-22 Thread Matheus Tavares Bernardino
Hi, everyone Unfortunately, not quite much to report this week :( I'm attending DebConf until July 28th but I'm trying to conciliate that with the work on my project. You can see my brief report of last week here: https://matheustavares.gitlab.io/posts/week-9-an-rfc-on-parallel-inflation As alway

Draft of Git Rev News edition 53

2019-07-22 Thread Christian Couder
Hi everyone! A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-53.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this

Re:

2019-07-22 Thread Mr Frank Park
Are you interested in a Loan? We offer Loan at 2% interest rate. if you are interested please send us the amount and your personal details for processing.

[PATCH] Close transport helper on protocol error

2019-07-22 Thread thibault . jamet
From: Thibault Jamet We have noticed that in some cases, when the transport is not fully compliant with the protocol, git exits with a status of 128 without closing the transport. This usually does not have consequences in a standard unix environment as the process gets then attached to the init

Re: Possible bug in Makefile when executing curl-config

2019-07-22 Thread Jeff King
[+cc the author of that patch] On Mon, Jul 22, 2019 at 07:46:37PM +, Raitanen, Adam wrote: > I believe there may be a bug in the Makefile introduced by the following > commit: > > https://github.com/git/git/commit/23c4bbe28e61974577164db09cbd1d1c7e568ca4 > > The commit was merged in 2.20.0

Re: [PATCH] credential: add nocache option to the credentials API

2019-07-22 Thread Jeff King
On Mon, Jul 22, 2019 at 10:30:52AM -0700, Masaya Suzuki wrote: > > In that patch, I essentially proposed making all gathered credentials as > > nocache. That's a more secure default (though in some cases less > > convenient). > > > > It did break a case Shawn had of caching the result of another h

Possible bug in Makefile when executing curl-config

2019-07-22 Thread Raitanen, Adam
I believe there may be a bug in the Makefile introduced by the following commit: https://github.com/git/git/commit/23c4bbe28e61974577164db09cbd1d1c7e568ca4 The commit was merged in 2.20.0: * The way -lcurl library gets linked has been simplified by taking    advantage of the fact that we can jus

Re: [PATCH] grep: skip UTF8 checks explicitally

2019-07-22 Thread Ævar Arnfjörð Bjarmason
On Mon, Jul 22 2019, Johannes Schindelin wrote: > Hi Carlo, > > On Sun, 21 Jul 2019, Carlo Marcelo Arenas Belón wrote: > >> Usually PCRE is compiled with JIT support, and therefore the code >> path used includes calling pcre2_jit_match (for PCRE2), that ignores >> invalid UTF-8 in the corpus. >>

Re: What's cooking in git.git (Jul 2019, #04; Thu, 18)

2019-07-22 Thread Matthew DeVore
On Thu, Jul 18, 2019 at 03:36:06PM -0700, Junio C Hamano wrote: > * md/list-objects-filter-combo (2019-06-28) 10 commits > ... > > There is a bit of interaction with cc/multi-promisor topic, whose > conflict resolution I have no confidence in X-<. Extra sets of > eyes are appreciated. > ... >

[PATCH] grep: print the pcre2_jit_on value

2019-07-22 Thread Beat Bolli
When pcre2_jit_on is neither 1 nor 0, the BUG() call printed the value of pcre1_jit_on. Print the value of pcre2_jit_on instead. Signed-off-by: Beat Bolli --- grep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grep.c b/grep.c index f7c3a5803e..cd952ef5d3 100644 --- a/gre

[PATCH 2/5] repo-settings: add feature.manyCommits setting

2019-07-22 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee When a repo has many commits, it is helpful to write and read the commit-graph file. Future changes to Git may include new config settings that are benefitial in this scenario. Create the 'feature.manyCommits' config setting that changes the default values of 'core.commitGra

[PATCH 3/5] repo-settings: parse core.untrackedCache

2019-07-22 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The core.untrackedCache config setting is slightly complicated, so clarify its use and centralize its parsing into the repo settings. The default value is "keep" (returned as -1), which persists the untracked cache if it exists. If the value is set as "false" (returned as 0

[PATCH 1/5] repo-settings: consolidate some config settings

2019-07-22 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee There are a few important config settings that are not loaded during git_default_config. These are instead loaded on-demand. Centralize these config options to a single scan, and store all of the values in a repo_settings struct. The values for each setting are initialized a

[PATCH 4/5] repo-settings: create feature.manyFiles setting

2019-07-22 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The feature.manyFiles setting is suitable for repos with many files in the working directory. By setting index.version=4 and core.untrackedCache=true, commands such as 'git status' should improve. While adding this setting, modify the index version precedence tests to check

[PATCH 0/5] Create 'feature.*' config area and some centralized config parsing

2019-07-22 Thread Derrick Stolee via GitGitGadget
This is a brand-new thread to replace ds/early-access. The discussion on that thread was very helpful [1]. With this in mind, I propose instead a set of "feature.*" config settings that form groups of "community recommended" settings (with some caveats). In the space below, I'll list a set of poss

[PATCH 5/5] repo-settings: create feature.experimental setting

2019-07-22 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The 'feature.experimental' setting includes config options that are not committed to become defaults, but could use additional testing. Update the following config settings to take new defaults, and to use the repo_settings struct if not already using them: * 'pack.useSpars

Re: [PATCH] credential: add nocache option to the credentials API

2019-07-22 Thread Masaya Suzuki
On Tue, Jul 9, 2019 at 5:56 AM Jeff King wrote: > > On Sat, Jul 06, 2019 at 10:51:32PM -0700, Masaya Suzuki wrote: > > > The credentials API calls credentials helpers in order. If a > > username/password pair is returned the helpers and if it's used for > > authentication successfully, it's announ

[PATCH] grep: skip UTF8 checks explicitly

2019-07-22 Thread Carlo Marcelo Arenas Belón
Usually PCRE is compiled with JIT support, and therefore the code path used includes calling pcre2_jit_match (for PCRE2), that ignores invalid UTF-8 in the corpus. Make that option explicit so it can be also used when JIT is not enabled and pcre2_match is called instead, preventing `git grep` to a

[RFC] Improved git signing interface

2019-07-22 Thread Ibrahim El Rhezzali
Hi Everyone, I have been selected by the Linux Foundation to work on a summer project. I would like to abstract the git signing interface and add support for signatures using decentralized identifiers (DID). Decentralized identifiers are an emerging standard [0] that allows individuals to control

Re: [PATCH v3 0/3] [RFC] Create 'core.featureAdoptionRate' setting to update config defaults

2019-07-22 Thread Derrick Stolee
On 7/9/2019 6:05 PM, Junio C Hamano wrote: > Derrick Stolee writes: > >> From this list, do you think any of these settings are likely to >> become defaults? It seems that protocol.version = 2 may be a default >> now that _most_ services have an implementation, and it always falls >> back to prot

Re: [PATCH] grep: skip UTF8 checks explicitally

2019-07-22 Thread Johannes Schindelin
Hi Carlo, On Sun, 21 Jul 2019, Carlo Marcelo Arenas Belón wrote: > Usually PCRE is compiled with JIT support, and therefore the code > path used includes calling pcre2_jit_match (for PCRE2), that ignores > invalid UTF-8 in the corpus. > > Make that option explicit so it can be also used when JIT

Re: [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag

2019-07-22 Thread Phillip Wood
Hi Rohit, It's good to see another patch reducing the differences between the rebase back ends. On 18/07/2019 19:55, Rohit Ashiwal wrote: > There are two backends available for rebasing, viz, the am and the > interactive. Naturally, there shall be some features that are > implemented in one but n