On Thu, Jun 27, 2019 at 01:25:15AM -0400, Jeff King wrote:
> Taylor and I noticed a slowdown in p1451 between v2.20.1 and v2.21.0. I
> was surprised to find that it bisects to bbb15c5193 (fsck: reduce word
> legos to help i18n, 2018-11-10).
>
> The important part, as it turns out, is the switch t
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It may be illuminating to see which objects were not included within a
> given filter. This also demonstrates, since filter-spec "tree:1" is
> used, that the 'omitted' list contains all objects which are omitted,
> not just the first objects w
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Demonstrate how filter specs can be used when performing a revision walk
> of all object types. In this case, tree depth is used. Contributors who
> are following the revision walking tutorial will be encouraged to run
> the revision walk with
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Provide a demonstration of a revision walk which traverses all types of
> object, not just commits. This type of revision walk is used for
> operations such as creating packfiles and performing fetches or clones,
> so it's useful to teach new
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> The final installment in the tutorial about sorting revision walk
> outputs. This commit reverses the commit list, so that we see newer
> commits last (handy since we aren't using a pager).
>
> It's important to note that rev->reverse needs to
Taylor and I noticed a slowdown in p1451 between v2.20.1 and v2.21.0. I
was surprised to find that it bisects to bbb15c5193 (fsck: reduce word
legos to help i18n, 2018-11-10).
The important part, as it turns out, is the switch to using fprintf_ln()
instead of a regular fprintf() with a "\n" in it.
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Order the revision walk by author or commit dates, to demonstrate how to
s/,//
> apply topo_sort to a revision walk.
>
> While following the tutorial, new contributors are guided to run a walk
> with each sort and compare the results.
>
> Si
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> In order to demonstrate how to create grep filters for revision walks,
> filter the walk performed by cmd_walken() to print only commits which
> are authored by someone with a gmail address.
> [...]
> Signed-off-by: Emily Shaffer
> ---
> diff
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> Add the final steps needed and implement the walk loop itself. We add a
> method walken_commit_walk() which performs the final setup to revision.c
> and then iterates over commits from get_revision().
> [...]
> Signed-off-by: Emily Shaffer
>
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> `struct rev_info` is what's used by the struct itself.
What "struct itself"? Do you mean 'struct rev_info' is used by the
_walk_ itself? Or something?
> `repo_init_revisions()` initializes the struct; then we need to set it
> up for the walk
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> For now, we have no configuration options we want to set up for
> ourselves, but in the future we may need to. At the very least, we
> should invoke git_default_config() for each config option; we will do so
> inside of a skeleton config callb
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It's expected that Git commands support '-h' in order to provide a
> consistent user experience (and this expectation is enforced by the
> test suite). '-h' is captured by parse_options() by default; in order to
> support this flag, we add a s
On Wed, Jun 26, 2019 at 7:51 PM Emily Shaffer wrote:
> It's expected that Git commands support '-h' in order to provide a
> consistent user experience (and this expectation is enforced by the
> test suite). '-h' is captured by parse_options() by default; in order to
> support this flag, we add a s
On Thu, Jun 27, 2019 at 2:58 AM Junio C Hamano wrote:
>
> Nguyễn Thái Ngọc Duy writes:
>
> > This is small refinements (except 4/4).
>
> What's the status of these?
Small test fixup needed. I should be able to do it later today.
> As another low-prio topic interferes
> with the code touched by
On Thu, Jun 27, 2019 at 1:51 AM Junio C Hamano wrote:
> > - @{literal} only accepts full ref. No turning "master" into
> > "refs/heads/master".
>
> This is already doable by saying "refs/heads/master", isn't it? Any
> ambiguous ones like a branch or a tag whose name is 'refs/heads/master'
> (i.
On 2019-06-26 at 00:03:26, Ævar Arnfjörð Bjarmason wrote:
> diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
> index 2d27969057..c89fb569e3 100644
> --- a/Documentation/git-grep.txt
> +++ b/Documentation/git-grep.txt
> @@ -271,6 +271,23 @@ providing this option will cause it to
On 2019-06-26 at 23:52:47, Mike Hommey wrote:
> Hi,
>
> I was surprised to figure out that urls/pushurls set up for remotes can
> be set multiple times, and that those urls end up being used
> sequentially.
Yes, this is actually a feature. It's useful when you want to push to
multiple remotes at
On Fri, Jun 21, 2019 at 03:58:38PM -0700, Jonathan Tan wrote:
> So what happens is that filter_fn, filter_free_fn, and filter_data are
> encapsulated into one opaque object, and users will now use filter_fn
> and filter_free_fn through other functions that we expose, allowing us
> to add some conve
On Wed, Jun 26, 2019 at 3:44 PM Taylor Blau wrote:
>
> Since cfe004a5a9 (ref-filter: limit traversal to prefix, 2017-05-22),
> the ref-filter code has sought to limit the traversals to a prefix of
> the given patterns.
>
> That code stopped short of handling more than one pattern, because it
> mea
Hi,
I was surprised to figure out that urls/pushurls set up for remotes can
be set multiple times, and that those urls end up being used
sequentially.
Sadly, this has the side effect that one cannot override the config from
the command line, as the url is then added as an extra url, which is
trie
Demonstrate that just like commit walks, object walks can have their
order reversed. Additionally, add verbose logging of objects encountered
in order to let contributors prove to themselves that the walk has
actually been reversed. With this commit, `git walken` becomes extremely
chatty - it's rec
Demonstrate how filter specs can be used when performing a revision walk
of all object types. In this case, tree depth is used. Contributors who
are following the revision walking tutorial will be encouraged to run
the revision walk with and without the filter in order to compare the
number of obje
`struct rev_info` is what's used by the struct itself.
`repo_init_revisions()` initializes the struct; then we need to set it
up for the walk we want to perform, which is done in
`final_rev_info_setup()`.
The most important step here is adding the first object we want to walk
to the pending array.
Add the final steps needed and implement the walk loop itself. We add a
method walken_commit_walk() which performs the final setup to revision.c
and then iterates over commits from get_revision().
This basic walk only prints the subject line of each commit in the
history. It is nearly equivalent t
The final installment in the tutorial about sorting revision walk
outputs. This commit reverses the commit list, so that we see newer
commits last (handy since we aren't using a pager).
It's important to note that rev->reverse needs to be set after
add_head_to_pending() or before setup_revisions()
It may be illuminating to see which objects were not included within a
given filter. This also demonstrates, since filter-spec "tree:1" is
used, that the 'omitted' list contains all objects which are omitted,
not just the first objects which were omitted - that is, it continues to
dereference omitt
Order the revision walk by author or commit dates, to demonstrate how to
apply topo_sort to a revision walk.
While following the tutorial, new contributors are guided to run a walk
with each sort and compare the results.
Signed-off-by: Emily Shaffer
Change-Id: I7ce2f3e8a77c42001293637ae209087afe
Provide a demonstration of a revision walk which traverses all types of
object, not just commits. This type of revision walk is used for
operations such as creating packfiles and performing fetches or clones,
so it's useful to teach new developers how it works. For starters, only
demonstrate the un
In order to demonstrate how to create grep filters for revision walks,
filter the walk performed by cmd_walken() to print only commits which
are authored by someone with a gmail address.
This commit demonstrates how to append a grep pattern to a
rev_info.grep_filter, to teach new contributors how
Eventually, we will want a good place to initialize default variables
for use during our revision walk(s) in `git walken`. For now, there's
nothing to do here, but let's add the scaffolding so that it's easy to
tell where to put the setup later on.
Signed-off-by: Emily Shaffer
---
builtin/walken
For now, we have no configuration options we want to set up for
ourselves, but in the future we may need to. At the very least, we
should invoke git_default_config() for each config option; we will do so
inside of a skeleton config callback so that we know where to add
configuration handling later
Since r1, made some significant changes.
- Added a commit for counting the 'omitted' list, to match the new
section added to the tutorial.
- Added significant comments to allow the sample to better stand on its
own.
- Fixed style issues (die() formatting, etc)
- Distinguished between hum
Begin to add scaffolding for `git walken`, a toy command which we will
teach to perform a number of revision walks, in order to demonstrate the
mechanics of revision walking for developers new to the Git project.
This commit is the beginning of an educational series which correspond
to the tutoria
It's expected that Git commands support '-h' in order to provide a
consistent user experience (and this expectation is enforced by the
test suite). '-h' is captured by parse_options() by default; in order to
support this flag, we add a short usage text to walken.c and invoke
parse_options().
With
Existing documentation on revision walks seems to be primarily intended
as a reference for those already familiar with the procedure. This
tutorial attempts to give an entry-level guide to a couple of bare-bones
revision walks so that new Git contributors can learn the concepts
without having to wa
Hi Ramsay,
On Thu, Jun 27, 2019 at 12:14 AM Ramsay Jones
wrote:
>
> If you need to re-roll your 'cc/multi-promisor' branch, could you please
> squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
> implement promisor_remote_get_direct()", 2019-06-25).
Sure, I have integrated
Hi,
Peff and I have been experimenting with using the references from a
repository's alternate to speed up the connectivity check following a
'git clone --reference'.
We have noticed that the connectivity check becomes much faster when
advertising both the heads and tags of an alternate, as oppos
Since cfe004a5a9 (ref-filter: limit traversal to prefix, 2017-05-22),
the ref-filter code has sought to limit the traversals to a prefix of
the given patterns.
That code stopped short of handling more than one pattern, because it
means invoking 'for_each_ref_in' multiple times. If we're not carefu
Junio, what do you think of this small patch that just updates a test:
https://public-inbox.org/git/20190605192624.129677-1-jonathanta...@google.com/
For what it's worth, Stolee and Peff have replied and both of them seem
to be OK with it.
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
The third batch of topics post 2.2
Signed-off-by: Ramsay Jones
---
Hi Christian,
If you need to re-roll your 'cc/multi-promisor' branch, could you please
squash this into the relevant patch (commit 9e27beaa23, "promisor-remote:
implement promisor_remote_get_direct()", 2019-06-25).
[No, this is not the same as the April patch!
Signed-off-by: Ramsay Jones
---
Hi Ævar,
If you need to re-roll your 'ab/test-env' branch, could you please
squash this into the relevant patch (commit b4f207f339, "env--helper:
new undocumented builtin wrapping git_env_*()", 2019-06-21).
Thanks!
ATB,
Ramsay Jones
builtin/env--helper.c | 2
Hi Gábor,
On Sun, Jun 02, 2019 at 01:22:39PM +0200, SZEDER Gábor wrote:
> On Sat, Jun 01, 2019 at 12:41:43AM +, brian m. carlson wrote:
> > On 2019-05-30 at 19:32:41, Johannes Schindelin wrote:
> > > Hi Gábor,
> > >
> > > do you have any idea why Travis is failing like this in the macOS/gcc
>
On 6/26/2019 4:03 PM, Carlo Marcelo Arenas Belón wrote:
an apparent typo for the environment variable was included with 81567caf87
("trace2: update docs to describe system/global config settings",
2019-04-15), and was missed when renamed variables by e4b75d6a1d
("trace2: rename environment var
an apparent typo for the environment variable was included with 81567caf87
("trace2: update docs to describe system/global config settings",
2019-04-15), and was missed when renamed variables by e4b75d6a1d
("trace2: rename environment variables to GIT_TRACE2*", 2019-05-19)
Signed-off-by: Carlo Mar
On 6/21/2019 12:33 PM, Junio C Hamano wrote:
"Jeff Hostetler via GitGitGadget" writes:
From: Jeff Hostetler
The --[no-]ahead-behind option was introduced in fd9b544a
(status: add --[no-]ahead-behind to status and commit for V2
format, 2018-01-09). This is a necessary change of behavior
in
Nguyễn Thái Ngọc Duy writes:
> This is small refinements (except 4/4).
What's the status of these? As another low-prio topic interferes
with the code touched by nd/switch-and-restore and hence needs to
wait for these to stabilize, I'd rather see us focus on finishing
these before switching our
Nguyễn Thái Ngọc Duy writes:
> This --json is supposed to help that. It dumps the index in a human
This and another one on the title need to become "--debug-json".
Are we expecting a reroll to introduce another layer above the most
primitive json writer that knows the schema used to represent
Nguyễn Thái Ngọc Duy writes:
> The problem is we try every possible way to resolve a rev. Let's have
> some annotation to express that we only want to resolve a rev in a
> certain way:
>
> - @{hash} only accepts a full hash or a short hash. If it's a
> short hash, it cannot be ambiguous.
This
Johannes Schindelin writes:
> ...
> Ah hah!
>
> If we would not have plenty of exercise for the PCRE2 build options, I
> would be worried. But AFAICT the CI build includes this all the time, so
> we're fine.
Well, I'd feel safer if it were not "all the time", i.e. we know we
are testing both sid
Ævar Arnfjörð Bjarmason writes:
> Move the "grep binary" test case added in aca20dd558 ("grep: add test
> script for binary file handling", 2010-05-22) so that it lives
> alongside the rest of the "grep" tests in t781*. This would have left
> a gap in the t/700* namespace, so move a "filter-bran
On Tue, Jun 25, 2019 at 11:09:08PM +, Pugh, Logan wrote:
> > Or in your case I suppose even better would just be an
> > option like "--if-not-configured-just-use-regular-diff". Then it would
> > do what you want, without impacting users who do want the interactive
> > setup.
>
> If such an op
Johannes Schindelin writes:
> Hi Matheus,
>
> On Tue, 18 Jun 2019, Matheus Tavares wrote:
>
>>[...]
>> +/*
>> + * Look for a recursive symlink at iter->base.path pointing to any
>> directory on
>> + * the previous stack levels. If it is found, return 1. If not, return 0.
>> + */
>> +static int f
Dimitriy writes:
> Seems it can extract plural forms only from Q_ (ngettext() call) and
> cannot from _N (gettext_noop() call) in current configuration[0].
> Maybe in this case we can try to forward already translated string
> to strbuf_humanise():
>
> static void strbuf_humanise(struct strbuf *b
Nguyễn Thái Ngọc Duy writes:
> This is the continuation of nd/sha1-name-c-wo-the-repository. In that
> series I sealed off one place in sha1-name.c that cannot walk trees
> from arbitrary repositories. With tree-walk.c taking 'struct
> repository *' directly, that check in there can now be remov
On 6/26/2019 12:27 PM, Junio C Hamano wrote:
> Derrick Stolee writes:
>
>>> diff --git a/builtin/merge-tree.c b/builtin/merge-tree.c
>>> index 34ca0258b1..97b54caeb9 100644
>>> --- a/builtin/merge-tree.c
>>> +++ b/builtin/merge-tree.c
>>> @@ -205,6 +205,7 @@ static void resolve(const struct trave
Derrick Stolee writes:
>> diff --git a/builtin/merge-tree.c b/builtin/merge-tree.c
>> index 34ca0258b1..97b54caeb9 100644
>> --- a/builtin/merge-tree.c
>> +++ b/builtin/merge-tree.c
>> @@ -205,6 +205,7 @@ static void resolve(const struct traverse_info *info,
>> struct name_entry *ours, s
>> sta
Ævar Arnfjörð Bjarmason writes:
> Change "-f " to not support patterns with "\0" in them under
> --fixed-strings, we'll now only support these under --perl-regexp with
> PCRE v2.
>
> A previous change to Documentation/git-grep.txt changed the
> description of "-f " to be vague enough as to not p
Hi Ramsay,
On Tue, 25 Jun 2019, Ramsay Jones wrote:
> On 25/06/2019 15:10, Johannes Schindelin wrote:
> > Hi Duy,
> [snip]
>
> >> Again our experiences differ. Mine is mostly about extensions,
> >> probably because I had to work on them more often. For normal entries
> >> "ls-files --debug" gives
Hi Ævar,
On Wed, 26 Jun 2019, Ævar Arnfjörð Bjarmason wrote:
> Bring back optimized fixed-string search for "grep", this time with
> PCRE v2 as an optional backend. As noted in [1] with kwset we were
> slower than PCRE v1 and v2 JIT with the kwset backend, so that
> optimization was counterproduc
Hi Ævar,
On Wed, 26 Jun 2019, Ævar Arnfjörð Bjarmason wrote:
> Move the "grep binary" test case added in aca20dd558 ("grep: add test
> script for binary file handling", 2010-05-22) so that it lives
> alongside the rest of the "grep" tests in t781*. This would have left
> a gap in the t/700* names
Hi Ævar,
On Wed, 26 Jun 2019, Ævar Arnfjörð Bjarmason wrote:
> This speeds things up a lot, but as shown in the patches & tests
> changed modifies the behavior where we have \0 in *patterns* (only
> possible with 'grep -f ').
I agree that it is not worth a lot to care about NULs in search patter
Hi Matheus,
On Tue, 18 Jun 2019, Matheus Tavares wrote:
>[...]
> +/*
> + * Look for a recursive symlink at iter->base.path pointing to any directory
> on
> + * the previous stack levels. If it is found, return 1. If not, return 0.
> + */
> +static int find_recursive_symlinks(struct dir_iterator_
On 6/26/2019 4:32 AM, Eugen Konkov wrote:
> Hello,
>
> For next diff the `}` line should not be detected as removed/added.
>
> As you can see there are differences only at new lines. (see attached
> pics)
>
> git version 2.21.0
>
>
> git diff -b -w --ignore-blank-lines
>
>
> git config:
>
Assalamu Alaikum Wa Rahmatullahi Wa Barakatuh,
hello dear
I came across your contact during my private search. Mrs Aisha Al-
Qaddafi is my name, the only daughter of late Libyan president, am a
single Mother and a Widow with three Children.I have funds the sum of
$27.5 million USD for, investme
Cher utilisateur de messagerie,
Dans nos efforts pour fournir un excellent service à tous nos utilisateurs,
nous prévoyons d'effectuer une mise à niveau du système. Le processus prend
environ 30 minutes. Ce message est diffusé depuis quelque temps déjà et nous
conseillons aux utilisateurs de se
Hi Junio
On 20/06/2019 05:35, Junio C Hamano wrote:
* pw/doc-synopsis-markup-opmode-options (2019-06-17) 1 commit
- show --continue/skip etc. consistently in synopsis
Docfix.
Will merge to 'next' and then to 'master'.
Thanks for fixing up the commit message an this one
Best Wishes
Ph
Junio C Hamano writes:
>
> Dimitriy Ryazantcev writes:
>
> > Currenly the data rate in throughput_string(...) method is
> > output by simple strbuf_humanise_bytes(...) call and '/s' append.
> > But for proper translation of such string the translator needs
> > full context.
> >
> > Add strbuf_hum
Hi Junio
Thanks for the comments
On 25/06/2019 21:44, Junio C Hamano wrote:
"Phillip Wood via GitGitGadget" writes:
From: Phillip Wood
commit 4a72486de9 ("fix cherry-pick/revert status after commit",
2019-04-16) used parse_insn_line() to parse the first line of the todo
list to check if it
My good friend
I am Mr. John Ben, the manager of Petroleum Engineer United State Of
America In my department i have a package for you If
you are interested then it is compulsory you contact me with
above details of yours for further procedure.
Your Full Name___
Your Home Ad
Cher utilisateur de messagerie,
Dans nos efforts pour fournir un excellent service à tous nos utilisateurs,
nous prévoyons d'effectuer une mise à niveau du système. Le processus prend
environ 30 minutes. Ce message est diffusé depuis quelque temps déjà et nous
conseillons aux utilisateurs de se
[I feel like this is something we should do, but I'm not sure. Hence
RFC. The patch is mostly to play with if you're curious. The die() thing
there is definitely wrong. And yeah all the syntax names are
placeholders.]
get_oid() is flexible and accepts multiple SHA-1 sources. Sometimes this
flexibi
Hello,
For next diff the `}` line should not be detected as removed/added.
As you can see there are differences only at new lines. (see attached
pics)
git version 2.21.0
git diff -b -w --ignore-blank-lines
git config:
[color "diff"]
old = red bold
new = green bold
[diff]
tool
On 06/25, Martin Ågren wrote:
> Hi Catalin
>
> Welcome to the list!
>
> On Tue, 25 Jun 2019 at 09:43, Catalin Criste wrote:
>
> > @@ -88,7 +88,7 @@ save [-p|--patch] [-k|--[no-]keep-index]
> > [-u|--include-untracked] [-a|--all] [-q
> >
> > This option is deprecated in favour of 'git s
Dial Direct Loan SA
Consolidate your debts with Dial Direct Loan SA for your peace of
mind at a fixed interest rate of 4.75%,personal and business loans
are also welcome.For details file in your applications by sending an email
to:dialdirectinfolo...@mail2consultant.com
Yours in Service,
Su
Hi everyone!
A draft of a new Git Rev News edition is available here:
https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-52.md
Everyone is welcome to contribute in any section either by editing the
above page on GitHub and sending a pull request, or by commenting on
this
76 matches
Mail list logo
