Re: [PATCH] init: make --template path relative to $CWD

2019-05-12 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > During git-init we chdir() to the target directory, but --template is > not adjusted. So it's relative to the target directory instead of > current directory. > It would be ok if it's documented, but --template in git-init.txt > mentions nothing about this behavio

Re: [PATCH] http-push: workaround for format overflow warning in gcc >= 9

2019-05-12 Thread Junio C Hamano
Eric Sunshine writes: >> if (request->curl_result != CURLE_OK) { >> fprintf(stderr, "Unable to get pack file %s\n%s", >> - request->url, curl_errorstr); >> + request->url ? request->url : "", >> +

Re: [PATCH v2] status: add an empty line when there is no hint

2019-05-12 Thread Junio C Hamano
林自均 writes: > Hi Junio, >> ... > Could you please give me some advice on my patch? Thank you. I tend to agree with what Phillip said in . If the difference between "status" and "commit" bothers you so much, i.e. When typing "git status", there is an empty line between the "Changes not

Re: [PATCH 01/14] cmd_{read,write}_tree: rename "unused" variable that is used

2019-05-12 Thread Junio C Hamano
Jeff King writes: > I kind of hate "cmd_prefix"; I was tempted to just call it "prefix" so > that all of the cmd_* functions were consistent, but I worried that it > really would get confused with the local variables (even if those > variables are renamed, as I do here). I tend to agree with you

Re: [PATCH v4 06/11] commit-graph: extract fill_oids_from_packs()

2019-05-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The write_commit_graph() method is too complex, so we are > extracting methods one by one. > > This extracts fill_oids_from_packs() that reads the given > pack-file list and fills the oid list in the context. > > Signed-off-by:

Re: [PATCH v4 11/11] commit-graph: extract write_commit_graph_file()

2019-05-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The write_commit_graph() method is too complex, so we are > extracting methods one by one. > > Extract write_commit_graph_file() that takes all of the information > in the context struct and writes the data to a commit-graph fi

push docs: inaccurate description of omitted destination?

2019-05-12 Thread Kyle Meyer
It seems to me that push's manpage contains a couple of inaccurate (or at least confusingly incomplete) statements about omitting the destination part of the refspec. First, the refspec section of the manpage has this to say: If `git push []` without any `` argument is set to update some

Re: [PATCH v4 03/11] commit-graph: collapse parameters into flags

2019-05-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The write_commit_graph() and write_commit_graph_reachable() methods > currently take two boolean parameters: 'append' and 'report_progress'. > We will soon expand the possible options to send to these methods, so > instead of c

Re: [PATCH v4 02/11] commit-graph: return with errors during write

2019-05-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The write_commit_graph() method uses die() to report failure and > exit when confronted with an unexpected condition. This use of > die() in a library function is incorrect and is now replaced by > error() statements and an int

Re: [PATCH v4 01/11] commit-graph: fix the_repository reference

2019-05-12 Thread Junio C Hamano
"Derrick Stolee via GitGitGadget" writes: > From: Derrick Stolee > > The parse_commit_buffer() method takes a repository pointer, so it > should not refer to the_repository anymore. Yup, makes sense. Thanks for spotting. > > Signed-off-by: Derrick Stolee > --- > commit.c | 2 +- > 1 file ch

Re: [PATCH v3 2/2] format-patch: teach format.notes config option

2019-05-12 Thread Junio C Hamano
Denton Liu writes: > @@ -864,6 +866,20 @@ static int git_format_config(const char *var, const char > *value, void *cb) > from = NULL; > return 0; > } > + if (!strcmp(var, "format.notes")) { > + struct strbuf buf = STRBUF_INIT; > + > +

PAZINOJUMS

2019-05-12 Thread FACEBOOK INC
FACEBOOK INC 1601 WiLLOW ROAD MENLO PARK, CA 94025 www.facebook.com fbpromol...@greatcitizenonlinepro.com Cienijamais Facebook lietotajs: Lai informetu jus, ka jusu Facebook konts ar e-pastu ir ieguvis naudas balvu 1 000 000,00 EUR (viens miljons eiro) par 2019. gada izdevuma Facebook vei

[PATCH] doc: explain why file: URLs and bundles don't mix

2019-05-12 Thread Alyssa Ross
Signed-off-by: Alyssa Ross --- Documentation/urls.txt | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/Documentation/urls.txt b/Documentation/urls.txt index b05da95788..c83d9f859e 100644 --- a/Documentation/urls.txt +++ b/Documentation/urls.txt @@ -43,14 +

Re: [PATCH v2 1/1] diff-highlight: Use correct /dev/null for UNIX and Windows

2019-05-12 Thread Philip Oakley
Hi Chris, On 07/05/2019 05:18, Chris Webster wrote: I know these can take some time but is this pending any update from me? The accepted changes will be merged back into the diff-so-fancy project. There was a question about other uses of /dev/null. In the contrib directory, there are a coupl

Re: allow a differn't diff.context config for git format-patch

2019-05-12 Thread Shawn Landden
On Mon, Apr 22, 2019 at 10:55 PM Jeff King wrote: > > On Tue, Apr 23, 2019 at 12:45:17PM +0900, Junio C Hamano wrote: > > > Jeff King writes: > > > > > ... I don't think it would be > > > too big a problem for format-patch to learn some options to configure > > > its diffs. We already have some o

"add worktree" fails with "fatal: Invalid path" error

2019-05-12 Thread Shaheed Haque
Hi, I'm running git v.2.20.1 on Ubuntu from a program which follows the pattern: 1. create a temporary directory /tmp/tmpabc 2. in a loop: 2a. create a second level of temporary directory /tmp/tmpabc/tmpworktree123 2b. use "git worktree add" on the second level directory

Re: [PATCH] make slash-rules more readable

2019-05-12 Thread Dr. Adam Nielsen
On 08.05.19 07:33, Junio C Hamano wrote: "Dr. Adam Nielsen" writes: + - A pattern that contains a non-trailing slash is matched relative to the location of the `.gitignore` file. + For example, `doc/frotz/` matches `doc/frotz` directory, but not + `a/doc/frotz` (relative from the `.gi

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-12 Thread Ævar Arnfjörð Bjarmason
On Sun, May 12 2019, Jeff King wrote: > On Sun, May 12, 2019 at 01:37:55AM +0200, Ævar Arnfjörð Bjarmason wrote: > >> This way of doing it just seems so weirdly convoluted. Read them one at >> a time, compute the SHA-1, just to see if they're different. Why not >> something closer to a plain mem