Re: new segfault in master (6a6c0f10a70a6eb1)

2019-05-11 Thread Duy Nguyen
On Sun, May 12, 2019 at 6:02 AM Jeff King wrote: > > On Sat, May 11, 2019 at 06:31:20PM -0400, Jeff King wrote: > > > On Sat, May 11, 2019 at 08:57:11PM +, Eric Wong wrote: > > > > > This test-tool submodule segfault seems new. Noticed it while > > > checking dmesg for other things. > > > > Y

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Jeff King
On Sun, May 12, 2019 at 01:37:55AM +0200, Ævar Arnfjörð Bjarmason wrote: > This way of doing it just seems so weirdly convoluted. Read them one at > a time, compute the SHA-1, just to see if they're different. Why not > something closer to a plain memcmp(): FWIW, I had the exact same thought on r

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Ævar Arnfjörð Bjarmason wrote: > On Sat, May 11 2019, Eric Wong wrote: > > +static int files_differ(FILE *fp, const char *path) > > +{ > > + struct stat st; > > + git_hash_ctx c; > > + struct object_id oid_old, oid_new; > > + struct strbuf tmp = STRBUF_INIT; > > + long new_len = ftell(fp

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Ævar Arnfjörð Bjarmason
On Sat, May 11 2019, Eric Wong wrote: > Do not change the existing info/refs and objects/info/packs > files if they match the existing content on the filesystem. > This is intended to preserve mtime and make it easier for dumb > HTTP pollers to rely on the If-Modified-Since header. > > Combined

Re: new segfault in master (6a6c0f10a70a6eb1)

2019-05-11 Thread Jeff King
On Sat, May 11, 2019 at 06:31:20PM -0400, Jeff King wrote: > On Sat, May 11, 2019 at 08:57:11PM +, Eric Wong wrote: > > > This test-tool submodule segfault seems new. Noticed it while > > checking dmesg for other things. > > Yeah, I hadn't seen it before. It's almost certainly the expect_fa

Re: new segfault in master (6a6c0f10a70a6eb1)

2019-05-11 Thread Jeff King
On Sat, May 11, 2019 at 08:57:11PM +, Eric Wong wrote: > This test-tool submodule segfault seems new. Noticed it while > checking dmesg for other things. Yeah, I hadn't seen it before. It's almost certainly the expect_failure added in 2b1257e463 (t/helper: add test-submodule-nested-repo-conf

Re: [PATCH v3 5/5] fast-export: do automatic reencoding of commit messages only if requested

2019-05-11 Thread Elijah Newren
On Sat, May 11, 2019 at 2:07 PM Torsten Bögershausen wrote: > On Fri, May 10, 2019 at 01:53:35PM -0700, Elijah Newren wrote: > This one is good: > > + if (unset || !strcmp(arg, "abort")) > > + reencode_mode = REENCODE_ABORT; > > But here: does it make sense to use REENCODE_YES/NO

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Eric Wong wrote: > Combined with stdio and kernel buffering; the kernel should be > able to avoid block layer writes and reduce wear. Along the same lines, I'd like to get repack to stop recreating identical packs at some point (but that could be months from now...)

Re: [PATCH v3 5/5] fast-export: do automatic reencoding of commit messages only if requested

2019-05-11 Thread Torsten Bögershausen
On Fri, May 10, 2019 at 01:53:35PM -0700, Elijah Newren wrote: > Automatic re-encoding of commit messages (and dropping of the encoding > header) hurts attempts to do reversible history rewrites (e.g. sha1sum > <-> sha256sum transitions, some subtree rewrites), and seems > inconsistent with the gen

new segfault in master (6a6c0f10a70a6eb1)

2019-05-11 Thread Eric Wong
This test-tool submodule segfault seems new. Noticed it while checking dmesg for other things. There's also "name-rev HEAD~4000" (bottom), which is old, I think... Core was generated by `$WT/t/helper/test-tool submodule-nested-repo-config submodule sub'. Program terminated with signal SIGSEGV, S

[PATCH v2] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Wong
Eric Sunshine wrote: > On Fri, May 10, 2019 at 9:35 PM Eric Wong wrote: > > + if (strbuf_fread(&tmp, (size_t)new_len, fp) != (size_t)new_len) > > + return 1; > > Although strbuf_fread() will release 'tmp' automatically if the read > actually fails, it won't do so otherwise. S

[no subject]

2019-05-11 Thread Sirawan Primvihan
ส่งจากโทรศัพท์มือถือ Huawei ของฉัน

Re: Merge commit diff results are confusing and inconsistent

2019-05-11 Thread Philip Oakley
Hi Robert, On 07/05/2019 15:10, Robert Dailey wrote: The majority use case I'm interested in is seeing net-positive changes that happen in merge commits. Normally I take for granted that merge commits have nothing meaningful in them (meaningful here defined as something unexpected for a merge co

Re: GSoC students and mentors 2019

2019-05-11 Thread Kaartic.Sivaraam
Hi Rohit and Matheus, Congrats both for getting selected to contribute to the Git project. Hope to see your contributions improve usability of Git in the upcoming version :-) Wishing you the best on completing your projects! -- Sivaraam QUOTE: "The reasonable man adapts himself to the con

Re: [PATCH] update-server-info: avoid needless overwrites

2019-05-11 Thread Eric Sunshine
On Fri, May 10, 2019 at 9:35 PM Eric Wong wrote: > Do not change the existing info/refs and objects/info/packs > files if they match the existing content on the filesystem. > This is intended to preserve mtime and make it easier for dumb > HTTP pollers to rely on the If-Modified-Since header. > [.

FROM: MR. GEORGE WILFRED

2019-05-11 Thread EU.UNDP/EOTF
Contract Award/Review Committee: E U/UNDP/EOTF. Special Project Unit. Burkina Faso . Dear Friend, I am the Chairman of this review committee and we are in charge of executing developmental projects under the (UNDP/EU/EOTF) accross Western Africa Nations . We have a contracts originally awarded to