Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-08 Thread Junio C Hamano
Duy Nguyen writes: > I feel lost (and the answer "go read partial clone code!" is perfectly > acceptable) but why would we need to diff trees of two different > repositories? It's just a speculation into far future to open possibilities of what we cannot do right now. There is no *NEED*, just l

Re: "commit --author=..." does not work if global email and name is not set

2019-04-08 Thread Junio C Hamano
Piotr Krukowiecki writes: >> If a real person making commits uses their own account (just on that >> machine), he or she can set up `user.name` and `user.email` settings in >> the per-user Git configuration file > > There is one common "test" (Windows) account which is used both by > automatic te

git push --atomic and HTTP(S) vs SSH

2019-04-08 Thread Bryan Turner
A question came up on Stack Overflow[1], and then again through our support channels, about "git push --atomic" and a behavior mismatch between HTTP(S) and SSH. I'm easily able to reproduce the behavior, but I don't see anything Bitbucket Server-related about how this works (and I get exactly the s

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Torsten Bögershausen
On 2019-04-08 21:36, Matheus Tavares Bernardino wrote: > On Mon, Apr 8, 2019 at 4:19 PM Philip Oakley wrote: >> >> Hi Matheus >> >> On 08/04/2019 18:04, Matheus Tavares Bernardino wrote: Another "32-bit problem" should also be expressly considered during the GSoC work because of the MS W

Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)

2019-04-08 Thread Torsten Bögershausen
On 2019-04-08 13:16, Sven Strickroth wrote: > A path such as 'c:/somepath/submodule/../.git/modules/submodule' wasn't > resolved correctly any more, because the *nix variant of > offset_1st_component is used instead of the Win32 specific version. > > Regression was introduced in commit > 25d90d1cb7

Re: [PATCH 2/7] t: introduce tests for unexpected object types

2019-04-08 Thread Taylor Blau
Hi Eric, On Mon, Apr 08, 2019 at 11:28:19PM -0400, Eric Sunshine wrote: > On Mon, Apr 8, 2019 at 10:31 PM Taylor Blau wrote: > > On Mon, Apr 08, 2019 at 03:44:25PM +0900, Junio C Hamano wrote: > > > Eric Sunshine writes: > > > >> > > + git cat-file commit $commit | > > > >> > > + per

Re: [PATCH 2/7] t: introduce tests for unexpected object types

2019-04-08 Thread Eric Sunshine
On Mon, Apr 8, 2019 at 10:31 PM Taylor Blau wrote: > On Mon, Apr 08, 2019 at 03:44:25PM +0900, Junio C Hamano wrote: > > Eric Sunshine writes: > > >> > > + git cat-file commit $commit | > > >> > > + perl -lpe "/^author/ && print q(parent $blob)" \ > > >> > > + >broken-commit

Re: [PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)

2019-04-08 Thread Taylor Blau
Hi Sven, On Mon, Apr 08, 2019 at 01:16:33PM +0200, Sven Strickroth wrote: > A path such as 'c:/somepath/submodule/../.git/modules/submodule' wasn't > resolved correctly any more, because the *nix variant of > offset_1st_component is used instead of the Win32 specific version. I'm not a win32 expe

Re: [PATCH 2/7] t: introduce tests for unexpected object types

2019-04-08 Thread Taylor Blau
Hi Junio, On Mon, Apr 08, 2019 at 03:44:25PM +0900, Junio C Hamano wrote: > Eric Sunshine writes: > > > On Fri, Apr 5, 2019 at 2:24 PM Jeff King wrote: > >> On Fri, Apr 05, 2019 at 12:50:33PM +0200, SZEDER Gábor wrote: > >> > > + git cat-file commit $commit | > >> > > + perl -lpe "/

Re: [PATCH 2/7] t: introduce tests for unexpected object types

2019-04-08 Thread Taylor Blau
Hi Ævar, On Sun, Apr 07, 2019 at 11:00:19PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Apr 05 2019, Jeff King wrote: > > > On Fri, Apr 05, 2019 at 08:42:29PM +0200, SZEDER Gábor wrote: > > > >> > > Don't run git commands upstream of a pipe, because the pipe hides > >> > > their exit code.

Re: [PATCH 6/7] rev-list: let traversal die when --missing is not in use

2019-04-08 Thread Taylor Blau
Hi Peff, On Sun, Apr 07, 2019 at 09:41:13AM -0400, Jeff King wrote: > On Fri, Apr 05, 2019 at 10:36:48PM -0700, Taylor Blau wrote: > > > > > Of those, I think (3) is probably the best path forward. However, this > > > > patch does none of them. In the name of expediently fixing the > > > > regress

Re: [PATCH][RFC] read-cache: read_index_from() accepts repo as arg

2019-04-08 Thread Taylor Blau
Hi Kapil, On Sun, Apr 07, 2019 at 01:07:12PM +0530, Kapil Jain wrote: > Signed-off-by: Kapil Jain > --- > > In read-cache, the read_index_from() function had a TODO task, > this patch completes that. There are some other functions in the same file > where this exact TODO needs to be done, will pr

Re: [RFC] TODO in read-cache.c

2019-04-08 Thread Taylor Blau
Hi Kapil, Welcome to Git! I am thrilled to see new faces on the mailing list. On Sat, Apr 06, 2019 at 05:43:56PM +0530, Kapil Jain wrote: > On Sat, Apr 6, 2019 at 5:33 PM Duy Nguyen wrote: > > > > trace2 API can already take 'struct repository' (the_repository is a > > pointer to 'struct reposit

Re: [[GSoC][PATCH …]] In notes-merge.c updated notes_merge_commit()

2019-04-08 Thread Taylor Blau
Hi Thomas, On Sat, Apr 06, 2019 at 03:41:27PM +0100, Thomas Gummerer wrote: > > Subject: [[GSoC][PATCH …]] In notes-merge.c updated notes_merge_commit() > > Commit messages are usually in the format ": description>". So a better title might be "notes-merge: use > dir-iterator in notes_merge_comm

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Josh Steadmon
On 2019.04.09 00:23, Christian Couder wrote: > On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon wrote: > > > > Helped-By: Jonathan Tan > > Helped-By: Jeff King > > Helped-By: Jonathan Nieder > > Signed-off-by: Josh Steadmon > > > > Signed-off-by: Josh Steadmon > > Your S-o-B is duplicated an th

Re: [PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Christian Couder
On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon wrote: > > Helped-By: Jonathan Tan > Helped-By: Jeff King > Helped-By: Jonathan Nieder > Signed-off-by: Josh Steadmon > > Signed-off-by: Josh Steadmon Your S-o-B is duplicated an there is a spurious line between the duplicated lines. Do you use a

Re: [GSoC][RFC] discussion about stashing with conflicts

2019-04-08 Thread Thomas Gummerer
On 04/08, Kapil Jain wrote: > while understanding add_index_entry_with_check() > i got to do_invalidate_path(). > > the commit hash for do_invalidate_path() function is > `749864627c2d3c33bbc56d7ba0b5542af698cc40` > > in the commit message it is explained that, cache-tree is used to > store objec

Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

2019-04-08 Thread Josh Steadmon
On 2019.04.08 13:28, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > unique (AFAICT "actually unique" in practice) in the parallel in-flight > > jh/trace2-sid-fix > > (https://public-inbox.org/git/4352952677a11776a18ec9b6862cf358307cfafd.1553879063.git.gitgitgad...@gmail.com/) > > >

[PATCH v3] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Josh Steadmon
For large repositories, enumerating the list of all promisor objects (in order to exclude them from a rev-list walk) can take a significant amount of time). When --exclude-promisor-objects is passed to rev-list, don't enumerate the promisor objects. Instead, filter them (and any children objects)

Re: [PATCH v2] rev-list: exclude promisor objects at walk time

2019-04-08 Thread Josh Steadmon
On 2019.04.04 17:09, Josh Steadmon wrote: > On 2019.04.04 20:00, Jeff King wrote: > > On Thu, Apr 04, 2019 at 04:47:26PM -0700, Josh Steadmon wrote: > > > > > > Did you (or anybody else) have any thoughts on the case where a given > > > > object is referred to both by a promisor and a non-promisor

Re: [PATCH v2 01/13] packfile.h: drop extern from function declarations

2019-04-08 Thread Jeff King
On Mon, Apr 08, 2019 at 02:13:17PM +0900, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > > > >> > /* global flag to enable extra checks when accessing packed objects */ > >> > -extern int do_check_packed_object_crc; > >> > +int do

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 4:19 PM Philip Oakley wrote: > > Hi Matheus > > On 08/04/2019 18:04, Matheus Tavares Bernardino wrote: > >> Another "32-bit problem" should also be expressly considered during the > >> GSoC work because of the MS Windows definition of uInt / long to be only > >> 32 bits, lea

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Philip Oakley
Hi Matheus On 08/04/2019 18:04, Matheus Tavares Bernardino wrote: Another "32-bit problem" should also be expressly considered during the GSoC work because of the MS Windows definition of uInt / long to be only 32 bits, leading to much of the Git code failing on the Git for Windows port and on t

Re: [PATCH] clone: send server options when using protocol v2

2019-04-08 Thread Jonathan Tan
> > Teach "clone" the same ability, except that because "clone" already > > has "-o" for another parameter, teach "clone" only to receive > > "--server-option". > > Can you give an example of what this would be used for? An example I > can think of might be > > git clone --server-option=pr

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 6:26 AM Philip Oakley wrote: > > On 08/04/2019 02:23, Duy Nguyen wrote: > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > wrote: > >>> Git has a very optimized mechanism to compactly store > >>> objects (blobs, trees, commits, etc.) in packfiles[2]. These files are >

Re: [PATCH v2] t5551: mark half-auth no-op fetch test as v0-only

2019-04-08 Thread Jonathan Tan
> > + # NEEDSWORK: When using HTTP(S), protocol v0 supports a "half-auth" > > + # configuration with authentication required only when downloading > > + # objects and not refs, by having the HTTP server only require > > + # authentication for the "git-upload-pack" path and not "info/refs".

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Sun, Apr 7, 2019 at 7:52 PM Christian Couder wrote: > > Hi Matheus > > On Sun, Apr 7, 2019 at 10:48 PM Matheus Tavares Bernardino > wrote: > > > > This is my proposal for GSoC with the subject "Make pack access code > > thread-safe". > > Thanks! > > > I'm late in schedule but I would like to a

Re: Pull without fetch

2019-04-08 Thread Damien Robert
>From Damien Robert, Mon 08 Apr 2019 at 16:53:40 (+0200) : > > Others may have a better idea, but I do not immediately see any > > solution better than inventing a new option to "git pull". So here is a RFC patch that implements --no-fetch. (I am not sure about the wording of the documentation, an

Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines

2019-04-08 Thread Barret Rhoden
On 4/8/19 5:48 AM, Michael Platings wrote: Hi David, You also get an out-of-memory error with the patch Barret posted at the start of this thread. I think I see the issue, and will fix it when I repost the patch set. Barret

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 3:58 AM Christian Couder wrote: > > On Mon, Apr 8, 2019 at 5:32 AM Duy Nguyen wrote: > > > > On Mon, Apr 8, 2019 at 8:23 AM Duy Nguyen wrote: > > > > > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > > wrote: > > > > > Git has a very optimized mechanism to compactly

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Matheus Tavares Bernardino
On Mon, Apr 8, 2019 at 12:32 AM Duy Nguyen wrote: > > On Mon, Apr 8, 2019 at 8:23 AM Duy Nguyen wrote: > > > > On Mon, Apr 8, 2019 at 5:52 AM Christian Couder > > wrote: > > > > Git has a very optimized mechanism to compactly store > > > > objects (blobs, trees, commits, etc.) in packfiles[2]. T

Re: [PATCH v2] sha1-file: test the error behavior of alt_odb_usable()

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Mar 29 2019, Ævar Arnfjörð Bjarmason wrote: > On Fri, Mar 29 2019, Jeff King wrote: > >> On Thu, Mar 28, 2019 at 09:04:56PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >>> Add a test for the error() case in alt_odb_usable() where an alternate >>> directory doesn't exist. This behavior has b

Re: [PATCH 1/2] commit/reset: try to clean up sequencer state

2019-04-08 Thread Phillip Wood
On 01/04/2019 11:09, Duy Nguyen wrote: On Fri, Mar 29, 2019 at 11:32 PM Phillip Wood wrote: From: Phillip Wood When cherry-picking or reverting a sequence of commits and if the final pick/revert has conflicts and the user uses `git commit` to commit the conflict resolution and does not run `

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 08 2019, SZEDER Gábor wrote: > On Mon, Apr 08, 2019 at 02:44:59PM +0200, Ævar Arnfjörð Bjarmason wrote: >> >> On Mon, Apr 08 2019, SZEDER Gábor wrote: >> >> > When 'git blame' is invoked without specifying the commit to start >> > blaming from, it starts from the given file's state i

Re: Pull without fetch

2019-04-08 Thread Damien Robert
>From Junio C Hamano, Mon 08 Apr 2019 at 10:34:07 (+0900) : > In that simpler world, what you are trying to do would have been: > git fetch > # did I get anything worth integrating? > git merge FETCH_HEAD Indeed. > That obviously would not work for those with "pull.rebase", and

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread SZEDER Gábor
On Mon, Apr 08, 2019 at 02:44:59PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Apr 08 2019, SZEDER Gábor wrote: > > > When 'git blame' is invoked without specifying the commit to start > > blaming from, it starts from the given file's state in the work tree. > > However, when invoked in a b

Re: [GSoC][RFC] discussion about stashing with conflicts

2019-04-08 Thread Kapil Jain
while understanding add_index_entry_with_check() i got to do_invalidate_path(). the commit hash for do_invalidate_path() function is `749864627c2d3c33bbc56d7ba0b5542af698cc40` in the commit message it is explained that, cache-tree is used to store object names of index file objects and it is kept

Re: [PATCH 2/2] fix cherry-pick/revert status after commit

2019-04-08 Thread Phillip Wood
On 01/04/2019 09:34, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood If the user commits a conflict resolution using 'git commit' during a sequence of picks then 'git status' missed the fact that a cherry-pick/revert is still in progress. How well would this play with the pre

Re: [PATCH 1/2] commit/reset: try to clean up sequencer state

2019-04-08 Thread Phillip Wood
Hi Junio On 01/04/2019 09:28, Junio C Hamano wrote: Phillip Wood writes: From: Phillip Wood When cherry-picking or reverting a sequence of commits and if the final pick/revert has conflicts and the user uses `git commit` to commit the conflict resolution and does not run `git cherry-pick --

[PATCH v3] git-gui: Handle Ctrl + BS/Del in the commit msg

2019-04-08 Thread Ismael Luceno Cortes
- Control+BackSpace: Delete word to the left of the cursor. - Control+Delete : Delete word to the right of the cursor. Originally introduced by BRIEF and Turbo Vision between 1985 and 1992, they were adopted by most CUA-Compliant UIs, including those of: OS/2, Windows, Mac OS, Qt, GTK, Open/Libr

Re: Pull without fetch

2019-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2019 at 7:51 PM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, Apr 08 2019, Duy Nguyen wrote: > > > On Mon, Apr 8, 2019 at 8:34 AM Junio C Hamano wrote: > >> > >> Damien Robert writes: > >> > >> > is there a way to do a git pull without it running git fetch? > >> > Looking at the so

Re: Pull without fetch

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 08 2019, Duy Nguyen wrote: > On Mon, Apr 8, 2019 at 8:34 AM Junio C Hamano wrote: >> >> Damien Robert writes: >> >> > is there a way to do a git pull without it running git fetch? >> > Looking at the source in builtin/pull.c does not seem to indicate so. >> >> The reason behind tha

Re: [PATCH] blame: default to HEAD in a bare repo when no start commit is given

2019-04-08 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 08 2019, SZEDER Gábor wrote: > When 'git blame' is invoked without specifying the commit to start > blaming from, it starts from the given file's state in the work tree. > However, when invoked in a bare repository without a start commit, > then there is no work tree state to start f

Re: "commit --author=..." does not work if global email and name is not set

2019-04-08 Thread Piotr Krukowiecki
On Mon, Apr 8, 2019 at 1:06 PM Jakub Narebski wrote: > > Piotr Krukowiecki writes: > > >> On Sat, Apr 6, 2019 at 8:25 PM Jakub Narebski wrote: > >>> > >>> Better though is to focus on what you want, namely to prevent accidental > >>> commits without specified author, instead of how you want to a

[PATCH] Unbreak real_path on Windows for already absolute paths (with Visual Studio)

2019-04-08 Thread Sven Strickroth
A path such as 'c:/somepath/submodule/../.git/modules/submodule' wasn't resolved correctly any more, because the *nix variant of offset_1st_component is used instead of the Win32 specific version. Regression was introduced in commit 25d90d1cb72ce51407324259516843406142fe89. Signed-off-by: Sven St

Re: [GSoC][RFC] discussion about stashing with conflicts

2019-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2019 at 6:00 PM Kapil Jain wrote: > for finding that commit message did you do something like this: > git log -L :repo_read_index_unmerged:read-cache.c No. I'm old fashioned. I just do "git log --patch --follow " then search read_index_unmerged, which should at least appear in the

Re: "commit --author=..." does not work if global email and name is not set

2019-04-08 Thread Jakub Narebski
Piotr Krukowiecki writes: >> On Sat, Apr 6, 2019 at 8:25 PM Jakub Narebski wrote: >>> >>> Better though is to focus on what you want, namely to prevent accidental >>> commits without specified author, instead of how you want to achieve it, >>> i.e. using --author to provide both author and commi

Re: [GSoC][RFC] discussion about stashing with conflicts

2019-04-08 Thread Kapil Jain
On Mon, Apr 8, 2019 at 4:02 PM Duy Nguyen wrote: > > Sometimes when I don't understand what some code does, I look at "git > log --patch". In this case, there a big explanation in ad3762042a > (read-cache: fix directory/file conflict handling in > read_index_unmerged(), 2018-07-31) that might help

Re: [GSoC][RFC] discussion about stashing with conflicts

2019-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2019 at 12:49 PM Kapil Jain wrote: > > On Mon, Apr 8, 2019 at 12:09 AM Thomas Gummerer wrote: > > > > On 04/07, Kapil Jain wrote: > > > > > > what is the use of ce_stage macro ? > > > tells about stage of an index entry. > > > if ce_stage says, stage #0 i.e staging area, then that

Re: [PATCH/docs] make slash-rules more readable

2019-04-08 Thread Dr. Adam Nielsen
Am Mo., 8. Apr. 2019 um 09:51 Uhr schrieb Junio C Hamano : > > "Adam Nielsen" writes: > > A few notes on the form. > > > From: Adam Nielsen > > This "author" identity and the name-email on the Signed-off-by: line > should match, at least for this project. I cannot tell which one is > your prefer

Re: [PATCH] fixup! diff: batch fetching of missing blobs

2019-04-08 Thread Duy Nguyen
On Mon, Apr 8, 2019 at 11:06 AM Junio C Hamano wrote: > > Duy Nguyen writes: > > >> Avoid a usage of the_repository by propagating the configured repository > >> to add_if_missing(). Also, prefetch only if the repository being diffed > >> is the_repository (because we do not support lazy fetching

Re: [PATCH v2 2/2] diff: batch fetching of missing blobs

2019-04-08 Thread Christian Couder
On Mon, Apr 8, 2019 at 9:59 AM Junio C Hamano wrote: > > Christian Couder writes: > > > I will at least add something telling that in most cases > > "repository_format_partial_clone" and fetch_objects() shouldn't be > > used directly anymore. > > Yes, that would be necessary not in the log, but i

PAYMENT NOTIFICATION

2019-04-08 Thread Babachir David
OFFICE OF THE PRESIDENCY FEDERAL REPUBLIC OF NIGERIA. FCT -ABUJA PAYMENT NOTIFICATION PAYMENT 2019: Attn:Beneficiary, We the entire members of Federal House of Senate,The office of Presidency,Directors of Nigerian National Petroleum Corporation,on behalf of the Federal Republic of Nigerian u

Re: "commit --author=..." does not work if global email and name is not set

2019-04-08 Thread Piotr Krukowiecki
On Fri, Apr 5, 2019 at 10:12 AM Junio C Hamano wrote: > You can still do > > git -c user.name=me -c user.email=m...@my.addre.ss commit ... [...] > GIT_COMMITTER_NAME=me GIT_COMMITTER_EMAIL=m...@my.addre.ss \ > git commit --author=me ... > > even though it is not any shorter ;-). There are a

Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines

2019-04-08 Thread Michael Platings
Hi David, You also get an out-of-memory error with the patch Barret posted at the start of this thread. I'm sorry you interpreted my message as declaring it somebody else's problem, that definitely wasn't my intent. I merely ran out of time to investigate further and I figure Barret is going to be

Re: [GSoC][RFC] Proposal: Make pack access code thread-safe

2019-04-08 Thread Philip Oakley
On 08/04/2019 02:23, Duy Nguyen wrote: On Mon, Apr 8, 2019 at 5:52 AM Christian Couder wrote: Git has a very optimized mechanism to compactly store objects (blobs, trees, commits, etc.) in packfiles[2]. These files are created by[3]: 1. listing objects; 2. sorting the list with some good heuri

Re: [PATCH v2 2/2] diff: batch fetching of missing blobs

2019-04-08 Thread Junio C Hamano
Christian Couder writes: > Patch 3f82acbca2 (Use promisor_remote_get_direct() and > has_promisor_remote(), 2019-04-01) in cc/multi-promisor starts with: > > Use promisor_remote_get_direct() and has_promisor_remote() > > Instead of using the repository_format_partial_clone global > and

Re: [PATCH/docs] make slash-rules more readable

2019-04-08 Thread Junio C Hamano
"Dr. Adam Nielsen" writes: A few notes on the form. > From: Adam Nielsen This "author" identity and the name-email on the Signed-off-by: line should match, at least for this project. I cannot tell which one is your preference, and I do not have any preference over your name either ;-), but pl