Re: [PATCH v2 2/2] diff: batch fetching of missing blobs

2019-04-06 Thread Christian Couder
Hi, On Fri, Apr 5, 2019 at 3:38 PM Johannes Schindelin wrote: > On Thu, 4 Apr 2019, SZEDER Gábor wrote: > > > On Fri, Mar 29, 2019 at 02:39:28PM -0700, Jonathan Tan wrote: > > > diff --git a/t/t4067-diff-partial-clone.sh b/t/t4067-diff-partial-clone.sh > > > new file mode 100755 > > > index

Re: git glossary --help ?

2019-04-06 Thread Duy Nguyen
On Sun, Apr 7, 2019 at 12:31 AM Philip Oakley wrote: > > Following the discussions about the tag peeling issue, I thought to have > a look at what the git glossary says. > > I had it in my head that when the git guides were linked to the help > system, that the --help option provided a short circu

Re: [RFC] TODO in read-cache.c

2019-04-06 Thread Duy Nguyen
On Sat, Apr 6, 2019 at 8:30 PM Kapil Jain wrote: > > On Sat, Apr 6, 2019 at 5:49 PM Duy Nguyen wrote: > > > > On Sat, Apr 6, 2019 at 7:14 PM Kapil Jain wrote: > > > > In some cases, it will be simple. For example, if you have a look at > > > > repo_read_index(), it already knows what repo it han

Re: Bug: subcommand autocomplete fails on 2.21.0

2019-04-06 Thread SZEDER Gábor
On Sat, Apr 06, 2019 at 07:49:29PM +0200, SZEDER Gábor wrote: > On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote: > > With git 2.21.0, tab completion no longer works for subcommands. > > > > STEPS TO REPRODUCE > > 1. install git 2.21.0 from https://git-scm.com/download/mac > > 2. sou

Re: [PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-06 Thread Denton Liu
On Sat, Apr 06, 2019 at 09:44:49PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Apr 01 2019, Denton Liu wrote: > > > Thanks again for your feedback, Ævar! I think we're both on the same page > > now. > > Hopefully I've addressed all of your high-level concerns with this patchset > > and >

Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

2019-04-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Apr 04 2019, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Thu, Apr 4, 2019 at 5:29 PM Junio C Hamano wrote: >>> * nd/precious (2019-04-01) 1 commit >>> - Introduce "precious" file concept >>> >>> "git clean" learned to pay attention to the 'precious' attributes >>> and keep un

Re: git glossary --help ?

2019-04-06 Thread Philip Oakley
Hi Andreas, On 06/04/2019 19:09, Andreas Schwab wrote: On Apr 06 2019, Philip Oakley wrote: Following the discussions about the tag peeling issue, I thought to have a look at what the git glossary says. I had it in my head that when the git guides were linked to the help system, that the --h

Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

2019-04-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Apr 04 2019, Junio C Hamano wrote: > * dl/rebase-i-keep-base (2019-04-03) 4 commits > - rebase: teach rebase --keep-base > - rebase: fast-forward --onto in more cases > - t3432: test rebase fast-forward behavior > - t3431: add rebase --fork-point tests > > "git rebase --keep-base "

Re: [PATCH v3 0/4] rebase: teach rebase --keep-base

2019-04-06 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 01 2019, Denton Liu wrote: > Thanks again for your feedback, Ævar! I think we're both on the same page now. > Hopefully I've addressed all of your high-level concerns with this patchset > and > we can move into a discussion on implementation detail. Late in replying to this, have b

Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

2019-04-06 Thread Ævar Arnfjörð Bjarmason
On Thu, Apr 04 2019, Junio C Hamano wrote: Just comments on ab/* stuff: > * ab/gc-reflog (2019-04-01) 7 commits > - gc: handle & check gc.reflogExpire config > - reflog tests: assert lack of early exit with expiry="never" > - reflog tests: test for the "points nowhere" warning > - reflog te

Re: "commit --author=..." does not work if global email and name is not set

2019-04-06 Thread Jakub Narebski
Piotr Krukowiecki writes: > Hi, > > I have a repo downloaded on machines which do automatic tests. > Sometimes I want to make a quick fix there and push back to origin. > Reading git-commit docs I had impression that I can use "--author=me" > and it will work. But it requires setting global user

Re: git glossary --help ?

2019-04-06 Thread Andreas Schwab
On Apr 06 2019, Philip Oakley wrote: > Following the discussions about the tag peeling issue, I thought to have a > look at what the git glossary says. > > I had it in my head that when the git guides were linked to the help > system, that the --help option provided a short circuit direct to help

Re: Bug: subcommand autocomplete fails on 2.21.0

2019-04-06 Thread SZEDER Gábor
On Sat, Apr 06, 2019 at 12:36:30PM -0400, Paul Schreiber wrote: > With git 2.21.0, tab completion no longer works for subcommands. > > STEPS TO REPRODUCE > 1. install git 2.21.0 from https://git-scm.com/download/mac > 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update > yo

git glossary --help ?

2019-04-06 Thread Philip Oakley
Following the discussions about the tag peeling issue, I thought to have a look at what the git glossary says. I had it in my head that when the git guides were linked to the help system, that the --help option provided a short circuit direct to help item. However this did not happen. I foun

Bug: subcommand autocomplete fails on 2.21.0

2019-04-06 Thread Paul Schreiber
With git 2.21.0, tab completion no longer works for subcommands. STEPS TO REPRODUCE 1. install git 2.21.0 from https://git-scm.com/download/mac 2. source /usr/local/etc/bash_completion.d/git-extras (manually, or update your .bashrc/.profile and start a new terminal) 2. git clone https://github.co

Re: [[GSoC][PATCH …]] In notes-merge.c updated notes_merge_commit()

2019-04-06 Thread Thomas Gummerer
> Subject: [[GSoC][PATCH …]] In notes-merge.c updated notes_merge_commit() Commit messages are usually in the format ": ". So a better title might be "notes-merge: use dir-iterator in notes_merge_commit". It would also be beneficial for you to have a look at the mailing list archives at https://

Re: [RFC] TODO in read-cache.c

2019-04-06 Thread Kapil Jain
On Sat, Apr 6, 2019 at 5:49 PM Duy Nguyen wrote: > > On Sat, Apr 6, 2019 at 7:14 PM Kapil Jain wrote: > > > In some cases, it will be simple. For example, if you have a look at > > > repo_read_index(), it already knows what repo it handles, so you can > > > just extend read_index_from() to take '

[PATCH 0/2] Minor document fixes

2019-04-06 Thread Philip Oakley
A couple of minor fixes seen while looking at the Git-for-Wondows patch thicket and getting my head around the conflict resolutions I did note that there was potential for the rerere-train to be integrated with the main rerere code, and maybe learn from the range-diff, and the rebasing merge todo

[PATCH 2/2] describe doc: remove '7-char' abbreviation reference

2019-04-06 Thread Philip Oakley
While the minimum is 7-char, the unambiguous length can be longer. Signed-off-by: Philip Oakley --- noticed while looking int the Git-for-Windows patch thicket - was looking for the ~n^m style! --- Documentation/git-describe.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/2] rerere doc: quote `rerere.enabled`

2019-04-06 Thread Philip Oakley
Signed-off-by: Philip Oakley --- Noticed while attempting to train the Git-for-Windows rebasing- merge series. --- Documentation/git-rerere.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/git-rerere.txt b/Documentation/git-rerere.txt index df310d2a58..95763d7

Pull without fetch

2019-04-06 Thread Damien Robert
Dear git developpers, is there a way to do a git pull without it running git fetch? Looking at the source in builtin/pull.c does not seem to indicate so. Here is my use case: I do a `git fetch --all` to look at the incoming changes, and only afterwards I would like to do a `git pull --no-fetch`.

Re: [RFC] TODO in read-cache.c

2019-04-06 Thread Duy Nguyen
On Sat, Apr 6, 2019 at 7:14 PM Kapil Jain wrote: > > In some cases, it will be simple. For example, if you have a look at > > repo_read_index(), it already knows what repo it handles, so you can > > just extend read_index_from() to take 'struct repository *' and pass > > 'repo' to it. > > > > Be c

Re: [RFC] TODO in read-cache.c

2019-04-06 Thread Kapil Jain
On Sat, Apr 6, 2019 at 5:33 PM Duy Nguyen wrote: > > trace2 API can already take 'struct repository' (the_repository is a > pointer to 'struct repository'). I'm pretty sure the purpose is to > _not_ pass the_repository (because it implies the default repo, which > is not always true). Which means

Re: [RFC] TODO in read-cache.c

2019-04-06 Thread Duy Nguyen
On Sat, Apr 6, 2019 at 6:42 PM Kapil Jain wrote: > > i found some TODO tasks inside `read-cache.c` in `read_index_from()` > function. which says: > > /* > * TODO trace2: replace "the_repository" with the actual repo instance > that is associated with the given "istate". > */ > > this same TODO occ

Re: [PATCH] clone: send server options when using protocol v2

2019-04-06 Thread Jonathan Nieder
Jonathan Tan wrote: > Commit 5e3548ef16 ("fetch: send server options when using protocol v2", > 2018-04-24) taught "fetch" the ability to send server options when using > protocol v2, but not "clone". This ability is triggered by "-o" or > "--server-option". > > Teach "clone" the same ability, exc

[RFC] TODO in read-cache.c

2019-04-06 Thread Kapil Jain
i found some TODO tasks inside `read-cache.c` in `read_index_from()` function. which says: /* * TODO trace2: replace "the_repository" with the actual repo instance that is associated with the given "istate". */ this same TODO occurs at 4 other places in the same file. Will it be ok, if i complet

[PATCH v3 29/33] sha1-name.c: add repo_get_oid()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cache.h b/cache.h index 2149dc4f56..f6e87194d0 100644 --- a/cache.h +++ b/cache.h @@ -1380,7 +1380,8 @@ enum get_oid_result { */

[PATCH v3 32/33] sha1-name.c: remove the_repo from other get_oid_*

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 18 -- sha1-name.c | 35 --- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/cache.h b/cache.h index 3718b3db8a..871a167bf8 100644 --- a/cache.h +++ b/cache.h @@ -1381,12 +1381,1

[PATCH v3 33/33] sha1-name.c: remove the_repo from get_oid_mb()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 18 +++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index 871a167bf8..9a600a8b50 100644 --- a/cache.h +++ b/cache.h @@ -1386,6 +1386,7 @@ int repo_get_oid_committish(st

[PATCH v3 30/33] submodule-config.c: use repo_get_oid for reading .gitmodules

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Since 76e9bdc437 (submodule: support reading .gitmodules when it's not in the working tree - 2018-10-25), every time you do git grep --recurse-submodules you are likely to see one warning line per submodule (unless all those submodules also have submodules). On a superproject with plenty of s

[PATCH v3 31/33] sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_name

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 4 +++- setup.c | 7 --- sha1-name.c | 6 -- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/cache.h b/cache.h index f6e87194d0..3718b3db8a 100644 --- a/cache.h +++ b/cache.h @@ -1387,7 +1387,9 @@ extern int get_oid

[PATCH v3 25/33] sha1-name.c: remove the_repo from handle_one_ref()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 5741a9f821..d9050776dd 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1189,15 +1189,21 @@ static enum get_oid_result get_oid

[PATCH v3 26/33] sha1-name.c: remove the_repo from diagnose_invalid_index_path()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- dir.c | 8 dir.h | 4 +++- sha1-name.c | 7 --- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/dir.c b/dir.c index b2cabadf25..e6d97343f4 100644 --- a/dir.c +++ b/dir.c @@ -2315,6 +2315,14 @@ int file_exists(const c

[PATCH v3 24/33] sha1-name.c: remove the_repo from get_oid_1()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
There is a cyclic dependency between one of these functions so they cannot be converted one by one, so all related functions are converted at once. Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 7 +-- sha1-name.c | 59 - 2 files ch

[PATCH v3 28/33] sha1-name.c: remove the_repo from get_oid_with_context_1()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sha1-name.c b/sha1-name.c index 6b53ea2eeb..64a50d1291 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -12,6 +12,7 @@ #include "packfile.h" #include "object-store.h"

[PATCH v3 27/33] sha1-name.c: remove the_repo from resolve_relative_path()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
"remove" is not entirely correct. But at least the function is aware that if the given repo is not the_repository, then $CWD and is_inside_work_tree() means nothing. Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sh

[PATCH v3 21/33] sha1-name.c: remove the_repo from get_oid_oneline()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 49c62d5254..fb80306f1a 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -15,7 +15,7 @@ #include "midx.h" #include "commit-reach.h"

[PATCH v3 23/33] sha1-name.c: remove the_repo from get_oid_basic()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 1cda854f02..d4c135aea8 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -773,8 +773,8 @@ static inline int push_mark(con

[PATCH v3 17/33] sha1-name.c: remove the_repo from get_short_oid()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index cdcf84b826..2643b75b54 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -436,7 +436,8 @@ static void sort_ambiguous_oid_array(str

[PATCH v3 20/33] sha1-name.c: add repo_interpret_branch_name()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 7d9512ac44..49c62d5254 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1390,7 +1390,8 @@ static int interpret_empty_at(const cha

[PATCH v3 19/33] sha1-name.c: remove the_repo from interpret_branch_mark()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index af8bf5b351..7d9512ac44 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1412,9 +1412,9 @@ static int reinterpret(const char *name, in

[PATCH v3 22/33] sha1-name.c: remove the_repo from get_describe_name()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index fb80306f1a..1cda854f02 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1097,7 +1097,9 @@ static int peel_onion(const char *name, int len,

[PATCH v3 18/33] sha1-name.c: remove the_repo from interpret_nth_prior_checkout()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 2643b75b54..af8bf5b351 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -771,7 +771,7 @@ static inline int push_mark(const char *

[PATCH v3 10/33] refs.c: remove the_repo from read_ref_at()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/show-branch.c | 6 -- refs.c| 7 --- refs.h| 3 ++- sha1-name.c | 3 ++- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/builtin/show-branch.c b/builtin/show-branch.c index 934e514944

[PATCH v3 13/33] sha1-name.c: remove the_repo from find_abbrev_len_packed()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 7558ce51a3..b9381aaba6 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -514,6 +514,7 @@ struct min_abbrev_data { unsigned int init_le

[PATCH v3 09/33] refs.c: add repo_dwim_log()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 21 +++-- refs.h | 1 + 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c index bd0fec5776..edea001446 100644 --- a/refs.c +++ b/refs.c @@ -603,9 +603,11 @@ int expand_ref(struct repository *repo, cons

[PATCH v3 15/33] sha1-name.c: store and use repo in struct disambiguate_state

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 95 + 1 file changed, 59 insertions(+), 36 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 9b57787b76..a75992eb54 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -17,13 +17,14 @@

[PATCH v3 14/33] sha1-name.c: add repo_find_unique_abbrev_r()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 6 -- sha1-name.c | 15 +-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index fcb24b5781..4f8ebb0a67 100644 --- a/cache.h +++ b/cache.h @@ -1045,8 +1045,10 @@ extern void check_repository_

[PATCH v3 16/33] sha1-name.c: add repo_for_each_abbrev()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cache.h b/cache.h index 4f8ebb0a67..0cb95c0d4f 100644 --- a/cache.h +++ b/cache.h @@ -1392,7 +1392,8 @@ extern enum get_oid_result get_oid_with_contex

[PATCH v3 08/33] refs.c: add repo_dwim_ref()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 12 +--- refs.h | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/refs.c b/refs.c index 1f5864aa36..bd0fec5776 100644 --- a/refs.c +++ b/refs.c @@ -555,14 +555,20 @@ static char *substitute_branch_name(struct repositor

[PATCH v3 11/33] commit.c: add repo_get_commit_tree()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Remove the implicit dependency on the_repository in this function. It will be used in sha1-name.c functions when they are updated to take any 'struct repository'. get_commit_tree() remains as a compat wrapper, to be slowly replaced later. Signed-off-by: Nguyễn Thái Ngọc Duy --- commit.c

[PATCH v3 12/33] sha1-name.c: remove the_repo from sort_ambiguous()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 15a1107998..7558ce51a3 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -383,10 +383,11 @@ static int collect_ambiguous(const struc

[PATCH v3 04/33] refs.c: add refs_ref_exists()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/refs.c b/refs.c index 142888a40a..b869f32d8b 100644 --- a/refs.c +++ b/refs.c @@ -241,9 +241,14 @@ int read_ref(const char *refname, struct object_id *oid) return read_

[PATCH v3 03/33] packfile.c: add repo_approximate_object_count()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- packfile.c | 14 +++--- packfile.h | 3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/packfile.c b/packfile.c index 16bcb75262..2ad4fab2f8 100644 --- a/packfile.c +++ b/packfile.c @@ -893,25 +893,25 @@ static void prepare_packe

[PATCH v3 05/33] refs.c: add refs_shorten_unambiguous_ref()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 11 +-- refs.h | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/refs.c b/refs.c index b869f32d8b..3dde824aab 100644 --- a/refs.c +++ b/refs.c @@ -1169,7 +1169,8 @@ int update_ref(const char *msg, const char *refname,

[PATCH v3 06/33] refs.c: remove the_repo from substitute_branch_name()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 8 ++-- refs.c | 9 + sha1-name.c | 8 ++-- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index ac92421f3a..fcb24b5781 100644 --- a/cache.h +++ b/cache.h @@ -1468,8 +1468,12 @@ extern in

[PATCH v3 02/33] builtin rebase: use oideq()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
From: SZEDER Gábor Use oideq() instead of !oidcmp(), as it is more idiomatic, and might give the compiler more opportunities to optimize. Patch generated with 'contrib/coccinelle/free.cocci' and Coccinelle v1.0.7 (previous Coccinelle versions don't notice this). Signed-off-by: SZEDER Gábor Sig

[PATCH v3 07/33] refs.c: remove the_repo from expand_ref()

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c| 10 ++ refs.h| 2 +- upload-pack.c | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c index 44df049796..1f5864aa36 100644 --- a/refs.c +++ b/refs.c @@ -558,12 +558,13 @@ static char *subs

[PATCH v3 01/33] builtin rebase: use FREE_AND_NULL

2019-04-06 Thread Nguyễn Thái Ngọc Duy
From: SZEDER Gábor Use the macro FREE_AND_NULL to release memory allocated for 'head_name' and clear its pointer. Patch generated with 'contrib/coccinelle/free.cocci' and Coccinelle v1.0.7 (previous Coccinelle versions don't notice this). Signed-off-by: SZEDER Gábor Signed-off-by: Nguyễn Thái

[PATCH v3 00/33] nd/sha1-name-c-wo-the-repository updates

2019-04-06 Thread Nguyễn Thái Ngọc Duy
Hopefully the final fix for commit.cocci in 11/33. Instead of adding more commit details on 01/33 I replaced it with the two commits from Szeder, he put more efforts into them anyway. Range-diff dựa trên v2: 1: b992f6c799 ! 1: aa603ea09e rebase: 'make coccicheck' cleanup @@ -1,6 +1,14 @@

Re: [PATCH v2] t5551: mark half-auth no-op fetch test as v0-only

2019-04-06 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > When using protocol v0, upload-pack over HTTP permits a "half-auth" > configuration in which, at the web server layer, the info/refs path is > not protected by authentication but the git-upload-pack path is, so that > a user can perform fetches that do not download any o

Re: Proposal

2019-04-06 Thread brestnic...@unwe.bg
I have a deal for you

Re: [PATCH 2/2] Documentation/git-svn: improve asciidoctor compatibility

2019-04-06 Thread Martin Ågren
On Sat, 6 Apr 2019 at 00:51, Todd Zullinger wrote: > > The second paragraph in the CONFIGURATION section intends to emphasize > the word 'must' with bold type. Adjust the formatting slightly to > provide similar results between asciidoc and asciidoctor. I don't think this explains the problem yo

Re: [PATCH 1/2] Documentation/git-show-branch: drop last use of {apostrophe}

2019-04-06 Thread Martin Ågren
On Sat, 6 Apr 2019 at 00:51, Todd Zullinger wrote: > > The {apostrophe} was needed at the time of a521845800 ("Documentation: > remove stray backslash in show-branch discussion", 2010-08-20). All > other uses of {apostrophe} were removed in 6cf378f0cb ("docs: stop using > asciidoc no-inline-liter

Re: [PATCH 0/2] a few more minor asciidoc/tor formatting fixes

2019-04-06 Thread Martin Ågren
On Sat, 6 Apr 2019 at 00:51, Todd Zullinger wrote: > Here's what I have currently. I haven't tested this much with > asciidoctor-1.5.x releases (or maybe not at all -- it's been a > week or so since I worked on this). Tested with Asciidoctor 1.5.5. For both patches, AsciiDoctor stumbles before t