Fw: git describe issue

2019-04-02 Thread Amiel Elboim
Hi! I've found strange behavior with 'git describe' command, look like for me as bug.  In the case I create 2 tags on same commit and I run 'git describe --tags' I expect to get the latest tag, but always I get the first tag I created on the commit. Unlike git-describe documentations - "Th

Re: [PATCH v2 2/2] mailinfo: support Unicode scissors

2019-04-02 Thread Junio C Hamano
Jeff King writes: > In fact, I think you could then combine this with the previous > conditional and get: > > if (skip_prefix(c, ">8", &end) || > skip_prefix(c, "8<", &end) || > skip_prefix(c, ">%", &end) || > skip_prefix(c, "%<", &end) || > /* U-2702 in UTF-8 */ >

Re: [PATCH v2 4/7] trace2: use system config for default trace2 settings

2019-04-02 Thread Jonathan Nieder
Josh Steadmon wrote: > A question for the list: should these new config vars also be documented > in the git-config manpage, or is it better to keep these separate since > they are only read from the system config? Yes, they should be in the git-config manpage. *If* they are read only from the s

Re: [PATCH v2 4/7] trace2: use system config for default trace2 settings

2019-04-02 Thread Jonathan Nieder
Hi, Jeff Hostetler via GitGitGadget wrote: > Teach git to read the system config (usually "/etc/gitconfig") for > default Trace2 settings. This allows system-wide Trace2 settings to > be installed and inherited to make it easier to manage a collection of > systems. Yay! Thanks for writing this

Re: git-gui: executed hooks are different from command-line git if hooksPath is set

2019-04-02 Thread Jan Ziak
On Mon, 1 Apr 2019 at 22:46, Johannes Schindelin wrote: > Could you give `master` of https://github.com/git-for-windows/git a try? > (Despite the name, we aim to keep it functional on the same platforms as > Git itself.) > > I am fairly certain that I fixed it there, and contributed a PR to the Gi

[PATCH v2.5 2/2] tag: prevent nested tags

2019-04-02 Thread Denton Liu
Robert Dailey reported confusion on the mailing list about a nested tag which was most likely created by mistake. Jeff King noted that this isn't a very common case so, most likely, creating a tag-to-a-tag is a user-error. Prevent mistakes by erroring and providing advice on nested tags, unless "-

I will be waiting for your urgent answer

2019-04-02 Thread Jucai LI
Beautiful day, My name is Mr. Jucai Li, Chief Executive Officer of the Bank of China I am looking for a business partner who will work with me in a joint venture. Contact me in my private email for more details. Email (jucailil...@gmail.com) I am waiting to hear from you. Many thanks, Mr. Jucai

Re: [GSoC][PATCH v1] t9811: avoid pipe in git commands in test script

2019-04-02 Thread Khalid Ali
Thanks for the feedback Junio. I was wondering if I should resubmit the patch without my comments. Also, I was wondering if I should be adding a call to check the exit codes of this test and the file called 'actual' at the end of the script. On Mon, Apr 1, 2019 at 10:39 PM Junio C Hamano wrote:

[GSoC][RFC] proposal: convert git-submodule to builtin script

2019-04-02 Thread Khalid Ali
Hi, My name is Khalid Ali and I am looking to convert the git-submodule to a builtin C script. The link below contains my first proposal draft [1] and my microproject is at [2]. My main concern is that my second task is not verbose enough. I am not sure if I should add a specific breakdown of larg

Re: Make the git codebase thread-safe

2019-04-02 Thread Matheus Tavares Bernardino
On Mon, Apr 1, 2019 at 10:07 PM Duy Nguyen wrote: > > On Tue, Apr 2, 2019 at 7:52 AM Matheus Tavares > wrote: > > I downloaded chromium to give it a try and got (on a machine with i7 and > > SSD, running Manjaro Linux): > > > > - 17s on blame for a file with long history[2] > > - 2m on blame for

[PATCH v2 3/4] t3009: test that ls-files -o traverses bogus repo

2019-04-02 Thread Kyle Meyer
When a2d5156c2b (resolve_gitlink_ref: ignore non-repository paths, 2016-01-22) added this test, the purpose was to check the 'ls-files -o' didn't die() when processing the bogus repository. The expected output didn't even need to be adjusted for the addition because the bogus repository is treated

[PATCH v2 2/4] t3000: move non-submodule repo test to separate file

2019-04-02 Thread Kyle Meyer
a2d5156c2b (resolve_gitlink_ref: ignore non-repository paths, 2016-01-22) added a test to t3000-ls-files-others.sh to check that 'ls-files -o' does not die() when given a subdirectory that looks like a repository but is actually a subdirectory containing a bogus .git file. Move this test to a sepa

[PATCH v2 4/4] dir: do not traverse repositories with no commits

2019-04-02 Thread Kyle Meyer
When treat_directory() encounters a directory that is not in the index and DIR_NO_GITLINKS is unset, it calls resolve_gitlink_ref() to decide if a directory looks like a repository, in which case the directory won't be traversed. As a result, 'status -uall' and 'ls-files -o' will show only the dir

[PATCH v2 1/4] submodule: refuse to add repository with no commits

2019-04-02 Thread Kyle Meyer
When the path given to 'git submodule add' is an existing repository that is not in the index, the repository is passed to 'git add'. If this repository doesn't have any commits, we don't get a useful result: there is no subproject OID to track, and any untracked files in the sub-repository are ad

[PATCH v2 0/4] dir: Treat a repository without commits as a repository

2019-04-02 Thread Kyle Meyer
> Kyle Meyer writes: > > [...] > >> diff --git a/git-submodule.sh b/git-submodule.sh >> index 514ede2596..6c74656027 100755 >> --- a/git-submodule.sh >> +++ b/git-submodule.sh >> @@ -234,10 +234,18 @@ cmd_add() >> if test -z "$force" && >> ! git add --dry-run --ignore-missing --n

RE: Bad performance when using git log --parents (used by gitk)

2019-04-02 Thread Johannes Schindelin
Hi Björn, On Tue, 2 Apr 2019, Björn Pettersson A wrote: > Thanks for a quick reply (with lots of details). > > Hitting some quadratic complexity algorithm explains why the "degradation" > is so huge. And if I understand it correctly we are more or less "unlucky" > to hit such access patterns more

Ich werde auf Ihre dringende Antwort warten

2019-04-02 Thread Jucai LI
Schöner Tag, Mein Name ist Herr Jucai Li, Chief Executive Officer der Bank of China Ich suche einen Geschäftspartner, der mit mir in einem Joint Venture zusammenarbeiten wird. Kontaktieren Sie mich in meiner privaten E-Mail für weitere Details. E-Mail (jucailil...@gmail.com) Ich warte darauf, v

Re: [PATCH v3 2/8] git-p4: add failing test for "git-p4: match branches case insensitively if configured"

2019-04-02 Thread Mazo, Andrey
> On Mon, Apr 01, 2019 at 06:02:21PM +, Mazo, Andrey wrote: >> diff --git a/t/t9801-git-p4-branch.sh b/t/t9801-git-p4-branch.sh >> index 6a86d6996b..c48532e12b 100755 >> --- a/t/t9801-git-p4-branch.sh >> +++ b/t/t9801-git-p4-branch.sh >> @@ -608,10 +608,102 @@ test_expect_success 'Update a file

Re: [PATCH 09/31] commit.c: add repo_get_commit_tree()

2019-04-02 Thread SZEDER Gábor
On Sat, Mar 30, 2019 at 06:19:05PM +0700, Nguyễn Thái Ngọc Duy wrote: > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > commit.c | 5 +++-- > commit.h | 3 ++- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/commit.c b/commit.c > index a5333c7ac6..f0a5506f04 100644 > --- a/commit

RE: Bad performance when using git log --parents (used by gitk)

2019-04-02 Thread Björn Pettersson A
Hello Jeff! Thanks for a quick reply (with lots of details). Hitting some quadratic complexity algorithm explains why the "degradation" is so huge. And if I understand it correctly we are more or less "unlucky" to hit such access patterns more often in the new repo. Anyway, nice to see that you

Re: [Bug] git log - reports wrong date and time

2019-04-02 Thread Chanseok Oh
Turns out I wasn't using TZ in the right way. One of the formats for TZ is std offset, where std string specifies the name of the time zone (such as EDT, PDT, KST, or JST) and offset is the time that should be added to get UTC. In this format, you specify the time zone information directly, which m

Re: [PATCH v2 2/2] mailinfo: support Unicode scissors

2019-04-02 Thread Jeff King
On Mon, Apr 01, 2019 at 11:53:34PM +0200, Andrei Rybak wrote: > diff --git a/mailinfo.c b/mailinfo.c > index f4aaa89788..804b07cd8a 100644 > --- a/mailinfo.c > +++ b/mailinfo.c > @@ -701,6 +701,13 @@ static int is_scissors_line(const char *line) > c++; >

Re: [PATCH v2 1/2] mailinfo: use starts_with() for clarity

2019-04-02 Thread Jeff King
On Mon, Apr 01, 2019 at 11:53:33PM +0200, Andrei Rybak wrote: > Existing checks using memcmp(3) never read past the end of the line, > because all substrings we are interested in are two characters long, and > the outer loop guarantees we have at least one character. So at most we > will look at t

Re: [PATCH v2 3/4] progress: clear previous progress update dynamically

2019-04-02 Thread Jeff King
On Mon, Apr 01, 2019 at 04:15:42PM +0200, SZEDER Gábor wrote: > > I don't think it could matter here, as these are meant to be smallish > > strings, but I think we should get into the habit of using size_t > > consistently to hold string lengths. > > > > It makes auditing for integer overflow pro

Re: Bad performance when using git log --parents (used by gitk)

2019-04-02 Thread Jeff King
On Tue, Apr 02, 2019 at 11:31:59AM +, Björn Pettersson A wrote: > Example: > > Run "git log --parents" for an old file (bswap.ll), and a brand new file > (dummy). Interesting case. I was able to reproduce it here pretty easily, and I have a start on a solution below. > So for bswap.ll it t

Re: [PATCH v3 2/8] git-p4: add failing test for "git-p4: match branches case insensitively if configured"

2019-04-02 Thread SZEDER Gábor
Hi Junio and Andrey, On Mon, Apr 01, 2019 at 06:02:21PM +, Mazo, Andrey wrote: > diff --git a/t/t9801-git-p4-branch.sh b/t/t9801-git-p4-branch.sh > index 6a86d6996b..c48532e12b 100755 > --- a/t/t9801-git-p4-branch.sh > +++ b/t/t9801-git-p4-branch.sh > @@ -608,10 +608,102 @@ test_expect_success

[PATCH] blame.c: don't drop origin blobs as eagerly

2019-04-02 Thread David Kastrup
When a parent blob already has chunks queued up for blaming, dropping the blob at the end of one blame step will cause it to get reloaded right away, doubling the amount of I/O and unpacking when processing a linear history. Keeping such parent blobs in memory seems like a reasonable optimization

Re: Make the git codebase thread-safe

2019-04-02 Thread David Kastrup
Duy Nguyen writes: > On Tue, Apr 2, 2019 at 5:30 PM David Kastrup wrote: >> >> Duy Nguyen writes: >> >> > On Tue, Apr 2, 2019 at 7:52 AM Matheus Tavares >> > wrote: >> >> I downloaded chromium to give it a try and got (on a machine with i7 and >> >> SSD, running Manjaro Linux): >> >> >> >> - 1

Re: Make the git codebase thread-safe

2019-04-02 Thread Duy Nguyen
On Tue, Apr 2, 2019 at 5:30 PM David Kastrup wrote: > > Duy Nguyen writes: > > > On Tue, Apr 2, 2019 at 7:52 AM Matheus Tavares > > wrote: > >> I downloaded chromium to give it a try and got (on a machine with i7 and > >> SSD, running Manjaro Linux): > >> > >> - 17s on blame for a file with long

Bad performance when using git log --parents (used by gitk)

2019-04-02 Thread Björn Pettersson A
Hi! The LLVM project is moving from SVN to git, creating a single repo on github for several LLVM sub-projects. In the past we have had one git repo mirror for each sub-project (mirroring the SVN projects). Unfortunately, I've seen some performance problems with git (or rather gitk) when start

Re: test suite: why does git add large_file create a pack, rather than an object?

2019-04-02 Thread Duy Nguyen
On Mon, Apr 1, 2019 at 10:10 PM Philip Oakley wrote: > > hi Junio, > On 01/04/2019 11:47, Junio C Hamano wrote: > > Philip Oakley writes: > > > >> At the moment I'm using an extended _test_ case that starts by adding > >> a ~5.1Gb file and then using verify-pack, which aborts with an error. > >>

Re: Make the git codebase thread-safe

2019-04-02 Thread David Kastrup
Duy Nguyen writes: > On Tue, Apr 2, 2019 at 7:52 AM Matheus Tavares > wrote: >> I downloaded chromium to give it a try and got (on a machine with i7 and >> SSD, running Manjaro Linux): >> >> - 17s on blame for a file with long history[2] >> - 2m on blame for a huge file[3] >> - 15s on log for bo