Re: Google "Season of Docs"

On Sat, Mar 30, 2019 at 10:48 PM Philip Oakley wrote: > > * Developers rarely want to write documentation (it's too obvious to them) > -- Our code base has become larger than the average brain-full, maybe > that (developer education) also could also benefit from some further > structural documenta

Re: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

On Sun, Mar 31, 2019 at 3:38 AM Thomas Gummerer wrote: > > On 03/30, Jonathan Chang wrote: > > Signed-off-by: Jonathan Chang > > --- > > t/t-basic.sh | 14 -- > > 1 file changed, 8 insertions(+), 6 deletions(-) > > > > diff --git a/t/t-basic.sh b/t/t-basic.sh > > index 3d

[GSoC][PATCH v5 2/7] clone: better handle symlinked files at .git/objects/

There is currently an odd behaviour when locally cloning a repository with symlinks at .git/objects: using --no-hardlinks all symlinks are dereferenced but without it, Git will try to hardlink the files with the link() function, which has an OS-specific behaviour on symlinks. On OSX and NetBSD, it

[GSoC][PATCH v5 7/7] clone: replace strcmp by fspathcmp

Replace the use of strcmp by fspathcmp at copy_or_link_directory, which is more permissive/friendly to case-insensitive file systems. Signed-off-by: Matheus Tavares Suggested-by: Nguyễn Thái Ngọc Duy --- builtin/clone.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin

[GSoC][PATCH v5 1/7] clone: test for our behavior on odd objects/* content

From: Ævar Arnfjörð Bjarmason Add tests for what happens when we perform a local clone on a repo containing odd files at .git/object directory, such as symlinks to other dirs, or unknown files. I'm bending over backwards here to avoid a SHA-1 dependency. See [1] for an earlier and simpler versio

[GSoC][PATCH v5 6/7] clone: use dir-iterator to avoid explicit dir traversal

Replace usage of opendir/readdir/closedir API to traverse directories recursively, at copy_or_link_directory function, by the dir-iterator API. This simplifies the code and avoids recursive calls to copy_or_link_directory. This process also makes copy_or_link_directory call die() in case of an err

[GSoC][PATCH v5 3/7] dir-iterator: add flags parameter to dir_iterator_begin

Add the possibility of giving flags to dir_iterator_begin to initialize a dir-iterator with special options. Currently possible flags are DIR_ITERATOR_PEDANTIC, which makes dir_iterator_advance abort immediately in the case of an error while trying to fetch next entry; and DIR_ITERATOR_FOLLOW_SYML

[GSoC][PATCH v5 0/7] clone: dir-iterator refactoring with tests

This patchset contains: - a replacement of explicit recursive dir iteration at copy_or_link_directory for the dir-iterator API; - some refactoring and behaviour changes at local clone, mainly to take care of symlinks and hidden files at .git/objects; and - tests for this type of files Changes

[GSoC][PATCH v5 4/7] clone: copy hidden paths at local clone

Make the copy_or_link_directory function no longer skip hidden directories. This function, used to copy .git/objects, currently skips all hidden directories but not hidden files, which is an odd behaviour. The reason for that could be unintentional: probably the intention was to skip '.' and '..' o

[GSoC][PATCH v5 5/7] clone: extract function from copy_or_link_directory

Extract dir creation code snippet from copy_or_link_directory to its own function named mkdir_if_missing. This change will help to remove copy_or_link_directory's explicit recursion, which will be done in a following patch. Also makes the code more readable. Signed-off-by: Matheus Tavares --- bu

Re: [PATCH] asciidoctor-extensions: provide ``

On Sat, Mar 30, 2019 at 02:00:14PM -0400, Todd Zullinger wrote: > Thanks for the very useful docbook5/xmlto details! > > The hard-coded use of the non-namespaced stylesheets in > xmlto is unfortunate. I hadn't gotten far enough along to > run into that limitation of xmlto, so many thanks for savi

Typo in the .gitignore docs?

Hi everyone, I think there is a typo in the gitignore docs. Its stated on https://git-scm.com/docs/gitignore that >If the pattern does not contain a slash /, Git treats it as a shell >glob pattern and checks for a match against the pathname relative to >the location of the .gitignore file (relat

Re: [GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

On 03/30, Jonathan Chang wrote: > Signed-off-by: Jonathan Chang > --- > t/t-basic.sh | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/t/t-basic.sh b/t/t-basic.sh > index 3de13daabe..49923c5ff1 100755 > --- a/t/t-basic.sh > +++ b/t/t-basi

Re: [GSoC][PATCH v4 2/7] clone: better handle symlinked files at .git/objects/

On 03/30, Matheus Tavares Bernardino wrote: > On Fri, Mar 29, 2019 at 5:05 PM Thomas Gummerer wrote: > > > > On 03/29, Matheus Tavares Bernardino wrote: > > > Ok, what if instead of using linkat() we use 'realpath(const char > > > *path, char *resolved_path)', which will resolve any symlinks at >

[PATCH v1 1/2] Documentation/rev-list-options: wrap --date= block with "--"

Using "+" to continue multiple list items is more tedious and error-prone than wrapping the entire block with "--" block markers. When using asciidoctor, the list items after the --date=iso list items are incorrectly formatted when using "+" continuation. Use "--" block markers to correctly forma

[PATCH v1 0/2] minor asciidoc/tor formatting fixes

Just chipping away at the remaining differences between asciidoc and asciidoctor. Todd Zullinger (2): Documentation/rev-list-options: wrap --date= block with "--" Documentation/git-status: fix titles in porcelain v2 section Documentation/git-status.txt | 12 Documentation/

[PATCH v1 2/2] Documentation/git-status: fix titles in porcelain v2 section

Asciidoc uses either one-line or two-line syntax for document/section titles[1]. The two-line form is used in git-status. Fix a few section titles in the porcelain v2 section which were inadvertently using markdown syntax. [1] http://asciidoc.org/userguide.html#X17 Signed-off-by: Todd Zullinger

Re: [PATCH v3 04/11] gc docs: include the "gc.*" section from "config" in "gc"

Hi Ævar, Ævar Arnfjörð Bjarmason wrote: > diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt > index 66386439b7..c037a46b09 100644 > --- a/Documentation/git-gc.txt > +++ b/Documentation/git-gc.txt > @@ -45,28 +45,12 @@ OPTIONS > --auto:: > With this option, 'git gc' checks whe

Re: [PATCH] asciidoctor-extensions: provide ``

Hi, brian m. carlson wrote: > On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote: >> There's still the matter of 2.0 dropping docbook45. I'll >> try to get around to testing 1.5.x releases with docbook5 to >> see if they work reasonably well. If not, we can add a >> version check and

Google "Season of Docs"

We mentor Summer of Code projects. Perhaps we should be doing something similar for docs.  Now Google are: https://opensource.googleblog.com/2019/03/introducing-season-of-docs.html April 2-23: Open source organizations apply to take part in Season of Docs My thoughts include: * There is an expa

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

On Sat, Mar 30, 2019 at 1:49 AM Rohit Ashiwal wrote: > > Hi Elijah > > On 2019-03-30 0:38 UTC Elijah Newren wrote: > > > I'm curious if you're looking at an old version of the documentation > > (...or maybe the documentation just isn't that clear?). Interactive > > rebases have supported --sign

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

On Sat, Mar 30, 2019 at 12:16 AM Christian Couder wrote: > > 6. `[Bonus]` If everything goes well and time permits, discuss with the > > mentor(s) > > the possibility of deprecating the am backend of rebase. This point is last > > to > > work on as it provides no "cosmetic" difference on the us

Good day,

Hello. I sent you a message containing the details of the transaction did you received it? Kind Regards. Mrs. Annabelle Edo.

[GSoC][PATCH v4 3/5] t0000: use test_line_count instead of wc -l

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 47666b013e..3de13daabe 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1136,8 +1136,8 @@ test_expect_success 'git commit

[GSoC][PATCH v4 1/5] t0000: fix indentation

Fix indentation of a line containing a pipeline to reduce the noise when refactoring the pipeline in a subsequent commit. This has been wrong since the refactoring done in 1b5b2b641a ("t: modernise style", 2012-03-02), but carries no meaning. Signed-off-by: Jonathan Chang --- t/t-basic.s

[GSoC][PATCH v4 2/5] t0000: avoid using pipes

The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. This commit doesn't make any additional simplifications, such as using the test_line_count function for countin

[GSoC][PATCH v4 4/5] t0000: use test_cmp instead of "test" builtin

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 3de13daabe..49923c5ff1 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -1118,16 +1118,18 @@ P=$(test_oid root)

[GSoC][PATCH v4 0/5] Avoid using pipes

I added 2 additional patches that modernize style, based on discussion in [1]. Also added description in commit message as suggested in [2]. [v1]: https://public-inbox.org/git/20190309154555.33407-1-ttjt...@gmail.com/ [v2]: https://public-inbox.org/git/20190310080739.63984-1-ttjt...@gmail.com/ [v

[GSoC][PATCH v4 5/5] t0000: make use of the test_must_be_empty function

Signed-off-by: Jonathan Chang --- t/t-basic.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t-basic.sh b/t/t-basic.sh index 49923c5ff1..0cb69a89de 100755 --- a/t/t-basic.sh +++ b/t/t-basic.sh @@ -51,7 +51,7 @@ test_expect_success 'verify that the r

test suite: why does git add large_file create a pack, rather than an object?

I'm looking at the Git-for-Windows(GfW) >4Gb  large file problem following Torsten and Thomas's work (and others). [1,2,3, etc.] I've added a few more changes to my branch [2] to get the zlib to properly count past its 32bit limit when wrapped in the git_inflate (etc) wrapper code. [4] At th

Re: Feature Request git clone shallow-include

On Sat, Mar 30, 2019 at 5:02 AM Joe Enzminger wrote: > > Duy - > > Any updates on this feature request? Nope. I've been busy with other stuff. I did have a look at the possibility of reusing code in sha1-name.c and concluded that it's not quite safe. > Joe > > On Thu, Feb 21, 2019 at 7:06 AM Duy

[PATCH 29/31] sha1-name.c: remove the_repo from maybe_die_on_misspelt_object_name

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 4 +++- setup.c | 7 --- sha1-name.c | 6 -- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/cache.h b/cache.h index f6e87194d0..3718b3db8a 100644 --- a/cache.h +++ b/cache.h @@ -1387,7 +1387,9 @@ extern int get_oid

[PATCH 28/31] submodule-config.c: use repo_get_oid for reading .gitmodules

Since 76e9bdc437 (submodule: support reading .gitmodules when it's not in the working tree - 2018-10-25), every time you do git grep --recurse-submodules you are likely to see one warning line per submodule (unless all those submodules also have submodules). On a superproject with plenty of s

[PATCH 30/31] sha1-name.c: remove the_repo from other get_oid_*

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 18 -- sha1-name.c | 35 --- 2 files changed, 32 insertions(+), 21 deletions(-) diff --git a/cache.h b/cache.h index 3718b3db8a..871a167bf8 100644 --- a/cache.h +++ b/cache.h @@ -1381,12 +1381,1

[PATCH 31/31] sha1-name.c: remove the_repo from get_oid_mb()

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 18 +++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index 871a167bf8..9a600a8b50 100644 --- a/cache.h +++ b/cache.h @@ -1386,6 +1386,7 @@ int repo_get_oid_committish(st

[PATCH 23/31] sha1-name.c: remove the_repo from handle_one_ref()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 5741a9f821..d9050776dd 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1189,15 +1189,21 @@ static enum get_oid_result get_oid

[PATCH 15/31] sha1-name.c: remove the_repo from get_short_oid()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index cdcf84b826..2643b75b54 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -436,7 +436,8 @@ static void sort_ambiguous_oid_array(str

[PATCH 27/31] sha1-name.c: add repo_get_oid()

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cache.h b/cache.h index 2149dc4f56..f6e87194d0 100644 --- a/cache.h +++ b/cache.h @@ -1380,7 +1380,8 @@ enum get_oid_result { */

[PATCH 22/31] sha1-name.c: remove the_repo from get_oid_1()

There is a cyclic dependency between one of these functions so they cannot be converted one by one, so all related functions are converted at once. Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 7 +-- sha1-name.c | 59 - 2 files ch

[PATCH 00/31] Kill the_repository in sha1-name.c

This whole series is to fix a known issue from ao/submodule-wo-gitmodules-checked-out. Commit 76e9bdc437 (submodule: support reading .gitmodules when it's not in the working tree - 2018-10-25) makes "git grep --recurse-submodules" print warning: nested submodules ... not supported yet one lin

[PATCH 14/31] sha1-name.c: add repo_for_each_abbrev()

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 3 ++- sha1-name.c | 5 +++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cache.h b/cache.h index 4f8ebb0a67..0cb95c0d4f 100644 --- a/cache.h +++ b/cache.h @@ -1392,7 +1392,8 @@ extern enum get_oid_result get_oid_with_contex

[PATCH 11/31] sha1-name.c: remove the_repo from find_abbrev_len_packed()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 7558ce51a3..b9381aaba6 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -514,6 +514,7 @@ struct min_abbrev_data { unsigned int init_le

[PATCH 21/31] sha1-name.c: remove the_repo from get_oid_basic()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 1cda854f02..d4c135aea8 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -773,8 +773,8 @@ static inline int push_mark(con

[PATCH 26/31] sha1-name.c: remove the_repo from get_oid_with_context_1()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sha1-name.c b/sha1-name.c index 6b53ea2eeb..64a50d1291 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -12,6 +12,7 @@ #include "packfile.h" #include "object-store.h"

[PATCH 18/31] sha1-name.c: add repo_interpret_branch_name()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 7d9512ac44..49c62d5254 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1390,7 +1390,8 @@ static int interpret_empty_at(const cha

[PATCH 25/31] sha1-name.c: remove the_repo from resolve_relative_path()

"remove" is not entirely correct. But at least the function is aware that if the given repo is not the_repository, then $CWD and is_inside_work_tree() means nothing. Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sh

[PATCH 24/31] sha1-name.c: remove the_repo from diagnose_invalid_index_path()

Signed-off-by: Nguyễn Thái Ngọc Duy --- dir.c | 8 dir.h | 4 +++- sha1-name.c | 7 --- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/dir.c b/dir.c index b2cabadf25..e6d97343f4 100644 --- a/dir.c +++ b/dir.c @@ -2315,6 +2315,14 @@ int file_exists(const c

[PATCH 20/31] sha1-name.c: remove the_repo from get_describe_name()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index fb80306f1a..1cda854f02 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1097,7 +1097,9 @@ static int peel_onion(const char *name, int len,

[PATCH 04/31] refs.c: remove the_repo from substitute_branch_name()

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 8 ++-- refs.c | 9 + sha1-name.c | 8 ++-- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index ac92421f3a..fcb24b5781 100644 --- a/cache.h +++ b/cache.h @@ -1468,8 +1468,12 @@ extern in

[PATCH 02/31] refs.c: add refs_ref_exists()

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/refs.c b/refs.c index 142888a40a..b869f32d8b 100644 --- a/refs.c +++ b/refs.c @@ -241,9 +241,14 @@ int read_ref(const char *refname, struct object_id *oid) return read_

[PATCH 06/31] refs.c: add repo_dwim_ref()

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 12 +--- refs.h | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/refs.c b/refs.c index 1f5864aa36..bd0fec5776 100644 --- a/refs.c +++ b/refs.c @@ -555,14 +555,20 @@ static char *substitute_branch_name(struct repositor

[PATCH 03/31] refs.c: add refs_shorten_unambiguous_ref()

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 11 +-- refs.h | 2 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/refs.c b/refs.c index b869f32d8b..3dde824aab 100644 --- a/refs.c +++ b/refs.c @@ -1169,7 +1169,8 @@ int update_ref(const char *msg, const char *refname,

[PATCH 10/31] sha1-name.c: remove the_repo from sort_ambiguous()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 15a1107998..7558ce51a3 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -383,10 +383,11 @@ static int collect_ambiguous(const struc

[PATCH 09/31] commit.c: add repo_get_commit_tree()

Signed-off-by: Nguyễn Thái Ngọc Duy --- commit.c | 5 +++-- commit.h | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/commit.c b/commit.c index a5333c7ac6..f0a5506f04 100644 --- a/commit.c +++ b/commit.c @@ -340,7 +340,8 @@ void free_commit_buffer(struct parsed_object_pool

[PATCH 19/31] sha1-name.c: remove the_repo from get_oid_oneline()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 49c62d5254..fb80306f1a 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -15,7 +15,7 @@ #include "midx.h" #include "commit-reach.h"

[PATCH 16/31] sha1-name.c: remove the_repo from interpret_nth_prior_checkout()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 2643b75b54..af8bf5b351 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -771,7 +771,7 @@ static inline int push_mark(const char *

[PATCH 17/31] sha1-name.c: remove the_repo from interpret_branch_mark()

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index af8bf5b351..7d9512ac44 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -1412,9 +1412,9 @@ static int reinterpret(const char *name, in

[PATCH 07/31] refs.c: add repo_dwim_log()

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c | 21 +++-- refs.h | 1 + 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c index bd0fec5776..edea001446 100644 --- a/refs.c +++ b/refs.c @@ -603,9 +603,11 @@ int expand_ref(struct repository *repo, cons

[PATCH 08/31] refs.c: remove the_repo from read_ref_at()

Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/show-branch.c | 6 -- refs.c| 7 --- refs.h| 3 ++- sha1-name.c | 3 ++- 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/builtin/show-branch.c b/builtin/show-branch.c index 934e514944

[PATCH 12/31] sha1-name.c: add repo_find_unique_abbrev_r()

Signed-off-by: Nguyễn Thái Ngọc Duy --- cache.h | 6 -- sha1-name.c | 15 +-- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/cache.h b/cache.h index fcb24b5781..4f8ebb0a67 100644 --- a/cache.h +++ b/cache.h @@ -1045,8 +1045,10 @@ extern void check_repository_

[PATCH 05/31] refs.c: remove the_repo from expand_ref()

Signed-off-by: Nguyễn Thái Ngọc Duy --- refs.c| 10 ++ refs.h| 2 +- upload-pack.c | 2 +- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/refs.c b/refs.c index 44df049796..1f5864aa36 100644 --- a/refs.c +++ b/refs.c @@ -558,12 +558,13 @@ static char *subs

[PATCH 13/31] sha1-name.c: store and use repo in struct disambiguate_state

Signed-off-by: Nguyễn Thái Ngọc Duy --- sha1-name.c | 95 + 1 file changed, 59 insertions(+), 36 deletions(-) diff --git a/sha1-name.c b/sha1-name.c index 9b57787b76..a75992eb54 100644 --- a/sha1-name.c +++ b/sha1-name.c @@ -17,13 +17,14 @@

[PATCH 01/31] packfile.c: add repo_approximate_object_count()

Signed-off-by: Nguyễn Thái Ngọc Duy --- packfile.c | 14 +++--- packfile.h | 3 ++- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/packfile.c b/packfile.c index 16bcb75262..2ad4fab2f8 100644 --- a/packfile.c +++ b/packfile.c @@ -893,25 +893,25 @@ static void prepare_packe

Re: [PATCH v2 15/15] merge-recursive: switch directory rename detection default

On Sat, Mar 30 2019, Elijah Newren wrote: I may have more, just quickly skimming this for the first time... > merge.renames:: > - Whether and how Git detects renames. If set to "false", > - rename detection is disabled. If set to "true", basic rename > - detection is enabled. Def

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

Hi Elijah On 2019-03-30 0:38 UTC Elijah Newren wrote: > I'm curious if you're looking at an old version of the documentation > (...or maybe the documentation just isn't that clear?). Interactive > rebases have supported --signoff since commit a852ec7f273c ("rebase: > extend --signoff support",

[PATCH] test-lib: whitelist GIT_TR2_* in the environment

Add GIT_TR2_* to the whitelist of environment variables that we don't clear when running the test suite. This allows us to use the test suite to produce trace2 test data, which is handy to e.g. write consumers that collate the trace data itself. One caveat here is that we produce trace output for

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

Hi Rohit, On Fri, Mar 29, 2019 at 11:33 PM Rohit Ashiwal wrote: > > This is the v2 of the draft proposal[1]. I've added some details to the > proposal, > it talks more about what to implement instead of how. It is still incomplete. > > I'm currently adding more to the overview section, where I'l