Re: [PATCH] diff: batch fetching of missing blobs

2019-03-27 Thread Jeff King
On Tue, Mar 26, 2019 at 03:09:06PM -0700, Jonathan Tan wrote: > When running a command like "git show" or "git diff" in a partial clone, > batch all missing blobs to be fetched as one request. > > This is similar to c0c578b33c ("unpack-trees: batch fetching of missing > blobs", 2017-12-08), but f

Re: [PATCH] asciidoctor-extensions: provide ``

2019-03-27 Thread Jeff King
On Wed, Mar 27, 2019 at 10:54:34PM -0400, Jeff King wrote: > @@ -112,6 +118,13 @@ construct_makemanflags () { > elif test "$1" = "-asciidoctor" > then > echo USE_ASCIIDOCTOR=YesPlease > + elif test "$1" = "-asciidoctor2" > + then > + echo USE_ASCIIDOCT

Re: [PATCH] fetch-pack: binary search when storing wanted-refs

2019-03-27 Thread Jeff King
On Wed, Mar 27, 2019 at 02:11:10PM -0700, Jonathan Tan wrote: > In do_fetch_pack_v2(), the "sought" array is sorted by name, and it is > not subsequently reordered (within the function). Therefore, > receive_wanted_refs() can assume that "sought" is sorted, and can thus > use a binary search when

Re: Puzzling Git backtrace

2019-03-27 Thread Bryan Turner
On Wed, Mar 27, 2019 at 6:50 PM Jeff King wrote: > > On Wed, Mar 27, 2019 at 05:49:27PM -0700, Bryan Turner wrote: > > > I'm trying to assist a Bitbucket Server customer who is seeing some > > "git-upload-pack" processes "hang" on their server. > > > > While investigating, we had them connect gdb

Re: [PATCH] asciidoctor-extensions: provide ``

2019-03-27 Thread Jeff King
On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote: > > I updated to asciidoctor-2.0.1 this morning to test, in case > > it was one of the issues fixed since the 2.0.0 release. > > Alas, we're the first to hit it and report it. > > Dan Allen fixed this upstream and released 2.0.2 toda

Re: [PATCH 3/5] progress: assemble percentage and counters in a strbuf before printing

2019-03-27 Thread Jeff King
On Wed, Mar 27, 2019 at 11:24:51AM +0100, SZEDER Gábor wrote: > On Tue, Mar 26, 2019 at 01:45:41AM -0400, Jeff King wrote: > > On Mon, Mar 25, 2019 at 11:38:42AM +0100, SZEDER Gábor wrote: > > > > > The following patches in this series want to handle the progress bar's > > > title and changing pa

Re: Calculating pack file SHA value

2019-03-27 Thread Jeff King
On Wed, Mar 27, 2019 at 09:06:20PM -0400, Farhan Khan wrote: > I am trying to figure out how to calculate the SHA value of a pack file when > you > run `git index-pack file.pack`. I am close, but having a bit of trouble at the > end. Here's my understanding so far. It's all but the last 20 bytes

Re: Puzzling Git backtrace

2019-03-27 Thread Jeff King
On Wed, Mar 27, 2019 at 05:49:27PM -0700, Bryan Turner wrote: > I'm trying to assist a Bitbucket Server customer who is seeing some > "git-upload-pack" processes "hang" on their server. > > While investigating, we had them connect gdb to their processes (which > are 2.10.0 built from source using

Calculating pack file SHA value

2019-03-27 Thread Farhan Khan
Hi all, I am trying to figure out how to calculate the SHA value of a pack file when you run `git index-pack file.pack`. I am close, but having a bit of trouble at the end. Here's my understanding so far. Git buffers data to be processed and when its exhausted, updates the SHA checksum with the p

Puzzling Git backtrace

2019-03-27 Thread Bryan Turner
I'm trying to assist a Bitbucket Server customer who is seeing some "git-upload-pack" processes "hang" on their server. While investigating, we had them connect gdb to their processes (which are 2.10.0 built from source using a simple unzip-and-run-make approach) and get the backtraces for them. T

Re: [PATCH] asciidoctor-extensions: provide ``

2019-03-27 Thread brian m. carlson
On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote: > There's still the matter of 2.0 dropping docbook45. I'll > try to get around to testing 1.5.x releases with docbook5 to > see if they work reasonably well. If not, we can add a > version check and set ASCIIDOC_DOCBOOK appropriately

Re: [GSoC] [t9803]

2019-03-27 Thread Denton Liu
On Wed, Mar 27, 2019 at 11:01:38PM +, Julian Cheng wrote: > I'm running Ubuntu 16.04. "sudo apt-get upgrade" tell me I'm up to date. I > hope it's not just that I'm not running a more recent Ubuntu. I am running Ubuntu 16.04 currently as well, so that shouldn't be a problem. Admittedly, I'm

[RFC PATCH 1/1] git-p4: inexact label detection

2019-03-27 Thread Mazo, Andrey
Labels in Perforce are not global, but can be placed on a particular view/subdirectory. This might pose difficulties when importing only parts of Perforce depot into a git repository. For example: 1. Depot layout is as follows: //depot/metaproject/branch1/subprojectA/... //depot/metaproj

RE: [GSoC] [t9803]

2019-03-27 Thread Julian Cheng
I'm running Ubuntu 16.04. "sudo apt-get upgrade" tell me I'm up to date. I hope it's not just that I'm not running a more recent Ubuntu. From: Denton Liu [liu.den...@gmail.com] Sent: March-27-19 6:51 PM To: Julian Cheng Cc: git@vger.kernel.org Subject: Re:

Re: [GSoC] [t9803]

2019-03-27 Thread Denton Liu
On Wed, Mar 27, 2019 at 10:04:46PM +, Julian Cheng wrote: > Denton, thanks for the pointers! > > I get the following when I run "make" in the top level directory of git and > I'm not sure how to deal with it. Any ideas? > $ make > LINK git-http-fetch > .../lib/libcurl.so: undefined refere

Re: [PATCH v2 2/5] docs: do not document the `git remote-testgit` command

2019-03-27 Thread Johannes Schindelin
Hi Ævar, On Tue, 26 Mar 2019, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Mar 25 2019, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin > > > > Since 7ded055401 (build: do not install git-remote-testgit, 2013-06-07), > > we do not install it. Therefore it makes no sense

RE: [GSoC] [t9803]

2019-03-27 Thread Julian Cheng
Denton, thanks for the pointers! I get the following when I run "make" in the top level directory of git and I'm not sure how to deal with it. Any ideas? $ make LINK git-http-fetch .../lib/libcurl.so: undefined reference to `SSLv2_client_method' collect2: error: ld returned 1 exit status Make

Re: [PATCH] diff: batch fetching of missing blobs

2019-03-27 Thread Johannes Schindelin
Hi Jonathan, On Tue, 26 Mar 2019, Jonathan Tan wrote: > When running a command like "git show" or "git diff" in a partial clone, > batch all missing blobs to be fetched as one request. > > This is similar to c0c578b33c ("unpack-trees: batch fetching of missing > blobs", 2017-12-08), but for anoth

[PATCH] fetch-pack: binary search when storing wanted-refs

2019-03-27 Thread Jonathan Tan
In do_fetch_pack_v2(), the "sought" array is sorted by name, and it is not subsequently reordered (within the function). Therefore, receive_wanted_refs() can assume that "sought" is sorted, and can thus use a binary search when storing wanted-refs retrieved from the server. Replace the existing li

Re: [GSoC] [t9803]

2019-03-27 Thread Denton Liu
Hi Julian, On Wed, Mar 27, 2019 at 07:26:12PM +, Julian Cheng wrote: > Hello Git Community, > > I’m new here and hoping to get to be a part of GSOC 2019. I have questions > about the main project and the microproject > > Main Project Quesctions > I was hoping to work on “git revert --drop”

Re: [GSoC][PATCH] microporject test_path_is_*

2019-03-27 Thread Mooga
Hi Eliah, thanks for the advice, but still after I read the SubmittingPatches , and see around the Submitting patches process still confussing for me , there's a better way for explanation as an example Regards On 27.03.19, 18:06, "Elijah Newren" wrote: Hi Mooga, On Wed, M

[GSoC] [t9803]

2019-03-27 Thread Julian Cheng
Hello Git Community, I’m new here and hoping to get to be a part of GSOC 2019. I have questions about the main project and the microproject Main Project Quesctions I was hoping to work on “git revert --drop” and “git commit --reword”. Are there any mentors available for this project? The ideas

Re: Unable to change remote url of origin

2019-03-27 Thread Andreas Schwab
On Mär 27 2019, Petr Bena wrote: > # Display remote URL > > petr.bena@MacBook:~/Documents/grumpy$ git remote -v > origin    g...@github.com:grumpy-irc/grumpy (fetch) > origin    g...@github.com:grumpy-irc/grumpy (push) > > #Now change it to HTTPS instead of SSH > > petr.bena@MacBook:~/Documents/g

Re: [PATCH] In `git log --graph`, default to --pretty=oneline --abbrev-commit

2019-03-27 Thread Alex Henrie
On Sun, Mar 24, 2019 at 11:27 PM Rafael Ascensão wrote: > > Or just $git log --graph --oneline, since --oneline is a shortcut for the > longer --pretty=oneline --abbrev-commit. Thanks for the tip! I didn't know about the --oneline option, but now that I do, I suppose I don't really need an alias

Re: [GSoC][PATCH] microporject test_path_is_*

2019-03-27 Thread Elijah Newren
Hi Mooga, On Wed, Mar 27, 2019 at 5:27 AM Mooga wrote: > > > So for example that is git diff > > diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh > index 286bba35d8..fc82965a0f 100755 > --- a/t/t2400-worktree-add.sh > +++ b/t/t2400-worktree-add.sh > @@ -66,7 +66,7 @@ test_expect_su

Re: [GSoC] Unify ref-filter formats with other --pretty formats

2019-03-27 Thread Kapil Jain
> On Tue, Mar 26, 2019 at 2:48 AM Olga Telezhnaya > wrote: >> Kapil Jain wrote: > > Now, the verify_ref_format function can be used inside > > get_commit_format function, hence reusing logic. > > Is this a correct example to work on, for this project ? > > Hi! Yes, in my opinion your example loo

From Barr Philip

2019-03-27 Thread uk1uk12019a
>From Barr This is Barr Philip Twite reaching you from the United Kingdom further to my previous email notice. I have not received your response till this date. Kindly forward to me the required information to engender further discuss. Information should include; your full Names Address Telephone

Re: [PATCH 0/3] rebase: learn --keep-base

2019-03-27 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 26 2019, Denton Liu wrote: > Hi Ævar, > > On Tue, Mar 26, 2019 at 09:35:48PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> On Tue, Mar 26 2019, Denton Liu wrote: >> >> > Hi Ævar, >> > >> > On Tue, Mar 26, 2019 at 03:35:34PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> >> >> On Sat, Mar

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 27 2019, SZEDER Gábor wrote: > On Wed, Mar 27, 2019 at 12:21:55PM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> On Wed, Mar 27 2019, SZEDER Gábor wrote: >> >> > On Wed, Mar 27, 2019 at 11:09:18AM +0100, Ævar Arnfjörð Bjarmason wrote: >> >> > There are likewise several that use one of >

Re: [PATCH] cherry-pick: do not error on non-merge commits when '-m 1' is specified

2019-03-27 Thread Sergey Organov
Jeff King writes: > On Mon, Mar 25, 2019 at 09:43:09AM +0300, Sergey Organov wrote: > >> How about changing "git show -p M" to output "diff -p M^ M" rather than >> "diff-tree --cc M" for merge commits? It's really surprising specifying >> -p has no visible effect. > > That's because "-p" is alrea

Re: git replace --graft does error checking too late

2019-03-27 Thread Christian Couder
On Wed, Mar 27, 2019 at 2:11 PM Christian Couder wrote: > > On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab wrote: > > > > When running `git replace --graft A B' where B is a non-commit (eg. a > > tag) it displays an error, > > Yeah, it seems that when A is a commit and B a tag I get: > > "error:

Re: git replace --graft does error checking too late

2019-03-27 Thread Christian Couder
On Wed, Mar 27, 2019 at 11:24 AM Andreas Schwab wrote: > > When running `git replace --graft A B' where B is a non-commit (eg. a > tag) it displays an error, Yeah, it seems that when A is a commit and B a tag I get: "error: object A is a tag, not a commit" which is wrong as A is a commit. > bu

Re: Unable to change remote url of origin

2019-03-27 Thread Petr Bena
On 27/03/2019 13:57, Kevin Daudt wrote: On Wed, Mar 27, 2019 at 01:25:27PM +0100, Petr Bena wrote: Hello, I used to change remote URL simply by editing .git/config (which may not be most correct way), but out of sudden I am no longer able to do that. So I decided to do it the "proper way" but s

Re: Unable to change remote url of origin

2019-03-27 Thread Kevin Daudt
On Wed, Mar 27, 2019 at 01:25:27PM +0100, Petr Bena wrote: > Hello, > > I used to change remote URL simply by editing .git/config (which may not be > most correct way), but out of sudden I am no longer able to do that. So I > decided to do it the "proper way" but still - to no avail. Here is what

Unable to change remote url of origin

2019-03-27 Thread Petr Bena
Hello, I used to change remote URL simply by editing .git/config (which may not be most correct way), but out of sudden I am no longer able to do that. So I decided to do it the "proper way" but still - to no avail. Here is what I do and also it's visible what is wrong: # Display remote URL

[GSoC][PATCH] microporject test_path_is_*

2019-03-27 Thread Mooga
So for example  that is git diff diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh index 286bba35d8..fc82965a0f 100755 --- a/t/t2400-worktree-add.sh +++ b/t/t2400-worktree-add.sh @@ -66,7 +66,7 @@ test_expect_success '"add" worktree' ' test_expect_success '"add" worktree with lock'

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread SZEDER Gábor
On Wed, Mar 27, 2019 at 12:21:55PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Mar 27 2019, SZEDER Gábor wrote: > > > On Wed, Mar 27, 2019 at 11:09:18AM +0100, Ævar Arnfjörð Bjarmason wrote: > >> > There are likewise several that use one of > >> >! test -e path/to/filename > >> > or > >

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread Mooga
So for example that is git diff diff --git a/t/t2400-worktree-add.sh b/t/t2400-worktree-add.sh index 286bba35d8..fc82965a0f 100755 --- a/t/t2400-worktree-add.sh +++ b/t/t2400-worktree-add.sh @@ -66,7 +66,7 @@ test_expect_success '"add" worktree' ' test_expect_success '"add" worktree with lock'

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 27 2019, SZEDER Gábor wrote: > On Wed, Mar 27, 2019 at 11:09:18AM +0100, Ævar Arnfjörð Bjarmason wrote: >> > There are likewise several that use one of >> >! test -e path/to/filename >> > or >> >! test -f path/to/filename >> > or >> > test ! -f path/to/filename >> > which c

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread SZEDER Gábor
On Wed, Mar 27, 2019 at 11:09:18AM +0100, Ævar Arnfjörð Bjarmason wrote: > > There are likewise several that use one of > >! test -e path/to/filename > > or > >! test -f path/to/filename > > or > > test ! -f path/to/filename > > which could be replaced by > > test_path_is_missing path/t

Re: [PATCH 1/3] tag: prevent recursive tags

2019-03-27 Thread Ævar Arnfjörð Bjarmason
On Wed, Mar 27 2019, Elijah Newren wrote: > On Tue, Mar 26, 2019 at 12:56 AM Denton Liu wrote: >> >> Robert Dailey reported confusion on the mailing list about a recursive >> tag which was most likely created by mistake. Jeff King noted that this >> isn't a very common case so, most likely, cre

Re: [PATCH v3 10/21] checkout: split part of it to new command 'switch'

2019-03-27 Thread Phillip Wood
On 26/03/2019 15:48, Elijah Newren wrote: > On Tue, Mar 26, 2019 at 8:24 AM Duy Nguyen wrote: >> On Tue, Mar 26, 2019 at 10:01 PM Elijah Newren wrote: > >> Yeah.. --ignore-in-process does not necessarily mean aborting >> something when you just want to get out to examine some other commit. >> An

Re: [PATCH 3/5] progress: assemble percentage and counters in a strbuf before printing

2019-03-27 Thread SZEDER Gábor
On Tue, Mar 26, 2019 at 01:45:41AM -0400, Jeff King wrote: > On Mon, Mar 25, 2019 at 11:38:42AM +0100, SZEDER Gábor wrote: > > > The following patches in this series want to handle the progress bar's > > title and changing parts (i.e. the counter and the optional percentage > > and throughput comb

git replace --graft does error checking too late

2019-03-27 Thread Andreas Schwab
When running `git replace --graft A B' where B is a non-commit (eg. a tag) it displays an error, but creates the replace ref anyway. I think it should verify that B names a commit object before creating the ref. Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BA

Re: [PATCH] diff: batch fetching of missing blobs

2019-03-27 Thread SZEDER Gábor
On Tue, Mar 26, 2019 at 03:09:06PM -0700, Jonathan Tan wrote: > diff --git a/t/t4067-diff-partial-clone.sh b/t/t4067-diff-partial-clone.sh > new file mode 100755 > index 00..38f03be114 > --- /dev/null > +++ b/t/t4067-diff-partial-clone.sh > @@ -0,0 +1,76 @@ > +#!/bin/sh > + > +test_descript

Re: [GSoC] microporject test_path_is_*

2019-03-27 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 26 2019, Elijah Newren wrote: > Hi, > > On Tue, Mar 26, 2019 at 2:10 PM Mooga wrote: >> >> Hi, >> I am still a bit confused about the task itself >> >> it’s just text replacing for example: >> t1400-update-ref.sh , line 194 -> `test_path_is_missing` has to be >> ‘test_path_is_file

Re: [PATCH] asciidoctor-extensions: provide ``

2019-03-27 Thread SZEDER Gábor
On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote: > Dan Allen fixed this upstream and released 2.0.2 today. > It's very good to know that asciidoctor upstream is > incredibly responsive. If anyone runs into Dan at a > conference, please buy him a beer. ;) I noticed the "Release beer

[PATCH] interpret-trailers.txt: start the desc line with a capital letter

2019-03-27 Thread Nguyễn Thái Ngọc Duy
This description line is shown in 'git help -a' and all other commands description starts with an uppercase character. This just makes that printout a bit nicer. Signed-off-by: Nguyễn Thái Ngọc Duy --- Documentation/git-interpret-trailers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [RFC PATCH 0/1] Fuzzy blame

2019-03-27 Thread Duy Nguyen
On Wed, Mar 27, 2019 at 3:26 PM Michael Platings wrote: > > > Another good place to keep these revs is git-notes, > > which probably could result in faster lookups too and can be made > > visible in git-log. > > Oh wow, I really like this. A major concern I had about the revisions > file was that

Re: [RFC PATCH 0/1] Fuzzy blame

2019-03-27 Thread Michael Platings
> Another good place to keep these revs is git-notes, > which probably could result in faster lookups too and can be made > visible in git-log. Oh wow, I really like this. A major concern I had about the revisions file was that you don't know what a revision ID will be until it's upstream. If you

Re:

2019-03-27 Thread giorgio bugatto
Good day , my name is Giorgio Bugatto , i sent you a mail and there was no response , please confirm that you did get this mail for more details. Regards. Giorgio